From 3c6f8001fb5d63ef92da36e662ac58396f18a9d0 Mon Sep 17 00:00:00 2001 From: Tom Clegg Date: Sun, 16 Feb 2014 02:17:15 -0800 Subject: [PATCH] Add and remove collection tags with ajax. --- .../app/assets/javascripts/application.js | 62 ++++++++++++++----- .../app/controllers/application_controller.rb | 4 +- .../app/controllers/collections_controller.rb | 4 +- .../views/collections/_index_tbody.html.erb | 6 +- 4 files changed, 56 insertions(+), 20 deletions(-) diff --git a/apps/workbench/app/assets/javascripts/application.js b/apps/workbench/app/assets/javascripts/application.js index 2f3b094446..92cce3e31c 100644 --- a/apps/workbench/app/assets/javascripts/application.js +++ b/apps/workbench/app/assets/javascripts/application.js @@ -49,24 +49,58 @@ jQuery(function($){ $('.loading').fadeOut('fast', 0); }). on('click', '.removable-tag a', function(e) { - $(this).parents('[data-tag-link-uuid]').eq(0).remove(); + var tag_span = $(this).parents('[data-tag-link-uuid]').eq(0) + tag_span.fadeTo('fast', 0.2); + $.ajax('/links/' + tag_span.attr('data-tag-link-uuid'), + {dataType: 'json', + type: 'POST', + data: { '_method': 'DELETE' }, + context: tag_span}). + done(function(data, status, jqxhr) { + this.remove(); + }). + fail(function(jqxhr, status, error) { + this.addClass('label-danger').fadeTo('fast', '1'); + }); return false; }). on('click', 'a.add-tag-button', function(e) { - new_tag = window.prompt("Add tag for collection "+ - $(this).parents('tr').attr('data-object-uuid'), + var jqxhr; + var new_tag_uuid = 'new-tag-' + Math.random(); + var tag_head_uuid = $(this).parents('tr').attr('data-object-uuid'); + var new_tag = window.prompt("Add tag for collection "+ + tag_head_uuid, ""); - if (new_tag != null) { - new_tag_uuid = 'xxx'; - $(this). - parent(). - find('>span'). - append($(''). - attr('data-tag-link-uuid', new_tag_uuid). - text(new_tag). - append('  ')). - append(' '); - } + if (new_tag == null) + return false; + var new_tag_span = + $(''). + attr('data-tag-link-uuid', new_tag_uuid). + text(new_tag). + css('opacity', '0.2'). + append('  '); + $(this). + parent(). + find('>span'). + append(new_tag_span). + append(' '); + $.ajax($(this).attr('data-remote-href'), + {dataType: 'json', + type: $(this).attr('data-remote-method'), + data: { + 'link[head_kind]': 'arvados#collection', + 'link[head_uuid]': tag_head_uuid, + 'link[link_class]': 'tag', + 'link[name]': new_tag + }, + context: new_tag_span}). + done(function(data, status, jqxhr) { + this.attr('data-tag-link-uuid', data.uuid). + fadeTo('fast', '1'); + }). + fail(function(jqxhr, status, error) { + this.addClass('label-danger').fadeTo('fast', '1'); + }); return false; }); diff --git a/apps/workbench/app/controllers/application_controller.rb b/apps/workbench/app/controllers/application_controller.rb index 02ebc8b3a1..e94428e92d 100644 --- a/apps/workbench/app/controllers/application_controller.rb +++ b/apps/workbench/app/controllers/application_controller.rb @@ -107,9 +107,10 @@ class ApplicationController < ActionController::Base end def create - @object ||= model_class.new params[model_class.to_s.singularize.to_sym] + @object ||= model_class.new params[model_class.to_s.underscore.singularize] @object.save! respond_to do |f| + f.json { render json: @object } f.html { redirect_to(params[:return_to] || @object) } @@ -120,6 +121,7 @@ class ApplicationController < ActionController::Base def destroy if @object.destroy respond_to do |f| + f.json { render json: @object } f.html { redirect_to(params[:return_to] || :back) } diff --git a/apps/workbench/app/controllers/collections_controller.rb b/apps/workbench/app/controllers/collections_controller.rb index f8895da5d3..b6997b9759 100644 --- a/apps/workbench/app/controllers/collections_controller.rb +++ b/apps/workbench/app/controllers/collections_controller.rb @@ -19,7 +19,7 @@ class CollectionsController < ApplicationController @collection_info = {} @collections.each do |c| @collection_info[c.uuid] = { - tags: [], + tag_links: [], wanted: false, wanted_by_me: false, provenance: [], @@ -31,7 +31,7 @@ class CollectionsController < ApplicationController info = @collection_info[link.head_uuid] case link.link_class when 'tag' - info[:tags] << link.name + info[:tag_links] << link when 'resources' info[:wanted] = true info[:wanted_by_me] ||= link.tail_uuid == current_user.uuid diff --git a/apps/workbench/app/views/collections/_index_tbody.html.erb b/apps/workbench/app/views/collections/_index_tbody.html.erb index f7209ee10d..fad520ebd1 100644 --- a/apps/workbench/app/views/collections/_index_tbody.html.erb +++ b/apps/workbench/app/views/collections/_index_tbody.html.erb @@ -30,11 +30,11 @@ <% end %> -  Add +  Add <% if @collection_info[c.uuid] %> - <% @collection_info[c.uuid][:tags].uniq.each do |tag| %> - <%= tag %>  + <% @collection_info[c.uuid][:tag_links].each do |tag_link| %> + <%= tag_link.name %>  <% end %> <% end %> -- 2.30.2