From 35729f8faeae665e5a706d56cfacf01e76de99a9 Mon Sep 17 00:00:00 2001 From: radhika Date: Thu, 2 Oct 2014 14:54:59 -0400 Subject: [PATCH] 3583: extend encode quotes logic for script parameters as well, just in case. --- apps/workbench/app/helpers/provenance_helper.rb | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/apps/workbench/app/helpers/provenance_helper.rb b/apps/workbench/app/helpers/provenance_helper.rb index 677b9cd94f..4faad99e6d 100644 --- a/apps/workbench/app/helpers/provenance_helper.rb +++ b/apps/workbench/app/helpers/provenance_helper.rb @@ -149,7 +149,7 @@ module ProvenanceHelper end unless node == "" node += "']" - node_value = "#{node}".gsub("\"", "\\\"") + node_value = encode_quotes node gr += "\"#{node_value}\" [label=\"#{node_value}\"];\n" gr += edge(job_uuid(job), node_value, {:label => prefix}) end @@ -160,8 +160,9 @@ module ProvenanceHelper gr += edge(job_uuid(job), m, {:label => prefix}) gr += generate_provenance_edges(m) elsif @opts[:all_script_parameters] - gr += "\"#{sp}\" [label=\"#{sp}\"];\n" - gr += edge(job_uuid(job), sp, {:label => prefix}) + sp_value = encode_quotes sp + gr += "\"#{sp_value}\" [label=\"#{sp_value}\"];\n" + gr += edge(job_uuid(job), sp_value, {:label => prefix}) end end gr @@ -264,6 +265,9 @@ module ProvenanceHelper gr end + def encode_quotes value + value.andand.gsub("\"", "\\\"") + end end def self.create_provenance_graph(pdata, svgId, opts={}) -- 2.30.2