From 33af4962460b99718e26e9c22b6e8cae1a19d253 Mon Sep 17 00:00:00 2001 From: Tom Clegg Date: Tue, 23 Oct 2018 14:28:39 -0400 Subject: [PATCH] 14388: Fix typo. Condition (si.want != si.want) should have been (si.want != sj.want). Arvados-DCO-1.1-Signed-off-by: Tom Clegg --- services/keep-balance/balance.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/services/keep-balance/balance.go b/services/keep-balance/balance.go index 8a06b902fc..6bfd175737 100644 --- a/services/keep-balance/balance.go +++ b/services/keep-balance/balance.go @@ -568,14 +568,14 @@ func (bal *Balancer) balanceBlock(blkid arvados.SizedDigest, blk *BlockState) ba // Prefer a mount that satisfies the // desired class. return bal.mountsByClass[class][si.mnt] - } else if wanti, wantj := si.want, si.want; wanti != wantj { + } else if si.want != sj.want { // Prefer a mount that will have a // replica no matter what we do here // -- either because it already has an // untrashable replica, or because we // already need it to satisfy a // different storage class. - return slots[i].want + return si.want } else if orderi, orderj := srvRendezvous[si.mnt.KeepService], srvRendezvous[sj.mnt.KeepService]; orderi != orderj { // Prefer a better rendezvous // position. -- 2.30.2