From 2d3723c301085ebfcb1f3a8940451edc15f10f93 Mon Sep 17 00:00:00 2001 From: Tom Clegg Date: Tue, 15 Jun 2021 18:31:08 -0400 Subject: [PATCH] 17803: Note todo's. Arvados-DCO-1.1-Signed-off-by: Tom Clegg --- lib/config/load.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/lib/config/load.go b/lib/config/load.go index 15174ae9cf..169b252a0e 100644 --- a/lib/config/load.go +++ b/lib/config/load.go @@ -182,6 +182,11 @@ func (ldr *Loader) Load() (*arvados.Config, error) { ldr.configdata = buf } + // FIXME: We should reject YAML if the same key is used twice + // in a map/object, like {foo: bar, foo: baz}. Maybe we'll get + // this fixed free when we upgrade ghodss/yaml to a version + // that uses go-yaml v3. + // Load the config into a dummy map to get the cluster ID // keys, discarding the values; then set up defaults for each // cluster ID; then load the real config on top of the @@ -291,6 +296,8 @@ func (ldr *Loader) Load() (*arvados.Config, error) { checkKeyConflict(fmt.Sprintf("Clusters.%s.PostgreSQL.Connection", id), cc.PostgreSQL.Connection), ldr.checkEmptyKeepstores(cc), ldr.checkUnlistedKeepstores(cc), + // TODO: check non-empty Rendezvous on + // services other than Keepstore } { if err != nil { return nil, err -- 2.30.2