From 0486a1fe8e98fb613eceabfd745875ed2b0d4395 Mon Sep 17 00:00:00 2001 From: Lisa Knox Date: Mon, 22 May 2023 11:42:08 -0400 Subject: [PATCH] 15768: cleanup Arvados-DCO-1.1-Signed-off-by: Lisa Knox --- .../multiselectToolbar/MultiselectToolbar.tsx | 19 +++++++++++++++---- src/store/processes/processes-actions.ts | 2 +- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/src/components/multiselectToolbar/MultiselectToolbar.tsx b/src/components/multiselectToolbar/MultiselectToolbar.tsx index 2409bc9ce7..fc036b2964 100644 --- a/src/components/multiselectToolbar/MultiselectToolbar.tsx +++ b/src/components/multiselectToolbar/MultiselectToolbar.tsx @@ -86,7 +86,8 @@ export const MultiselectToolbar = connect( withStyles(styles)((props: MultiselectToolbarProps & WithStyles) => { // console.log(props); const { classes, actions, isVisible, checkedList } = props; - const currentResourceKinds = Array.from(new Set(selectedToArray(checkedList).map((element) => extractUuidKind(element)))); + + const currentResourceKinds = Array.from(selectedToKindSet(checkedList)); const buttons = actions.filter((action) => currentResourceKinds.length && currentResourceKinds.every((kind) => action.relevantKinds.has(kind as ResourceKind))); return ( @@ -105,7 +106,7 @@ export const MultiselectToolbar = connect( }) ); -function selectedToArray(checkedList: TCheckedList): Array { +function selectedToArray(checkedList: TCheckedList): Array { const arrayifiedSelectedList: Array = []; for (const [key, value] of Object.entries(checkedList)) { if (value === true) { @@ -115,6 +116,16 @@ function selectedToArray(checkedList: TCheckedList): Array { return arrayifiedSelectedList; } +function selectedToKindSet(checkedList: TCheckedList): Set { + const setifiedList = new Set(); + for (const [key, value] of Object.entries(checkedList)) { + if (value === true) { + setifiedList.add(extractUuidKind(key) as string); + } + } + return setifiedList; +} + function mapStateToProps(state: RootState) { const { isVisible, checkedList } = state.multiselect; return { @@ -133,6 +144,6 @@ function mapDispatchToProps(dispatch: Dispatch) { } function removeMulti(dispatch: Dispatch, checkedList: TCheckedList): void { - const list: Array = selectedToArray(checkedList); - dispatch(list.length === 1 ? openRemoveProcessDialog(list[0]) : openRemoveManyProcessesDialog(list)); + const selectedList: Array = selectedToArray(checkedList); + dispatch(selectedList.length === 1 ? openRemoveProcessDialog(selectedList[0]) : openRemoveManyProcessesDialog(selectedList)); } diff --git a/src/store/processes/processes-actions.ts b/src/store/processes/processes-actions.ts index 8e48168762..1d3be43533 100644 --- a/src/store/processes/processes-actions.ts +++ b/src/store/processes/processes-actions.ts @@ -302,7 +302,7 @@ export const openRemoveManyProcessesDialog = (list: Array) => (dispatch: id: REMOVE_MANY_PROCESSES_DIALOG, data: { title: 'Remove processes permanently', - text: `Are you sure you want to remove all ${list.length} processes?`, + text: `Are you sure you want to remove these ${list.length} processes?`, confirmButtonLabel: 'Remove', list, }, -- 2.30.2