From 0198b4937df2be79e41ea76ea6c31841441f4f2c Mon Sep 17 00:00:00 2001 From: Tom Clegg Date: Mon, 10 Nov 2014 16:50:15 -0500 Subject: [PATCH] 4434: use select! instead of &= to preserve duplicates. --- .../test/functional/arvados/v1/groups_controller_test.rb | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/services/api/test/functional/arvados/v1/groups_controller_test.rb b/services/api/test/functional/arvados/v1/groups_controller_test.rb index 294afc292f..c974076c6f 100644 --- a/services/api/test/functional/arvados/v1/groups_controller_test.rb +++ b/services/api/test/functional/arvados/v1/groups_controller_test.rb @@ -152,8 +152,12 @@ class Arvados::V1::GroupsControllerTest < ActionController::TestCase end.uniq do |name| name[0] end - # Array#& is documented to preserve order of sorted_names. - sorted_names &= reliably_sortable_names + # Preserve order of sorted_names. But do not use &=. If + # sorted_names has out-of-order duplicates, we want to preserve + # them here, so we can detect them and fail the test below. + sorted_names.select! do |name| + reliably_sortable_names.include? name + end actually_checked_anything = false previous = nil sorted_names.each do |entry| -- 2.39.5