Tim Pierce [Mon, 26 Jan 2015 15:24:40 +0000 (10:24 -0500)]
5010: fixed integration test
Fixed a failing integration test that checked for the presence of a
collection in the Home project after being deleted. Removed the
assertion that checked the Home project post-deletion.
Tim Pierce [Fri, 23 Jan 2015 16:55:04 +0000 (11:55 -0500)]
5010: updated functional tests for new trash behavior
Renamed "project admin can remove items from the project" to "project
admin can remove collections from the project" and updated it to verify
that the target collection has actually been made inaccessible to API
queries.
Added "project admin can remove items from project other than
collections" test to verify that objects which don't support expires_at
continue to exhibit the old behavior.
Brett Smith [Wed, 21 Jan 2015 16:38:18 +0000 (11:38 -0500)]
4967: crunch-job unmounts old Keep mounts more robustly.
The previous version looked for mounts under $JOB_WORK before
unmounting anything. We long ago started mounting under $TASK_WORK,
so unmounting hasn't been working for a while. This version unmounts
every FUSE mount with "keep" in the path, so it will be much more
flexible.
I also changed the cleanup to use bash -e, so the logs are more likely
to indicate if there was trouble during the cleanup step.
Brett Smith [Thu, 15 Jan 2015 22:30:28 +0000 (17:30 -0500)]
4840: Workbench selection actions are submitted by POST.
The previous implementation could get 414 Request URI Too Long
responses by stuffing a large number of selections into the link href.
This commit sidesteps that problem by POSTing the data with a hidden
form instead. It's based on rails-ujs' strategy for handling links
with data-method that we were already using for some selection
actions, so it should be minimally disruptive.
Tim Pierce [Fri, 16 Jan 2015 19:51:28 +0000 (14:51 -0500)]
4922: force google-api-python-client install
Install google-api-python-client with 'pip install -I' to fix the case
where the Docker image already has an older version of
google-api-python-client installed.
Brett Smith [Wed, 14 Jan 2015 20:22:24 +0000 (15:22 -0500)]
3835: PySDK raises NotFoundError when all Keep services report such.
Previously, we raised this error when >= 75% of services reported
such, as the most reasonable available cutoff to make the
distinction. Now that Keep exceptions include detailed information
about the error from each service, it seems useful to make this
threshold stricter, and only raise NotFoundError when we're sure
that's the problem. See further discussion from
<https://arvados.org/issues/3835#note-11>.
Brett Smith [Fri, 9 Jan 2015 18:15:07 +0000 (13:15 -0500)]
3835: Improve error reporting in PySDK Keep client.
* Create a KeepRequestError base exception to store information about
errors encountered when talking to Keep services, and include those
in the default formatting.
* Include Keep service error information in exceptions raised by the
Keep client.
Brett Smith [Wed, 14 Jan 2015 17:47:38 +0000 (12:47 -0500)]
Python packages use python-daemon<2.
It's good to see python-daemon under active development, but they're
working out so many little issues so rapidly that we're having a hard
time keeping on top of them in our builds. We're pinning the version
until things settle down a little. No issue #.
Radhika Chippada [Wed, 14 Jan 2015 16:10:27 +0000 (11:10 -0500)]
3686: Support sharing pane in repository show page.
Refactor current project sharing work into application area and reuse it for sharing repositories.
Refactor methods used by tests into helper and reuse in repository sharing tests.
Peter Amstutz [Mon, 12 Jan 2015 17:23:40 +0000 (12:23 -0500)]
4924: Update prints uuid from results, not the uuid originally specified.
Catch Oj::ParseError as well as JSON::ParserError. Titleize only HTTP status
messages, not every error message.
Peter Amstutz [Fri, 9 Jan 2015 20:37:42 +0000 (15:37 -0500)]
4924: Distinguish between errors the user can do something about (syntax errors
or well-formed server errors) and errors that the user probably can't recover
from (everything else.) Prints "Updated object" on success.