Be consistent about the version of ruby that is installed by rvm and
used by the various containers. Be consistent about using rvm-exec and
bundle exec in every command that uses ruby.
Add documentation and warning about --realclean option to build.sh
Brett Smith [Wed, 9 Jul 2014 01:32:40 +0000 (21:32 -0400)]
3201: Simplify logic to decide "My Projects" is selectable.
Thinking about it on the commute home, I decided that my previous
implementation that inspected action_href (e007ef71) was too clever by
half. Following the adage that explicit is better than implicit, this
version provides a knob you can turn to just say whether or not "My
Projects" is selectable.
Brett Smith [Tue, 8 Jul 2014 22:06:45 +0000 (18:06 -0400)]
3201: Only Projects can be moved to "My Projects."
Before this commit, it was possible to move any object that goes in
folders to "My Projects." If you did, it would be removed from any
project, and owned by the user directly. This is non-obvious. Data
should be removed from projects by using the trash icon on the project
page instead.
This is the same principle that we already take with POST parameters,
applied to the body of the Job itself. It immediately prevents
sending nil runtime_constraints, which the API server doesn't accept.
It should also mean that any error messages passed on from the API
server are more likely to be helpful.
Brett Smith [Tue, 8 Jul 2014 19:59:39 +0000 (15:59 -0400)]
3209: arv-run-pipeline-instance sends instance body as JSON.
If we don't encode the body as JSON ourselves, the API client library
will omit empty attributes. This can cause required component
attributes like script_parameters to be lost, so we need to circumvent
that behavior. It also seems safe, since we already do the same
encoding in the update method. Closes #3209.
Brett Smith [Mon, 7 Jul 2014 21:52:31 +0000 (17:52 -0400)]
3176: Fix arv-put's resume cache writing.
Refactoring directory creation into _util accidentally broke this:
arv-put was trying to save the cache to a relatively directory that
almost never existed, and then silently ignored the error.
refs #3140
Revert back the UI to display only one tab instead of 5 content tabs since it is not working when accessing a project with large amounts of data.
Merge branch '3140-undo-project-content-tabs'
Peter Amstutz [Mon, 7 Jul 2014 20:54:17 +0000 (16:54 -0400)]
Don't use "arv" command wrapper, call arv-get/arv-put directly. Avoids
dependency on arvados-cli gem being properly configured on compute node.
no issue #
Peter Amstutz [Mon, 7 Jul 2014 19:45:24 +0000 (15:45 -0400)]
arv-run-pipeline-instance sends error message to logs table when job submission
fails. Pipeline instance view in workbench now shows messages for the pipeline
instance (in addition to the jobs) and shows messages when the pipeline is
failed (not only when it is running.)
crunch-dispatch: make sure to update the info['slurm_state'] for the
correct node, not just the first one that happens to have a matching
hostname in our database.
Peter Amstutz [Mon, 7 Jul 2014 18:09:20 +0000 (14:09 -0400)]
Consider script_parameters in determining whether to merge script boxes in
pipeline graph drawing. Also tweaks behavior generating label for
script_parameter boxes to be more compact. closes #3100
Tom Clegg [Fri, 4 Jul 2014 17:01:28 +0000 (13:01 -0400)]
3185: Fix job validation failure with no errors given.
* Do not fail docker validation if runtime_constraints==nil.
* Reposition "check docker image" and "check script version" as
validations, rather than before_validation and before_create/update
filters respectively.
* Use valid values for the non-docker attributes in docker test cases.
* Add tests to ensure job validation failures provide error messages.
Move test/functional/arvados/v1/git_setup.rb to
test/helpers/git_test_helper.rb and fix bugs:
* Use "setup do" form instead of "def setup" to avoid clobbering other
setup tasks
* Restore git_repositories_dir to its original value during teardown,
to avoid polluting other tests