Lucas Di Pentima [Wed, 20 Jan 2021 15:29:58 +0000 (12:29 -0300)]
Merge branch '17109-keepweb-urls-pdh-support'
Refs #17109
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Fri, 15 Jan 2021 19:59:34 +0000 (20:59 +0100)]
Merge branch '17256-file-selection-dialog-issue'
refs #16256
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Fri, 15 Jan 2021 17:18:50 +0000 (18:18 +0100)]
17256: Code optimisation
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Thu, 14 Jan 2021 21:34:35 +0000 (18:34 -0300)]
17109: Adds support for inline keep-web PDH URLs.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Thu, 14 Jan 2021 20:56:37 +0000 (21:56 +0100)]
17256: Added map to enable item resolution
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Peter Amstutz [Thu, 14 Jan 2021 19:17:42 +0000 (14:17 -0500)]
Merge branch '17257-wf-advanced-settings' refs #17257
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Thu, 14 Jan 2021 19:17:13 +0000 (14:17 -0500)]
17257: Don't export DEFAULT_ADVANCED_FORM_VALUES any more
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Thu, 14 Jan 2021 18:28:54 +0000 (13:28 -0500)]
17257: openRunProcess calls getWorkflowRunnerSettings for correct defaults
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Lucas Di Pentima [Thu, 14 Jan 2021 13:58:01 +0000 (10:58 -0300)]
Merge branch '17109-keepweb-webdav-urls'
Refs #17109
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Wed, 13 Jan 2021 15:45:41 +0000 (16:45 +0100)]
Merge branch '17231-stuck-on-loading-page-after-login'
closes #17231
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Wed, 13 Jan 2021 12:57:18 +0000 (13:57 +0100)]
17231: Moved redirect code to other lifecycle method
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Tue, 12 Jan 2021 23:32:30 +0000 (20:32 -0300)]
17109: Hopefully fixes several integration test flakyness issues.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 12 Jan 2021 22:12:25 +0000 (19:12 -0300)]
17109: Fixes related unit test.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 12 Jan 2021 21:38:01 +0000 (18:38 -0300)]
17109: Merge branch 'master' into 17109-keepweb-webdav-urls
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 12 Jan 2021 21:33:50 +0000 (18:33 -0300)]
17109: Handles keep-web's inline wildcard urls correctly.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Tue, 12 Jan 2021 16:09:05 +0000 (17:09 +0100)]
Merge branch '15771-deleting-a-selection-of-files-fails'
closes #15771
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Tue, 12 Jan 2021 10:28:42 +0000 (11:28 +0100)]
15771: Fixed failing unit tests
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Mon, 11 Jan 2021 15:58:44 +0000 (16:58 +0100)]
Merge branch '17016-delete-single-file-deletes-whole-collection'
closes #17016
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Fri, 8 Jan 2021 20:59:27 +0000 (21:59 +0100)]
17231: Added timeout to allow app to load properly before redirect
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>01~
Peter Amstutz [Fri, 8 Jan 2021 19:28:20 +0000 (14:28 -0500)]
Add test guards to wait for progress bar to complete before continuing
no issue #
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Daniel Kutyła [Fri, 8 Jan 2021 16:37:32 +0000 (17:37 +0100)]
17016: Added more unit tests
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Peter Amstutz [Fri, 8 Jan 2021 16:18:25 +0000 (11:18 -0500)]
Fix type refs #17234
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Daniel Kutyła [Thu, 7 Jan 2021 21:34:07 +0000 (22:34 +0100)]
17016: Code optimisation
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Peter Amstutz [Thu, 7 Jan 2021 16:50:46 +0000 (11:50 -0500)]
Merge branch '17234-wf-runner-ram' refs #17234
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Wed, 6 Jan 2021 22:22:36 +0000 (17:22 -0500)]
Merge branch '16622-dav-s3-dialog' refs #16622
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Wed, 6 Jan 2021 22:14:10 +0000 (17:14 -0500)]
17234: Set RAM request for runner container consistently with a-c-r
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Wed, 6 Jan 2021 21:13:13 +0000 (16:13 -0500)]
16622: Add Enzyme tests for WebDavS3InfoDialog
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Tue, 5 Jan 2021 21:56:25 +0000 (16:56 -0500)]
16622: Show connection info for projects as well.
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Tue, 5 Jan 2021 21:00:19 +0000 (16:00 -0500)]
16622: Make the http version a link too
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Tue, 5 Jan 2021 20:57:58 +0000 (15:57 -0500)]
16622: Tweak icon & titles
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Tue, 5 Jan 2021 20:44:08 +0000 (15:44 -0500)]
16622: Use /by_id/, add Cyberduck and MacOS to popup.
Correctly select between collections and download endpoints depending
on whether wildcard DNS is configured.
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Daniel Kutyła [Tue, 5 Jan 2021 20:23:15 +0000 (21:23 +0100)]
17231: Changed the way we navigate to a other page
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Tue, 5 Jan 2021 18:40:31 +0000 (19:40 +0100)]
17016: Added browser test
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Peter Amstutz [Mon, 4 Jan 2021 20:56:03 +0000 (15:56 -0500)]
16622: Dialog with connection details for WebDAV and S3
Uses tabs to reduce visual clutter
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Mon, 4 Jan 2021 16:28:14 +0000 (11:28 -0500)]
Merge branch '17223-webshell' refs #17223
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Wed, 23 Dec 2020 20:24:15 +0000 (15:24 -0500)]
17223: Provide working webshell link by directing user to Workbench1
Eventual fix will be to add the actual webshell javascript terminal
into Workbench 2.
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Lucas Di Pentima [Mon, 14 Dec 2020 22:08:10 +0000 (19:08 -0300)]
Merge branch '17152-always-preserve-collection-versions'
Closes #17152
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 11 Dec 2020 22:26:36 +0000 (19:26 -0300)]
17152: Avoids returning for code consistency reasons.
Other webdav funcs don't return values, and there's no client code expecting
an answer from that func.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 11 Dec 2020 15:41:30 +0000 (12:41 -0300)]
17152: Avoids doing one extra request to persist versions on update.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Tue, 8 Dec 2020 21:17:12 +0000 (22:17 +0100)]
Merge branch '16812-images-issue-fix'
Closes #16812
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Tue, 8 Dec 2020 21:15:47 +0000 (22:15 +0100)]
16812: Tests improvements
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Tue, 8 Dec 2020 18:21:02 +0000 (19:21 +0100)]
16812: Adding token as query param
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Mon, 7 Dec 2020 19:39:33 +0000 (20:39 +0100)]
16812: Fixed img preview for collection items
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Fri, 4 Dec 2020 21:41:11 +0000 (18:41 -0300)]
17152: Adjusts cypress integration tests.
* Changes arvados' config disabling the collection idle versioning feature.
* Fixes one test that required versioning when updating via API calls.
The rest of the versioning tests continue to work because of the updates made
on workbench2.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 3 Dec 2020 21:58:22 +0000 (18:58 -0300)]
17152: Adjusts the collection service methods to preserve versions.
As the create() method sets preserve_version to true, it's better
to re-set it to true after each update, so that the modified_at timestamp
of the previous version doesn't change.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 2 Dec 2020 13:37:28 +0000 (10:37 -0300)]
Merge branch '17098-old-version-as-head'
Closes #17098
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Tue, 1 Dec 2020 22:04:59 +0000 (23:04 +0100)]
17016: Fixed deleteFiles function
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Tue, 1 Dec 2020 21:26:32 +0000 (18:26 -0300)]
17098: Improves wording on the "Restore version" action.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 1 Dec 2020 13:27:16 +0000 (10:27 -0300)]
17098: Improves dialog message wording.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Mon, 30 Nov 2020 23:13:10 +0000 (20:13 -0300)]
17098: Adds confirmation dialog on 'Recover version' action.
Also updates integeration test.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Fri, 27 Nov 2020 19:00:19 +0000 (20:00 +0100)]
Merge branch '17114-side-panel-tree-as-list'
Refs #17114
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Thu, 26 Nov 2020 20:30:26 +0000 (21:30 +0100)]
17114: Code cleanup
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Wed, 25 Nov 2020 19:05:00 +0000 (16:05 -0300)]
17098: Removes unnecessary prop.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 25 Nov 2020 17:54:07 +0000 (14:54 -0300)]
17098: Adjusts resourceUuidToContextMenuKind() call on version browser.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 25 Nov 2020 17:53:29 +0000 (14:53 -0300)]
17098: Merge branch 'master' into 17098-old-version-as-head
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 25 Nov 2020 17:31:29 +0000 (14:31 -0300)]
Merge branch '13494-collection-version-browser'
Closes #13494
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 25 Nov 2020 16:25:17 +0000 (13:25 -0300)]
17098: Updates integration test for the 'recover version' operation.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 25 Nov 2020 16:08:19 +0000 (13:08 -0300)]
17098: Avoids offering the 'Add to favorites' action on old versions.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 25 Nov 2020 15:19:02 +0000 (12:19 -0300)]
17098: Adds integration test checks for the new action.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 25 Nov 2020 15:00:59 +0000 (12:00 -0300)]
17098: Fixes unit test for refactored menu kind function.
Added 'redux-mock-store' package that will allow us to unit test dispatched
actions.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Tue, 24 Nov 2020 22:04:10 +0000 (23:04 +0100)]
17114: FlatTree introduced to support old behaviour
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Tue, 24 Nov 2020 20:02:54 +0000 (17:02 -0300)]
13494: Adds context menu support to collection versions browser.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Tue, 24 Nov 2020 17:04:31 +0000 (18:04 +0100)]
17114: Code cleanup, style cleanup
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>01~
Lucas Di Pentima [Mon, 23 Nov 2020 22:38:16 +0000 (19:38 -0300)]
17098: Adds ability to recover an old version collection as the head version.
This includes a proper menu action set for old collections with the new action.
Also, duplicated code was removed for the collection admin menu action set.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Mon, 23 Nov 2020 22:22:22 +0000 (19:22 -0300)]
17098: Refactors context menu's kind decision function.
Over time, the function got several optional arguments that were mostly
intrinsic of the resource being queried, or the user type. This produced lot
of duplicated and error prone code on the caller's side.
Now, all callers only need to provide a uuid, the will get the same result.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Mon, 23 Nov 2020 16:08:18 +0000 (13:08 -0300)]
17098: Removes unused code file.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 20 Nov 2020 22:22:47 +0000 (19:22 -0300)]
13494: Re-activates other collection related tests.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 20 Nov 2020 21:54:38 +0000 (18:54 -0300)]
13494: Adds integration test for collection version browsing.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 20 Nov 2020 18:07:04 +0000 (15:07 -0300)]
13494: Forces complete collection panel reload on after file operations.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Thu, 19 Nov 2020 23:31:11 +0000 (00:31 +0100)]
17114: Replaced tree with list for children items
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Thu, 19 Nov 2020 19:17:59 +0000 (16:17 -0300)]
13494: Adds explaining tooltip to version number link on collection panel.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 19 Nov 2020 16:13:06 +0000 (13:13 -0300)]
13494: Fixes another integration test check.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 19 Nov 2020 13:48:49 +0000 (10:48 -0300)]
13494: Fixes integration test.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 18 Nov 2020 21:46:21 +0000 (18:46 -0300)]
13494: Makes several operations asynchronous.
Details panel's collection version browser refresh, property addition and
removal, file renaming and removal are now asynchronous.
Also, the details panel gets reloaded when this collection operations take
place.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 18 Nov 2020 21:43:45 +0000 (18:43 -0300)]
13494: Simplifies collection update action calling.
Also makes action asynchronous, and refresh details panel after the update
operation is done.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 18 Nov 2020 21:41:43 +0000 (18:41 -0300)]
13494: Avoids doing unnecessary API requests on collection's move action.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 18 Nov 2020 21:39:58 +0000 (18:39 -0300)]
13494: Fixes multi-value property removal.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 18 Nov 2020 18:21:23 +0000 (15:21 -0300)]
13494: Adds version number on collection's status renderer.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 18 Nov 2020 15:19:35 +0000 (12:19 -0300)]
13494: Enhances collection versions browser's layout.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 18 Nov 2020 14:30:48 +0000 (11:30 -0300)]
13494: Avoids unnecessary details panel re-renders.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 17 Nov 2020 15:25:42 +0000 (12:25 -0300)]
13494: Maintains 'Head version' data on the collection panel.
This is to avoid the rest of the information changing places on the panel.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 13 Nov 2020 22:50:04 +0000 (19:50 -0300)]
13494: Allows the user to open the versions tab by clicking on the version nr.
This is done by syncing the details panel component state with the general app
state where we currently store the active tab number.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 13 Nov 2020 19:54:35 +0000 (16:54 -0300)]
13494: Forces version list retrieval when details panel is toggled on.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 13 Nov 2020 18:16:19 +0000 (15:16 -0300)]
13494: Adds content to the "versions" tab on collection's details panel.
Old versions are requested only when the details panel is open.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 12 Nov 2020 19:51:00 +0000 (16:51 -0300)]
13494: Merge branch 'master' into 13494-collection-version-browser
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 12 Nov 2020 19:32:07 +0000 (16:32 -0300)]
Merge branch '15685-file-renaming-empty-name'
Closes #15685
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 12 Nov 2020 19:31:01 +0000 (16:31 -0300)]
15685: Adds missing redux-form configs for immediate validation feedback.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 12 Nov 2020 19:14:07 +0000 (16:14 -0300)]
15685: Adds validations to file names to avoid '.' and '..'
Although the backend already does validations, this will provide a better UX
because of the immediate feedback and better error message.
Also, adjusted tests.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 12 Nov 2020 19:11:54 +0000 (16:11 -0300)]
15685: Sets dialog forms to get immediate validation feedback.
Surprinsingly, this setting is off by default:
https://redux-form.com/7.4.2/docs/api/reduxform.md/#-code-touchonchange-boolean-code-optional-
...so validations only happened after the first field blur event.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Thu, 12 Nov 2020 17:12:56 +0000 (18:12 +0100)]
Merge branch '16005-collections-projects-open-in-new-tab'
closes #16005
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Thu, 12 Nov 2020 17:11:38 +0000 (18:11 +0100)]
16005: Removed unused functions
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Thu, 12 Nov 2020 17:02:37 +0000 (18:02 +0100)]
Merge branch '17101-login-doesnt-navigate-user-back-to-original-path'
closes #17101
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Thu, 12 Nov 2020 15:27:24 +0000 (12:27 -0300)]
13494: Fixes edge case on file size formatter.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 12 Nov 2020 15:24:54 +0000 (12:24 -0300)]
13494: Sets "owner" column off by default on different panels.
Also adds the column to "Public favorites" panel, but keep it off by default.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 12 Nov 2020 00:44:29 +0000 (21:44 -0300)]
15685: Fixed a rename test case that shouldn't be allowed on WB2.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 12 Nov 2020 00:12:43 +0000 (21:12 -0300)]
15685: Adds integration tests, fixes rename dialog error reporting.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 11 Nov 2020 21:46:47 +0000 (18:46 -0300)]
15685: Cleans up tests with example data.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Peter Amstutz [Wed, 11 Nov 2020 21:33:12 +0000 (16:33 -0500)]
17101: Use redux router instead of setting window.location.href
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Lucas Di Pentima [Wed, 11 Nov 2020 21:25:45 +0000 (18:25 -0300)]
15685: Adds empty dir name validation to rename file dialog.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 11 Nov 2020 21:10:28 +0000 (18:10 -0300)]
15685: Adds file path validation on rename file dialog.
Also, allows edition of the complete path instead of just the name, to mnatch
workbench1 behavior, enabling the user to move the file to a directory inside
the collection.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
projects / arvados.git / log