arvados.git
9 years ago3550: Remove extraneous "to" in usage message.
Tom Clegg [Tue, 16 Sep 2014 19:59:04 +0000 (15:59 -0400)]
3550: Remove extraneous "to" in usage message.

9 years ago3411: set default collection expiration policy
Tim Pierce [Tue, 16 Sep 2014 04:57:44 +0000 (00:57 -0400)]
3411: set default collection expiration policy

* Added default_scope to Collections restricting them to collections that
  have not yet expired

* Added a default_trash_lifetime setting in application.default.yml,
  exposed in the discovery doc setting 'defaultTrashLifetime' (default:
  2 weeks)

* Added test fixtures to exercise fetching expired collections and
  collections that expire in the future.

9 years ago3878: Fix block cache sharing across threads so arv-mount uses a bounded amount
Peter Amstutz [Tue, 16 Sep 2014 18:49:38 +0000 (14:49 -0400)]
3878: Fix block cache sharing across threads so arv-mount uses a bounded amount
of memory to store block.  Also fixes bug in cache management code and cleans
some exception handler error reporting.

9 years agoMerge branch 'master' into 2761-diagnostic-suite
radhika [Tue, 16 Sep 2014 17:01:26 +0000 (13:01 -0400)]
Merge branch 'master' into 2761-diagnostic-suite

9 years agocloses #2875
radhika [Tue, 16 Sep 2014 15:28:53 +0000 (11:28 -0400)]
closes #2875
Merge branch '2875-pipeline-description'

9 years ago2875: minor text update
radhika [Tue, 16 Sep 2014 15:27:30 +0000 (11:27 -0400)]
2875: minor text update

9 years ago2875: collection description is now textile and also the display is updated.
radhika [Tue, 16 Sep 2014 15:22:02 +0000 (11:22 -0400)]
2875: collection description is now textile and also the display is updated.

9 years ago2875: remove junk migration lines
radhika [Tue, 16 Sep 2014 14:54:53 +0000 (10:54 -0400)]
2875: remove junk migration lines

9 years ago3877: Fix memory leak after "log truncated" decision. Clean up code.
Tom Clegg [Tue, 16 Sep 2014 14:51:27 +0000 (10:51 -0400)]
3877: Fix memory leak after "log truncated" decision. Clean up code.

9 years ago3705: update for code review
Tim Pierce [Tue, 16 Sep 2014 06:15:13 +0000 (02:15 -0400)]
3705: update for code review

* Changed the type of the NextItem channel from *list.Element to
  interface{} (i.e. a list.Element.Value)
* Better comments
* Cleaner testing framework
* TestBlockWorkListReaderBlocks to exercise the case where readers block
  when the list is exhausted, and resume when new data is supplied.

9 years ago3705: describe BlockWorkList flow more explicitly
Tim Pierce [Mon, 15 Sep 2014 22:19:40 +0000 (18:19 -0400)]
3705: describe BlockWorkList flow more explicitly

Updated file comments to describe the overall data flow for a
BlockWorkList manager and worker more explicitly.

9 years ago3550: Update docs to match new flag name. Add note about job re-use.
Tom Clegg [Mon, 15 Sep 2014 16:20:15 +0000 (12:20 -0400)]
3550: Update docs to match new flag name. Add note about job re-use.

9 years agoMerge branch 'master' into 2761-diagnostic-suite
radhika [Mon, 15 Sep 2014 16:01:58 +0000 (12:01 -0400)]
Merge branch 'master' into 2761-diagnostic-suite

Conflicts:
apps/workbench/config/application.default.yml

9 years agono issue # fix failing test to use selenium driver
radhika [Mon, 15 Sep 2014 15:27:45 +0000 (11:27 -0400)]
no issue # fix failing test to use selenium driver

9 years ago2875: integration tests to verify description on pipeline templates, instances, and...
radhika [Mon, 15 Sep 2014 14:54:10 +0000 (10:54 -0400)]
2875: integration tests to verify description on pipeline templates, instances, and jobs.

9 years ago3550: Merge branch 'master' into 3550-local-pipeline
Tom Clegg [Mon, 15 Sep 2014 13:55:22 +0000 (09:55 -0400)]
3550: Merge branch 'master' into 3550-local-pipeline

9 years ago3550: Clarify help message, mention that there are limitations.
Tom Clegg [Mon, 15 Sep 2014 13:55:14 +0000 (09:55 -0400)]
3550: Clarify help message, mention that there are limitations.

9 years agoUpdated Gemfile to pull in changes from commit:ac594f1 refs #3187
Peter Amstutz [Mon, 15 Sep 2014 13:46:54 +0000 (09:46 -0400)]
Updated Gemfile to pull in changes from commit:ac594f1 refs #3187

9 years ago2875: render template description as textile attribte in show recent page
radhika [Mon, 15 Sep 2014 12:18:37 +0000 (08:18 -0400)]
2875: render template description as textile attribte in show recent page

9 years ago2875: add description option
radhika [Mon, 15 Sep 2014 12:10:29 +0000 (08:10 -0400)]
2875: add description option

9 years ago2875: add initial description to pipeline instance when created using arv-run-pipelin...
radhika [Fri, 12 Sep 2014 22:15:21 +0000 (18:15 -0400)]
2875: add initial description to pipeline instance when created using arv-run-pipeline-instance script

9 years agoMerge branch 'master' into 2875-pipeline-description
radhika [Fri, 12 Sep 2014 20:49:57 +0000 (16:49 -0400)]
Merge branch 'master' into 2875-pipeline-description

9 years agocloses #3654
radhika [Fri, 12 Sep 2014 20:46:51 +0000 (16:46 -0400)]
closes #3654
Merge branch '3654-combine-selections'

9 years agoMerge branch 'master' into 3654-combine-selections
radhika [Fri, 12 Sep 2014 20:43:28 +0000 (16:43 -0400)]
Merge branch 'master' into 3654-combine-selections

9 years ago2875: initial description on pipeline instance when the template has no name.
radhika [Fri, 12 Sep 2014 20:41:48 +0000 (16:41 -0400)]
2875: initial description on pipeline instance when the template has no name.

9 years agoMerge branch 'master' into 2875-pipeline-description
radhika [Fri, 12 Sep 2014 19:48:45 +0000 (15:48 -0400)]
Merge branch 'master' into 2875-pipeline-description

9 years ago2875: set initial description on the new pipeline instance created by running a template.
radhika [Fri, 12 Sep 2014 19:46:05 +0000 (15:46 -0400)]
2875: set initial description on the new pipeline instance created by running a template.

9 years agoBug fix: manifests with extra spaces
Tim Pierce [Fri, 12 Sep 2014 19:18:15 +0000 (15:18 -0400)]
Bug fix: manifests with extra spaces

Extend the regular expression to match manifest_text to permit more than
a single space in manifest entries (seen in e.g. 91534558193f42a2f7f8aca872e5a78d+15723)

No issue #

9 years ago3654: disable search icon collection show page rather than hide it when it is not...
radhika [Fri, 12 Sep 2014 18:19:44 +0000 (14:19 -0400)]
3654: disable search icon collection show page rather than hide it when it is not applicable.

9 years agoMerge branch 'master' into 3654-combine-selections
radhika [Fri, 12 Sep 2014 17:26:37 +0000 (13:26 -0400)]
Merge branch 'master' into 3654-combine-selections

9 years agoMerge branch 'master' into 2875-pipeline-description
radhika [Fri, 12 Sep 2014 17:23:06 +0000 (13:23 -0400)]
Merge branch 'master' into 2875-pipeline-description

Conflicts:
services/api/app/models/pipeline_instance.rb
services/api/db/structure.sql

9 years ago2875: add new partial to display name and description.
radhika [Fri, 12 Sep 2014 17:17:14 +0000 (13:17 -0400)]
2875: add new partial to display name and description.

9 years ago3605: Provide "info" field to all requesters. Filters out any keys with text
Peter Amstutz [Fri, 12 Sep 2014 14:25:55 +0000 (10:25 -0400)]
3605: Provide "info" field to all requesters.  Filters out any keys with text
"secret" to non-admin users.  Also fix fiddlesticks on workbench viewing
details for node.

9 years agoMerge branch '3187-start-finish-timestamps-tasks-pipelines' refs #3187
Peter Amstutz [Fri, 12 Sep 2014 13:43:34 +0000 (09:43 -0400)]
Merge branch '3187-start-finish-timestamps-tasks-pipelines' refs #3187

9 years agoFixed typo Y% -> %Y
Peter Amstutz [Fri, 12 Sep 2014 13:39:09 +0000 (09:39 -0400)]
Fixed typo Y% -> %Y

9 years ago3654: update tests to match the selection dropdown text changes.
radhika [Thu, 11 Sep 2014 23:37:39 +0000 (19:37 -0400)]
3654: update tests to match the selection dropdown text changes.

9 years ago2875: add description to jobs and pipeline_instances.
radhika [Thu, 11 Sep 2014 23:20:04 +0000 (19:20 -0400)]
2875: add description to jobs and pipeline_instances.

9 years agoIncluded included file.
mishaz [Thu, 11 Sep 2014 22:30:46 +0000 (22:30 +0000)]
Included included file.

9 years agoMoved code to seperate file for syntax coloring.
mishaz [Thu, 11 Sep 2014 22:29:27 +0000 (22:29 +0000)]
Moved code to seperate file for syntax coloring.
Switched to using arv.List instead of arv.Call.

9 years ago3338: Tests that the fixture collection count for a project matches what is displayed...
Phil Hodgson [Thu, 11 Sep 2014 22:18:39 +0000 (18:18 -0400)]
3338: Tests that the fixture collection count for a project matches what is displayed in the tab

9 years ago3338: vital action missing from previous commit
Phil Hodgson [Thu, 11 Sep 2014 21:49:15 +0000 (17:49 -0400)]
3338: vital action missing from previous commit

9 years ago3338: System in place that allows for item counts to be displayed next to tab titles...
Phil Hodgson [Thu, 11 Sep 2014 21:30:59 +0000 (17:30 -0400)]
3338: System in place that allows for item counts to be displayed next to tab titles via AJAX.
(Currently does not refresh itself after activities such as adding or removing items, but this is now eminently possible.)

9 years agoMerge branch 'master' into 3654-combine-selections
radhika [Thu, 11 Sep 2014 20:19:52 +0000 (16:19 -0400)]
Merge branch 'master' into 3654-combine-selections

9 years ago3654: move the checkbox to the left of the row in collection show page. also, fixed...
radhika [Thu, 11 Sep 2014 20:18:07 +0000 (16:18 -0400)]
3654: move the checkbox to the left of the row in collection show page. also, fixed a bug where the newly added selection dropdown shows up in the collection file chooser popup.

9 years ago3187: Update the task start time when the task actually starts.
Peter Amstutz [Thu, 11 Sep 2014 19:54:50 +0000 (15:54 -0400)]
3187: Update the task start time when the task actually starts.

9 years agoFallout from #3036: the test for the checkbox value on acceptance of the
Ward Vandewege [Thu, 11 Sep 2014 19:01:41 +0000 (15:01 -0400)]
Fallout from #3036: the test for the checkbox value on acceptance of the
user agreement was expecting a keep hash, rather than an Arvados UUID.

This fixes accepting the user agreement (if one or more are present).

refs #3036

9 years ago3654: add a default name to newly created combined collection
radhika [Thu, 11 Sep 2014 19:01:07 +0000 (15:01 -0400)]
3654: add a default name to newly created combined collection

9 years ago3705: replace pullmgr with a BlockWorkList
Tim Pierce [Thu, 11 Sep 2014 18:44:48 +0000 (14:44 -0400)]
3705: replace pullmgr with a BlockWorkList

9 years agoMerge branch 'master' into 3654-combine-selections
radhika [Thu, 11 Sep 2014 17:38:00 +0000 (13:38 -0400)]
Merge branch 'master' into 3654-combine-selections

9 years agoClean up manifest whitespace in split-fastq.
Brett Smith [Thu, 11 Sep 2014 15:21:36 +0000 (11:21 -0400)]
Clean up manifest whitespace in split-fastq.

The previous code was generating two spaces between the stream name
and block list, because it had the space from as_manifest() as well as
its own join.  This yielded an invalid manifest.

No issue #.

9 years ago2761: update comment
radhika [Thu, 11 Sep 2014 14:33:41 +0000 (10:33 -0400)]
2761: update comment

9 years ago2761: input selection revisited
radhika [Thu, 11 Sep 2014 14:02:58 +0000 (10:02 -0400)]
2761: input selection revisited

9 years ago3661: tentative implementation of Capybara "best practice" of using that class's...
Phil Hodgson [Thu, 11 Sep 2014 13:37:07 +0000 (09:37 -0400)]
3661: tentative implementation of Capybara "best practice" of using that class's reset_sessions! in the teardown

9 years ago3661: Add a new test that ensures that the new "Copy to project" button works for...
Phil Hodgson [Thu, 11 Sep 2014 13:35:27 +0000 (09:35 -0400)]
3661: Add a new test that ensures that the new "Copy to project" button works for collections

9 years agoMerge branch 'master' into 3187-start-finish-timestamps-tasks-pipelines
Peter Amstutz [Thu, 11 Sep 2014 13:02:14 +0000 (09:02 -0400)]
Merge branch 'master' into 3187-start-finish-timestamps-tasks-pipelines

9 years agoMerge branch 'master' into 2761-diagnostic-suite
radhika [Thu, 11 Sep 2014 02:27:19 +0000 (22:27 -0400)]
Merge branch 'master' into 2761-diagnostic-suite

9 years ago2761: file path needs lookup in prevew panel
radhika [Thu, 11 Sep 2014 02:26:28 +0000 (22:26 -0400)]
2761: file path needs lookup in prevew panel

9 years ago3705: add BlockWorkList and unit tests
Tim Pierce [Wed, 10 Sep 2014 17:38:07 +0000 (13:38 -0400)]
3705: add BlockWorkList and unit tests

9 years agoPrevent PySDK CollectionReader from sending UUIDs to Keep.
Brett Smith [Wed, 10 Sep 2014 21:00:21 +0000 (17:00 -0400)]
Prevent PySDK CollectionReader from sending UUIDs to Keep.

No issue #.  I tickled this while I was working on #3147.  Ward saw
the apparent symptom come up in a Job log, so I'm pushing the fix at
his request.  I have a test prepared in my branch, along with a bunch
of test infrastructure.

9 years ago2761: test in staging.
radhika [Wed, 10 Sep 2014 20:13:07 +0000 (16:13 -0400)]
2761: test in staging.

9 years agoMerge branch 'master' into 2761-diagnostic-suite
radhika [Wed, 10 Sep 2014 19:36:11 +0000 (15:36 -0400)]
Merge branch 'master' into 2761-diagnostic-suite

9 years ago2761: wait for the pipeline run to complete or until wait time exceeds.
radhika [Wed, 10 Sep 2014 19:32:39 +0000 (15:32 -0400)]
2761: wait for the pipeline run to complete or until wait time exceeds.

9 years ago3846: Improve timeout handling in PySDK KeepClient.
Brett Smith [Wed, 10 Sep 2014 18:22:01 +0000 (14:22 -0400)]
3846: Improve timeout handling in PySDK KeepClient.

* Catch socket errors (including timeouts) and treat them as
  transient with regard to retry logic.
* Increase the default timeout to 5 minutes.  Given how long it can
  take to PUT 64MiB to a proxy and wait for two servers to return
  success, this seems like a reasonable default.  Future improvements
  could set different timeouts based on the request type and whether
  or not we're talking to a proxy.

Closes #3846.

9 years ago3661: make existing tests pass
Phil Hodgson [Wed, 10 Sep 2014 18:11:12 +0000 (14:11 -0400)]
3661: make existing tests pass

9 years agoMerge branch 'master' into 2761-diagnostic-suite
radhika [Wed, 10 Sep 2014 17:47:08 +0000 (13:47 -0400)]
Merge branch 'master' into 2761-diagnostic-suite

9 years ago2761: test updates to be able to handle multiple inputs
radhika [Wed, 10 Sep 2014 17:45:47 +0000 (13:45 -0400)]
2761: test updates to be able to handle multiple inputs

9 years ago3661: Added buttons for Copy and Move to the general #show page, showing them if...
Phil Hodgson [Wed, 10 Sep 2014 16:48:54 +0000 (12:48 -0400)]
3661: Added buttons for Copy and Move to the general #show page, showing them if the model class #goes_in_projects?

9 years ago3842: Keep::Manifest concatenates file information from manifest.
Brett Smith [Wed, 10 Sep 2014 16:39:58 +0000 (12:39 -0400)]
3842: Keep::Manifest concatenates file information from manifest.

The previous implementation failed to consider the possibility that
file information would be spread across multiple lines of a manifest.
This would cause, e.g., the same file to be yielded many times from
each_file.

This requirement makes it impossible to return file size information
without parsing the entire manifest.  Because of that, I have reworked
the Ruby SDK API so that method names are more consistent with their
performance characteristics.  I have also added some methods to do
some basic file existence checking that do not require parsing the
whole manifest.

Closes #3842.  Refs #3720.

9 years ago2761: load inputs dynamically
radhika [Wed, 10 Sep 2014 15:45:19 +0000 (11:45 -0400)]
2761: load inputs dynamically

9 years ago2761: diagnostics testing config in application.yml
radhika [Wed, 10 Sep 2014 14:40:59 +0000 (10:40 -0400)]
2761: diagnostics testing config in application.yml

9 years ago3187: Record started_at and finished_at for tasks and pipelines.
Peter Amstutz [Tue, 9 Sep 2014 19:39:55 +0000 (15:39 -0400)]
3187: Record started_at and finished_at for tasks and pipelines.

9 years ago2761: use application.yml to configure diagnostics testing
radhika [Tue, 9 Sep 2014 19:35:58 +0000 (15:35 -0400)]
2761: use application.yml to configure diagnostics testing

9 years agoMerge branch 'master' into 2761-diagnostic-suite
radhika [Tue, 9 Sep 2014 19:19:21 +0000 (15:19 -0400)]
Merge branch 'master' into 2761-diagnostic-suite

9 years agoMerge branch 'master' into 3654-combine-selections
radhika [Tue, 9 Sep 2014 19:17:43 +0000 (15:17 -0400)]
Merge branch 'master' into 3654-combine-selections

9 years ago3654: display show icon for files only when the file suffix is one of txt, gif etc...
radhika [Tue, 9 Sep 2014 19:16:23 +0000 (15:16 -0400)]
3654: display show icon for files only when the file suffix is one of txt, gif etc. Also, fixed a bug in summary html where the collection show was failing when finished_at is not available.

9 years ago#3830: Make crunch-job's git calls more robust.
Brett Smith [Tue, 9 Sep 2014 19:16:22 +0000 (15:16 -0400)]
#3830: Make crunch-job's git calls more robust.

* Check git's exit status and only continue on 0.
* Log git's exit status after optional calls.
* Always log the resolved commit hash when it's found.

Hopefully this will prevent a recurrence of refs #3830, or help rule
out some possibilities if it does happen.  Tested by hand on 4xphq.

9 years ago3187: Migration to add started_at and finished_at to job_tasks and pipeline_instances.
Peter Amstutz [Tue, 9 Sep 2014 18:43:29 +0000 (14:43 -0400)]
3187: Migration to add started_at and finished_at to job_tasks and pipeline_instances.

9 years agoMerge branch 'master' into 3654-combine-selections
radhika [Tue, 9 Sep 2014 17:25:12 +0000 (13:25 -0400)]
Merge branch 'master' into 3654-combine-selections

9 years agoMerge branch 'master' into 2761-diagnostic-suite
radhika [Tue, 9 Sep 2014 17:24:20 +0000 (13:24 -0400)]
Merge branch 'master' into 2761-diagnostic-suite

9 years ago2761: diagnostics testing
radhika [Tue, 9 Sep 2014 17:23:49 +0000 (13:23 -0400)]
2761: diagnostics testing

9 years agoMerge branch '3453-arv-list-docker-images' closes #3453, #3472, refs #3125
Peter Amstutz [Tue, 9 Sep 2014 15:58:12 +0000 (11:58 -0400)]
Merge branch '3453-arv-list-docker-images' closes #3453, #3472, refs #3125

9 years ago3453: Rename check_project_exists to desired_project_uuid. Now raises and
Peter Amstutz [Tue, 9 Sep 2014 15:53:48 +0000 (11:53 -0400)]
3453: Rename check_project_exists to desired_project_uuid.  Now raises and
catches distinct apiclient.errors.Error, ValueError errors for project not
found or invalid uuid.

9 years agoMerge branch '3586-job-priority' closes #3586
Peter Amstutz [Tue, 9 Sep 2014 13:25:27 +0000 (09:25 -0400)]
Merge branch '3586-job-priority' closes #3586

9 years agoMerge branch 'master' into 3586-job-priority closes #3586
Peter Amstutz [Mon, 8 Sep 2014 20:56:51 +0000 (16:56 -0400)]
Merge branch 'master' into 3586-job-priority closes #3586

9 years agoAdded to Go SDK documentation:
mishaz [Mon, 8 Sep 2014 22:53:25 +0000 (22:53 +0000)]
Added to Go SDK documentation:

* Added link to instuctions on how to develop with bleeding edge client code.
* Fixed type error in documentation.
* Added instructions on how to view all returned fields with a map.

9 years agoMerge branch '3644-arv-mount-projects' closes #3644
Peter Amstutz [Mon, 8 Sep 2014 20:55:47 +0000 (16:55 -0400)]
Merge branch '3644-arv-mount-projects' closes #3644

9 years ago3453: Refactored arv-put to remove support for name links, correctly use
Peter Amstutz [Mon, 8 Sep 2014 20:54:49 +0000 (16:54 -0400)]
3453: Refactored arv-put to remove support for name links, correctly use
ensure_name_unique to prevent name collisions.  arv-keepdocker should now
correctly handle cases where the user provides a image hash instead of
repository/tag. Fixed tests.

9 years ago3644: Update tests broken by merge
Peter Amstutz [Mon, 8 Sep 2014 19:54:35 +0000 (15:54 -0400)]
3644: Update tests broken by merge

9 years ago3823: bug fixes for arvados-bcbio-nextgen.py
Tim Pierce [Mon, 8 Sep 2014 19:47:54 +0000 (15:47 -0400)]
3823: bug fixes for arvados-bcbio-nextgen.py

Refs #3823

9 years ago3644: Moved some common regex patterns into SDK
Peter Amstutz [Mon, 8 Sep 2014 19:37:55 +0000 (15:37 -0400)]
3644: Moved some common regex patterns into SDK

9 years agoMerge branch 'master' into 3644-arv-mount-projects
Peter Amstutz [Mon, 8 Sep 2014 19:07:05 +0000 (15:07 -0400)]
Merge branch 'master' into 3644-arv-mount-projects

9 years ago3644: Restore 'tag' tests and add 'SharedDirectory' and 'HomeDirectory' tests.
Peter Amstutz [Mon, 8 Sep 2014 19:06:33 +0000 (15:06 -0400)]
3644: Restore 'tag' tests and add 'SharedDirectory' and 'HomeDirectory' tests.
All tests should pass now.

9 years agoMerge branch '3663-collection-reader-performance'
Tim Pierce [Mon, 8 Sep 2014 18:06:43 +0000 (14:06 -0400)]
Merge branch '3663-collection-reader-performance'

Closes #3663.

9 years agoMerge branch 'master' into 3654-combine-selections
radhika [Mon, 8 Sep 2014 14:56:51 +0000 (10:56 -0400)]
Merge branch 'master' into 3654-combine-selections

9 years ago3453: Add ensure_unique_name=True to collection create.
Peter Amstutz [Mon, 8 Sep 2014 14:56:19 +0000 (10:56 -0400)]
3453: Add ensure_unique_name=True to collection create.

9 years ago3654: redirection to newly created collection is now working.
radhika [Mon, 8 Sep 2014 14:56:12 +0000 (10:56 -0400)]
3654: redirection to newly created collection is now working.

9 years agoMerge branch 'master' into 3453-arv-list-docker-images
Peter Amstutz [Mon, 8 Sep 2014 14:53:52 +0000 (10:53 -0400)]
Merge branch 'master' into 3453-arv-list-docker-images

9 years agoAdded create#ensure_unique_name to discovery document. "Add a subproject"
Peter Amstutz [Mon, 8 Sep 2014 14:53:32 +0000 (10:53 -0400)]
Added create#ensure_unique_name to discovery document.  "Add a subproject"
button now uses "ensure_unique_name" to avoid errors when the user creates more
than one project called "New project".  refs #3822

9 years ago3453: Create links and collection objects in the specified project, even if
Peter Amstutz [Mon, 8 Sep 2014 14:43:49 +0000 (10:43 -0400)]
3453: Create links and collection objects in the specified project, even if
the docker image has already been uploaded to some other project.

9 years agoMerge branch 'master' into 3654-combine-selections
radhika [Sat, 6 Sep 2014 19:53:17 +0000 (15:53 -0400)]
Merge branch 'master' into 3654-combine-selections