arvados.git
8 years agoMerge branch '7846-magic-invalidate-entry' closes #7846
Peter Amstutz [Thu, 21 Jan 2016 21:49:45 +0000 (16:49 -0500)]
Merge branch '7846-magic-invalidate-entry' closes #7846

8 years agoMerge branch '8008-package-testing' refs #8008
Peter Amstutz [Thu, 21 Jan 2016 19:07:11 +0000 (14:07 -0500)]
Merge branch '8008-package-testing' refs #8008

8 years ago7846: Better directory entry invalidation, fixes MagicDirApiError test. Also
Peter Amstutz [Thu, 21 Jan 2016 18:37:20 +0000 (13:37 -0500)]
7846: Better directory entry invalidation, fixes MagicDirApiError test.  Also
fix bug in typo in exception handler.

8 years agorefs #6833
radhika [Wed, 20 Jan 2016 21:15:12 +0000 (16:15 -0500)]
refs #6833
Merge branch '6833-arv-mount-cache-refresh'

8 years ago6833: get blobSignatureTtl from discovery document and use it to set the poll_time.
radhika [Mon, 11 Jan 2016 14:37:10 +0000 (09:37 -0500)]
6833: get blobSignatureTtl from discovery document and use it to set the poll_time.

8 years ago6833: add poll_time to CollectionDirectory.
radhika [Thu, 7 Jan 2016 18:14:05 +0000 (13:14 -0500)]
6833: add poll_time to CollectionDirectory.

8 years agoFix typo.
Ward Vandewege [Wed, 20 Jan 2016 18:19:58 +0000 (13:19 -0500)]
Fix typo.

refs #8248

8 years agocloses #8028
radhika [Wed, 20 Jan 2016 17:37:34 +0000 (12:37 -0500)]
closes #8028
Merge branch '8028-crunch-dispatch-local'

8 years ago8028: Update the stub based test to use waitGroup.Wait() instead of sleep.
radhika [Wed, 20 Jan 2016 17:33:16 +0000 (12:33 -0500)]
8028: Update the stub based test to use waitGroup.Wait() instead of sleep.

8 years ago8028: In runningCmds loop, no need to wait for process termination.
radhika [Wed, 20 Jan 2016 17:05:59 +0000 (12:05 -0500)]
8028: In runningCmds loop, no need to wait for process termination.

8 years ago8028: add command to waitGroup during run method itself; not during signal handling.
radhika [Wed, 20 Jan 2016 16:40:30 +0000 (11:40 -0500)]
8028: add command to waitGroup during run method itself; not during signal handling.

8 years ago8028: when a signal is received, terminate all running commands and wait in a WaitGroup.
radhika [Wed, 20 Jan 2016 12:16:05 +0000 (07:16 -0500)]
8028: when a signal is received, terminate all running commands and wait in a WaitGroup.

8 years ago8028: add signal handling to dispatcher.
radhika [Wed, 20 Jan 2016 02:40:59 +0000 (21:40 -0500)]
8028: add signal handling to dispatcher.

8 years ago8028: After getting list of Queued containers, instead of looking for containers...
radhika [Tue, 19 Jan 2016 17:16:51 +0000 (12:16 -0500)]
8028: After getting list of Queued containers, instead of looking for containers.ItemsAvailable, look for len(containers.Items)

8 years ago8028: crunch-dispatch-local implementation
radhika [Wed, 13 Jan 2016 16:15:28 +0000 (11:15 -0500)]
8028: crunch-dispatch-local implementation

8 years agoMerge branch '8248-explain-serialize'
Ward Vandewege [Wed, 20 Jan 2016 16:26:16 +0000 (11:26 -0500)]
Merge branch '8248-explain-serialize'

closes #8248

8 years agoDoc improvement: explain in more detail what the -serialize argument to
Ward Vandewege [Wed, 20 Jan 2016 16:25:20 +0000 (11:25 -0500)]
Doc improvement: explain in more detail what the -serialize argument to
keepstore does.

closes #8248

8 years agoMerge branch '7816-crunch2-exec' closes #7816
Peter Amstutz [Wed, 20 Jan 2016 16:04:51 +0000 (11:04 -0500)]
Merge branch '7816-crunch2-exec' closes #7816

8 years agoMerge branch '8177-keep-web-trust-all-content-flag' closes #8177
Tom Clegg [Wed, 20 Jan 2016 02:12:38 +0000 (21:12 -0500)]
Merge branch '8177-keep-web-trust-all-content-flag' closes #8177

8 years ago8177: Offer -trust-all-content option for no-wildcard installs.
Tom Clegg [Tue, 19 Jan 2016 22:38:05 +0000 (17:38 -0500)]
8177: Offer -trust-all-content option for no-wildcard installs.

Add alert about XSS on intranet sites.

8 years ago7816: CopyReaderToLog renamed to ReadWriteLines. Use Writer instead of Logger
Peter Amstutz [Tue, 19 Jan 2016 22:07:59 +0000 (17:07 -0500)]
7816: CopyReaderToLog renamed to ReadWriteLines.  Use Writer instead of Logger
to avoid unnecessary copy.

8 years ago8177: Expand trust_all_content comments.
Tom Clegg [Mon, 18 Jan 2016 21:17:17 +0000 (16:17 -0500)]
8177: Expand trust_all_content comments.

Skip whole check_uri block when trust_all_content.

Fix test name.

8 years ago8177: add trust_all_content config to Workbench.
radhika [Mon, 18 Jan 2016 05:04:48 +0000 (00:04 -0500)]
8177: add trust_all_content config to Workbench.

8 years ago7816: Rename to crunch-run
Peter Amstutz [Tue, 19 Jan 2016 21:43:54 +0000 (16:43 -0500)]
7816: Rename to crunch-run

8 years agoMerge branch '7996-keep-web-doc' closes #7996
Tom Clegg [Tue, 19 Jan 2016 04:19:35 +0000 (23:19 -0500)]
Merge branch '7996-keep-web-doc' closes #7996

8 years ago7996: Add keep-web to install TOC and server/cert lists.
Tom Clegg [Mon, 18 Jan 2016 02:45:46 +0000 (21:45 -0500)]
7996: Add keep-web to install TOC and server/cert lists.

8 years ago7816: Fixes recommended by golint.
Peter Amstutz [Fri, 15 Jan 2016 21:32:08 +0000 (16:32 -0500)]
7816: Fixes recommended by golint.

8 years ago7816: Change ThrottledLogger Stop() to Close(). Choose finalState once so that
Peter Amstutz [Fri, 15 Jan 2016 20:50:33 +0000 (15:50 -0500)]
7816: Change ThrottledLogger Stop() to Close().  Choose finalState once so that
log and container record can't go out of sync.  Add comments.

8 years ago8008: Remove workbench git version constraint.
Peter Amstutz [Fri, 15 Jan 2016 15:10:48 +0000 (10:10 -0500)]
8008: Remove workbench git version constraint.

8 years agoFix cli "update" example. No issue #
Tom Clegg [Thu, 14 Jan 2016 20:20:46 +0000 (15:20 -0500)]
Fix cli "update" example. No issue #

8 years agoMerge branch '8189-handle-large-collections-better' refs #8189
Tom Clegg [Thu, 14 Jan 2016 20:19:48 +0000 (15:19 -0500)]
Merge branch '8189-handle-large-collections-better' refs #8189

8 years ago8189: Use large page size only when fetching all pages.
Tom Clegg [Thu, 14 Jan 2016 18:15:08 +0000 (13:15 -0500)]
8189: Use large page size only when fetching all pages.

8 years ago8008: Add dependencies on libcurl and postgresql dev packages in order to build
Peter Amstutz [Thu, 14 Jan 2016 16:44:18 +0000 (11:44 -0500)]
8008: Add dependencies on libcurl and postgresql dev packages in order to build
gems.

8 years ago8189: Replace MAX_LIMIT const with max_items_per_response config.
Tom Clegg [Thu, 14 Jan 2016 16:27:08 +0000 (11:27 -0500)]
8189: Replace MAX_LIMIT const with max_items_per_response config.

8 years ago8189: Fix too-small page size in "fetch all pages" code.
Ward Vandewege [Thu, 14 Jan 2016 16:01:04 +0000 (11:01 -0500)]
8189: Fix too-small page size in "fetch all pages" code.

Python SDK and workbench effectively default to the API server's
MAX_LIMIT when requesting a list of objects, in those cases where no
explicit limit is set in the client code.

8 years ago8008: Add git dependency to api server and workbench.
Peter Amstutz [Wed, 13 Jan 2016 21:21:27 +0000 (16:21 -0500)]
8008: Add git dependency to api server and workbench.

8 years agoMerge branch '8014-rails-postinst-doc-update-wip'
Brett Smith [Tue, 12 Jan 2016 01:23:56 +0000 (20:23 -0500)]
Merge branch '8014-rails-postinst-doc-update-wip'

Refs #8014.  Closes #8111.

8 years ago8014: Install guide uses new Rails postinst scripts for configuration.
Brett Smith [Tue, 5 Jan 2016 22:33:11 +0000 (17:33 -0500)]
8014: Install guide uses new Rails postinst scripts for configuration.

8 years ago7816: Converted testing to use stubbed out ThinDockerClient instead of real Docker.
Peter Amstutz [Wed, 6 Jan 2016 21:38:58 +0000 (16:38 -0500)]
7816: Converted testing to use stubbed out ThinDockerClient instead of real Docker.

8 years ago7816: Crunch2 executor prototype work in progress.
Peter Amstutz [Wed, 6 Jan 2016 15:52:07 +0000 (10:52 -0500)]
7816: Crunch2 executor prototype work in progress.

8 years ago7816: Update Go SDK to use correct block locator pattern. Change FileToken
Peter Amstutz [Wed, 6 Jan 2016 15:51:28 +0000 (10:51 -0500)]
7816: Update Go SDK to use correct block locator pattern.  Change FileToken
string in manifest to FileStreamSegment struct.

8 years agocloses #7607
radhika [Tue, 5 Jan 2016 22:37:46 +0000 (17:37 -0500)]
closes #7607
Merge branch '7607-getting-started-flag'

8 years agoMerge branch 'master' into 7607-getting-started-flag
radhika [Tue, 5 Jan 2016 22:37:08 +0000 (17:37 -0500)]
Merge branch 'master' into 7607-getting-started-flag

8 years agoMerge branch '8095-install-guide-rails-sudo-wip'
Brett Smith [Tue, 5 Jan 2016 19:54:42 +0000 (14:54 -0500)]
Merge branch '8095-install-guide-rails-sudo-wip'

Closes #8095, #8096.

8 years ago8095: Make install guide bundle commands more consistent.
Brett Smith [Thu, 31 Dec 2015 16:23:34 +0000 (11:23 -0500)]
8095: Make install guide bundle commands more consistent.

* Always instruct the user to use `sudo -u`.  This prevents the
  commands from generating cache files that the web server can't write
  later.
* Always execute the command in the server's main directory.  This
  helps people run on automatic: if they leave a shell session open at
  the API server directory, they can paste in a combination of Rails
  console and script commands without `cd`ing around.
* Always give both RVM and non-RVM instructions.  There might be a
  good way to streamline this, e.g., by telling them to use rvmsudo
  when available, but that can be a later optimization.

8 years agoAdd pycurl version constraint to Python SDK because of breaking API change, refs...
Peter Amstutz [Tue, 5 Jan 2016 17:44:42 +0000 (12:44 -0500)]
Add pycurl version constraint to Python SDK because of breaking API change, refs #8104

8 years ago7607: updated user_profile_test to set getting_started config in test.
radhika [Tue, 5 Jan 2016 13:32:09 +0000 (08:32 -0500)]
7607: updated user_profile_test to set getting_started config in test.

8 years ago7607: Update application layout tests; by default getting_started is disabled and...
radhika [Mon, 4 Jan 2016 23:42:34 +0000 (18:42 -0500)]
7607: Update application layout tests; by default getting_started is disabled and hence the help menu will not include this option.
Also, added an additional test case for user with profile but no getting_started flag and expect the popup upon first login.

8 years ago7942: Skip unreliable test. refs #7942
Tom Clegg [Mon, 4 Jan 2016 21:02:54 +0000 (16:02 -0500)]
7942: Skip unreliable test. refs #7942

8 years agoMerge branch '7957-new-software-collections-install-wip'
Brett Smith [Mon, 4 Jan 2016 20:07:39 +0000 (15:07 -0500)]
Merge branch '7957-new-software-collections-install-wip'

Closes #7957, #8097.

8 years ago7957: Update Software Collections instructions in install guide.
Brett Smith [Thu, 31 Dec 2015 17:08:17 +0000 (12:08 -0500)]
7957: Update Software Collections instructions in install guide.

* Document the process we currently follow on CentOS 6.
* Add a reference for RHEL instructions.
* Move noteboxes up, so people can follow the instructions
  linearly ("enable Software Collections, then install the packages").

8 years agoMerge branch '7816-exit-code' refs #7816
Peter Amstutz [Mon, 4 Jan 2016 19:34:47 +0000 (14:34 -0500)]
Merge branch '7816-exit-code' refs #7816

8 years ago8080: Pull c.reload etc out of the assert_raises. Remove spurious blank lines.
Peter Amstutz [Mon, 4 Jan 2016 19:34:12 +0000 (14:34 -0500)]
8080: Pull c.reload etc out of the assert_raises.  Remove spurious blank lines.

8 years agoMerge branch '8082-col-markup' refs #8082
Tom Clegg [Mon, 4 Jan 2016 17:58:17 +0000 (12:58 -0500)]
Merge branch '8082-col-markup' refs #8082

8 years ago8082: Fix column markup (always use up "log" grid column, always use up all 12 grid...
Tom Clegg [Mon, 4 Jan 2016 17:55:54 +0000 (12:55 -0500)]
8082: Fix column markup (always use up "log" grid column, always use up all 12 grid columns).

8 years ago8014: Add #configure anchors to API server and Workbench install guides.
Brett Smith [Fri, 1 Jan 2016 20:26:22 +0000 (15:26 -0500)]
8014: Add #configure anchors to API server and Workbench install guides.

Package postinst scripts will use these to point people to the right
places in the documentation to read what steps they need to take
manually.  The SSO server docs+package already follow this
convention.  Refs #8014.

8 years ago8082: Ensure consistent column widths in Workbench job banner.
Brett Smith [Wed, 30 Dec 2015 23:53:12 +0000 (18:53 -0500)]
8082: Ensure consistent column widths in Workbench job banner.

4dcf4e849f242a929ce03b5d529e0e1a63fbaeb0 is the commit that introduced
the column inconsistencies.  This is the smallest patch I could find
to address the issue.  It may be less than ideal because it always
allocates a column to something that may not be displayed, but the
logic to keep track of column widths is already hairy and there are so
many conditions here that it stood to get a lot worse.  Closes #8082.

8 years ago8077: Tutorial suggests using the arvados/jobs Docker image.
Brett Smith [Wed, 30 Dec 2015 23:10:38 +0000 (18:10 -0500)]
8077: Tutorial suggests using the arvados/jobs Docker image.

This is all the hash script needs, and clusters are more likely to
have it than arvados/jobs-java-bwa-samtools, which is more of an
internal thing.  Closes #8077.

8 years ago7816: Add exit_code field to Container model. Can only be set when container
Peter Amstutz [Tue, 29 Dec 2015 22:01:24 +0000 (17:01 -0500)]
7816: Add exit_code field to Container model.  Can only be set when container
is marked "Complete".

8 years agoIncrease timeout for bringing up test server.
Tom Clegg [Wed, 23 Dec 2015 20:30:41 +0000 (15:30 -0500)]
Increase timeout for bringing up test server.

No issue #

8 years agoMerge branch '7965-fail-abandoned-jobs' closes #7965
Tom Clegg [Wed, 23 Dec 2015 19:28:41 +0000 (14:28 -0500)]
Merge branch '7965-fail-abandoned-jobs' closes #7965

8 years ago7965: Fail orphaned jobs still marked "running" after reboot.
Tom Clegg [Fri, 18 Dec 2015 19:33:28 +0000 (14:33 -0500)]
7965: Fail orphaned jobs still marked "running" after reboot.

8 years agoFix documentation typo git_repo_https_base not git_repo_http_base, no issue #
Peter Amstutz [Sun, 20 Dec 2015 02:59:26 +0000 (21:59 -0500)]
Fix documentation typo git_repo_https_base not git_repo_http_base, no issue #

8 years agoMerge branch '7884-ajax-log-redirect' closes #7884
Tom Clegg [Fri, 18 Dec 2015 20:40:40 +0000 (15:40 -0500)]
Merge branch '7884-ajax-log-redirect' closes #7884

8 years ago7884: Clarify "credentials" comment.
Tom Clegg [Fri, 18 Dec 2015 20:40:11 +0000 (15:40 -0500)]
7884: Clarify "credentials" comment.

8 years ago7884: Detect when a "download log" response has a JSON-encoded redirect
Tom Clegg [Thu, 17 Dec 2015 06:07:32 +0000 (01:07 -0500)]
7884: Detect when a "download log" response has a JSON-encoded redirect
to keep-web, and convert it to POST to avoid a second redirect that
would be forbidden by SOP.

8 years ago7884: Serve simple cross-origin AJAX POST requests without redirecting.
Tom Clegg [Thu, 17 Dec 2015 06:03:37 +0000 (01:03 -0500)]
7884: Serve simple cross-origin AJAX POST requests without redirecting.

8 years agoMerge branch '7927-docker-cleaner-api-version-wip'
Brett Smith [Fri, 18 Dec 2015 18:30:10 +0000 (13:30 -0500)]
Merge branch '7927-docker-cleaner-api-version-wip'

Closes #7927, #8025.

8 years ago7927: Docker cleaner service uses Docker API v1.14.
Brett Smith [Wed, 16 Dec 2015 16:07:24 +0000 (11:07 -0500)]
7927: Docker cleaner service uses Docker API v1.14.

This helps it work consistently across a variety of Docker versions.
See the comment in the tests for more background.

8 years agoLog request body size. No issue #
Tom Clegg [Thu, 17 Dec 2015 18:50:01 +0000 (13:50 -0500)]
Log request body size. No issue #

8 years agoMerge branch '7901-human-summary' closes #7901
Tom Clegg [Thu, 17 Dec 2015 15:06:50 +0000 (10:06 -0500)]
Merge branch '7901-human-summary' closes #7901

8 years ago7901: Add job stats, elapsed time, summed user+sys and tx+rx, and some human-readable...
Tom Clegg [Thu, 17 Dec 2015 15:05:30 +0000 (10:05 -0500)]
7901: Add job stats, elapsed time, summed user+sys and tx+rx, and some human-readable highlights.

8 years ago7942: Skip unreliable test. refs #7942
Tom Clegg [Wed, 16 Dec 2015 20:34:43 +0000 (15:34 -0500)]
7942: Skip unreliable test. refs #7942

8 years agoMerge branch '7888-azure-read-mux' refs #7888
Tom Clegg [Wed, 16 Dec 2015 19:51:44 +0000 (14:51 -0500)]
Merge branch '7888-azure-read-mux' refs #7888

8 years ago7888: Fix whitespace / gofmt
Tom Clegg [Wed, 16 Dec 2015 19:51:25 +0000 (14:51 -0500)]
7888: Fix whitespace / gofmt

8 years ago7888: Option to use multiple concurrent range requests when fetching from Azure.
Tom Clegg [Wed, 16 Dec 2015 17:43:35 +0000 (12:43 -0500)]
7888: Option to use multiple concurrent range requests when fetching from Azure.

8 years agoMerge branch '7454-azure-custom-data' closes #7454
Peter Amstutz [Wed, 16 Dec 2015 15:29:51 +0000 (10:29 -0500)]
Merge branch '7454-azure-custom-data' closes #7454

8 years ago7454: switch order of arvados_create_kwargs() to be consistent with
Peter Amstutz [Wed, 16 Dec 2015 14:49:52 +0000 (09:49 -0500)]
7454: switch order of arvados_create_kwargs() to be consistent with
create_node().  Use pipes.quote() to shellquote values.  Add ex_customdata
test.

8 years agoMerge branch '6429-fix-container-indexes' refs #6429
Peter Amstutz [Tue, 15 Dec 2015 15:00:46 +0000 (10:00 -0500)]
Merge branch '6429-fix-container-indexes' refs #6429

8 years agoAdd required indexes to containers and container_requests tables. refs #6429
Peter Amstutz [Tue, 15 Dec 2015 14:56:38 +0000 (09:56 -0500)]
Add required indexes to containers and container_requests tables. refs #6429

8 years agoIncrease default Python SDK timeout to 256s.
Tom Clegg [Tue, 15 Dec 2015 14:54:37 +0000 (09:54 -0500)]
Increase default Python SDK timeout to 256s.

No issue #

8 years ago7901: Fix variable name typo in crunchstat-summary.
Brett Smith [Mon, 14 Dec 2015 22:23:22 +0000 (17:23 -0500)]
7901: Fix variable name typo in crunchstat-summary.

Refs #7901.

8 years agoMerge branch '7901-crunchstat-summary' refs #7901
Tom Clegg [Mon, 14 Dec 2015 21:56:53 +0000 (16:56 -0500)]
Merge branch '7901-crunchstat-summary' refs #7901

8 years ago7901: Add crunchstat-summary program.
Tom Clegg [Mon, 14 Dec 2015 21:07:32 +0000 (16:07 -0500)]
7901: Add crunchstat-summary program.

8 years agoCleanup of test cleanup. refs #6429
Peter Amstutz [Mon, 14 Dec 2015 20:38:58 +0000 (15:38 -0500)]
Cleanup of test cleanup.  refs #6429

8 years agoSmall test cleanup. refs #6429
Peter Amstutz [Mon, 14 Dec 2015 20:31:07 +0000 (15:31 -0500)]
Small test cleanup.  refs #6429

8 years agoMerge branch '6429-crunch2-api' closes #6429
Peter Amstutz [Mon, 14 Dec 2015 20:22:39 +0000 (15:22 -0500)]
Merge branch '6429-crunch2-api' closes #6429

8 years agoMerge branch '7939-arv-mount-errors' closes #7939
Peter Amstutz [Mon, 14 Dec 2015 20:21:59 +0000 (15:21 -0500)]
Merge branch '7939-arv-mount-errors' closes #7939

8 years ago7939: Use 100:: for bogus host check and add comment about API check.
Peter Amstutz [Mon, 14 Dec 2015 20:20:23 +0000 (15:20 -0500)]
7939: Use 100:: for bogus host check and add comment about API check.

8 years ago6429: Add for test child container requests are set priority=0 when parent
Peter Amstutz [Mon, 14 Dec 2015 19:22:43 +0000 (14:22 -0500)]
6429: Add for test child container requests are set priority=0 when parent
container is in final state.

8 years ago7939: Additional check for bad token.
Peter Amstutz [Mon, 14 Dec 2015 19:11:33 +0000 (14:11 -0500)]
7939: Additional check for bad token.

8 years ago7939: Check exit code in tests.
Peter Amstutz [Mon, 14 Dec 2015 19:09:20 +0000 (14:09 -0500)]
7939: Check exit code in tests.

8 years ago7939: Move daemonize to _run_standalone() after llfuse.init(), preserving open
Peter Amstutz [Fri, 11 Dec 2015 19:49:01 +0000 (14:49 -0500)]
7939: Move daemonize to _run_standalone() after llfuse.init(), preserving open
file descriptors.  Add tests for various error conditions that can prevent
successful mount.

8 years ago7607: enablee flag should be set to false by default
Nancy Ouyang [Fri, 11 Dec 2015 23:09:20 +0000 (18:09 -0500)]
7607: enablee flag should be set to false by default

8 years ago7607: added logic to remove getting started dialogue by default. Still needs tests.
Nancy Ouyang [Fri, 11 Dec 2015 23:07:49 +0000 (18:07 -0500)]
7607: added logic to remove getting started dialogue by default. Still needs tests.

8 years ago7454: Fix tests
Peter Amstutz [Fri, 11 Dec 2015 20:43:44 +0000 (15:43 -0500)]
7454: Fix tests

8 years ago7454: Add 'size' to arvados_create_kwargs so that it can be included in CustomData.
Peter Amstutz [Fri, 11 Dec 2015 20:37:55 +0000 (15:37 -0500)]
7454: Add 'size' to arvados_create_kwargs so that it can be included in CustomData.

8 years ago7454: use small CustomData script to set /var/tmp/arv-node-data/arv-ping-url
Peter Amstutz [Fri, 11 Dec 2015 20:13:56 +0000 (15:13 -0500)]
7454: use small CustomData script to set /var/tmp/arv-node-data/arv-ping-url

8 years agoMerge branch 'master' into 7454-azure-custom-data
Peter Amstutz [Fri, 11 Dec 2015 19:59:02 +0000 (14:59 -0500)]
Merge branch 'master' into 7454-azure-custom-data

8 years ago6429: Callback calls container_completed! instead of just setting state to final.
Peter Amstutz [Fri, 11 Dec 2015 15:24:06 +0000 (10:24 -0500)]
6429: Callback calls container_completed! instead of just setting state to final.