arvados.git
10 years agoMerge branch '3618-column-ordering' closes #3618
Phil Hodgson [Tue, 4 Nov 2014 15:16:21 +0000 (16:16 +0100)]
Merge branch '3618-column-ordering' closes #3618

10 years agoUpdate version dependency to ensure CollectionReader has a normalize() method. refs...
Tom Clegg [Tue, 4 Nov 2014 14:48:44 +0000 (09:48 -0500)]
Update version dependency to ensure CollectionReader has a normalize() method. refs #3706

10 years agoMerge branch 'master' into 3618-column-ordering
Phil Hodgson [Tue, 4 Nov 2014 14:47:11 +0000 (15:47 +0100)]
Merge branch 'master' into 3618-column-ordering

10 years ago3618: accommodate new fixture indexing in pipeline_instance tests (including run...
Phil Hodgson [Tue, 4 Nov 2014 13:58:44 +0000 (14:58 +0100)]
3618: accommodate new fixture indexing in pipeline_instance tests (including run-time=0 test)

10 years ago3618: accommodate new fixture indexing in pipeline_instance tests
Phil Hodgson [Tue, 4 Nov 2014 11:32:55 +0000 (12:32 +0100)]
3618: accommodate new fixture indexing in pipeline_instance tests

10 years agoMerge branch '3706-keep-warning' closes #3706
Tom Clegg [Mon, 3 Nov 2014 22:30:15 +0000 (17:30 -0500)]
Merge branch '3706-keep-warning' closes #3706

10 years ago3706: Oops, the test was broken, the feature works fine.
Tom Clegg [Mon, 3 Nov 2014 22:27:54 +0000 (17:27 -0500)]
3706: Oops, the test was broken, the feature works fine.

10 years ago3706: Add (skipped) test for broken max_manifest_depth=0 feature.
Tom Clegg [Mon, 3 Nov 2014 22:13:38 +0000 (17:13 -0500)]
3706: Add (skipped) test for broken max_manifest_depth=0 feature.

10 years ago3706: Merge branch 'master' into 3706-keep-warning
Tom Clegg [Mon, 3 Nov 2014 20:27:13 +0000 (15:27 -0500)]
3706: Merge branch 'master' into 3706-keep-warning

10 years ago3706: Remove superfluous conditional.
Tom Clegg [Mon, 3 Nov 2014 19:33:15 +0000 (14:33 -0500)]
3706: Remove superfluous conditional.

10 years ago3706: Add back "collections.get => 404" to "fallback to Keep" test.
Tom Clegg [Mon, 3 Nov 2014 18:33:06 +0000 (13:33 -0500)]
3706: Add back "collections.get => 404" to "fallback to Keep" test.

10 years agoThe sso server docker image is not used by default at the moment, so
Ward Vandewege [Mon, 3 Nov 2014 18:31:26 +0000 (13:31 -0500)]
The sso server docker image is not used by default at the moment, so
arvdock shouldn't try to start it unless explicitly requested (part 2).

refs #4383

10 years ago3706: Prefer "is None" and "is not None" to "== None" and "!= None".
Tom Clegg [Mon, 3 Nov 2014 14:35:59 +0000 (09:35 -0500)]
3706: Prefer "is None" and "is not None" to "== None" and "!= None".

10 years ago3706: Mutating normalize() does not return self.
Tom Clegg [Mon, 3 Nov 2014 14:33:16 +0000 (09:33 -0500)]
3706: Mutating normalize() does not return self.

10 years ago3706: Process directory trees in sorted() order, instead of the order
Tom Clegg [Mon, 3 Nov 2014 14:32:16 +0000 (09:32 -0500)]
3706: Process directory trees in sorted() order, instead of the order
returned by os.listdir().

This causes write_directory_tree() to produce a manifest that is
normalized to the greatest extent possible for the given
max_manifest_depth.

10 years ago4388: Ruby Keep::Manifest skips blank lines in manifests.
Brett Smith [Mon, 3 Nov 2014 16:10:51 +0000 (11:10 -0500)]
4388: Ruby Keep::Manifest skips blank lines in manifests.

Closes #4388.

10 years agoThe sso server docker image is not used by default at the moment, so
Ward Vandewege [Mon, 3 Nov 2014 15:33:54 +0000 (10:33 -0500)]
The sso server docker image is not used by default at the moment, so
arvdock shouldn't try to start it unless explicitly requested.

refs #4383

10 years agosystem_user and anonymous_user should be excluded from
Ward Vandewege [Mon, 3 Nov 2014 04:39:40 +0000 (23:39 -0500)]
system_user and anonymous_user should be excluded from
auto_setup_new_user, always.

refs #4383

10 years agoEnable auto_setup_new_users in the docker API server image.
Ward Vandewege [Mon, 3 Nov 2014 02:03:34 +0000 (21:03 -0500)]
Enable auto_setup_new_users in the docker API server image.

refs #4383

10 years ago3618: refactor scroll tests to share code
Phil Hodgson [Sat, 1 Nov 2014 14:22:48 +0000 (15:22 +0100)]
3618: refactor scroll tests to share code

10 years ago3706: Clarify test case.
Tom Clegg [Fri, 31 Oct 2014 23:46:26 +0000 (19:46 -0400)]
3706: Clarify test case.

10 years ago3706: Prefer join() to many string concatenations.
Tom Clegg [Fri, 31 Oct 2014 23:36:49 +0000 (19:36 -0400)]
3706: Prefer join() to many string concatenations.

10 years ago3706: Prefer "if x" to "if len(x) > 0".
Tom Clegg [Fri, 31 Oct 2014 22:58:37 +0000 (18:58 -0400)]
3706: Prefer "if x" to "if len(x) > 0".

10 years ago3706: Two blank lines after class definition.
Tom Clegg [Fri, 31 Oct 2014 22:56:16 +0000 (18:56 -0400)]
3706: Two blank lines after class definition.

10 years ago3706: Really make the API server return the wrong data, instead of just saying so.
Tom Clegg [Fri, 31 Oct 2014 21:21:31 +0000 (17:21 -0400)]
3706: Really make the API server return the wrong data, instead of just saying so.

10 years ago3706: Put --normalize and --max-manifest-depth arguments in a mutually_exclusive_group.
Tom Clegg [Fri, 31 Oct 2014 20:48:34 +0000 (16:48 -0400)]
3706: Put --normalize and --max-manifest-depth arguments in a mutually_exclusive_group.

10 years agoMerge branch '4040-fuse-tests'
Tim Pierce [Fri, 31 Oct 2014 20:45:56 +0000 (16:45 -0400)]
Merge branch '4040-fuse-tests'

Fixes #4040.

10 years ago3706: normalize() returns None instead of self. Add equally convenient, and more...
Tom Clegg [Fri, 31 Oct 2014 20:44:19 +0000 (16:44 -0400)]
3706: normalize() returns None instead of self. Add equally convenient, and more Pythonic, manifest_text(normalize=True) feature.

10 years ago3706: Catch and return exceptions in _populate_* methods to dry up _populate()
Tom Clegg [Fri, 31 Oct 2014 20:30:07 +0000 (16:30 -0400)]
3706: Catch and return exceptions in _populate_* methods to dry up _populate()

10 years ago4040: code review feedback
Tim Pierce [Fri, 31 Oct 2014 20:21:11 +0000 (16:21 -0400)]
4040: code review feedback

* Renamed
** collection_owned_by_fuse_1 -> collection_1_owned_by_fuse
** collection_owned_by_fuse_2 -> collection_2_owned_by_fuse
* Added fixtures pipeline_instance_owned_by_fuse and
  pipeline_instance_in_fuse_project.
* Added name link for the empty collection, to exercise that links are
  exposed in the filesystem in the expected way.

10 years agoFix broken link in docs. Duh.
Ward Vandewege [Fri, 31 Oct 2014 20:13:52 +0000 (16:13 -0400)]
Fix broken link in docs. Duh.

refs #4186

10 years agoMerge branch '4186-install-doc-improvements-2'
Ward Vandewege [Fri, 31 Oct 2014 15:04:03 +0000 (11:04 -0400)]
Merge branch '4186-install-doc-improvements-2'

refs #4186

10 years agoClean up the installation overview pages a bit more.
Ward Vandewege [Fri, 31 Oct 2014 15:03:30 +0000 (11:03 -0400)]
Clean up the installation overview pages a bit more.

refs #4186

10 years agoMerge branch 'master' into 4186-install-doc-improvements-2
Ward Vandewege [Fri, 31 Oct 2014 14:52:24 +0000 (10:52 -0400)]
Merge branch 'master' into 4186-install-doc-improvements-2

10 years agoAdd keepstore installation page.
Ward Vandewege [Fri, 31 Oct 2014 14:47:45 +0000 (10:47 -0400)]
Add keepstore installation page.

refs #4186

10 years agoWorkbench: Change from yui to uglifier to compress javascript in
Ward Vandewege [Fri, 31 Oct 2014 14:43:28 +0000 (10:43 -0400)]
Workbench: Change from yui to uglifier to compress javascript in
config/environments/production.rb.example

No issue #

10 years agoFix typo.
Ward Vandewege [Fri, 31 Oct 2014 02:07:11 +0000 (22:07 -0400)]
Fix typo.

refs #4186

10 years agoKeepproxy just needs an anonymous token.
Ward Vandewege [Wed, 29 Oct 2014 16:27:45 +0000 (12:27 -0400)]
Keepproxy just needs an anonymous token.

refs #4186

10 years agoBatch of improvements for the manual installation documentation:
Ward Vandewege [Wed, 29 Oct 2014 15:40:12 +0000 (11:40 -0400)]
Batch of improvements for the manual installation documentation:

* add prerequisites section
* add shell server section
* add keepproxy section
* many other updates throughout

refs #4186

10 years ago3618: improve api security for sorting to make sure each column we sort by is for...
Phil Hodgson [Fri, 31 Oct 2014 13:04:51 +0000 (14:04 +0100)]
3618: improve api security for sorting to make sure each column we sort by is for a real table and a real column in the db

10 years ago3618: make sure something happens if the order param is actually detected as an array
Phil Hodgson [Fri, 31 Oct 2014 13:04:07 +0000 (14:04 +0100)]
3618: make sure something happens if the order param is actually detected as an array

10 years ago3618: bug fix: was confusing the "desc" meaning a "descending sort" with the "desc...
Phil Hodgson [Fri, 31 Oct 2014 13:03:25 +0000 (14:03 +0100)]
3618: bug fix: was confusing the "desc" meaning a "descending sort" with the "desc" that is the beginning of the column name "description"

10 years agoMerge branch 'master' into 3618-column-ordering
Phil Hodgson [Fri, 31 Oct 2014 12:56:01 +0000 (13:56 +0100)]
Merge branch 'master' into 3618-column-ordering

Conflicts (all resolved including fixes):
apps/workbench/app/controllers/projects_controller.rb
apps/workbench/app/views/projects/_show_jobs_and_pipelines.html.erb
apps/workbench/app/views/projects/_show_tab_contents.html.erb
services/api/app/controllers/arvados/v1/groups_controller.rb

10 years agoMerge branch '3824-crunch-container-setup' closes #3824
Tom Clegg [Thu, 30 Oct 2014 21:13:31 +0000 (17:13 -0400)]
Merge branch '3824-crunch-container-setup' closes #3824

10 years ago3824: Merge branch 'master' into 3824-crunch-container-setup
Tom Clegg [Thu, 30 Oct 2014 21:13:23 +0000 (17:13 -0400)]
3824: Merge branch 'master' into 3824-crunch-container-setup

10 years ago3824: Fix comment to state that tasks must not assume $TASK_KEEPMOUNT is /keep.
Tom Clegg [Thu, 30 Oct 2014 21:05:25 +0000 (17:05 -0400)]
3824: Fix comment to state that tasks must not assume $TASK_KEEPMOUNT is /keep.

10 years agoFix google-api-client version deps. No issue #
Tom Clegg [Thu, 30 Oct 2014 20:33:23 +0000 (16:33 -0400)]
Fix google-api-client version deps. No issue #

10 years agoMerge branch '4359-project-paging' closes #4359
Tom Clegg [Thu, 30 Oct 2014 20:30:56 +0000 (16:30 -0400)]
Merge branch '4359-project-paging' closes #4359

10 years agoMerge branch '4088-filterable-docs' refs #4088
Tom Clegg [Thu, 30 Oct 2014 20:13:35 +0000 (16:13 -0400)]
Merge branch '4088-filterable-docs' refs #4088

10 years ago3706: Use normalize() in arv-mount.
Tom Clegg [Thu, 30 Oct 2014 19:59:41 +0000 (15:59 -0400)]
3706: Use normalize() in arv-mount.

10 years ago3824: Import GPG key needed for RVM installation.
Tom Clegg [Thu, 30 Oct 2014 18:48:05 +0000 (14:48 -0400)]
3824: Import GPG key needed for RVM installation.

10 years ago3824: Remove redundant "apt-get update", standardize on "apt-get update -qq" and...
Tom Clegg [Thu, 30 Oct 2014 18:27:58 +0000 (14:27 -0400)]
3824: Remove redundant "apt-get update", standardize on "apt-get update -qq" and "apt-get install -qqy".

10 years ago3824: Set mode on /etc/fuse.conf in compute image.
Tom Clegg [Thu, 30 Oct 2014 18:04:14 +0000 (14:04 -0400)]
3824: Set mode on /etc/fuse.conf in compute image.

10 years ago4307: Workbench: only pipeline components are not editable after start.
Brett Smith [Thu, 30 Oct 2014 17:45:10 +0000 (13:45 -0400)]
4307: Workbench: only pipeline components are not editable after start.

This fixes a regression from d7fdbbab.  Closes #4307.

10 years ago4088: Add usage docs to filterable.js
Tom Clegg [Thu, 30 Oct 2014 17:43:34 +0000 (13:43 -0400)]
4088: Add usage docs to filterable.js

10 years ago3824: Bring back $! in error message, in case it's helpful.
Tom Clegg [Thu, 30 Oct 2014 17:05:17 +0000 (13:05 -0400)]
3824: Bring back $! in error message, in case it's helpful.

10 years ago3824: Merge branch 'master' into 3824-crunch-container-setup
Tom Clegg [Thu, 30 Oct 2014 17:02:56 +0000 (13:02 -0400)]
3824: Merge branch 'master' into 3824-crunch-container-setup

10 years ago3824: Use Data::Dumper instead of custom quoting to show srun/task exec args.
Tom Clegg [Thu, 30 Oct 2014 17:00:05 +0000 (13:00 -0400)]
3824: Use Data::Dumper instead of custom quoting to show srun/task exec args.

10 years ago4091: Use <=N instead of <N+1. Pass "uuid not in" filter to API instead of adding...
Tom Clegg [Wed, 29 Oct 2014 21:06:17 +0000 (17:06 -0400)]
4091: Use <=N instead of <N+1. Pass "uuid not in" filter to API instead of adding custom filter params.

10 years ago4040: clarify variable names
Tim Pierce [Wed, 29 Oct 2014 20:23:08 +0000 (16:23 -0400)]
4040: clarify variable names

Per code review: give d1, d2, d3 more descriptive variable names.

10 years agocloses #4091
radhika [Wed, 29 Oct 2014 19:23:45 +0000 (15:23 -0400)]
closes #4091
Merge branch '4091-test-infinite-scrolling'

10 years agoMerge branch 'master' into 4091-test-infinite-scrolling
radhika [Wed, 29 Oct 2014 19:23:07 +0000 (15:23 -0400)]
Merge branch 'master' into 4091-test-infinite-scrolling

10 years ago4091: set the limit size to 50 for "Jobs and pipelines" tab.
radhika [Wed, 29 Oct 2014 19:21:45 +0000 (15:21 -0400)]
4091: set the limit size to 50 for "Jobs and pipelines" tab.

10 years ago4040: update FUSE driver tests with stable fixtures
Tim Pierce [Wed, 29 Oct 2014 19:12:47 +0000 (15:12 -0400)]
4040: update FUSE driver tests with stable fixtures

Added test fixtures specifically for FUSE driver tests.

10 years agoFix Node Manager test bug introduced by last commit.
Brett Smith [Wed, 29 Oct 2014 18:58:59 +0000 (14:58 -0400)]
Fix Node Manager test bug introduced by last commit.

Bad Brett, only running specific tests.  No issue #.

10 years agoFix race condition in Node Manager shutdown tests.
Brett Smith [Wed, 29 Oct 2014 18:22:16 +0000 (14:22 -0400)]
Fix race condition in Node Manager shutdown tests.

ComputeNodeMonitorActor considers a shutdown when it's initialized.
Blocking on the subscription we send ensures that message is fully
processed before the tests continue.  This is important because
several of them change the shutdown state immediately after, and that
might be seen by the internal shutdown consideration without this.

No issue #, but see
<https://ci.curoverse.com/job/arvados-api-server/1027/console>.

10 years agoFix the goldang consarned FUSE tests again.
Tim Pierce [Wed, 29 Oct 2014 16:53:19 +0000 (12:53 -0400)]
Fix the goldang consarned FUSE tests again.

No issue #, dammit

10 years agoMerge branch '4088-collection-show-files-filter'
Tim Pierce [Wed, 29 Oct 2014 16:07:07 +0000 (12:07 -0400)]
Merge branch '4088-collection-show-files-filter'

Refs #4088.

10 years ago4088: filter only on files
Tim Pierce [Wed, 29 Oct 2014 15:40:52 +0000 (11:40 -0400)]
4088: filter only on files

Only apply the regex filter to files; continue to process subdirectories
as normal in order to keep the appropriate filename hierarchy.

10 years ago3618: Make tests pass: bugs were revealed in "Other objects" tab related to there...
Phil Hodgson [Wed, 29 Oct 2014 15:39:56 +0000 (16:39 +0100)]
3618: Make tests pass: bugs were revealed in "Other objects" tab related to there not being any sorting going on there, etc.; add checks for HTML5 history and for nulls and undefineds

10 years ago4088: fix alignment for right-floating input field
Tim Pierce [Wed, 29 Oct 2014 15:19:32 +0000 (11:19 -0400)]
4088: fix alignment for right-floating input field

10 years agoMerge branch 'master' into 3618-column-ordering
Phil Hodgson [Wed, 29 Oct 2014 11:21:14 +0000 (12:21 +0100)]
Merge branch 'master' into 3618-column-ordering

10 years ago3618: store in the browser history state the current sort settings for each tab
Phil Hodgson [Wed, 29 Oct 2014 11:20:08 +0000 (12:20 +0100)]
3618: store in the browser history state the current sort settings for each tab

10 years agoImprove config/application.yml.example for the API server and workbench:
Ward Vandewege [Wed, 29 Oct 2014 02:18:37 +0000 (22:18 -0400)]
Improve config/application.yml.example for the API server and workbench:

* API server: define prefix_uuid in development mode
* workbench: add a production section

No issue #

10 years ago4088: code review feedback
Tim Pierce [Tue, 28 Oct 2014 21:26:58 +0000 (17:26 -0400)]
4088: code review feedback

* Filter files by regex before .take(10000)
* Added "regular expression" placeholder in the filter input box
* Issue a Rails "alert" div if the regex could not be parsed
* Test that we're actually viewing a collection when no matches are
  found (and not a fiddlesticks page or something)

10 years agoFix off-by-one error in Node Manager server calculations.
Brett Smith [Tue, 28 Oct 2014 17:32:05 +0000 (13:32 -0400)]
Fix off-by-one error in Node Manager server calculations.

This bug prevented Node Manager from starting nodes for a job that
requested a number of nodes equal to the daemon's max_nodes setting.
No issue #.

10 years ago4091: update jobs fixture to set same created_at timestamp for some of the jobs.
radhika [Tue, 28 Oct 2014 17:16:43 +0000 (13:16 -0400)]
4091: update jobs fixture to set same created_at timestamp for some of the jobs.

10 years ago4091: enhance code to handle the case where there are more than one item in the next...
radhika [Tue, 28 Oct 2014 16:18:17 +0000 (12:18 -0400)]
4091: enhance code to handle the case where there are more than one item in the next page matching the previous page's last object's created_at time.
Also, handle the case where the entire next page has the same created_at time as the previous page's last item; to keep things simple, stop scrolling in this case.

10 years ago4088: filter collection file view by regex
Tim Pierce [Tue, 28 Oct 2014 15:14:47 +0000 (11:14 -0400)]
4088: filter collection file view by regex

Added a "Filter" field for supplying a regular expression to filter
filenames. Updated integration tests.

10 years ago3824: Remove redundant addition of arvados package repo and key.
Tom Clegg [Tue, 28 Oct 2014 14:59:40 +0000 (10:59 -0400)]
3824: Remove redundant addition of arvados package repo and key.

10 years ago3824: Add sources.list file missing from commit:0f9aaf1
Tom Clegg [Tue, 28 Oct 2014 14:35:13 +0000 (10:35 -0400)]
3824: Add sources.list file missing from commit:0f9aaf1

10 years ago3618: remove unnecessary "raw" directive for the sort columns table header attribute
Phil Hodgson [Tue, 28 Oct 2014 10:48:46 +0000 (11:48 +0100)]
3618: remove unnecessary "raw" directive for the sort columns table header attribute

10 years ago3824: Fix up logging messages.
Tom Clegg [Tue, 28 Oct 2014 05:06:02 +0000 (01:06 -0400)]
3824: Fix up logging messages.

10 years ago3706: Merge branch 'master' into 3706-keep-warning
Tom Clegg [Tue, 28 Oct 2014 02:24:35 +0000 (22:24 -0400)]
3706: Merge branch 'master' into 3706-keep-warning

10 years ago3706: Remove automatic normalization. Add --normalize option to
Tom Clegg [Tue, 28 Oct 2014 02:20:22 +0000 (22:20 -0400)]
3706: Remove automatic normalization. Add --normalize option to
arv-put. Add normalize() and stripped_manifest() methods to
CollectionReader. Clean up normalize code.

10 years ago3706: Consolidate more regular expressions into util package.
Tom Clegg [Tue, 28 Oct 2014 02:12:53 +0000 (22:12 -0400)]
3706: Consolidate more regular expressions into util package.

10 years ago3706: Do not leave zero-length file segment at end of stream after finish_current_file().
Tom Clegg [Tue, 28 Oct 2014 02:08:24 +0000 (22:08 -0400)]
3706: Do not leave zero-length file segment at end of stream after finish_current_file().

10 years ago3706: In CollectionReader, try fetching manifests before/after API
Tom Clegg [Tue, 28 Oct 2014 02:04:54 +0000 (22:04 -0400)]
3706: In CollectionReader, try fetching manifests before/after API
server when the ID is a Keep locator with/without a permission hint
respectively. Do not display a warning if the manifest is found one
way or the other.

10 years ago4091: retain filters in project contents collections and similar tabs.
radhika [Mon, 27 Oct 2014 20:38:38 +0000 (16:38 -0400)]
4091: retain filters in project contents collections and similar tabs.

10 years agoMerge branch 'master' into 4091-test-infinite-scrolling
radhika [Mon, 27 Oct 2014 20:24:07 +0000 (16:24 -0400)]
Merge branch 'master' into 4091-test-infinite-scrolling

10 years ago4091: change project contents order from uuid to created_at.
radhika [Mon, 27 Oct 2014 20:23:21 +0000 (16:23 -0400)]
4091: change project contents order from uuid to created_at.

10 years agoMerge branch '4015-collection-chooser-portable-data-hash'
Tim Pierce [Mon, 27 Oct 2014 20:13:12 +0000 (16:13 -0400)]
Merge branch '4015-collection-chooser-portable-data-hash'

Fixes #4015.

10 years ago4015: update FUSE mount tests (again)
Tim Pierce [Mon, 27 Oct 2014 19:49:00 +0000 (15:49 -0400)]
4015: update FUSE mount tests (again)

10 years ago4015: simplify integration tests
Tim Pierce [Mon, 27 Oct 2014 18:06:12 +0000 (14:06 -0400)]
4015: simplify integration tests

Responding to code review in #4015-8:

We can (and should) test that the collection portable_data_hash is
recorded in individual tests without adding explicit new tests or
fixtures.

Updated test 'Create and run a pipeline' and the helper
create_and_run_pipeline_in_aproject to check that the collection
portable_data_hash, uuid and name have been recorded correctly in the
Advanced tab.

10 years agoMerge branch 'master' into 4091-test-infinite-scrolling
radhika [Mon, 27 Oct 2014 17:46:33 +0000 (13:46 -0400)]
Merge branch 'master' into 4091-test-infinite-scrolling

10 years agoMerge branch '4297-dispatch-load' refs #4297
Tom Clegg [Mon, 27 Oct 2014 17:35:34 +0000 (13:35 -0400)]
Merge branch '4297-dispatch-load' refs #4297

10 years ago3706: Silence fallback-to-keep warning, show both errors (API and Keep) if both fail.
Tom Clegg [Mon, 27 Oct 2014 17:35:28 +0000 (13:35 -0400)]
3706: Silence fallback-to-keep warning, show both errors (API and Keep) if both fail.

10 years ago4297: Merge branch 'master' into 4297-dispatch-load
Tom Clegg [Mon, 27 Oct 2014 16:54:16 +0000 (12:54 -0400)]
4297: Merge branch 'master' into 4297-dispatch-load

10 years ago4297: Rename @have_tags -> @job_tags, @have_commits -> @fetched_commits. Add comments.
Tom Clegg [Mon, 27 Oct 2014 16:53:28 +0000 (12:53 -0400)]
4297: Rename @have_tags -> @job_tags, @have_commits -> @fetched_commits. Add comments.

10 years ago4297: Use save! instead of save to ensure failures get logged.
Tom Clegg [Mon, 27 Oct 2014 16:52:52 +0000 (12:52 -0400)]
4297: Use save! instead of save to ensure failures get logged.