arvados.git
3 years ago17119: rename a field in the context menu actions unit test, for
Ward Vandewege [Tue, 23 Mar 2021 19:11:22 +0000 (15:11 -0400)]
17119: rename a field in the context menu actions unit test, for
       clarity.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago17119: further changes after review feedback.
Ward Vandewege [Tue, 23 Mar 2021 16:40:56 +0000 (12:40 -0400)]
17119: further changes after review feedback.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago17119: implement review feedback.
Ward Vandewege [Sun, 21 Mar 2021 02:03:14 +0000 (22:03 -0400)]
17119: implement review feedback.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago17119: fix integration tests.
Ward Vandewege [Fri, 19 Mar 2021 14:19:22 +0000 (10:19 -0400)]
17119: fix integration tests.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago17119: add more unit tests.
Ward Vandewege [Fri, 19 Mar 2021 13:30:55 +0000 (09:30 -0400)]
17119: add more unit tests.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago17119: fix unit tests (process resources do not have a writable_by field
Ward Vandewege [Thu, 18 Mar 2021 21:38:55 +0000 (17:38 -0400)]
17119: fix unit tests (process resources do not have a writable_by field
       so isEditable is always false), and fix a bug where the type of
the last project visited would affect editable state of objects at other
routes (e.g. "Shared with me").

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago17119: Fixes unit tests improving store mocking and error reporting.
Lucas Di Pentima [Wed, 17 Mar 2021 21:41:35 +0000 (18:41 -0300)]
17119: Fixes unit tests improving store mocking and error reporting.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17119: Merge branch 'master' into 17119-support-filter-groups
Ward Vandewege [Wed, 17 Mar 2021 20:56:03 +0000 (16:56 -0400)]
17119: Merge branch 'master' into 17119-support-filter-groups

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoMerge branch '16848-unit-tests-fixes'
Lucas Di Pentima [Wed, 17 Mar 2021 20:54:05 +0000 (17:54 -0300)]
Merge branch '16848-unit-tests-fixes'
Refs #16848

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago16848: Removed commented out code.
Lucas Di Pentima [Wed, 17 Mar 2021 20:50:02 +0000 (17:50 -0300)]
16848: Removed commented out code.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago16848: Fixes unit tests.
Lucas Di Pentima [Wed, 17 Mar 2021 20:24:29 +0000 (17:24 -0300)]
16848: Fixes unit tests.

DetailsAttribute component needed a mocked store to be able to be tested
inside TokenDialog. Extracted the layout related code to a simpler component
so that can be used directly and tested is easier.
Also, fixed a couple of assertions on the token dialog tests.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17119: Merge branch 'master' into 17119-support-filter-groups
Ward Vandewege [Fri, 12 Mar 2021 22:49:39 +0000 (17:49 -0500)]
17119: Merge branch 'master' into 17119-support-filter-groups

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoMerge branch '17119-make-arvados-path-configurable-in-tests'
Ward Vandewege [Fri, 12 Mar 2021 22:45:55 +0000 (17:45 -0500)]
Merge branch '17119-make-arvados-path-configurable-in-tests'

refs #17119

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago17119: Merge branch 'master' into 17119-make-arvados-path-configurable-in-tests
Ward Vandewege [Fri, 12 Mar 2021 22:45:18 +0000 (17:45 -0500)]
17119: Merge branch 'master' into 17119-make-arvados-path-configurable-in-tests

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago17119: add a filter group test.
Ward Vandewege [Fri, 12 Mar 2021 22:44:17 +0000 (17:44 -0500)]
17119: add a filter group test.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago17119: update the Makefile and tools/run-integration-tests.sh to make
Ward Vandewege [Fri, 12 Mar 2021 15:01:04 +0000 (10:01 -0500)]
17119: update the Makefile and tools/run-integration-tests.sh to make
       the arvados source path configurable.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago17119: list the group class on the project details screen.
Ward Vandewege [Thu, 11 Mar 2021 21:46:13 +0000 (16:46 -0500)]
17119: list the group class on the project details screen.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago17119: The "+ New" button should be disabled when viewing a filter
Ward Vandewege [Thu, 11 Mar 2021 17:45:10 +0000 (12:45 -0500)]
17119: The "+ New" button should be disabled when viewing a filter
       group.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago17119: the "Move to" dialog should not show filter groups as a potential
Ward Vandewege [Thu, 11 Mar 2021 17:37:39 +0000 (12:37 -0500)]
17119: the "Move to" dialog should not show filter groups as a potential
       destination.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago17119: add basic filter group support.
Ward Vandewege [Thu, 11 Mar 2021 21:28:48 +0000 (16:28 -0500)]
17119: add basic filter group support.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoMerge branch '16848-token-handling-improvements'
Lucas Di Pentima [Thu, 11 Mar 2021 17:54:37 +0000 (14:54 -0300)]
Merge branch '16848-token-handling-improvements'
Closes #16848

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago16848: Changes layout for token & api host display. Reduces code block font.
Lucas Di Pentima [Thu, 11 Mar 2021 17:40:54 +0000 (14:40 -0300)]
16848: Changes layout for token & api host display. Reduces code block font.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago16848: Adds unit test.
Lucas Di Pentima [Wed, 10 Mar 2021 22:24:02 +0000 (19:24 -0300)]
16848: Adds unit test.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago16848: Moves the "get new token" button up.
Lucas Di Pentima [Tue, 9 Mar 2021 17:58:38 +0000 (14:58 -0300)]
16848: Moves the "get new token" button up.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoMerge branch '17436-Favorites-in-workflow-picker-dialog-is-different-to-favorite...
Daniel Kutyła [Tue, 9 Mar 2021 16:54:35 +0000 (17:54 +0100)]
Merge branch '17436-Favorites-in-workflow-picker-dialog-is-different-to-favorite-list'
closes #17436

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years ago16848: Updates unit test.
Lucas Di Pentima [Tue, 9 Mar 2021 16:31:25 +0000 (13:31 -0300)]
16848: Updates unit test.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago16848: Updates 'get api token' dialog.
Lucas Di Pentima [Tue, 9 Mar 2021 16:00:30 +0000 (13:00 -0300)]
16848: Updates 'get api token' dialog.

Adds individual copyable api host & token information in additional to the
currently present shell code block.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17436: Created generic code for project creation in cypress
Daniel Kutyła [Mon, 8 Mar 2021 22:38:08 +0000 (23:38 +0100)]
17436: Created generic code for project creation in cypress

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years ago16848: Resets extra cached token from the store when not valid anymore.
Lucas Di Pentima [Mon, 8 Mar 2021 17:04:45 +0000 (14:04 -0300)]
16848: Resets extra cached token from the store when not valid anymore.

This is to make the "Get API token" dialog default to the wb2's session token.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago16848: Checks cached token validity before using it.
Lucas Di Pentima [Mon, 8 Mar 2021 15:22:06 +0000 (12:22 -0300)]
16848: Checks cached token validity before using it.

The cached token could be invalid or have its expiration date changed from an
API call outside Workbench2.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17436: Code cleanup
Daniel Kutyła [Mon, 8 Mar 2021 07:30:14 +0000 (08:30 +0100)]
17436: Code cleanup

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years ago16848: Adds a legend for non-expiring tokens on the get token dialog.
Lucas Di Pentima [Fri, 5 Mar 2021 15:32:27 +0000 (12:32 -0300)]
16848: Adds a legend for non-expiring tokens on the get token dialog.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoMerge branch '17414-Collection-file-listing-shows-only-half-of-the-last-entry'
Daniel Kutyła [Thu, 4 Mar 2021 18:30:48 +0000 (19:30 +0100)]
Merge branch '17414-Collection-file-listing-shows-only-half-of-the-last-entry'
closes #17414

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years ago17436: fixed workflow cration favorites list
Daniel Kutyła [Wed, 3 Mar 2021 21:45:47 +0000 (22:45 +0100)]
17436: fixed workflow cration favorites list

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years ago17414: Added padding to the last element
Daniel Kutyła [Tue, 2 Mar 2021 10:54:48 +0000 (11:54 +0100)]
17414: Added padding to the last element

 Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years ago16848: Adds unit tests.
Lucas Di Pentima [Tue, 23 Feb 2021 20:52:58 +0000 (17:52 -0300)]
16848: Adds unit tests.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago16848: Adds expiration date to the "Get API Token" dialog.
Lucas Di Pentima [Tue, 23 Feb 2021 19:30:26 +0000 (16:30 -0300)]
16848: Adds expiration date to the "Get API Token" dialog.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago16848: Only request an extra token when needed.
Lucas Di Pentima [Tue, 23 Feb 2021 16:10:47 +0000 (13:10 -0300)]
16848: Only request an extra token when needed.

Instead of preemptively asking for the extra token at session init, ask for
one every time it's needed, avoiding creating unused tokens.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoMerge branch 'master' into 16848-token-handling-improvements
Lucas Di Pentima [Mon, 22 Feb 2021 21:04:57 +0000 (18:04 -0300)]
Merge branch 'master' into 16848-token-handling-improvements

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoMerge branch '17319-service-layer-uuid-validation'
Lucas Di Pentima [Mon, 22 Feb 2021 20:34:06 +0000 (17:34 -0300)]
Merge branch '17319-service-layer-uuid-validation'
Closes #17319

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17319: Don't use a real axios instance if not needed.
Lucas Di Pentima [Mon, 22 Feb 2021 20:24:28 +0000 (17:24 -0300)]
17319: Don't use a real axios instance if not needed.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17319: Unit test code cleanup.
Lucas Di Pentima [Mon, 22 Feb 2021 20:17:42 +0000 (17:17 -0300)]
17319: Unit test code cleanup.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17319: Moved mocks' initializations into beforeEach().
Lucas Di Pentima [Mon, 22 Feb 2021 19:59:40 +0000 (16:59 -0300)]
17319: Moved mocks' initializations into beforeEach().

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17319: Throws exceptions when attempting to use "" as uuid on service calls.
Lucas Di Pentima [Fri, 19 Feb 2021 20:28:20 +0000 (17:28 -0300)]
17319: Throws exceptions when attempting to use "" as uuid on service calls.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17319: Adds tests exposing the bug.
Lucas Di Pentima [Fri, 19 Feb 2021 20:27:37 +0000 (17:27 -0300)]
17319: Adds tests exposing the bug.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoMerge branch '17306-Favorites-in-copy-dialog-is-different-to-favorite-list'
Daniel Kutyła [Thu, 18 Feb 2021 21:12:08 +0000 (22:12 +0100)]
Merge branch '17306-Favorites-in-copy-dialog-is-different-to-favorite-list'
closes #17306

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years ago17306: Fixed tests for collections
Daniel Kutyła [Thu, 18 Feb 2021 19:34:25 +0000 (20:34 +0100)]
17306: Fixed tests for collections

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years ago16848: Fixes unit test.
Lucas Di Pentima [Wed, 17 Feb 2021 23:31:07 +0000 (20:31 -0300)]
16848: Fixes unit test.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17306: Fixed copying of a collection elements
Daniel Kutyła [Wed, 17 Feb 2021 21:45:42 +0000 (22:45 +0100)]
17306: Fixed copying of a collection elements

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years ago17306: Code cleanup
Daniel Kutyła [Wed, 17 Feb 2021 21:13:46 +0000 (22:13 +0100)]
17306: Code cleanup

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>01~

3 years ago17306: Fixed typos
Daniel Kutyła [Wed, 17 Feb 2021 21:01:41 +0000 (22:01 +0100)]
17306: Fixed typos

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>01~

3 years ago16848: Always use wb2 token when LoginCluster is set and isn't the home cluster
Lucas Di Pentima [Wed, 17 Feb 2021 20:53:05 +0000 (17:53 -0300)]
16848: Always use wb2 token when LoginCluster is set and isn't the home cluster

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17306: Failing test fix
Daniel Kutyła [Wed, 17 Feb 2021 20:48:43 +0000 (21:48 +0100)]
17306: Failing test fix

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years ago16848: Avoids showing API errors when the extra token creation fails.
Lucas Di Pentima [Wed, 17 Feb 2021 18:48:32 +0000 (15:48 -0300)]
16848: Avoids showing API errors when the extra token creation fails.

If the cluster's config API.TokenLifetime isn't zero, creating new tokens
isn't allowed. From wb2's side, there's no way to know in advance if this
will be allowed so this commit avoids showing the error on app's bootup
and shows a warning message on the UI when the user tries to do it manually.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago16848: Makes 'Open as S3 bucket' dialog use the extra api token if available.
Lucas Di Pentima [Tue, 16 Feb 2021 23:11:07 +0000 (20:11 -0300)]
16848: Makes 'Open as S3 bucket' dialog use the extra api token if available.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago16848: Adds an extra token to be displayed on the 'get token' dialog.
Lucas Di Pentima [Tue, 16 Feb 2021 23:00:57 +0000 (20:00 -0300)]
16848: Adds an extra token to be displayed on the 'get token' dialog.

Also, adds a "Get new token" button to the dialog to allow the user to
request new tokens.
These extra tokens won't be expired on logout, so they're suitable for use
on S3 URLs and other tasks the user may need.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17306: Fixed copying of a collection elements
Daniel Kutyła [Tue, 16 Feb 2021 22:18:22 +0000 (23:18 +0100)]
17306: Fixed copying of a collection elements

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years ago16848: Adds test for idle timer reset via localStorage event.
Lucas Di Pentima [Mon, 15 Feb 2021 21:03:30 +0000 (18:03 -0300)]
16848: Adds test for idle timer reset via localStorage event.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago16848: Improved event handler installation/removal.
Lucas Di Pentima [Mon, 15 Feb 2021 20:44:13 +0000 (17:44 -0300)]
16848: Improved event handler installation/removal.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago16848: Synchronizes auto-logout between different windows/tabs.
Lucas Di Pentima [Fri, 12 Feb 2021 22:54:41 +0000 (19:54 -0300)]
16848: Synchronizes auto-logout between different windows/tabs.

On user action, a localStorage key is updated with the timestamp. The other
windows/tabs of the same app receive the change event and reset the idle
timer accordingly.
There's some event debouncing going on so there's a 1 sec delay between
the active window/tab and the rest.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago16848: Renames 'current token dialog' code to 'token dialog'.
Lucas Di Pentima [Fri, 12 Feb 2021 16:23:06 +0000 (13:23 -0300)]
16848: Renames 'current token dialog' code to 'token dialog'.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17306: Added configurable options for favorite tree
Daniel Kutyła [Tue, 9 Feb 2021 22:19:51 +0000 (23:19 +0100)]
17306: Added configurable options for favorite tree

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years ago17306: Added browser tests, filtering writable entities
Daniel Kutyła [Fri, 5 Feb 2021 22:46:38 +0000 (23:46 +0100)]
17306: Added browser tests, filtering writable entities

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years agoMerge branch '17308-property-editor-fixes'
Lucas Di Pentima [Wed, 3 Feb 2021 19:50:00 +0000 (16:50 -0300)]
Merge branch '17308-property-editor-fixes'
Closes #17308

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoMerge branch '17205-render-owner-name'
Daniel Kutyła [Wed, 3 Feb 2021 19:47:02 +0000 (20:47 +0100)]
Merge branch '17205-render-owner-name'
closes #17205

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years ago17308: Removes forgotten .only() call on integration test.
Lucas Di Pentima [Wed, 3 Feb 2021 19:46:58 +0000 (16:46 -0300)]
17308: Removes forgotten .only() call on integration test.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17205: Fixed types
Daniel Kutyła [Wed, 3 Feb 2021 19:29:08 +0000 (20:29 +0100)]
17205: Fixed types

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years agoMerge branch 'flaky-integration-test-fix'
Lucas Di Pentima [Wed, 3 Feb 2021 14:33:03 +0000 (11:33 -0300)]
Merge branch 'flaky-integration-test-fix'
No issue #

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoHopefully fixes flaky test by asserting on different file names when looping.
Lucas Di Pentima [Tue, 2 Feb 2021 22:48:49 +0000 (19:48 -0300)]
Hopefully fixes flaky test by asserting on different file names when looping.
No issue #

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17205: Created new renderer for owner name
Daniel Kutyła [Tue, 2 Feb 2021 22:33:48 +0000 (23:33 +0100)]
17205: Created new renderer for owner name

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years agoAvoids 404 responses when no container request is selected.
Lucas Di Pentima [Tue, 2 Feb 2021 19:41:55 +0000 (16:41 -0300)]
Avoids 404 responses when no container request is selected.
Refs #17319

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoAvoids 404 responses when no container request is selected.
Lucas Di Pentima [Tue, 2 Feb 2021 19:41:55 +0000 (16:41 -0300)]
Avoids 404 responses when no container request is selected.
Refs #17319

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17308: Adds project creation with properties integration test.
Lucas Di Pentima [Tue, 2 Feb 2021 16:20:17 +0000 (13:20 -0300)]
17308: Adds project creation with properties integration test.

Also reorganizes some test cases, and removes code duplication on the create
new project dialog for the property editor form.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17308: Adds vocabulary terms handling to new project dialog's property editor.
Lucas Di Pentima [Mon, 1 Feb 2021 22:27:09 +0000 (19:27 -0300)]
17308: Adds vocabulary terms handling to new project dialog's property editor.

Also, adds the ability to add multiple value properties. This makes the
new project dialog's editor behaviour consistent with the rest of the
application.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoMerge branch '17306-Favorites-in-copy-dialog-is-different-to-favorite-list' of git...
Daniel Kutyła [Mon, 1 Feb 2021 19:19:22 +0000 (20:19 +0100)]
Merge branch '17306-Favorites-in-copy-dialog-is-different-to-favorite-list' of git.arvados.org:arvados-workbench2 into 17306-Favorites-in-copy-dialog-is-different-to-favorite-list

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years ago17306: Removed userUuid from group call
Daniel Kutyła [Mon, 1 Feb 2021 18:50:39 +0000 (19:50 +0100)]
17306: Removed userUuid from group call

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years ago17306: Removed userUuid from group call
Daniel Kutyła [Mon, 1 Feb 2021 18:50:39 +0000 (19:50 +0100)]
17306: Removed userUuid from group call

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years ago17205: Added new component to fetch owner name
Daniel Kutyła [Thu, 28 Jan 2021 21:23:29 +0000 (22:23 +0100)]
17205: Added new component to fetch owner name

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years agoMerge branch '17266-property-ui-synonym-fix'
Lucas Di Pentima [Thu, 28 Jan 2021 19:29:46 +0000 (16:29 -0300)]
Merge branch '17266-property-ui-synonym-fix'
Closes #17266

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17266: Fixes integration test.
Lucas Di Pentima [Wed, 27 Jan 2021 22:00:37 +0000 (19:00 -0300)]
17266: Fixes integration test.

One cypress test started failing because instead of using visit() now the
tests navigate to collection through the app router, so previous state is
kept. The problem was that on collection updates an action was dispatched
to update the parent project of the collection. This caused issues with the
details panel incorrectly loading the project's details instead of keeping
the collection's data on it.

Also, updated yarn.lock after the cypress 6.x update.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17266: Handles onChange event separate on the property editor.
Lucas Di Pentima [Tue, 26 Jan 2021 14:27:52 +0000 (11:27 -0300)]
17266: Handles onChange event separate on the property editor.

When changing the property value field, on every event a vocabulary match
is attempted just in case the user submits the form by hitting <enter>.
The bug happened because the vocabulary matching was only relying on the
onBlur event, that doesn't fire in this case.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17266: Avoids adding a property value without a key.
Lucas Di Pentima [Mon, 25 Jan 2021 20:33:55 +0000 (17:33 -0300)]
17266: Avoids adding a property value without a key.

Also resets the form whenever a property key changes, this avoids a previously
validated property value to be taken as valid with a different property key.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17266: Exposes the bug with an integration test.
Lucas Di Pentima [Wed, 27 Jan 2021 00:06:54 +0000 (21:06 -0300)]
17266: Exposes the bug with an integration test.

When the user typed a valid property value and hit <enter>, the literal
value's label is saved on the backend instead of its vocabulary ID.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17266: Avoids reloading the app on cypress tests by using search.
Lucas Di Pentima [Tue, 26 Jan 2021 14:23:43 +0000 (11:23 -0300)]
17266: Avoids reloading the app on cypress tests by using search.

Instead of using visit(url), whenever possible we should use some method
that makes the app do the routing. One way is to use the search bar with
UUIDs, as it will use the route to the proper resource panel.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoMerge branch '17256-File-selection-dialog-browser-tests'
Daniel Kutyła [Mon, 25 Jan 2021 21:03:25 +0000 (22:03 +0100)]
Merge branch '17256-File-selection-dialog-browser-tests'
closes #17256

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years agoMerge branch '17264-Files-in-file-picker-have-wrong-icon'
Daniel Kutyła [Mon, 25 Jan 2021 20:27:34 +0000 (21:27 +0100)]
Merge branch '17264-Files-in-file-picker-have-wrong-icon'
closes #17264

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years ago17264: Replaced file icon with new one
Daniel Kutyła [Mon, 25 Jan 2021 20:23:34 +0000 (21:23 +0100)]
17264: Replaced file icon with new one

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years ago17256: Fixed broken tests
Daniel Kutyła [Sun, 24 Jan 2021 10:32:48 +0000 (11:32 +0100)]
17256: Fixed broken tests

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years ago17256: Merge branch 'master' into 17256-File-selection-dialog-browser-tests
Lucas Di Pentima [Fri, 22 Jan 2021 18:38:29 +0000 (15:38 -0300)]
17256: Merge branch 'master' into 17256-File-selection-dialog-browser-tests

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoUpdates the Dockefile to request a newer nodejs base image.
Lucas Di Pentima [Fri, 22 Jan 2021 16:50:53 +0000 (13:50 -0300)]
Updates the Dockefile to request a newer nodejs base image.
Refs #17256

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17264: Added generic component to get resource icon
Daniel Kutyła [Thu, 21 Jan 2021 20:56:38 +0000 (21:56 +0100)]
17264: Added generic component to get resource icon

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years ago17256: Added browser tests
Daniel Kutyła [Wed, 20 Jan 2021 18:22:44 +0000 (19:22 +0100)]
17256: Added browser tests

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years agoMerge branch '17109-keepweb-urls-pdh-support'
Lucas Di Pentima [Wed, 20 Jan 2021 15:29:58 +0000 (12:29 -0300)]
Merge branch '17109-keepweb-urls-pdh-support'
Refs #17109

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoMerge branch '17256-file-selection-dialog-issue'
Daniel Kutyła [Fri, 15 Jan 2021 19:59:34 +0000 (20:59 +0100)]
Merge branch '17256-file-selection-dialog-issue'
refs #16256

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years ago17256: Code optimisation
Daniel Kutyła [Fri, 15 Jan 2021 17:18:50 +0000 (18:18 +0100)]
17256: Code optimisation

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years ago17109: Adds support for inline keep-web PDH URLs.
Lucas Di Pentima [Thu, 14 Jan 2021 21:34:35 +0000 (18:34 -0300)]
17109: Adds support for inline keep-web PDH URLs.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17256: Added map to enable item resolution
Daniel Kutyła [Thu, 14 Jan 2021 20:56:37 +0000 (21:56 +0100)]
17256: Added map to enable item resolution

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

3 years agoMerge branch '17257-wf-advanced-settings' refs #17257
Peter Amstutz [Thu, 14 Jan 2021 19:17:42 +0000 (14:17 -0500)]
Merge branch '17257-wf-advanced-settings' refs #17257

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago17257: Don't export DEFAULT_ADVANCED_FORM_VALUES any more
Peter Amstutz [Thu, 14 Jan 2021 19:17:13 +0000 (14:17 -0500)]
17257: Don't export DEFAULT_ADVANCED_FORM_VALUES any more

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago17257: openRunProcess calls getWorkflowRunnerSettings for correct defaults
Peter Amstutz [Thu, 14 Jan 2021 18:28:54 +0000 (13:28 -0500)]
17257: openRunProcess calls getWorkflowRunnerSettings for correct defaults

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>