arvados.git
4 years ago16795: Simplify "kill" behavior in stub driver.
Tom Clegg [Tue, 1 Sep 2020 21:10:09 +0000 (17:10 -0400)]
16795: Simplify "kill" behavior in stub driver.

Now, "kill" just sets a flag, and the "run" stub exits when it notices
the flag.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16795: Fix false-positive bug detection.
Tom Clegg [Tue, 1 Sep 2020 20:22:13 +0000 (16:22 -0400)]
16795: Fix false-positive bug detection.

The dispatcher simulation test occasionally fails with this error when
a crunch-run stub is killed, and the same container is rescheduled on
the same node before the first attempt's startup-phase sleep expires:

    bugf("[test] StubDriver bug or caller bug: pid %d exiting, running[%s]==%d", pid, uuid, svm.running[uuid])
... Error: [test] StubDriver bug or caller bug: pid 9 exiting, running[zzzzz-dz642-000000000000184]==0

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoMerge branch '16790-next-marker-omitempty'
Tom Clegg [Tue, 1 Sep 2020 15:33:25 +0000 (11:33 -0400)]
Merge branch '16790-next-marker-omitempty'

fixes #16790

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoCheck Content-Length header in HeadObject response.
Tom Clegg [Tue, 1 Sep 2020 14:47:17 +0000 (10:47 -0400)]
Check Content-Length header in HeadObject response.

refs #16596

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoMerge branch '16739-concurrent-node-create-throttle'
Ward Vandewege [Tue, 1 Sep 2020 14:34:10 +0000 (10:34 -0400)]
Merge branch '16739-concurrent-node-create-throttle'

closes #16739

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16739: Merge branch 'master' into 16739-concurrent-node-create-throttle
Ward Vandewege [Tue, 1 Sep 2020 14:33:27 +0000 (10:33 -0400)]
16739: Merge branch 'master' into 16739-concurrent-node-create-throttle

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16739: doc update: implement review feedback.
Ward Vandewege [Tue, 1 Sep 2020 14:32:47 +0000 (10:32 -0400)]
16739: doc update: implement review feedback.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16739: remove throttle.ResetError, update the err field directly from
Ward Vandewege [Tue, 1 Sep 2020 14:23:33 +0000 (10:23 -0400)]
16739: remove throttle.ResetError, update the err field directly from
       the test.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16790: Avoid returning empty NextMarker tag in list responses.
Tom Clegg [Tue, 1 Sep 2020 14:16:47 +0000 (10:16 -0400)]
16790: Avoid returning empty NextMarker tag in list responses.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16739: implement review feedback.
Ward Vandewege [Tue, 1 Sep 2020 13:43:57 +0000 (09:43 -0400)]
16739: implement review feedback.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16779: Create user accounts even if they don't have an ssh key
Peter Amstutz [Mon, 31 Aug 2020 18:22:27 +0000 (14:22 -0400)]
16779: Create user accounts even if they don't have an ssh key

refs #16779

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoFix redundant entry in cluster config, arvbox tells you to use adduser
Peter Amstutz [Mon, 31 Aug 2020 21:37:56 +0000 (17:37 -0400)]
Fix redundant entry in cluster config, arvbox tells you to use adduser

refs #16749

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoMerge branch '16788-add-nodejs-dependency-to-a-c-r-package'
Ward Vandewege [Mon, 31 Aug 2020 19:49:12 +0000 (15:49 -0400)]
Merge branch '16788-add-nodejs-dependency-to-a-c-r-package'

closes #16788

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16788: add package dependency on nodejs to arvados-cwl-runner.
Ward Vandewege [Mon, 31 Aug 2020 19:47:51 +0000 (15:47 -0400)]
16788: add package dependency on nodejs to arvados-cwl-runner.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16739: Fix using two different throttles.
Tom Clegg [Mon, 31 Aug 2020 19:34:22 +0000 (15:34 -0400)]
16739: Fix using two different throttles.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16739: a-d-c: add a concurrent node creation throttle option.
Ward Vandewege [Mon, 31 Aug 2020 18:42:14 +0000 (14:42 -0400)]
16739: a-d-c: add a concurrent node creation throttle option.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years agoMerge branch '16602-wb-acr-version' refs #16602
Peter Amstutz [Mon, 31 Aug 2020 15:29:01 +0000 (11:29 -0400)]
Merge branch '16602-wb-acr-version' refs #16602

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoMerge branch '16723-kill-vs-requeue'
Tom Clegg [Mon, 31 Aug 2020 14:30:04 +0000 (10:30 -0400)]
Merge branch '16723-kill-vs-requeue'

closes #16723

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoFix bug introduced with gofmt cleanup yesterday.
Ward Vandewege [Sun, 30 Aug 2020 12:03:19 +0000 (08:03 -0400)]
Fix bug introduced with gofmt cleanup yesterday.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years agoFix some golint warnings.
Ward Vandewege [Sat, 29 Aug 2020 11:20:19 +0000 (07:20 -0400)]
Fix some golint warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16602: fix test
Peter Amstutz [Fri, 28 Aug 2020 20:46:22 +0000 (16:46 -0400)]
16602: fix test

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoMerge branch '16535-s3'
Tom Clegg [Fri, 28 Aug 2020 20:17:48 +0000 (16:17 -0400)]
Merge branch '16535-s3'

closes #16535

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoMerge branch '16720-arv-mount-exception'
Tom Clegg [Fri, 28 Aug 2020 20:16:51 +0000 (16:16 -0400)]
Merge branch '16720-arv-mount-exception'

fixes #16720

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16602: Tweak fixture 'name' name to fix test
Peter Amstutz [Fri, 28 Aug 2020 20:04:19 +0000 (16:04 -0400)]
16602: Tweak fixture 'name' name to fix test

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16602: Test for applying WorkflowRunnerResource
Peter Amstutz [Fri, 28 Aug 2020 01:38:34 +0000 (21:38 -0400)]
16602: Test for applying WorkflowRunnerResource

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16602: Add missing file
Peter Amstutz [Wed, 26 Aug 2020 21:22:44 +0000 (17:22 -0400)]
16602: Add missing file

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16602: Workbench sets container_image from acrContainerImage
Peter Amstutz [Wed, 26 Aug 2020 19:44:59 +0000 (15:44 -0400)]
16602: Workbench sets container_image from acrContainerImage

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16602: Embed the desired workflow runner version in WorkflowRunnerResources
Peter Amstutz [Wed, 26 Aug 2020 19:40:33 +0000 (15:40 -0400)]
16602: Embed the desired workflow runner version in WorkflowRunnerResources

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoAdd missing install page for arvados-cwl-runner refs #15964
Peter Amstutz [Fri, 28 Aug 2020 20:01:39 +0000 (16:01 -0400)]
Add missing install page for arvados-cwl-runner refs #15964

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16535: Avoid including empty CommonPrefixes tag in list response.
Tom Clegg [Fri, 28 Aug 2020 15:28:29 +0000 (11:28 -0400)]
16535: Avoid including empty CommonPrefixes tag in list response.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoMerge branch '16749-arvbox-users' refs #16749
Peter Amstutz [Fri, 28 Aug 2020 14:31:15 +0000 (10:31 -0400)]
Merge branch '16749-arvbox-users' refs #16749

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoFix more gofmt warnings.
Ward Vandewege [Fri, 28 Aug 2020 12:29:57 +0000 (08:29 -0400)]
Fix more gofmt warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16749: Put AutoAdminFirstUser back
Peter Amstutz [Fri, 28 Aug 2020 02:17:31 +0000 (22:17 -0400)]
16749: Put AutoAdminFirstUser back

Fix git clone to use git.arvados.org

Fix typo redundant 'InternalURLs' field

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16720: Fix missing import.
Tom Clegg [Thu, 27 Aug 2020 19:50:25 +0000 (15:50 -0400)]
16720: Fix missing import.

Also delete unused inline import (sys), and double import (time).

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16720: Add missing import.
Tom Clegg [Thu, 27 Aug 2020 19:47:28 +0000 (15:47 -0400)]
16720: Add missing import.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoFix a few gofmt warnings.
Ward Vandewege [Thu, 27 Aug 2020 19:06:44 +0000 (15:06 -0400)]
Fix a few gofmt warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16749: Adjust test login message.
Peter Amstutz [Thu, 27 Aug 2020 17:23:14 +0000 (13:23 -0400)]
16749: Adjust test login message.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16749: Command line user management for arvbox
Peter Amstutz [Thu, 27 Aug 2020 17:09:16 +0000 (13:09 -0400)]
16749: Command line user management for arvbox

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoMerge branch '16613-sys-root-tok' refs #16613
Peter Amstutz [Wed, 26 Aug 2020 21:24:41 +0000 (17:24 -0400)]
Merge branch '16613-sys-root-tok' refs #16613

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16613: Tweak system_root_token_api_client record
Peter Amstutz [Wed, 26 Aug 2020 18:16:50 +0000 (14:16 -0400)]
16613: Tweak system_root_token_api_client record

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16613: Create special-purpose ApiClient record for SystemRootToken
Peter Amstutz [Tue, 25 Aug 2020 20:03:38 +0000 (16:03 -0400)]
16613: Create special-purpose ApiClient record for SystemRootToken

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16613: Add test using SystemRootToken to create other tokens.
Peter Amstutz [Thu, 20 Aug 2020 22:10:43 +0000 (18:10 -0400)]
16613: Add test using SystemRootToken to create other tokens.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years agoMerge branch '16314-arvbox-testuserdb'
Tom Clegg [Wed, 26 Aug 2020 13:54:23 +0000 (09:54 -0400)]
Merge branch '16314-arvbox-testuserdb'

refs #16314

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16314: Remove SSO from arvbox docs.
Tom Clegg [Wed, 26 Aug 2020 13:51:37 +0000 (09:51 -0400)]
16314: Remove SSO from arvbox docs.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16314: Merge branch 'master'
Tom Clegg [Tue, 25 Aug 2020 20:41:21 +0000 (16:41 -0400)]
16314: Merge branch 'master'

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoMerge branch '15964-fix-docs' refs #15964
Peter Amstutz [Tue, 25 Aug 2020 18:45:29 +0000 (14:45 -0400)]
Merge branch '15964-fix-docs' refs #15964

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago15964: Remove qr1hi from a few more places. Delete unused includes.
Peter Amstutz [Tue, 25 Aug 2020 18:24:42 +0000 (14:24 -0400)]
15964: Remove qr1hi from a few more places.  Delete unused includes.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16314: Search both user and tmp paths for gems.
Tom Clegg [Tue, 25 Aug 2020 18:18:12 +0000 (14:18 -0400)]
16314: Search both user and tmp paths for gems.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoMerge branch '16678-login-tokens-lifetime-config'
Lucas Di Pentima [Tue, 25 Aug 2020 18:00:33 +0000 (15:00 -0300)]
Merge branch '16678-login-tokens-lifetime-config'
Closes #16678

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16678: Fixes minor doc issues.
Lucas Di Pentima [Tue, 25 Aug 2020 17:56:42 +0000 (14:56 -0300)]
16678: Fixes minor doc issues.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16678: Wording improvements, document how to create a token at cli
Peter Amstutz [Tue, 25 Aug 2020 17:44:10 +0000 (13:44 -0400)]
16678: Wording improvements, document how to create a token at cli

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16314: Fix bundle install recipe.
Tom Clegg [Tue, 25 Aug 2020 15:16:47 +0000 (11:16 -0400)]
16314: Fix bundle install recipe.

Previous code used incorrect bin path when GEM_HOME was set by caller,
e.g., arvbox.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoMerge branch '15886-remove-arv-web' into master
Nico Cesar [Tue, 25 Aug 2020 15:14:00 +0000 (11:14 -0400)]
Merge branch '15886-remove-arv-web' into master

closes #15886

Arvados-DCO-1.1-Signed-off-by: Nico Cesar <nico@curii.com>

4 years ago16314: Fix cleanup of temp/arvbox dirs that contain readonly dirs.
Tom Clegg [Tue, 25 Aug 2020 14:12:55 +0000 (10:12 -0400)]
16314: Fix cleanup of temp/arvbox dirs that contain readonly dirs.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoRemove arv-web.py and documentation.
Nico Cesar [Tue, 25 Aug 2020 13:54:04 +0000 (09:54 -0400)]
Remove arv-web.py and documentation.

refs #15886

Arvados-DCO-1.1-Signed-off-by: Nico Cesar <nico@curii.com>

4 years agoFix a few gofmt warnings.
Ward Vandewege [Tue, 25 Aug 2020 02:11:09 +0000 (22:11 -0400)]
Fix a few gofmt warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16314: Serve login form in test login mode.
Tom Clegg [Mon, 24 Aug 2020 21:05:25 +0000 (17:05 -0400)]
16314: Serve login form in test login mode.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16678: Adds documentation about feature usage on the Admin section.
Lucas Di Pentima [Mon, 24 Aug 2020 19:47:47 +0000 (16:47 -0300)]
16678: Adds documentation about feature usage on the Admin section.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoReverts previously dropped commit that got reintroduced by a rebase.
Lucas Di Pentima [Mon, 24 Aug 2020 15:48:53 +0000 (12:48 -0300)]
Reverts previously dropped commit that got reintroduced by a rebase.
Refs #16470

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoMerge branch '16470-wb-rails-52'
Lucas Di Pentima [Mon, 24 Aug 2020 15:24:15 +0000 (12:24 -0300)]
Merge branch '16470-wb-rails-52'
Closes #16470

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoMerge branch '16535-s3'
Tom Clegg [Mon, 24 Aug 2020 15:23:18 +0000 (11:23 -0400)]
Merge branch '16535-s3'

refs #16535

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16470: Pins launchy gem to avoid requiring ruby >= 2.4.0
Lucas Di Pentima [Mon, 17 Aug 2020 19:39:01 +0000 (16:39 -0300)]
16470: Pins launchy gem to avoid requiring ruby >= 2.4.0

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16470: Fixes test failures caused by a change on ActiveModel::Dirty.
Lucas Di Pentima [Thu, 13 Aug 2020 18:01:42 +0000 (15:01 -0300)]
16470: Fixes test failures caused by a change on ActiveModel::Dirty.

This was a tough one to diagnose. The Dirty module introduced the usage of an
attribute mutation tracker, being disabled here for functional tests to start
working again.
This commit is based on: https://github.com/Dynamoid/dynamoid/pull/256

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16470: Removes unused cruft.
Lucas Di Pentima [Thu, 13 Aug 2020 17:42:27 +0000 (14:42 -0300)]
16470: Removes unused cruft.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16470: Cleans up config files.
Lucas Di Pentima [Mon, 10 Aug 2020 14:57:45 +0000 (11:57 -0300)]
16470: Cleans up config files.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16470: Removes deprecated 'secret_token' config key.
Lucas Di Pentima [Thu, 6 Aug 2020 17:33:52 +0000 (14:33 -0300)]
16470: Removes deprecated 'secret_token' config key.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16470: Updates & additions by running 'rails app:update'
Lucas Di Pentima [Thu, 6 Aug 2020 17:33:36 +0000 (14:33 -0300)]
16470: Updates & additions by running 'rails app:update'

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16470: Removes exception deprecated on rails 3.2
Lucas Di Pentima [Wed, 5 Aug 2020 19:57:26 +0000 (16:57 -0300)]
16470: Removes exception deprecated on rails 3.2

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16470: Upgrades to rails 5.2.
Lucas Di Pentima [Wed, 5 Aug 2020 19:53:13 +0000 (16:53 -0300)]
16470: Upgrades to rails 5.2.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16470: Fixes deprecation warning.
Lucas Di Pentima [Wed, 5 Aug 2020 19:43:54 +0000 (16:43 -0300)]
16470: Fixes deprecation warning.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16470: Applies changes from 'rails app:update'.
Lucas Di Pentima [Wed, 5 Aug 2020 18:39:47 +0000 (15:39 -0300)]
16470: Applies changes from 'rails app:update'.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16470: Pins the sprocket gem to avoid upgrading to 4.0, that causes issues.
Lucas Di Pentima [Wed, 5 Aug 2020 17:43:50 +0000 (14:43 -0300)]
16470: Pins the sprocket gem to avoid upgrading to 4.0, that causes issues.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16470: Upgrades rails to 5.1.7 on workbench.
Lucas Di Pentima [Wed, 5 Aug 2020 16:06:34 +0000 (13:06 -0300)]
16470: Upgrades rails to 5.1.7 on workbench.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16470: Fixes the last deprecation warnings.
Lucas Di Pentima [Fri, 24 Jul 2020 20:12:27 +0000 (17:12 -0300)]
16470: Fixes the last deprecation warnings.

It turned out that .lock!() is an ActiveRecord method, and I was confusing it
with Container::lock and ContainerRequest::lock.
Both lock! and with_lock methods need the record to be persisted or reloaded
explicitly.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16723: Don't lock after requeue until old crunch-run exits.
Tom Clegg [Mon, 24 Aug 2020 14:20:32 +0000 (10:20 -0400)]
16723: Don't lock after requeue until old crunch-run exits.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16314: Remove SSO from arvbox.
Tom Clegg [Mon, 24 Aug 2020 14:06:50 +0000 (10:06 -0400)]
16314: Remove SSO from arvbox.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoFix more ineffassign warnings.
Ward Vandewege [Sun, 23 Aug 2020 19:06:44 +0000 (15:06 -0400)]
Fix more ineffassign warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years agoFix more ineffassign warnings.
Ward Vandewege [Sat, 22 Aug 2020 15:37:27 +0000 (11:37 -0400)]
Fix more ineffassign warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years agoMerge branch '16723-kill-vs-requeue'
Tom Clegg [Sat, 22 Aug 2020 01:54:54 +0000 (21:54 -0400)]
Merge branch '16723-kill-vs-requeue'

fixes #16723

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16678: Adds rake task to manage long lived tokens.
Lucas Di Pentima [Sat, 22 Aug 2020 01:44:49 +0000 (22:44 -0300)]
16678: Adds rake task to manage long lived tokens.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16678: Fixes mistake on previous merge.
Lucas Di Pentima [Fri, 21 Aug 2020 21:51:51 +0000 (18:51 -0300)]
16678: Fixes mistake on previous merge.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoMerge branch 'master' into 16678-login-tokens-lifetime-config
Lucas Di Pentima [Fri, 21 Aug 2020 21:09:09 +0000 (18:09 -0300)]
Merge branch 'master' into 16678-login-tokens-lifetime-config

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoFix config key case.
Tom Clegg [Fri, 21 Aug 2020 20:40:34 +0000 (16:40 -0400)]
Fix config key case.

refs #16314

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoMerge branch '16314-testuserdb'
Tom Clegg [Fri, 21 Aug 2020 20:39:34 +0000 (16:39 -0400)]
Merge branch '16314-testuserdb'

refs #16314

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16723: Fix stubPool KillContainer(): return false if not running.
Tom Clegg [Fri, 21 Aug 2020 20:11:46 +0000 (16:11 -0400)]
16723: Fix stubPool KillContainer(): return false if not running.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoMerge branch '16565-no-more-latest-docker-jobs-image'
Ward Vandewege [Fri, 21 Aug 2020 19:35:45 +0000 (15:35 -0400)]
Merge branch '16565-no-more-latest-docker-jobs-image'

closes #16565

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16565: Merge branch 'master' into 16565-no-more-latest-docker-jobs-image
Ward Vandewege [Fri, 21 Aug 2020 19:35:00 +0000 (15:35 -0400)]
16565: Merge branch 'master' into 16565-no-more-latest-docker-jobs-image

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16723: fix test to reflect new stub instance name.
Ward Vandewege [Fri, 21 Aug 2020 19:29:45 +0000 (15:29 -0400)]
16723: fix test to reflect new stub instance name.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16723: Don't lock a requeued container while old crunch-runs exist.
Tom Clegg [Fri, 21 Aug 2020 15:30:04 +0000 (11:30 -0400)]
16723: Don't lock a requeued container while old crunch-runs exist.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16723: Fail test if a crunch-run stub is killed before finishing.
Tom Clegg [Fri, 21 Aug 2020 15:24:50 +0000 (11:24 -0400)]
16723: Fail test if a crunch-run stub is killed before finishing.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16678: Don't trust API clients from trusted URLs when TokenLifetime is set.
Lucas Di Pentima [Fri, 21 Aug 2020 14:59:01 +0000 (11:59 -0300)]
16678: Don't trust API clients from trusted URLs when TokenLifetime is set.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16723: Hold uuidLock in kill() to avoid racing with unlock+start.
Tom Clegg [Fri, 21 Aug 2020 14:42:49 +0000 (10:42 -0400)]
16723: Hold uuidLock in kill() to avoid racing with unlock+start.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16723: Fix double-container-running bug in test stub.
Tom Clegg [Fri, 21 Aug 2020 14:38:25 +0000 (10:38 -0400)]
16723: Fix double-container-running bug in test stub.

Two parts:

1. Update state to Complete before crunch-run exits, not after.

2. Don't call the "crashed while running" hook from the test stub
unless changing state to Running actually succeeded.

Also, call the "crashed while running" hook from the test stub if
changing state from Running to Complete fails.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16723: Use more readable instance IDs in tests.
Tom Clegg [Fri, 21 Aug 2020 13:24:02 +0000 (09:24 -0400)]
16723: Use more readable instance IDs in tests.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoFix whitespace in run-tests.sh
Ward Vandewege [Fri, 21 Aug 2020 13:36:45 +0000 (09:36 -0400)]
Fix whitespace in run-tests.sh

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16723: Reject invalid updates in API stub.
Tom Clegg [Fri, 21 Aug 2020 02:21:14 +0000 (22:21 -0400)]
16723: Reject invalid updates in API stub.

When dispatcher notices crunch-run has exited and the last known state
is Locked, it requeues the container. If crunch-run changed the
container state to Running before exiting (and dispatcher hasn't
noticed yet), dispatcher relies on RailsAPI/controller to reject the
requeue attempt.

Without this, the scheduler's state=Queued call was being accepted
even after losing a race to the stub's state=Running call,
occasionally causing a container to run twice and fail the randomized
simulation test.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16723: Fix wrong operation shown in debug log.
Tom Clegg [Fri, 21 Aug 2020 01:34:40 +0000 (21:34 -0400)]
16723: Fix wrong operation shown in debug log.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16535: Add S3 DeleteObject API.
Tom Clegg [Thu, 20 Aug 2020 20:24:19 +0000 (16:24 -0400)]
16535: Add S3 DeleteObject API.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years agoMerge branch '16625-add-azure-managed-image-support'
Ward Vandewege [Thu, 20 Aug 2020 19:39:26 +0000 (15:39 -0400)]
Merge branch '16625-add-azure-managed-image-support'

refs #16625

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

4 years ago16625: fix tests.
Ward Vandewege [Thu, 20 Aug 2020 19:38:38 +0000 (15:38 -0400)]
16625: fix tests.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>