arvados.git
10 years agoMerge branch 'master' into 4195-pipeline-tutorial
radhika [Thu, 23 Oct 2014 21:03:44 +0000 (17:03 -0400)]
Merge branch 'master' into 4195-pipeline-tutorial

10 years agorefs #4227
radhika [Thu, 23 Oct 2014 20:36:32 +0000 (16:36 -0400)]
refs #4227
Merge branch '4227-test-fix'

10 years agono issue #
radhika [Thu, 23 Oct 2014 20:27:02 +0000 (16:27 -0400)]
no issue #

10 years agono issue #
radhika [Thu, 23 Oct 2014 20:24:00 +0000 (16:24 -0400)]
no issue #
Merge branch 'master' of git.curoverse.com:arvados

10 years agorefs #4227 - update strptime format for parsing pipeline start and finish time.
radhika [Thu, 23 Oct 2014 20:22:50 +0000 (16:22 -0400)]
refs #4227 - update strptime format for parsing pipeline start and finish time.

10 years agoMerge branch '4139-clean-api-node-cruft-wip'
Brett Smith [Thu, 23 Oct 2014 19:44:35 +0000 (15:44 -0400)]
Merge branch '4139-clean-api-node-cruft-wip'

Refs #4139, #4274.  Closes #4276.

10 years ago4139: Node create API requires a node parameter.
Brett Smith [Thu, 23 Oct 2014 19:36:52 +0000 (15:36 -0400)]
4139: Node create API requires a node parameter.

This makes it more consistent with other API create methods.

10 years ago4139: Remove cloud node setup code from API server.
Brett Smith [Tue, 21 Oct 2014 14:58:59 +0000 (10:58 -0400)]
4139: Remove cloud node setup code from API server.

This code has never been used in production, and its functionality has
officially been assumed by Node Manager.

10 years agorefs #4227 - rescue from any error in parsing pipeline start and finish time so that...
radhika [Thu, 23 Oct 2014 19:37:52 +0000 (15:37 -0400)]
refs #4227 - rescue from any error in parsing pipeline start and finish time so that jenkins runs do not choke on these failures.

10 years agoIncrease limit for collections controller querying same portable_data_hash as
Peter Amstutz [Thu, 23 Oct 2014 17:53:31 +0000 (13:53 -0400)]
Increase limit for collections controller querying same portable_data_hash as
workaround to fix tests, refs #4058, but really needs a proper fix, refs #3400

10 years agoMerge branch '4058-workbench-collection-redirect' closes #4058
Peter Amstutz [Thu, 23 Oct 2014 15:18:54 +0000 (11:18 -0400)]
Merge branch '4058-workbench-collection-redirect' closes #4058

10 years ago4058: Typo fix "collection" -> "collections"
Peter Amstutz [Thu, 23 Oct 2014 15:18:29 +0000 (11:18 -0400)]
4058: Typo fix "collection" -> "collections"

10 years ago4058: Tweaked presentation per review feedback
Peter Amstutz [Thu, 23 Oct 2014 13:38:15 +0000 (09:38 -0400)]
4058: Tweaked presentation per review feedback

10 years agocloses #4026
radhika [Thu, 23 Oct 2014 02:25:46 +0000 (22:25 -0400)]
closes #4026
Merge branch '4026-project-move-admin'

10 years ago4026: simplify writable check
radhika [Thu, 23 Oct 2014 02:24:37 +0000 (22:24 -0400)]
4026: simplify writable check

10 years agoMerge branch 'master' into 4026-project-move-admin
radhika [Thu, 23 Oct 2014 00:10:17 +0000 (20:10 -0400)]
Merge branch 'master' into 4026-project-move-admin

10 years ago4137: Fix bad state reference in Node Manager daemon.
Brett Smith [Wed, 22 Oct 2014 19:13:09 +0000 (15:13 -0400)]
4137: Fix bad state reference in Node Manager daemon.

Refs #4137.

10 years agocloses #4227
radhika [Wed, 22 Oct 2014 18:57:27 +0000 (14:57 -0400)]
closes #4227
Merge branch '4227-date-display'

10 years agoMerge branch 'master' into 4227-date-display
radhika [Wed, 22 Oct 2014 18:55:55 +0000 (14:55 -0400)]
Merge branch 'master' into 4227-date-display

Conflicts:
apps/workbench/test/integration/projects_test.rb

10 years agorefs #4091 - comment out the test that is failing intermittently in jenkins env.
radhika [Wed, 22 Oct 2014 18:46:34 +0000 (14:46 -0400)]
refs #4091 - comment out the test that is failing intermittently in jenkins env.

10 years ago4139: Fix race condition in Node Manager tests.
Brett Smith [Wed, 22 Oct 2014 18:28:45 +0000 (14:28 -0400)]
4139: Fix race condition in Node Manager tests.

Get a reference to the monitor mock earlier, before the daemon starts
working with it.  Otherwise, we might get inconsistent state results.

Refs #4139.

10 years agoReport "swap" memory statistic if kernel provides it. refs #4185
Tom Clegg [Wed, 22 Oct 2014 18:01:10 +0000 (14:01 -0400)]
Report "swap" memory statistic if kernel provides it. refs #4185

10 years ago4227: much simplified date display test
radhika [Wed, 22 Oct 2014 17:12:10 +0000 (13:12 -0400)]
4227: much simplified date display test

10 years agoMerge branch 'master' into 4227-date-display
radhika [Wed, 22 Oct 2014 15:55:02 +0000 (11:55 -0400)]
Merge branch 'master' into 4227-date-display

10 years agoMerge branch '3826-crunchstat-netstats' closes #3826
Tom Clegg [Wed, 22 Oct 2014 15:01:55 +0000 (11:01 -0400)]
Merge branch '3826-crunchstat-netstats' closes #3826

10 years ago3826: Merge branch 'master' into 3826-crunchstat-netstats
Tom Clegg [Wed, 22 Oct 2014 14:57:03 +0000 (10:57 -0400)]
3826: Merge branch 'master' into 3826-crunchstat-netstats

10 years agoMerge branch '4139-node-manager-race-fix-wip'
Brett Smith [Wed, 22 Oct 2014 14:35:21 +0000 (10:35 -0400)]
Merge branch '4139-node-manager-race-fix-wip'

Refs #4139, #4275.

10 years ago4139: Node Manager more closely tracks nodes it boots.
Brett Smith [Wed, 22 Oct 2014 14:34:23 +0000 (10:34 -0400)]
4139: Node Manager more closely tracks nodes it boots.

When using Node Manager on EC2, we saw a race condition where a node
would finish setting up, but would not be returned in node listings
right away.  This adds a "booted" node state to the daemon, where a
node booted by Node Manager is assumed to be up and running unless it
disappears from the listing *after* being listed.  It's escalated to
the normal workflow after it appears in a listing.

10 years ago4139: Node Manager supports subscribing to shutdown events.
Brett Smith [Wed, 22 Oct 2014 14:02:33 +0000 (10:02 -0400)]
4139: Node Manager supports subscribing to shutdown events.

This is necessary to fix a race condition.  The daemon needs to be
able to track nodes that it has booted even if they don't appear in
listings.

10 years agoMerge branch 'master' into 4195-pipeline-tutorial
radhika [Tue, 21 Oct 2014 22:12:44 +0000 (18:12 -0400)]
Merge branch 'master' into 4195-pipeline-tutorial

10 years ago4195: fix the tutorial to match the latest dashboard ui.
radhika [Tue, 21 Oct 2014 22:11:45 +0000 (18:11 -0400)]
4195: fix the tutorial to match the latest dashboard ui.

10 years agoMerge branch '4266-log-performance' refs #4266
Tom Clegg [Tue, 21 Oct 2014 21:28:53 +0000 (17:28 -0400)]
Merge branch '4266-log-performance' refs #4266

10 years ago4266: Merge branch 'master' into 4266-log-performance
Tom Clegg [Tue, 21 Oct 2014 21:12:07 +0000 (17:12 -0400)]
4266: Merge branch 'master' into 4266-log-performance

10 years ago4266: Add word missing from comment.
Tom Clegg [Tue, 21 Oct 2014 20:36:13 +0000 (16:36 -0400)]
4266: Add word missing from comment.

10 years ago4266: Use each_line as enumerator instead of building an array with lines.each.
Tom Clegg [Tue, 21 Oct 2014 20:35:41 +0000 (16:35 -0400)]
4266: Use each_line as enumerator instead of building an array with lines.each.

10 years ago4266: Add missing "next" statement, oops.
Tom Clegg [Tue, 21 Oct 2014 20:34:53 +0000 (16:34 -0400)]
4266: Add missing "next" statement, oops.

10 years ago4227: update fixtures to use bigger finish times
radhika [Tue, 21 Oct 2014 19:57:47 +0000 (15:57 -0400)]
4227: update fixtures to use bigger finish times

10 years agoMerge branch 'master' of git.curoverse.com:arvados into 4227-date-display
radhika [Tue, 21 Oct 2014 19:44:46 +0000 (15:44 -0400)]
Merge branch 'master' of git.curoverse.com:arvados into 4227-date-display

10 years agoMerge branch '4139-node-manager-polling-logging-wip'
Brett Smith [Tue, 21 Oct 2014 18:35:49 +0000 (14:35 -0400)]
Merge branch '4139-node-manager-polling-logging-wip'

Refs #4275, #4139.

10 years ago4139: Improve scheduling of Node Manager polls.
Brett Smith [Tue, 21 Oct 2014 18:31:44 +0000 (14:31 -0400)]
4139: Improve scheduling of Node Manager polls.

* Catch all exceptions, so that we keep polling no matter what
  happens.  Use CLIENT_ERRORS as a hint about how much logging we
  need.
* Make the next poll time calculation a little less stateful and
  easier to follow.
* Add tests for poll scheduling.

10 years ago4139: Improve logging in Node Manager poll actors.
Brett Smith [Tue, 21 Oct 2014 18:13:37 +0000 (14:13 -0400)]
4139: Improve logging in Node Manager poll actors.

10 years ago4139: Node Manager callback actor avoids redundant delivery calls.
Brett Smith [Tue, 21 Oct 2014 15:19:05 +0000 (11:19 -0400)]
4139: Node Manager callback actor avoids redundant delivery calls.

This helps make it more responsive when it receives a shutdown
request.

10 years ago4227: some more test and fixture updates.
radhika [Tue, 21 Oct 2014 17:48:35 +0000 (13:48 -0400)]
4227: some more test and fixture updates.

10 years ago4266: Tweak long-line handling.
Tom Clegg [Tue, 21 Oct 2014 17:46:00 +0000 (13:46 -0400)]
4266: Tweak long-line handling.

10 years ago4266: Fix OOM when stderr has a lot of data with no newlines.
Tom Clegg [Tue, 21 Oct 2014 17:29:05 +0000 (13:29 -0400)]
4266: Fix OOM when stderr has a lot of data with no newlines.

10 years ago4227: minor test upadtes
radhika [Tue, 21 Oct 2014 17:28:57 +0000 (13:28 -0400)]
4227: minor test upadtes

10 years ago4266: Clean up streambuf.split(newline) loop.
Tom Clegg [Tue, 21 Oct 2014 17:05:36 +0000 (13:05 -0400)]
4266: Clean up streambuf.split(newline) loop.

10 years agoMerge branch 'master' into 4227-date-display
radhika [Tue, 21 Oct 2014 17:00:01 +0000 (13:00 -0400)]
Merge branch 'master' into 4227-date-display

10 years agocloses #4054
radhika [Tue, 21 Oct 2014 16:56:33 +0000 (12:56 -0400)]
closes #4054
Merge branch '4054-sharing-email'

10 years ago4091: the test with 200 jobs and 10 pipelines is failing in jenkins env. reduce the...
radhika [Tue, 21 Oct 2014 16:54:32 +0000 (12:54 -0400)]
4091: the test with 200 jobs and 10 pipelines is failing in jenkins env. reduce the number of pipelines to 2 to see if shorter runtime helps.

10 years agoMerge branch 'master' into 4054-sharing-email
radhika [Tue, 21 Oct 2014 16:48:35 +0000 (12:48 -0400)]
Merge branch 'master' into 4054-sharing-email

10 years ago4227: AM / PM indicator fix
radhika [Tue, 21 Oct 2014 16:47:37 +0000 (12:47 -0400)]
4227: AM / PM indicator fix

10 years agoArvados python SDK: do not blow up when HOME is not set.
Ward Vandewege [Tue, 21 Oct 2014 14:11:43 +0000 (10:11 -0400)]
Arvados python SDK: do not blow up when HOME is not set.

No issue #

10 years ago4266: Fix log processing performance.
Tom Clegg [Mon, 20 Oct 2014 21:30:30 +0000 (17:30 -0400)]
4266: Fix log processing performance.

* Remove "max log table entries per job" limit (and its horrible
  memory leak).

* When logs are coming fast, but under all throttle thresholds, group
  them into fewer rows in the logs table.

* Optimize performance by making a short code path when any threshold
  is exceeded. Now capable of ~200 MiB/s (of 100-character lines) on
  lappy386.

* Bring stream buffer back up to a reasonable size, add a comment to
  protect it from future style tweaks.

* Simplify time calculations by storing time-to-reopen-throttle
  instead of time-throttle-last-opened.

* Log "# bytes skipped" to stderr (sysadmin logs) too, not just the
  logs table.

10 years agoMerge branch '3787-docker-docs' closes #3787
Peter Amstutz [Mon, 20 Oct 2014 19:36:36 +0000 (15:36 -0400)]
Merge branch '3787-docker-docs' closes #3787

10 years ago3787: docker group -> @docker@ group for consistency
Peter Amstutz [Mon, 20 Oct 2014 19:35:48 +0000 (15:35 -0400)]
3787: docker group -> @docker@ group for consistency

10 years ago3787: Add note about needing to be in docker group. A few other minor text tweaks.
Peter Amstutz [Mon, 20 Oct 2014 19:23:21 +0000 (15:23 -0400)]
3787: Add note about needing to be in docker group.  A few other minor text tweaks.

10 years ago3787: Update title, grammar, add "Share Docker images", add job-pipeline-ref.html...
Peter Amstutz [Mon, 20 Oct 2014 18:12:41 +0000 (14:12 -0400)]
3787: Update title, grammar, add "Share Docker images", add job-pipeline-ref.html based on review feedback.

10 years agoMerge branch 'master' into 4026-project-move-admin
radhika [Mon, 20 Oct 2014 17:49:08 +0000 (13:49 -0400)]
Merge branch 'master' into 4026-project-move-admin

Conflicts:
apps/workbench/test/integration/projects_test.rb

10 years agoMerge branch 'master' into 4054-sharing-email
radhika [Mon, 20 Oct 2014 17:34:10 +0000 (13:34 -0400)]
Merge branch 'master' into 4054-sharing-email

10 years ago3826: Merge branch 'master' into 3826-crunchstat-netstats
Tom Clegg [Mon, 20 Oct 2014 16:34:58 +0000 (12:34 -0400)]
3826: Merge branch 'master' into 3826-crunchstat-netstats

10 years ago3826: Fix confusing reuse of variable name.
Tom Clegg [Mon, 20 Oct 2014 16:18:48 +0000 (12:18 -0400)]
3826: Fix confusing reuse of variable name.

10 years ago3826: Use strconv instead of scanner + sscanf.
Tom Clegg [Mon, 20 Oct 2014 16:18:13 +0000 (12:18 -0400)]
3826: Use strconv instead of scanner + sscanf.

10 years ago3826: Use global logChan. Use ioutil.ReadFile.
Tom Clegg [Mon, 20 Oct 2014 16:10:12 +0000 (12:10 -0400)]
3826: Use global logChan. Use ioutil.ReadFile.

10 years ago3826: Clean up slice initialization.
Tom Clegg [Mon, 20 Oct 2014 15:57:27 +0000 (11:57 -0400)]
3826: Clean up slice initialization.

10 years ago4058: Tests for portable data hash redirection and multiple matches page.
Peter Amstutz [Mon, 20 Oct 2014 15:39:13 +0000 (11:39 -0400)]
4058: Tests for portable data hash redirection and multiple matches page.

10 years agocloses #4062
radhika [Mon, 20 Oct 2014 15:25:19 +0000 (11:25 -0400)]
closes #4062
Merge branch '4062-infinite-scroll-repeat-TC'

10 years ago4062: Do not clobber next_page_url filters with local filters.
Tom Clegg [Mon, 20 Oct 2014 14:47:32 +0000 (10:47 -0400)]
4062: Do not clobber next_page_url filters with local filters.

10 years ago4058: If a portable data hash correpsonds to a single collection, automatically
Peter Amstutz [Mon, 20 Oct 2014 14:45:10 +0000 (10:45 -0400)]
4058: If a portable data hash correpsonds to a single collection, automatically
redirect to the collection page.  If not, show a special "menu" page listing
the matching collections.

10 years ago4062: Merge branch 'master' into 4062-infinite-scroll-repeat-TC
Tom Clegg [Mon, 20 Oct 2014 14:24:10 +0000 (10:24 -0400)]
4062: Merge branch 'master' into 4062-infinite-scroll-repeat-TC

10 years ago4026: admin user can move a project under another user's home project.
radhika [Mon, 20 Oct 2014 13:22:35 +0000 (09:22 -0400)]
4026: admin user can move a project under another user's home project.

10 years ago4054: minor test update
radhika [Sat, 18 Oct 2014 00:37:34 +0000 (20:37 -0400)]
4054: minor test update

10 years agoMerge branch 'master' into 4054-sharing-email
radhika [Sat, 18 Oct 2014 00:09:29 +0000 (20:09 -0400)]
Merge branch 'master' into 4054-sharing-email

10 years ago4054: show email address in sharing tab and update test to verify.
radhika [Fri, 17 Oct 2014 22:40:28 +0000 (18:40 -0400)]
4054: show email address in sharing tab and update test to verify.

10 years agoMerge branch '3698-invalid-output-of' closes #3698
Peter Amstutz [Fri, 17 Oct 2014 20:54:31 +0000 (16:54 -0400)]
Merge branch '3698-invalid-output-of' closes #3698

10 years agoMake sure to use httpclient 2.5.0 or higher for Workbench. Older
Ward Vandewege [Fri, 17 Oct 2014 19:47:11 +0000 (15:47 -0400)]
Make sure to use httpclient 2.5.0 or higher for Workbench. Older
versions force the use of SSLv3, which is no longer advisable now that
Poodle is a thing.

No issue #

10 years ago3698: Fix: components keys are symbols, not strings. Tweaked error message to
Peter Amstutz [Fri, 17 Oct 2014 19:36:49 +0000 (15:36 -0400)]
3698: Fix: components keys are symbols, not strings.  Tweaked error message to
tell you what the invalid output_of actually is.

10 years ago3698: Add check that output_of refers to an actual component.
Peter Amstutz [Fri, 17 Oct 2014 19:17:01 +0000 (15:17 -0400)]
3698: Add check that output_of refers to an actual component.

10 years ago4083: Searched for everything using strptime and added import _strptime where it...
Peter Amstutz [Fri, 17 Oct 2014 17:58:50 +0000 (13:58 -0400)]
4083: Searched for everything using strptime and added import _strptime where it was missing. closes #4083

10 years agoMerge branch '4229-close-files' closes #4229
Tom Clegg [Fri, 17 Oct 2014 15:45:33 +0000 (11:45 -0400)]
Merge branch '4229-close-files' closes #4229

10 years agoadded by_id subdirectory notes and arvados#collection
Nancy Ouyang [Fri, 17 Oct 2014 13:52:17 +0000 (09:52 -0400)]
added by_id subdirectory notes and arvados#collection

No issue #.

10 years ago4239: Update Python SDK for google-api-python-client 1.3.
Brett Smith [Fri, 17 Oct 2014 14:22:01 +0000 (10:22 -0400)]
4239: Update Python SDK for google-api-python-client 1.3.

This package renames the module from apiclient to googleapiclient.  It
provides a shim apiclient module for compatibility, but it only
exports the appropriate names, not real submodules.  Using it requires
changing imports like

    import apiclient.errors

to

    from apiclient import errors

This approach works (has been tested) with both versions 1.2 and 1.3.
Closes #4239.

10 years ago4189: Diagnostics suite doesn't try to clear Rails cache.
Brett Smith [Fri, 17 Oct 2014 12:36:54 +0000 (08:36 -0400)]
4189: Diagnostics suite doesn't try to clear Rails cache.

Refs #4189.

10 years agoMerge branch 'master' into 4062-infinite-scroll-repeat-issue
radhika [Fri, 17 Oct 2014 03:28:29 +0000 (23:28 -0400)]
Merge branch 'master' into 4062-infinite-scroll-repeat-issue

Conflicts:
services/api/test/fixtures/collections.yml
services/api/test/fixtures/jobs.yml

10 years ago4062: Do not include offset in the next_page_href when objects of multiple kinds...
radhika [Fri, 17 Oct 2014 03:19:57 +0000 (23:19 -0400)]
4062: Do not include offset in the next_page_href when objects of multiple kinds are being fetched; instead, we will rely on created_at filter alone.
Updated the tests and fixtures to expect all 200+ objects in the pipelines and jobs tab.
The test however is still not working as the created_at filter based fetch is not working.

10 years agoMerge branch '4189-workbench-project-admin-attr-editing-wip'
Brett Smith [Thu, 16 Oct 2014 21:23:57 +0000 (17:23 -0400)]
Merge branch '4189-workbench-project-admin-attr-editing-wip'

Closes #4189, #4202.

10 years ago4189: Workbench lets users with write permission rename objects in projects.
Brett Smith [Wed, 15 Oct 2014 18:04:12 +0000 (14:04 -0400)]
4189: Workbench lets users with write permission rename objects in projects.

The key part of this commit are the changes to ApplicationHelper.
There's also some refactoring to more consistently answer questions
about whether or not an attribute is editable.

There are also some tests in here that I wrote while I was tracking
down the problem.  They seem like a useful addition.

10 years ago4189: Workbench tests clear more state during teardown.
Brett Smith [Wed, 15 Oct 2014 17:29:48 +0000 (13:29 -0400)]
4189: Workbench tests clear more state during teardown.

I'm working on some new tests that pick up on stale state without
these changes.

10 years ago4189: Document the API server's writable_by field.
Brett Smith [Thu, 16 Oct 2014 21:00:39 +0000 (17:00 -0400)]
4189: Document the API server's writable_by field.

10 years ago4189: Add writable_by to User API response, so writable_by is available for every...
Tom Clegg [Thu, 16 Oct 2014 20:17:51 +0000 (16:17 -0400)]
4189: Add writable_by to User API response, so writable_by is available for every owner_uuid.

10 years ago4189: Admit in writable_by that an object is writable when its owner_uuid is writable.
Tom Clegg [Thu, 16 Oct 2014 20:11:13 +0000 (16:11 -0400)]
4189: Admit in writable_by that an object is writable when its owner_uuid is writable.

10 years ago4189: Look up owner's writable_by when API did not provide writable_by for the object...
Tom Clegg [Thu, 16 Oct 2014 20:09:16 +0000 (16:09 -0400)]
4189: Look up owner's writable_by when API did not provide writable_by for the object in question.

10 years ago4062: test updates
radhika [Thu, 16 Oct 2014 20:41:21 +0000 (16:41 -0400)]
4062: test updates

10 years ago3826: Reverse fields in "stat not found" warning.
Tom Clegg [Thu, 16 Oct 2014 20:39:18 +0000 (16:39 -0400)]
3826: Reverse fields in "stat not found" warning.

10 years agoMerge branch '3609-arv-ws' refs #3609
Peter Amstutz [Thu, 16 Oct 2014 19:35:00 +0000 (15:35 -0400)]
Merge branch '3609-arv-ws' refs #3609

10 years ago3609: Fix PollClient for case when there are no filters (get everything).
Peter Amstutz [Thu, 16 Oct 2014 19:34:25 +0000 (15:34 -0400)]
3609: Fix PollClient for case when there are no filters (get everything).

10 years ago3609: Testing fixups.
Peter Amstutz [Thu, 16 Oct 2014 19:24:51 +0000 (15:24 -0400)]
3609: Testing fixups.

10 years ago3609: Back out setting api_version, api_host, and api_insecure on api client
Peter Amstutz [Thu, 16 Oct 2014 18:59:18 +0000 (14:59 -0400)]
3609: Back out setting api_version, api_host, and api_insecure on api client
and instead document that caller to arvados.events.subscribe() should pass in a
freshly created api client.  Add event variable to indicate when subscription
is a success instead of sleeping.  Removed unused "import time".  Fixed "web
sockets" -> "websockets".

10 years ago4229: Add missing Close() calls
Tom Clegg [Thu, 16 Oct 2014 18:20:10 +0000 (14:20 -0400)]
4229: Add missing Close() calls

10 years ago4229: Get rid of sleep() in test
Tom Clegg [Thu, 16 Oct 2014 18:19:51 +0000 (14:19 -0400)]
4229: Get rid of sleep() in test