arvados.git
13 months agoMerge branch '20225-directory-input-subfolder-selection' into main. Closes #20225
Stephen Smith [Fri, 13 Oct 2023 14:16:50 +0000 (10:16 -0400)]
Merge branch '20225-directory-input-subfolder-selection' into main. Closes #20225

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

13 months ago20225: Remove unnecessary block permission signature from cypress test
Stephen Smith [Fri, 13 Oct 2023 14:05:20 +0000 (10:05 -0400)]
20225: Remove unnecessary block permission signature from cypress test

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

13 months ago20225: Mock group contents service to squelch errors in unit tests
Stephen Smith [Thu, 12 Oct 2023 20:07:57 +0000 (16:07 -0400)]
20225: Mock group contents service to squelch errors in unit tests

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

13 months ago20225: Add unit tests for tree expandNodeAncestors
Stephen Smith [Thu, 12 Oct 2023 19:39:13 +0000 (15:39 -0400)]
20225: Add unit tests for tree expandNodeAncestors

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

13 months ago20225: Add unit test to verify tree picker init / loadInitialValue preselects
Stephen Smith [Thu, 12 Oct 2023 18:53:53 +0000 (14:53 -0400)]
20225: Add unit test to verify tree picker init / loadInitialValue preselects
existing values on initialization

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

13 months ago20225: Add cypress test to verify tree picker collection subdirectory selection
Stephen Smith [Thu, 12 Oct 2023 18:53:23 +0000 (14:53 -0400)]
20225: Add cypress test to verify tree picker collection subdirectory selection

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

13 months ago20225: Trigger error if tree picker loadInitialValue fails to get any ancestors
Stephen Smith [Thu, 12 Oct 2023 18:51:14 +0000 (14:51 -0400)]
20225: Trigger error if tree picker loadInitialValue fails to get any ancestors
from ancestor service, also log the failed uuid in the console.

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

13 months ago20225: Catch tree picker loadproject errors and show toast / console error with proje...
Stephen Smith [Thu, 12 Oct 2023 18:50:02 +0000 (14:50 -0400)]
20225: Catch tree picker loadproject errors and show toast / console error with project uuid

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

13 months agoMerge branch '20891-incorrect-navigate-to-group'
Lisa Knox [Fri, 6 Oct 2023 13:12:11 +0000 (09:12 -0400)]
Merge branch '20891-incorrect-navigate-to-group'

closes #20891

Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

13 months ago20891: refined group narrowing Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox...
Lisa Knox [Thu, 5 Oct 2023 16:11:28 +0000 (12:11 -0400)]
20891: refined group narrowing Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

13 months agoMerge branch '21002-restore-banner-adjust-width'
Lisa Knox [Thu, 5 Oct 2023 14:45:32 +0000 (10:45 -0400)]
Merge branch '21002-restore-banner-adjust-width'

closes #21002

Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

13 months agoMerge branch '21033-wb2-dependency-upgrades'. Closes #21033
Lucas Di Pentima [Tue, 3 Oct 2023 20:52:35 +0000 (17:52 -0300)]
Merge branch '21033-wb2-dependency-upgrades'. Closes #21033

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas.dipentima@curii.com>

13 months ago21033: Applies dependency upgrades.
Lucas Di Pentima [Tue, 3 Oct 2023 18:59:23 +0000 (15:59 -0300)]
21033: Applies dependency upgrades.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas.dipentima@curii.com>

13 months ago21002: set banner maxWidth to 50% Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa...
Lisa Knox [Thu, 28 Sep 2023 19:23:33 +0000 (15:23 -0400)]
21002: set banner maxWidth to 50% Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

13 months ago21002: fixed notif menu clickboxes Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa...
Lisa Knox [Thu, 28 Sep 2023 16:03:05 +0000 (12:03 -0400)]
21002: fixed notif menu clickboxes Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

13 months ago21002: fixed tooltip focus on notificatoin icon Arvados-DCO-1.1-Signed-off-by: Lisa...
Lisa Knox [Thu, 28 Sep 2023 14:30:25 +0000 (10:30 -0400)]
21002: fixed tooltip focus on notificatoin icon Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

13 months ago20891: corrected navigation function in renderer Arvados-DCO-1.1-Signed-off-by:...
Lisa Knox [Wed, 27 Sep 2023 19:48:18 +0000 (15:48 -0400)]
20891: corrected navigation function in renderer  Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox@curii.com>

13 months ago20225: Correct cypress test names / add terminal newline (style)
Stephen Smith [Fri, 22 Sep 2023 14:35:34 +0000 (10:35 -0400)]
20225: Correct cypress test names / add terminal newline (style)

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

13 months ago20225: Remove unused imports / dead code
Stephen Smith [Fri, 22 Sep 2023 14:35:13 +0000 (10:35 -0400)]
20225: Remove unused imports / dead code

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

13 months ago20225: Add subdirectory selection support to directory array picker
Stephen Smith [Fri, 22 Sep 2023 14:12:42 +0000 (10:12 -0400)]
20225: Add subdirectory selection support to directory array picker

Adds cascade flag to tree picker to disable recursive directory selection

Reworks initProjectsTreePicker to support initializing multiple selections.
Loads each selection's ancestor tree in parallel, combines updates to same tree
pickers before inserting the ancestor tree, then loads necessary collections in
parallel

Changes checkbox visibility logic to show collection selection checkbox even
when collection is not loaded/expanded when cascade mode is off - since the
selection won't cascade there is no need to require the collection to be opened

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

13 months ago20225: Add subdirectory selection support to directory input
Stephen Smith [Thu, 21 Sep 2023 19:02:10 +0000 (15:02 -0400)]
20225: Add subdirectory selection support to directory input

Converts getFileOperationLocation into a dispatchable helper so it can access
the store to augment FileOperationLocations with a PDH

Converts DirectoryTreePickerField into a connected class component in order to
use getFileOperationLocation

Change DirectoryInputComponent to include directories in the picker and use
getFileOperationLocation to pass FileOperationLocation instead of Collection
objects so that the subpath within the collection can be embedded in the
Directory object

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

13 months agoMerge branch '19359-optional-enum' refs #19359
Peter Amstutz [Fri, 15 Sep 2023 14:03:21 +0000 (10:03 -0400)]
Merge branch '19359-optional-enum' refs #19359

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months ago19359: Can select empty item to clear optional enum input
Peter Amstutz [Thu, 14 Sep 2023 21:06:11 +0000 (17:06 -0400)]
19359: Can select empty item to clear optional enum input

Sets the field value to null, which means "use default value" in CWL.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months ago19359: Support 'optional' enum type parameters
Peter Amstutz [Fri, 8 Sep 2023 20:06:37 +0000 (16:06 -0400)]
19359: Support 'optional' enum type parameters

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months agoMerge branch '20913-user-profile' refs #20913
Peter Amstutz [Tue, 5 Sep 2023 18:36:50 +0000 (14:36 -0400)]
Merge branch '20913-user-profile' refs #20913

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months agoMerge branch '20899-wf-delete' refs #20899
Peter Amstutz [Fri, 1 Sep 2023 16:13:08 +0000 (12:13 -0400)]
Merge branch '20899-wf-delete' refs #20899

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months ago20913: Fix test to check that use profile gets saved
Peter Amstutz [Wed, 30 Aug 2023 20:23:33 +0000 (16:23 -0400)]
20913: Fix test to check that use profile gets saved

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months ago20899: Add menu item to delete workflow record
Peter Amstutz [Mon, 28 Aug 2023 19:19:39 +0000 (15:19 -0400)]
20899: Add menu item to delete workflow record

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months agoMerge branch '20884-rocky8-copy' refs #20884
Peter Amstutz [Thu, 24 Aug 2023 20:35:53 +0000 (16:35 -0400)]
Merge branch '20884-rocky8-copy' refs #20884

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months ago20884: Update Makefile copy rule to accommodate rocky8
Brett Smith [Thu, 24 Aug 2023 19:41:16 +0000 (15:41 -0400)]
20884: Update Makefile copy rule to accommodate rocky8

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>

14 months agoMerge branch '20829-can-manage' refs #20829
Peter Amstutz [Thu, 24 Aug 2023 19:06:05 +0000 (15:06 -0400)]
Merge branch '20829-can-manage' refs #20829

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months agoMerge branch '20890-remove-wb1-switch' refs #20890
Peter Amstutz [Thu, 24 Aug 2023 17:39:32 +0000 (13:39 -0400)]
Merge branch '20890-remove-wb1-switch'  refs #20890

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months agoMerge branch '20603-trash-show-all' refs #20603
Peter Amstutz [Thu, 24 Aug 2023 17:14:50 +0000 (13:14 -0400)]
Merge branch '20603-trash-show-all' refs #20603

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months ago20884: Add rocky8 to list of build targets
Peter Amstutz [Thu, 24 Aug 2023 13:57:50 +0000 (09:57 -0400)]
20884: Add rocky8 to list of build targets

refs #20884

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months ago20890: Remove "Switch to workbench 1" menu item
Peter Amstutz [Thu, 24 Aug 2023 13:54:41 +0000 (09:54 -0400)]
20890: Remove "Switch to workbench 1" menu item

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months agoMerge branch '20617-shared-with-me-filtering' into main. Closes #20617
Stephen Smith [Wed, 23 Aug 2023 19:31:26 +0000 (15:31 -0400)]
Merge branch '20617-shared-with-me-filtering' into main. Closes #20617

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

14 months ago20829: Check parent for editable status
Peter Amstutz [Tue, 22 Aug 2023 19:40:16 +0000 (15:40 -0400)]
20829: Check parent for editable status

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months ago20829: Migrate to canWrite and canManage for permission checks
Peter Amstutz [Tue, 22 Aug 2023 18:16:29 +0000 (14:16 -0400)]
20829: Migrate to canWrite and canManage for permission checks

Replace use of writableBy with canWrite and canManage, and remove
writableBy from workbench 2 entirely.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months ago20829: Add canWrite and canManage to group and API response dialog
Peter Amstutz [Tue, 22 Aug 2023 17:19:22 +0000 (13:19 -0400)]
20829: Add canWrite and canManage to group and API response dialog

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months ago20617: Extend sharing cypress test to check search/filters
Stephen Smith [Tue, 22 Aug 2023 17:04:25 +0000 (13:04 -0400)]
20617: Extend sharing cypress test to check search/filters

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

14 months ago20617: Move shared-with-me filter additions to getParams
Stephen Smith [Tue, 22 Aug 2023 15:18:50 +0000 (11:18 -0400)]
20617: Move shared-with-me filter additions to getParams

Prevents accidentally overriding filters and fixes filters being ignored

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

14 months ago20603: Trash shows all items, not just those owned by user
Peter Amstutz [Tue, 22 Aug 2023 15:17:45 +0000 (11:17 -0400)]
20603: Trash shows all items, not just those owned by user

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months agoMerge branch '20882-fix-priority' refs #20882
Peter Amstutz [Mon, 21 Aug 2023 20:18:44 +0000 (16:18 -0400)]
Merge branch '20882-fix-priority' refs #20882

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months agoMerge branch '20845-queued-process-filter' refs #20845
Peter Amstutz [Mon, 21 Aug 2023 20:18:10 +0000 (16:18 -0400)]
Merge branch '20845-queued-process-filter' refs #20845

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months agoMerge branch '20513-link-cwl-code' refs #20513
Peter Amstutz [Mon, 21 Aug 2023 20:17:33 +0000 (16:17 -0400)]
Merge branch '20513-link-cwl-code' refs #20513

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months agoMerge branch '19793-collection-back' refs #19793
Peter Amstutz [Mon, 21 Aug 2023 20:14:16 +0000 (16:14 -0400)]
Merge branch '19793-collection-back' refs #19793

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months agoMerge branch '20454-cost-display' refs #20454
Peter Amstutz [Mon, 21 Aug 2023 20:13:07 +0000 (16:13 -0400)]
Merge branch '20454-cost-display' refs #20454

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months agoMerge branch '18946-user-profile' refs #18946
Peter Amstutz [Mon, 21 Aug 2023 19:50:45 +0000 (15:50 -0400)]
Merge branch '18946-user-profile' refs #18946

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months agoMerge branch '20219-log-api' into main. Closes #20219
Stephen Smith [Mon, 21 Aug 2023 18:30:26 +0000 (14:30 -0400)]
Merge branch '20219-log-api' into main. Closes #20219

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

14 months agoMerge branch 'main' of git.arvados.org:arvados-workbench2 into 20219-log-api
Stephen Smith [Mon, 21 Aug 2023 17:35:34 +0000 (13:35 -0400)]
Merge branch 'main' of git.arvados.org:arvados-workbench2 into 20219-log-api

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

14 months agoMerge branch '19991-breadcrumbs-missing-bug' into main. Closes #19991
Stephen Smith [Mon, 21 Aug 2023 17:34:00 +0000 (13:34 -0400)]
Merge branch '19991-breadcrumbs-missing-bug' into main. Closes #19991

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

14 months ago20219: Suppress error toast when process logs fail to load due to 404
Stephen Smith [Mon, 21 Aug 2023 16:35:59 +0000 (12:35 -0400)]
20219: Suppress error toast when process logs fail to load due to 404

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

14 months ago20219: Add unit tests for log service webdav methods
Stephen Smith [Mon, 21 Aug 2023 16:31:27 +0000 (12:31 -0400)]
20219: Add unit tests for log service webdav methods

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

14 months ago20219: Make log service easier to test using interfaces
Stephen Smith [Mon, 21 Aug 2023 16:30:57 +0000 (12:30 -0400)]
20219: Make log service easier to test using interfaces

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

14 months ago20219: Make cypress collection replace files method more specific
Stephen Smith [Mon, 21 Aug 2023 16:30:23 +0000 (12:30 -0400)]
20219: Make cypress collection replace files method more specific

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

14 months ago20219: Rename doKeepRequest to doWebDAVRequest for clarity
Stephen Smith [Mon, 21 Aug 2023 16:22:41 +0000 (12:22 -0400)]
20219: Rename doKeepRequest to doWebDAVRequest for clarity

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

14 months ago19991: Switch localhost for 127.0.0.1 due to wb url change
Stephen Smith [Fri, 18 Aug 2023 22:27:33 +0000 (18:27 -0400)]
19991: Switch localhost for 127.0.0.1 due to wb url change

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

14 months ago19991: Change cypress url from localhost to 127.0.0.1 to match arvados
Stephen Smith [Fri, 18 Aug 2023 21:38:54 +0000 (17:38 -0400)]
19991: Change cypress url from localhost to 127.0.0.1 to match arvados
Solves cords cookie issues when testing inline io panel image previews

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

14 months ago19991: Switch search spec federated test cy.intercept to use 127.0.0.1 instead of...
Stephen Smith [Fri, 18 Aug 2023 20:27:17 +0000 (16:27 -0400)]
19991: Switch search spec federated test cy.intercept to use 127.0.0.1 instead of localhost.

Also change collection names to make collisions impossible

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

14 months ago18946: Don't navigate away from my-account page on password login
Peter Amstutz [Fri, 18 Aug 2023 18:22:56 +0000 (14:22 -0400)]
18946: Don't navigate away from my-account page on password login

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months ago19991: Add small delay to allow open in new tab / copy to clipboard to execute
Stephen Smith [Fri, 18 Aug 2023 16:57:48 +0000 (12:57 -0400)]
19991: Add small delay to allow open in new tab / copy to clipboard to execute

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

14 months ago19991: Fix for search cypress test
Stephen Smith [Fri, 18 Aug 2023 16:29:05 +0000 (12:29 -0400)]
19991: Fix for search cypress test

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

14 months ago19991: Fix some cypress tests
Stephen Smith [Fri, 18 Aug 2023 15:13:19 +0000 (11:13 -0400)]
19991: Fix some cypress tests

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

14 months ago20882: Submit with priority 500, not priority 1
Peter Amstutz [Fri, 18 Aug 2023 15:01:37 +0000 (11:01 -0400)]
20882: Submit with priority 500, not priority 1

(Priority ought to be editable but that's a different story)

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

14 months ago19991: Try to fix tests / elements detached from dom
Stephen Smith [Thu, 17 Aug 2023 18:36:54 +0000 (14:36 -0400)]
19991: Try to fix tests / elements detached from dom

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

14 months ago19991: Remove usage of side panel tree to generate breadcrumbs, uses ancestor
Stephen Smith [Thu, 17 Aug 2023 17:22:23 +0000 (13:22 -0400)]
19991: Remove usage of side panel tree to generate breadcrumbs, uses ancestor
service instead.

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

14 months ago20219: Try to fix tests on jenkins
Stephen Smith [Tue, 15 Aug 2023 23:29:56 +0000 (19:29 -0400)]
20219: Try to fix tests on jenkins

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

15 months ago20219: Increase cypress timeouts when appending logs
Stephen Smith [Tue, 15 Aug 2023 17:43:46 +0000 (13:43 -0400)]
20219: Increase cypress timeouts when appending logs

Waiting on an intercept doesn't work because on fast systems the wait is too late

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

15 months ago20219: Switch log panel requests to use live log endpoint, adjust tests to match
Stephen Smith [Tue, 15 Aug 2023 16:47:09 +0000 (12:47 -0400)]
20219: Switch log panel requests to use live log endpoint, adjust tests to match

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

15 months ago19793: Make browser back button work on nav to PDH
Peter Amstutz [Mon, 14 Aug 2023 20:40:32 +0000 (16:40 -0400)]
19793: Make browser back button work on nav to PDH

When navigating to a collection by PDH, if there is only one match, it
the portable data hash page automatically directs the user to the
appropriate collection page.  However, if the user pushes the back
button, they go back to portable data hash page which automatically
takes them to the collection page again.  This effectively breaks the
back button.

This fixes the bug by replacing (instead of "pushing") the top of the
location history with the collection page, so that the back button
from the collection page takes the user to their previous page without
revisiting the portable data hash page (so they are not endlessly
redirected).

This commit message is longer than the actual code fix.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

15 months ago18946: Fix flaky test
Peter Amstutz [Mon, 14 Aug 2023 20:07:43 +0000 (16:07 -0400)]
18946: Fix flaky test

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

15 months ago18946: Fix unit tests
Peter Amstutz [Mon, 14 Aug 2023 18:08:39 +0000 (14:08 -0400)]
18946: Fix unit tests

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

15 months ago18946: Add userProfileFormMessage
Peter Amstutz [Fri, 11 Aug 2023 15:12:06 +0000 (11:12 -0400)]
18946: Add userProfileFormMessage

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

15 months ago20845: Fix the "Queued" process status filter
Peter Amstutz [Fri, 11 Aug 2023 13:43:21 +0000 (09:43 -0400)]
20845: Fix the "Queued" process status filter

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

15 months ago20454: Consolidate cost display to a single 'Cost' field
Peter Amstutz [Wed, 9 Aug 2023 20:27:51 +0000 (16:27 -0400)]
20454: Consolidate cost display to a single 'Cost' field

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

15 months ago20513: Add "Workflow code" link to details
Peter Amstutz [Tue, 8 Aug 2023 21:18:41 +0000 (17:18 -0400)]
20513: Add "Workflow code" link to details

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

15 months agoMerge branch '20219-log-api' into main. Closes #20219
Stephen Smith [Thu, 3 Aug 2023 16:08:19 +0000 (12:08 -0400)]
Merge branch '20219-log-api' into main. Closes #20219

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

15 months ago20219: Log with level error and with promise rejection reason when polling fails
Stephen Smith [Thu, 3 Aug 2023 15:36:14 +0000 (11:36 -0400)]
20219: Log with level error and with promise rejection reason when polling fails

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

15 months ago20219: Move dev dependencies into devDependencies
Stephen Smith [Thu, 3 Aug 2023 15:09:12 +0000 (11:09 -0400)]
20219: Move dev dependencies into devDependencies

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

15 months ago20219: Better variable name
Stephen Smith [Wed, 2 Aug 2023 22:27:38 +0000 (18:27 -0400)]
20219: Better variable name

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

15 months ago20219: Pass through promise rejections from getLogFileContents
Stephen Smith [Wed, 2 Aug 2023 21:48:36 +0000 (17:48 -0400)]
20219: Pass through promise rejections from getLogFileContents

* No longer returns undefined for failed log fragments
* initProcessLogsPanel added catch to handle errors, on failure it shows a
  toast and initializes the store empty, allowing polling to run and retry if
  the container is running
* Add note to pollProcessLogs error console.log that the promise rejection is
  ignored currently
* loadContainerLogFileContents now handles errors from getLogFileContents
  * Switched from Promise.all to Promise.allSettled, which allows some promises
    to fail and still return a result
  * Replace undefined fragment & subfragment filtering with top level promise
    status filtering, subfragments can no longer have some failures due to
    sub-promises using .all which rejects on any failure
* Add es2020 to typescript lib array for Promise.allSettled

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

15 months agoMerge branch '20688-redirect-urldecode' refs #20688
Peter Amstutz [Wed, 2 Aug 2023 13:25:40 +0000 (09:25 -0400)]
Merge branch '20688-redirect-urldecode' refs #20688

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

15 months ago20219: Start / stop log polling when container is running
Stephen Smith [Wed, 2 Aug 2023 01:47:53 +0000 (21:47 -0400)]
20219: Start / stop log polling when container is running

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

15 months ago20219: Add console log to process log polling failure since promise rejection
Stephen Smith [Wed, 2 Aug 2023 01:30:28 +0000 (21:30 -0400)]
20219: Add console log to process log polling failure since promise rejection
is currently unhandled

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

15 months ago20219: Rearrange non-sortable logs to top of merged all logs view
Stephen Smith [Wed, 2 Aug 2023 01:26:37 +0000 (21:26 -0400)]
20219: Rearrange non-sortable logs to top of merged all logs view

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

15 months ago20219: Perform log file root path filtering in listLogFiles
Stephen Smith [Wed, 2 Aug 2023 01:20:49 +0000 (21:20 -0400)]
20219: Perform log file root path filtering in listLogFiles

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

15 months ago20219: Adjust logFileToLogType argument type to only CollectionFile and adjust
Stephen Smith [Wed, 2 Aug 2023 01:19:09 +0000 (21:19 -0400)]
20219: Adjust logFileToLogType argument type to only CollectionFile and adjust
loadContainerLogFileList filter type hint to satisfy type

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

15 months ago20219: Improve useAsyncInterval testability, add unit test
Stephen Smith [Wed, 2 Aug 2023 00:40:13 +0000 (20:40 -0400)]
20219: Improve useAsyncInterval testability, add unit test

* Combines useRefs for easier mocking
* Wraps callback execution in promise chain to prevent halting on non-async
  callbacks
* Clean up now unused async contexts
* Add explicit promise resolve/reject on PollProcessLogs
  * Add catch block to continue polling on error

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

15 months ago20688: Update test for uri encoding/decoding of PDH
Peter Amstutz [Mon, 31 Jul 2023 20:00:45 +0000 (16:00 -0400)]
20688: Update test for uri encoding/decoding of PDH

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

15 months ago20688: Make sure ARVADOS_DIRECTORY is set when it is needed
Peter Amstutz [Mon, 31 Jul 2023 19:24:00 +0000 (15:24 -0400)]
20688: Make sure ARVADOS_DIRECTORY is set when it is needed

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

15 months ago20219: Replace API & websocket log loading with webdav polling
Stephen Smith [Fri, 28 Jul 2023 15:18:20 +0000 (11:18 -0400)]
20219: Replace API & websocket log loading with webdav polling

* Add apiWebdavClient to log service for making webdav requests to the API and
  differentiate from keepWebdavClient
* Add listLogFiles and getLogFileContents methods to log service, contents can
  be fetched with range request
* Add loadContainerLogFileContents to load logs using webdav range requests
  * Files larger than the chunk limit (128k) are loaded as beginning and end
    in 2 64k fragments, snipline is appended to the last line of the first
    fragment
  * The chunks are all requested in parallel
* Add sorting of timestamped log types in combined log views (Main/All)
  * Lines without timestamps are merged with previous lines with timestamps
    * If no preceding lines of a sortable type exist, the leading lines are
      removed from combined log views - they can still be seen in the single
      log type filter
  * Non-timestamped log types (node-info/contaner) are pushed to the bottom
    with original ordering in All view
  * Merging & sorting is not applied to single log type view
* Remove snipline LogEventType as all sniplines now belong to specific log
  event types
* Update logs panel store and reducer to remember the last log byte requested
* Add polling useAsyncInterval utility function to poll log file sizes
  * Polling awaits for callback to finish to prevent race conditions
* Update process log code snippet style to remove gap between array of loglines
* Remove websocket handling of log events
* Replaced cypress log manipulation commands with webdav log helpers
* Add tests for polling, line sorting, correctly sized/positioned chunks, and
  snipline

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

15 months ago18946: Transitional user profile feature
Peter Amstutz [Fri, 21 Jul 2023 17:07:14 +0000 (13:07 -0400)]
18946: Transitional user profile feature

If UserProfileFormFields is non-empty, and the user's prefs.profile is
empty, wb2 will navigate to the user account page to encourage people
to fill out the profile.  Unlike wb1, filling it out is not mandatory.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

15 months ago20688: urldecode the redirect path before storing it
Peter Amstutz [Tue, 18 Jul 2023 17:46:50 +0000 (13:46 -0400)]
20688: urldecode the redirect path before storing it

Necessary because nginx url rewrites will turn the "+" into a "%2B",
so we need to turn it back.  After more than an hour of messing with
it, it's easier to fix workbench 2 than to fix nginx.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

16 months agoAdd note that available RAM is limited to requested RAM
Peter Amstutz [Fri, 16 Jun 2023 14:24:32 +0000 (10:24 -0400)]
Add note that available RAM is limited to requested RAM

closes #20635

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

17 months agoMerge branch '20031-collection-files-batch-operations' into main. Closes #20031
Stephen Smith [Mon, 5 Jun 2023 19:06:24 +0000 (15:06 -0400)]
Merge branch '20031-collection-files-batch-operations' into main. Closes #20031

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

17 months agoMerge branch '20449-processes-refresh' refs #20449
Peter Amstutz [Fri, 2 Jun 2023 20:54:45 +0000 (16:54 -0400)]
Merge branch '20449-processes-refresh' refs #20449

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

17 months agoSet document title on navigation to url path, refs #19369
Peter Amstutz [Fri, 2 Jun 2023 14:20:59 +0000 (10:20 -0400)]
Set document title on navigation to url path, refs #19369

This is very simplistic, but we can make it better later.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

17 months ago20449: Examine websocket messages before reloading process pages
Peter Amstutz [Thu, 1 Jun 2023 21:22:51 +0000 (17:22 -0400)]
20449: Examine websocket messages before reloading process pages

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

17 months ago20031: Cypress wait for re-render
Stephen Smith [Wed, 31 May 2023 14:36:12 +0000 (10:36 -0400)]
20031: Cypress wait for re-render

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

17 months ago20031: Try to fix unit test
Stephen Smith [Wed, 31 May 2023 13:50:30 +0000 (09:50 -0400)]
20031: Try to fix unit test

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>