arvados.git
3 years ago17170: Use exec() to eliminate intermediate arvados-client process.
Tom Clegg [Thu, 14 Jan 2021 21:16:20 +0000 (16:16 -0500)]
17170: Use exec() to eliminate intermediate arvados-client process.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17170: Improve error messages.
Tom Clegg [Thu, 14 Jan 2021 20:40:07 +0000 (15:40 -0500)]
17170: Improve error messages.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17170: Check container is readable before checking write permission.
Tom Clegg [Thu, 14 Jan 2021 20:39:34 +0000 (15:39 -0500)]
17170: Check container is readable before checking write permission.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17170: Fix -help output.
Tom Clegg [Thu, 14 Jan 2021 20:38:38 +0000 (15:38 -0500)]
17170: Fix -help output.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17109: Adds notes about Keep-web Same-Site restrictions.
Lucas Di Pentima [Thu, 14 Jan 2021 20:00:16 +0000 (17:00 -0300)]
17109: Adds notes about Keep-web Same-Site restrictions.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17170: Merge branch 'master'
Tom Clegg [Thu, 14 Jan 2021 16:08:46 +0000 (11:08 -0500)]
17170: Merge branch 'master'

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17170: Fix closing pty/tty when nil.
Tom Clegg [Thu, 14 Jan 2021 04:22:51 +0000 (23:22 -0500)]
17170: Fix closing pty/tty when nil.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17170: Fixup error display.
Tom Clegg [Thu, 14 Jan 2021 04:22:40 +0000 (23:22 -0500)]
17170: Fixup error display.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17170: "arvados-client shell" accepts container request UUID.
Tom Clegg [Wed, 13 Jan 2021 22:18:08 +0000 (17:18 -0500)]
17170: "arvados-client shell" accepts container request UUID.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17170: Improve error messages.
Tom Clegg [Wed, 13 Jan 2021 22:17:50 +0000 (17:17 -0500)]
17170: Improve error messages.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17170: Don't reuse transport that might have http2 enabled.
Tom Clegg [Wed, 13 Jan 2021 22:06:57 +0000 (17:06 -0500)]
17170: Don't reuse transport that might have http2 enabled.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17170: Dry up close-connection-on-error.
Tom Clegg [Wed, 13 Jan 2021 22:06:11 +0000 (17:06 -0500)]
17170: Dry up close-connection-on-error.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17170: Allow shell only if this user submitted all associated CRs.
Tom Clegg [Wed, 13 Jan 2021 22:03:40 +0000 (17:03 -0500)]
17170: Allow shell only if this user submitted all associated CRs.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years agoDocumentation: make the arvados-dispatch-cloud installation instructions
Ward Vandewege [Wed, 13 Jan 2021 21:37:48 +0000 (16:37 -0500)]
Documentation: make the arvados-dispatch-cloud installation instructions
a bit more clear.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago17170: Test arvados-client shell command.
Tom Clegg [Wed, 13 Jan 2021 05:13:48 +0000 (00:13 -0500)]
17170: Test arvados-client shell command.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17170: Fix dial when API host var is host:port.
Tom Clegg [Wed, 13 Jan 2021 05:10:09 +0000 (00:10 -0500)]
17170: Fix dial when API host var is host:port.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17170: Test controller->crunch-run tunnel.
Tom Clegg [Wed, 13 Jan 2021 04:22:46 +0000 (23:22 -0500)]
17170: Test controller->crunch-run tunnel.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17170: Fixup gateway auth secret.
Tom Clegg [Wed, 13 Jan 2021 02:57:40 +0000 (21:57 -0500)]
17170: Fixup gateway auth secret.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17170: Use TLS for controller->crunch-run traffic.
Tom Clegg [Wed, 13 Jan 2021 02:03:40 +0000 (21:03 -0500)]
17170: Use TLS for controller->crunch-run traffic.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17170: Specify login username. Improve logging.
Tom Clegg [Tue, 12 Jan 2021 05:30:45 +0000 (00:30 -0500)]
17170: Specify login username. Improve logging.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17170: Add "arvados-client shell" subcommand and backend support.
Tom Clegg [Mon, 11 Jan 2021 20:53:28 +0000 (15:53 -0500)]
17170: Add "arvados-client shell" subcommand and backend support.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years agoMerge branch '16106-azure-spot-instance-support'
Ward Vandewege [Mon, 11 Jan 2021 14:18:01 +0000 (09:18 -0500)]
Merge branch '16106-azure-spot-instance-support'

closes #16106

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago16106: Merge branch 'master' into 16106-azure-spot-instance-support
Ward Vandewege [Mon, 11 Jan 2021 14:17:32 +0000 (09:17 -0500)]
16106: Merge branch 'master' into 16106-azure-spot-instance-support

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago16106: address review comments.
Ward Vandewege [Mon, 11 Jan 2021 14:16:58 +0000 (09:16 -0500)]
16106: address review comments.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago16981: Removes the import cycle issue by moving code to lib/boot.
Lucas Di Pentima [Fri, 8 Jan 2021 21:59:51 +0000 (18:59 -0300)]
16981: Removes the import cycle issue by moving code to lib/boot.

As the code was really meant to be lib/boot helpers, instead of having
it on the arvadostest package, it's now on lib/boot/helper.go

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago16981: Removes config loader code to fix import cycle.
Lucas Di Pentima [Fri, 8 Jan 2021 21:37:14 +0000 (18:37 -0300)]
16981: Removes config loader code to fix import cycle.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago16981: Adds federation test on sync-groups.
Lucas Di Pentima [Fri, 8 Jan 2021 15:24:14 +0000 (12:24 -0300)]
16981: Adds federation test on sync-groups.

Makes sure that running the tool on a federated cluster with admin credentials
from the LoginCluster works correctly.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoFixes a couple of typos on the documentation. No issue #.
Lucas Di Pentima [Thu, 7 Jan 2021 22:27:39 +0000 (19:27 -0300)]
Fixes a couple of typos on the documentation. No issue #.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago16306: Command usage help.
Tom Clegg [Thu, 7 Jan 2021 22:24:29 +0000 (17:24 -0500)]
16306: Command usage help.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago16106: update Azure preemptible node code after real world testing. Add
Ward Vandewege [Thu, 7 Jan 2021 18:40:53 +0000 (13:40 -0500)]
16106: update Azure preemptible node code after real world testing. Add
       documentation.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoMerge branch '17224-login-sync' refs #17224
Peter Amstutz [Thu, 7 Jan 2021 16:49:59 +0000 (11:49 -0500)]
Merge branch '17224-login-sync' refs #17224

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago17224: Document LoginCluster configuration for login-sync
Peter Amstutz [Wed, 6 Jan 2021 21:39:19 +0000 (16:39 -0500)]
17224: Document LoginCluster configuration for login-sync

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years agoDocumentation: fix typos.
Ward Vandewege [Wed, 6 Jan 2021 19:46:06 +0000 (14:46 -0500)]
Documentation: fix typos.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago16106: Merge branch 'master' into 16106-azure-spot-instance-support
Ward Vandewege [Wed, 6 Jan 2021 14:52:13 +0000 (09:52 -0500)]
16106: Merge branch 'master' into 16106-azure-spot-instance-support

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoMerge branch '17175-boot-fail-rake-seed'
Tom Clegg [Wed, 6 Jan 2021 14:45:14 +0000 (09:45 -0500)]
Merge branch '17175-boot-fail-rake-seed'

fixes #17175

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago16981: Extracts test federation building code to the arvadostest package.
Lucas Di Pentima [Tue, 5 Jan 2021 20:40:27 +0000 (17:40 -0300)]
16981: Extracts test federation building code to the arvadostest package.

This is going to be reused on other integration test suites.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoFix typos in the documentation.
Ward Vandewege [Tue, 5 Jan 2021 17:51:26 +0000 (12:51 -0500)]
Fix typos in the documentation.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoMerge branch '17225-ruby-sdk' refs #17225
Peter Amstutz [Tue, 5 Jan 2021 16:43:03 +0000 (11:43 -0500)]
Merge branch '17225-ruby-sdk' refs #17225

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago16306: Remove daemontools dependency.
Tom Clegg [Mon, 4 Jan 2021 20:58:24 +0000 (15:58 -0500)]
16306: Remove daemontools dependency.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago16306: Exit 0 when startup-then-shutdown goes as planned.
Tom Clegg [Mon, 4 Jan 2021 20:42:35 +0000 (15:42 -0500)]
16306: Exit 0 when startup-then-shutdown goes as planned.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago16306: Fix inability to shutdown passenger processes.
Tom Clegg [Mon, 4 Jan 2021 20:26:46 +0000 (15:26 -0500)]
16306: Fix inability to shutdown passenger processes.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years agoWe now publish packages for Ubuntu Focal (20.04), and have stopped
Ward Vandewege [Mon, 4 Jan 2021 20:12:25 +0000 (15:12 -0500)]
We now publish packages for Ubuntu Focal (20.04), and have stopped
publishing them for Ubuntu Xenial (16.04).

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago16306: Refactor docker scripts into arvados-package command.
Tom Clegg [Mon, 4 Jan 2021 16:22:09 +0000 (11:22 -0500)]
16306: Refactor docker scripts into arvados-package command.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17224: Provide alternate credentials to use for creating user tokens
Peter Amstutz [Wed, 23 Dec 2020 21:19:39 +0000 (16:19 -0500)]
17224: Provide alternate credentials to use for creating user tokens

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago17224: Fix to have multiple clients connected to separate clusters
Peter Amstutz [Sat, 2 Jan 2021 16:59:57 +0000 (11:59 -0500)]
17224: Fix to have multiple clients connected to separate clusters

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

3 years ago16306: Rename arvados-dev buildpackage -> arvados-package build
Tom Clegg [Tue, 29 Dec 2020 20:18:19 +0000 (15:18 -0500)]
16306: Rename arvados-dev buildpackage -> arvados-package build

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years agoMerge branch '17151-system-token-validation'
Tom Clegg [Mon, 28 Dec 2020 21:52:16 +0000 (16:52 -0500)]
Merge branch '17151-system-token-validation'

closes #17151

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17175: Wait for seedDatabase before starting railsapi.
Tom Clegg [Mon, 28 Dec 2020 20:33:33 +0000 (15:33 -0500)]
17175: Wait for seedDatabase before starting railsapi.

If the rake task and the app start concurrently, they both try to set
up the database seeds. The exclusive-locking mechanism in
services/api/app/lib/current_api_client.rb doesn't cover this case
because the rake task and app don't use the same cache. If the app
commits the database seeds between the rake task's "check existing"
and "commit" steps, commit fails and the rake task aborts.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17175: Fix logging label for setuidgid-wrapped procs.
Tom Clegg [Mon, 28 Dec 2020 20:21:04 +0000 (15:21 -0500)]
17175: Fix logging label for setuidgid-wrapped procs.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago16306: Comment out Workbench2 so health check succeeds.
Tom Clegg [Mon, 28 Dec 2020 15:36:51 +0000 (10:36 -0500)]
16306: Comment out Workbench2 so health check succeeds.

To be re-enabled when supported by install/package/boot.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago16306: Fix env var ordering.
Tom Clegg [Mon, 28 Dec 2020 15:35:39 +0000 (10:35 -0500)]
16306: Fix env var ordering.

Ensure our GOBIN takes precedence over inherited value.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago16306: Remove more unneeded files from package.
Tom Clegg [Mon, 28 Dec 2020 15:35:26 +0000 (10:35 -0500)]
16306: Remove more unneeded files from package.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago16306: Fix permission issues.
Tom Clegg [Mon, 28 Dec 2020 15:35:03 +0000 (10:35 -0500)]
16306: Fix permission issues.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago16306: Circumvent Rails redirect-to-https in workbench health check.
Tom Clegg [Mon, 28 Dec 2020 15:33:27 +0000 (10:33 -0500)]
16306: Circumvent Rails redirect-to-https in workbench health check.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago16306: Add health check endpoint to dispatcher.
Tom Clegg [Mon, 28 Dec 2020 15:32:47 +0000 (10:32 -0500)]
16306: Add health check endpoint to dispatcher.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago16306: Use tmpfs to speed up package building.
Tom Clegg [Mon, 28 Dec 2020 15:32:13 +0000 (10:32 -0500)]
16306: Use tmpfs to speed up package building.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago16306: Add -eatmydata flag.
Tom Clegg [Mon, 28 Dec 2020 15:29:16 +0000 (10:29 -0500)]
16306: Add -eatmydata flag.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years agoMerge branch '17218-update-apt-repos'
Javier Bértoli [Wed, 23 Dec 2020 21:15:34 +0000 (18:15 -0300)]
Merge branch '17218-update-apt-repos'

closes #17218

Arvados-DCO-1.1-Signed-off-by: Javier Bértoli <jbertoli@curii.com>

3 years agoUpdate the provision script to use the new arvados-formula
Javier Bértoli [Wed, 23 Dec 2020 20:57:03 +0000 (17:57 -0300)]
Update the provision script to use the new arvados-formula

ref #17218

Arvados-DCO-1.1-Signed-off-by: Javier Bértoli <jbertoli@curii.com>

3 years agoFix arvados-src package version generation.
Ward Vandewege [Wed, 23 Dec 2020 16:58:03 +0000 (11:58 -0500)]
Fix arvados-src package version generation.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoMerge branch '17118-arvput-fix'
Lucas Di Pentima [Wed, 23 Dec 2020 15:27:35 +0000 (12:27 -0300)]
Merge branch '17118-arvput-fix'
Closes #17118

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoFix detection of packages that were already built.
Ward Vandewege [Wed, 23 Dec 2020 02:16:41 +0000 (21:16 -0500)]
Fix detection of packages that were already built.

refs #17218

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoMerge branch '17218-repository-update'
Ward Vandewege [Tue, 22 Dec 2020 22:10:27 +0000 (17:10 -0500)]
Merge branch '17218-repository-update'

closes #17218

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago16306: Merge branch 'master'
Tom Clegg [Tue, 22 Dec 2020 21:48:37 +0000 (16:48 -0500)]
16306: Merge branch 'master'

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago16306: Move nginx temp dirs into a subdir.
Tom Clegg [Tue, 22 Dec 2020 21:15:21 +0000 (16:15 -0500)]
16306: Move nginx temp dirs into a subdir.

When running as root, Nginx changes ownership of these temp dirs to
"nobody".  We also use the same TMPDIR for standalone passenger
processes, which run as www-data, so we need Nginx to leave it alone.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago16306: Remove some unneeded deps from prod/pkg.
Tom Clegg [Tue, 22 Dec 2020 21:14:55 +0000 (16:14 -0500)]
16306: Remove some unneeded deps from prod/pkg.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago16306: Monkeypatch fpm bug.
Tom Clegg [Tue, 22 Dec 2020 21:13:49 +0000 (16:13 -0500)]
16306: Monkeypatch fpm bug.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago16306: Comment why rm instead of exclude. Delete go tools, too.
Tom Clegg [Tue, 22 Dec 2020 21:13:45 +0000 (16:13 -0500)]
16306: Comment why rm instead of exclude. Delete go tools, too.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years agoWe've made a change in the structure of our apt repositories.
Ward Vandewege [Tue, 22 Dec 2020 19:52:26 +0000 (14:52 -0500)]
We've made a change in the structure of our apt repositories.

refs #17218

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago17118: Changes the way exception raising is done on PySDK's KeepWriterThread.
Lucas Di Pentima [Tue, 22 Dec 2020 15:41:01 +0000 (12:41 -0300)]
17118: Changes the way exception raising is done on PySDK's KeepWriterThread.

This solves the OOM bug where some keepstores fail when uploading data.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago16306: Fix Nginx not starting when running as non-root.
Tom Clegg [Tue, 22 Dec 2020 15:19:43 +0000 (10:19 -0500)]
16306: Fix Nginx not starting when running as non-root.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago16360: Don't bypass autofillConfig in production mode.
Tom Clegg [Tue, 22 Dec 2020 15:03:30 +0000 (10:03 -0500)]
16360: Don't bypass autofillConfig in production mode.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years agoFix a few staticcheck warnings.
Ward Vandewege [Mon, 21 Dec 2020 02:55:19 +0000 (21:55 -0500)]
Fix a few staticcheck warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoFix a few more golint warnings.
Ward Vandewege [Fri, 18 Dec 2020 22:55:50 +0000 (17:55 -0500)]
Fix a few more golint warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoFix another golint warning.
Ward Vandewege [Fri, 18 Dec 2020 02:38:02 +0000 (21:38 -0500)]
Fix another golint warning.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoMerge branch '17208-s3-signature-double-slash'
Tom Clegg [Tue, 15 Dec 2020 05:31:48 +0000 (00:31 -0500)]
Merge branch '17208-s3-signature-double-slash'

fixes #17208

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years agoFix a few more golint warnings.
Ward Vandewege [Tue, 15 Dec 2020 00:42:44 +0000 (19:42 -0500)]
Fix a few more golint warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoMerge branch '17152-collection-preserve-version-changes'
Lucas Di Pentima [Mon, 14 Dec 2020 21:35:29 +0000 (18:35 -0300)]
Merge branch '17152-collection-preserve-version-changes'
Refs #17152

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17208: Update test for s3cmd's new console output.
Tom Clegg [Mon, 14 Dec 2020 20:41:33 +0000 (15:41 -0500)]
17208: Update test for s3cmd's new console output.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17152: Improves modified_at conditional update check.
Lucas Di Pentima [Mon, 14 Dec 2020 13:31:14 +0000 (10:31 -0300)]
17152: Improves modified_at conditional update check.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years agoFix more golint warnings.
Ward Vandewege [Sun, 13 Dec 2020 19:26:57 +0000 (14:26 -0500)]
Fix more golint warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoFix more golint warnings.
Ward Vandewege [Sat, 12 Dec 2020 20:09:48 +0000 (15:09 -0500)]
Fix more golint warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago17152: Moves conditional preserve_version disabling to collection's controller.
Lucas Di Pentima [Fri, 11 Dec 2020 15:28:22 +0000 (12:28 -0300)]
17152: Moves conditional preserve_version disabling to collection's controller.

There was a bug that flipped preserve_version to false after creating a new
version even though the update request included preserve_version=true.
This happened because the logic was at model level, and was incorrect because
at that level we cannot know if the client included the attribute on its
request.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17208: Add test case.
Tom Clegg [Fri, 11 Dec 2020 05:43:40 +0000 (00:43 -0500)]
17208: Add test case.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17208: Merge branch 'master'
Tom Clegg [Fri, 11 Dec 2020 01:32:29 +0000 (20:32 -0500)]
17208: Merge branch 'master'

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years ago17152: Avoids creating audit logs when only 'preserve_version' is updated.
Lucas Di Pentima [Thu, 10 Dec 2020 20:58:58 +0000 (17:58 -0300)]
17152: Avoids creating audit logs when only 'preserve_version' is updated.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17152: Changes preserve_version semantics, updates related documentation.
Lucas Di Pentima [Thu, 10 Dec 2020 19:53:49 +0000 (16:53 -0300)]
17152: Changes preserve_version semantics, updates related documentation.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17152: Updates collection tests to reflect the new behavior.
Lucas Di Pentima [Thu, 10 Dec 2020 19:04:52 +0000 (16:04 -0300)]
17152: Updates collection tests to reflect the new behavior.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17152: Updates API revision number.
Lucas Di Pentima [Thu, 10 Dec 2020 19:04:05 +0000 (16:04 -0300)]
17152: Updates API revision number.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17208: Use normalized path to compute signatures.
Tom Clegg [Thu, 10 Dec 2020 21:41:41 +0000 (16:41 -0500)]
17208: Use normalized path to compute signatures.

Transparently clean paths containing "//".

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years agoCostanalyzer bugfix: when a collection uuid is supplied, write the csv
Ward Vandewege [Thu, 10 Dec 2020 15:33:57 +0000 (10:33 -0500)]
Costanalyzer bugfix: when a collection uuid is supplied, write the csv
files with the name of the associated container request uuid, not the
collection uuid. Also change tests to use a proper temporary directory
for the outputs, and do not reuse that directory between tests (which
hid the bug this commit fixed).

refs #17187

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoMerge branch '17202-no-redir-crossorigin'
Tom Clegg [Wed, 9 Dec 2020 23:47:15 +0000 (18:47 -0500)]
Merge branch '17202-no-redir-crossorigin'

refs #17202

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years agoFix ineffassign warning.
Ward Vandewege [Wed, 9 Dec 2020 22:06:06 +0000 (17:06 -0500)]
Fix ineffassign warning.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years agoMerge branch '17152-collection-versions-fixes'
Lucas Di Pentima [Wed, 9 Dec 2020 21:31:33 +0000 (18:31 -0300)]
Merge branch '17152-collection-versions-fixes'
Refs #17152

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

3 years ago17202: Test avoiding redirect for cross-origin inline images.
Tom Clegg [Wed, 9 Dec 2020 20:44:57 +0000 (15:44 -0500)]
17202: Test avoiding redirect for cross-origin inline images.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

3 years agoMerge branch '17199-available-port-race'
Tom Clegg [Wed, 9 Dec 2020 14:45:09 +0000 (09:45 -0500)]
Merge branch '17199-available-port-race'

fixes #17199

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

3 years ago17202: Use explicit SameSite=Lax for 303-with-cookie.
Tom Clegg [Wed, 9 Dec 2020 14:34:14 +0000 (09:34 -0500)]
17202: Use explicit SameSite=Lax for 303-with-cookie.

This improves XSS protection on some browsers, including Safari and
Firefox for Android.

On most browsers, Lax is already the default.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie/SameSite

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

3 years ago17202: Bypass 303-with-token on cross-origin requests.
Tom Clegg [Wed, 9 Dec 2020 00:52:36 +0000 (19:52 -0500)]
17202: Bypass 303-with-token on cross-origin requests.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

3 years agoMerge branch '17187-costanalyzer-updates'
Ward Vandewege [Tue, 8 Dec 2020 18:05:07 +0000 (13:05 -0500)]
Merge branch '17187-costanalyzer-updates'

closes #17187

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

3 years ago17187: Merge branch 'master' into 17187-costanalyzer-updates
Ward Vandewege [Tue, 8 Dec 2020 18:04:29 +0000 (13:04 -0500)]
17187: Merge branch 'master' into 17187-costanalyzer-updates

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>