Tom Clegg [Fri, 16 May 2014 19:28:20 +0000 (15:28 -0400)]
2809: Fix arvados_api_client usage in FileStreamer. refs #2809
Tom Clegg [Fri, 16 May 2014 14:57:32 +0000 (10:57 -0400)]
Remove debug log message. refs #1969
Tom Clegg [Fri, 16 May 2014 00:44:28 +0000 (20:44 -0400)]
2809: Fix disappearing ArvadosApiClient in development mode. refs #2809
Tom Clegg [Thu, 15 May 2014 21:14:15 +0000 (17:14 -0400)]
2755: Defer to CollectionReader to get manifests instead of going
directly to Keep (which only works when Keep has no permission
checks).
refs #2755
Ward Vandewege [Thu, 15 May 2014 21:11:08 +0000 (17:11 -0400)]
Merge branch '0000-arv-mount-bugfixes'
This closes #2831
Ward Vandewege [Thu, 15 May 2014 20:47:42 +0000 (16:47 -0400)]
CollectionReader can throw exceptions (for example, when passing an
argument that is not a manifest or collection UUID). Trap those and
print an error message, instead blowing up the fuse driver.
Ward Vandewege [Thu, 15 May 2014 20:18:38 +0000 (16:18 -0400)]
In daemon mode, arv-mount should set up the fuse connection before
forking to the background, so that any failures to set up are reported
to the user.
Tom Clegg [Thu, 15 May 2014 18:19:32 +0000 (14:19 -0400)]
2809: Merge branch '2809-workbench-rails4' refs #2809
Tom Clegg [Thu, 15 May 2014 18:19:06 +0000 (14:19 -0400)]
2809: Merge branch 'master' into 2809-workbench-rails4 refs #2809
Conflicts:
apps/workbench/app/models/arvados_api_client.rb
Tom Clegg [Thu, 15 May 2014 16:30:25 +0000 (12:30 -0400)]
2809: Move coffee-rails out of :assets section to make tests thread-safe.
Otherwise, when Rails decides to build assets while running the test
suite, we get:
WARN: tilt autoloading 'coffee_script' in a non thread-safe way; explicit require 'coffee_script' suggested.
Tom Clegg [Thu, 15 May 2014 16:26:10 +0000 (12:26 -0400)]
2809: Remove javascript and coffeescript boilerplate.
Tom Clegg [Wed, 14 May 2014 22:00:09 +0000 (18:00 -0400)]
2809: Remove some unnecessary sleep(0.1).
Tom Clegg [Wed, 14 May 2014 21:56:59 +0000 (17:56 -0400)]
2809: Rearrange "run API server during tests" to suit Minitest 5.
Also, use passenger instead of webrick.
Tom Clegg [Wed, 14 May 2014 20:35:39 +0000 (16:35 -0400)]
2809: Upgrade to Rails 4.1
Tom Clegg [Wed, 14 May 2014 18:21:05 +0000 (14:21 -0400)]
2809: Add wait_for_ajax after submitting forms, to avoid race condition.
Tom Clegg [Wed, 14 May 2014 17:26:42 +0000 (13:26 -0400)]
2809: Remove debug printfs, add comment explaining why so much "permit!"
Tom Clegg [Wed, 14 May 2014 17:25:24 +0000 (13:25 -0400)]
2809: Add note about harmless warning when installing the themes_for_rails gem.
Tom Clegg [Wed, 14 May 2014 17:08:04 +0000 (13:08 -0400)]
2809: Fix whitespace.
Tom Clegg [Sat, 10 May 2014 00:29:09 +0000 (20:29 -0400)]
2809: Turn off secret_key_base by default, instead of requiring it in config.
Tom Clegg [Sat, 10 May 2014 00:28:40 +0000 (20:28 -0400)]
2809: Fix load_config so it loads in time to set passenger configs.
Tom Clegg [Fri, 9 May 2014 18:38:39 +0000 (14:38 -0400)]
2809: Merge branch 'master' refs #2809
Conflicts:
apps/workbench/Gemfile.lock
apps/workbench/app/controllers/application_controller.rb
apps/workbench/app/models/arvados_api_client.rb
apps/workbench/app/models/group.rb
apps/workbench/app/models/user.rb
apps/workbench/app/views/layouts/application.html.erb
Tom Clegg [Thu, 15 May 2014 15:33:20 +0000 (11:33 -0400)]
2756: Fix "duplicate tab" behavior in Chrome.
Tom Clegg [Thu, 15 May 2014 15:09:43 +0000 (11:09 -0400)]
2756: Fix ajax refresh on pipeline instance page.
Tom Clegg [Wed, 14 May 2014 22:07:40 +0000 (18:07 -0400)]
Merge branch '2762-owner-uuid-integrity'
closes #2762
Tom Clegg [Wed, 14 May 2014 22:02:51 +0000 (18:02 -0400)]
2762: Merge branch 'master' into 2762-owner-uuid-integrity
Misha Zatsman [Wed, 14 May 2014 19:19:35 +0000 (19:19 +0000)]
Merge branch 'master' of git.curoverse.com:arvados
Tom Clegg [Wed, 14 May 2014 18:05:15 +0000 (14:05 -0400)]
2762: Fix wrong class used in test case.
Tom Clegg [Wed, 14 May 2014 18:04:44 +0000 (14:04 -0400)]
2762: Finish enigmatic comment.
Tom Clegg [Wed, 14 May 2014 18:04:20 +0000 (14:04 -0400)]
2762: Move destroy_permission_links method to HasUuid.
Tim Pierce [Wed, 14 May 2014 17:02:30 +0000 (13:02 -0400)]
2328: fix log.Warning bug
oops.
Tim Pierce [Wed, 14 May 2014 16:24:46 +0000 (12:24 -0400)]
Merge branch '2328-keep-permission-flags' (closes #2328)
Misha Zatsman [Wed, 14 May 2014 00:58:43 +0000 (00:58 +0000)]
Merge branch '1968-monitor-disk-usage'
Lots of changes to datamanager. refs #2719
Tim Pierce [Wed, 14 May 2014 05:15:38 +0000 (01:15 -0400)]
2328: code review comments.
Misha Zatsman [Wed, 14 May 2014 00:54:18 +0000 (00:54 +0000)]
Reversed histogram format, so timestamps come first.
Tom Clegg [Tue, 13 May 2014 19:21:10 +0000 (15:21 -0400)]
Really write log messages to logfile. refs #2221 commit:
ced5e21
Tom Clegg [Tue, 13 May 2014 18:45:42 +0000 (14:45 -0400)]
Fix job state cleanup in crunch-job failure case.
Tom Clegg [Tue, 13 May 2014 18:36:50 +0000 (14:36 -0400)]
2673: Use _method=GET hack to avoid combining request body with GET
method (but still support parameters too long to fit in a query
string).
Tim Pierce [Tue, 13 May 2014 18:25:37 +0000 (14:25 -0400)]
2328: more 80-column fixes
Tim Pierce [Tue, 13 May 2014 18:05:45 +0000 (14:05 -0400)]
2328: incorporate code review comments.
Wrap very long lines to 80 columns.
Describe each test failure more explicitly.
TestIndexHandler: Add /index/prefix tests for unauthenticated and
authenticated non-superusers.
TestGetHandler: initialize all variables in one var block.
main: failure to read permission key or data manager token is now a
fatal error.
Tom Clegg [Tue, 13 May 2014 17:37:17 +0000 (13:37 -0400)]
Specify required ruby version (>= 2.1.0) in gems.
Tom Clegg [Tue, 13 May 2014 17:30:31 +0000 (13:30 -0400)]
2673: Update bundle to ensure we get commit:
67f1781 at runtime.
Tom Clegg [Tue, 13 May 2014 17:13:58 +0000 (13:13 -0400)]
2673: Move auth to headers, avoid combining request body with GET method.
Tom Clegg [Tue, 13 May 2014 16:49:20 +0000 (12:49 -0400)]
2821: Add "delete" button to pipeline instances page. closes #2821
Tom Clegg [Tue, 13 May 2014 16:44:04 +0000 (12:44 -0400)]
2673: Update bundle to ensure we get commit:
7ff8586 at runtime.
Tom Clegg [Tue, 13 May 2014 14:13:45 +0000 (10:13 -0400)]
2638: Fix css syntax.
Tom Clegg [Mon, 12 May 2014 19:37:24 +0000 (15:37 -0400)]
Add self-signed.{key,pem} to .gitignore files.
Tom Clegg [Mon, 12 May 2014 19:28:58 +0000 (15:28 -0400)]
Merge branch '2673-no-request-body-in-get'
closes #2673
Tom Clegg [Mon, 12 May 2014 19:01:37 +0000 (15:01 -0400)]
2673: Move auth to headers, avoid combining request body with GET method.
Tom Clegg [Mon, 12 May 2014 17:43:09 +0000 (13:43 -0400)]
2754: Hide unhelpful "Add a new job" button.
Tom Clegg [Mon, 12 May 2014 17:36:43 +0000 (13:36 -0400)]
2812: Fix "not in" filter so it can retrieve rows with null values.
closes #2812
radhika [Mon, 12 May 2014 17:11:15 +0000 (13:11 -0400)]
Merge branch 'master' into 2352-remove-attrs
Tom Clegg [Mon, 12 May 2014 14:41:17 +0000 (10:41 -0400)]
2808: Fix paging on jobs, pipeline_instances, api_client_authorizations.
Restore Jobs link to left nav.
closes #2808
radhika [Mon, 12 May 2014 00:29:29 +0000 (20:29 -0400)]
Merge branch 'master' into 2352-remove-attrs
Tom Clegg [Sun, 11 May 2014 20:30:53 +0000 (16:30 -0400)]
Merge branch 'master' into 2762-owner-uuid-integrity
Tom Clegg [Sun, 11 May 2014 20:24:25 +0000 (16:24 -0400)]
2756: Use site-default x-editable mode for pipeline instance name.
Inline mode avoided an "editable popup hides behind left nav" bug
which was fixed in
c66afecd36cf7d91223b5db79f3e120954f8217d.
Tom Clegg [Sun, 11 May 2014 07:02:57 +0000 (03:02 -0400)]
2762: Rename assign_uuid to has_uuid to reflect expanded scope.
Tom Clegg [Sun, 11 May 2014 06:55:45 +0000 (02:55 -0400)]
2762: When deleting an object, delete permissions and fail if other
links would be left dangling.
Tom Clegg [Sat, 10 May 2014 18:55:57 +0000 (14:55 -0400)]
2762: Test assigning random non-existent owner_uuids to new objects.
Tom Clegg [Sat, 10 May 2014 18:34:32 +0000 (14:34 -0400)]
2762: Protect owner_uuid referential integrity when changing uuids and
deleting users and groups.
radhika [Sat, 10 May 2014 18:26:31 +0000 (14:26 -0400)]
2352: log statement to include uuid if either active or success found in changed attributes.
Tim Pierce [Sat, 10 May 2014 03:12:18 +0000 (23:12 -0400)]
2328: restrict all /index requests to superuser
Per discussion with Tom on IRC: all /index requests, whether they
include a prefix argument or not, should be restricted to the superuser.
radhika [Sat, 10 May 2014 03:00:23 +0000 (23:00 -0400)]
2352: Address review feedback: (1) input can be edited even in Ready state, (2) pipeline cleanup to set state to Paused if RunningOnClient.
radhika [Sat, 10 May 2014 00:22:26 +0000 (20:22 -0400)]
Merge branch 'master' into 2352-remove-attrs
Brett Smith [Fri, 9 May 2014 21:35:32 +0000 (17:35 -0400)]
2803: Make all Python required versions match wheezy.
Brett Smith [Fri, 9 May 2014 21:06:16 +0000 (17:06 -0400)]
2803: Further relax Python SDK requirement for httplib2.
Our build server is using version 0.7.4, so it's apparently fine.
Brett Smith [Fri, 9 May 2014 20:51:17 +0000 (16:51 -0400)]
Merge branch '2803-python-package-split-wip'
Closes #2803, #2804.
Brett Smith [Fri, 9 May 2014 20:24:00 +0000 (16:24 -0400)]
2803: Relax Python library requirements.
Refs #2803. We're generally undemanding on the libraries we pull in,
and this can help us use more OS-packaged libraries.
Brett Smith [Fri, 9 May 2014 20:18:11 +0000 (16:18 -0400)]
2803: FUSE driver is now under the AGPL.
This is both our intent after the package split, and consistent with
/COPYING file.
Brett Smith [Fri, 9 May 2014 18:37:07 +0000 (14:37 -0400)]
2803: Split arvados and arvados_fuse Python modules.
Prior commits tried to make separate SDK and FUSE packages from the
same sdk/python source tree. However, this didn't work as intended
once the packages were installed. Python modules don't work like Ruby
namespaces. If you ask Python to import arvados.fuse, it finds the
arvados module, then looks for the fuse submodule under it. So you
can't have arvados.fuse installed somewhere completely differently.
In addition, Python packages assume the installation script is called
setup.py. So they wouldn't find setup_fuse.py.
We still want to have the FUSE module separate, so in discussion on
IRC we decided that the least worst option was to rename the module to
arvados_fuse. This commit implements that. If accepted, the new
build procedure will be:
$ python setup.py egg_info -b \
".$(git log --format=format:%ct.%h -n1 .)" sdist upload
Refs #2803.
radhika [Fri, 9 May 2014 20:24:31 +0000 (16:24 -0400)]
2352: add a info level log statement in pipeline_instance.rb if active or success flags are updated. The expection is that this should no longer happen.
radhika [Fri, 9 May 2014 18:54:07 +0000 (14:54 -0400)]
2352: Update the workbench and arv-run-pipeline-instance script to use pipeline_instance status instead of active and success flags.
Brett Smith [Fri, 9 May 2014 14:44:16 +0000 (10:44 -0400)]
2803: Remove unused setup.py.src.
Ward Vandewege [Fri, 9 May 2014 13:23:00 +0000 (09:23 -0400)]
Fix whitespace.
Tom Clegg [Fri, 9 May 2014 08:12:44 +0000 (04:12 -0400)]
Fix Python SDK test suite issues.
Tom Clegg [Fri, 9 May 2014 06:57:27 +0000 (02:57 -0400)]
Fix python SDK test suite issues.
Tim Pierce [Fri, 9 May 2014 06:49:51 +0000 (02:49 -0400)]
2328: handler_test.go refactoring
Refactoring to make tests easier to read and understand.
Tom Clegg [Fri, 9 May 2014 02:33:12 +0000 (22:33 -0400)]
Fix pipeline instance state tests.
Ward Vandewege [Fri, 9 May 2014 02:05:12 +0000 (22:05 -0400)]
Do not blindly overwrite GOPATH if it exists.
Tim Pierce [Fri, 9 May 2014 01:51:50 +0000 (21:51 -0400)]
2328: fix TestPutHandler permission_ttl
permission_ttl is normally initialized in main, which is not run from a
unit test. So a unit test which relies on generating valid permission
signatures must initialize permission_ttl itself.
Misha Zatsman [Fri, 9 May 2014 01:08:46 +0000 (01:08 +0000)]
Merge branch '2638-add-cache-age-disk-usage-histogram-to-workbench' closes #2638
Tim Pierce [Thu, 8 May 2014 22:05:49 +0000 (18:05 -0400)]
2328: simplify tests, permission_ttl variable
Incorporating code review:
Added ExpectStatusCode and ExpectBody to simplify repetitive tests.
permission_ttl is now a time.Duration to reduce confusion about units.
Peter Amstutz [Thu, 8 May 2014 21:10:07 +0000 (17:10 -0400)]
Fixed stop_keep(). Updated test_mount because the fixture changed (again).
Peter Amstutz [Thu, 8 May 2014 20:54:18 +0000 (16:54 -0400)]
Merge branch 'master' of git.clinicalfuture.com:arvados
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
Peter Amstutz [Thu, 8 May 2014 20:52:45 +0000 (16:52 -0400)]
- Added MANIFEST.in to include setup_header.py in the source package. Now gets
the version number from PKG-INFO metadata if available, or git if not, which
should handle all the cases of using sdist, pip install, or install from git
checkout.
- Improved run_test_server.py and fixed Python SDK tests to use it.
Tom Clegg [Thu, 8 May 2014 20:45:47 +0000 (16:45 -0400)]
Trim newline from logfile hash emerging from `arv keep put`.
radhika [Thu, 8 May 2014 20:40:48 +0000 (16:40 -0400)]
Merge branch '2525-java-sdk'
Brett Smith [Thu, 8 May 2014 20:38:46 +0000 (16:38 -0400)]
2759: Workbench shouldn't try to make links from Link names.
Because the name attribute can include arbitrary text, it might
resemble an Arvados object UUID. If that happens, the
_arvados_attr_value partial will try to make a link from it. All
sorts of weirdness could happen as a result (our specific bug was a
bad URL fed to Workbench's API client), so don't even try. Just
render the name directly as editable text.
Closes #2759.
Misha Zatsman [Thu, 8 May 2014 20:10:04 +0000 (20:10 +0000)]
Merge branch 'master' of git.curoverse.com:arvados into 2638-add-cache-age-disk-usage-histogram-to-workbench
Misha Zatsman [Thu, 8 May 2014 20:09:07 +0000 (20:09 +0000)]
Added some documentation and renamed variables after Tim's review.
Ward Vandewege [Thu, 8 May 2014 19:04:41 +0000 (15:04 -0400)]
Remove now-superfluous build.sh step from the documentation to build the
Python SDK from source.
Tim Pierce [Thu, 8 May 2014 18:30:49 +0000 (14:30 -0400)]
2328: do not expose keys to /bin/ps
For the data manager token and permission key, the command line flags
now specify a file from which to read secrets rather than specifying
them on the command line:
--data-manager-token-file
--permission-key-file
radhika [Thu, 8 May 2014 18:25:43 +0000 (14:25 -0400)]
2525: update available params method
radhika [Thu, 8 May 2014 18:06:04 +0000 (14:06 -0400)]
2525: getAvailableParametersForMethod includes properties from request also.
This is required for create and update methods which have no other parameters.
radhika [Thu, 8 May 2014 17:42:50 +0000 (13:42 -0400)]
Merge branch '2352-use-state'
Brett Smith [Thu, 8 May 2014 17:22:04 +0000 (13:22 -0400)]
Merge branch '2739-fix-100-task-limit-wip'
Closes #2739.
Brett Smith [Thu, 8 May 2014 17:19:27 +0000 (13:19 -0400)]
2739: Ensure crunch-job spawns all new tasks.
Without this fix, crunch-job would only spawn tasks up to the API
server default result limit (currently 100). Refs #2739.
Brett Smith [Thu, 8 May 2014 17:15:16 +0000 (13:15 -0400)]
Bugfix: Don't crash trying to render a new log buffer.
If you submit a Job and then try to load your Workbench Dashboard,
Workbench will likely crash because the log_buffer is a symbol at that
time. This check guards to make sure that we only try to render
actual log content.
radhika [Thu, 8 May 2014 17:02:55 +0000 (13:02 -0400)]
2352: when a running pipeline_instance is stopped in workbench, put it in Paused state.
Similar behavior as when run with --run-here at command prompt.
radhika [Thu, 8 May 2014 14:45:00 +0000 (10:45 -0400)]
Merge branch 'master' into 2352-use-state
radhika [Thu, 8 May 2014 14:40:53 +0000 (10:40 -0400)]
2352: fix issue with setting active during save