arvados.git
9 years agoMerge branch '6272-index-eof' closes #6272
Tom Clegg [Wed, 17 Jun 2015 02:30:03 +0000 (22:30 -0400)]
Merge branch '6272-index-eof' closes #6272

9 years ago6272: Add blank line to indicate index response EOF. Error out of data manager if...
Tom Clegg [Tue, 16 Jun 2015 20:14:58 +0000 (16:14 -0400)]
6272: Add blank line to indicate index response EOF. Error out of data manager if not received.

9 years agoDo not blow up if HOME is not set. refs #2256
Tom Clegg [Tue, 16 Jun 2015 22:17:03 +0000 (18:17 -0400)]
Do not blow up if HOME is not set. refs #2256

9 years ago3198: Add enable_write flag to FUSE and --enable-write and --read-only to
Peter Amstutz [Tue, 16 Jun 2015 19:35:31 +0000 (15:35 -0400)]
3198: Add enable_write flag to FUSE and --enable-write and --read-only to
arv-mount.  Update documentation.  Code cleanup in locators_and_ranges() and
set_state().

9 years agoMerge branch '6222-precompile-regexps' refs #6222
Tom Clegg [Tue, 16 Jun 2015 20:09:04 +0000 (16:09 -0400)]
Merge branch '6222-precompile-regexps' refs #6222

9 years ago6222: Precompile all regexps. Remove wasted effort in GetBlockHandler.
Tom Clegg [Sat, 6 Jun 2015 20:29:48 +0000 (16:29 -0400)]
6222: Precompile all regexps. Remove wasted effort in GetBlockHandler.

9 years ago6156: support config format for setting a node's hostname
radhika [Tue, 16 Jun 2015 15:32:55 +0000 (11:32 -0400)]
6156: support config format for setting a node's hostname

9 years ago6277: Add check_manifest_validity before_filter in collection model; however, at...
radhika [Mon, 15 Jun 2015 19:02:23 +0000 (15:02 -0400)]
6277: Add check_manifest_validity before_filter in collection model; however, at the moment, this method always true after logging the validation error.

9 years agorefs #6277
radhika [Mon, 15 Jun 2015 15:34:58 +0000 (11:34 -0400)]
refs #6277
Merge branch '6277-manifest-validation'

9 years agoMerge branch 'master' into 6277-manifest-validation
radhika [Mon, 15 Jun 2015 15:34:37 +0000 (11:34 -0400)]
Merge branch 'master' into 6277-manifest-validation

9 years ago6277: all that work and missed the basic nil and empty string check!!!
radhika [Mon, 15 Jun 2015 15:33:45 +0000 (11:33 -0400)]
6277: all that work and missed the basic nil and empty string check!!!

9 years ago3198: Performance tuning based on benchmarking. Limit number of segments to
Peter Amstutz [Mon, 15 Jun 2015 14:49:00 +0000 (10:49 -0400)]
3198: Performance tuning based on benchmarking.  Limit number of segments to
look ahead for prefetch, don't prefetch blocks over and over again.

9 years agocloses #6254
radhika [Mon, 15 Jun 2015 14:45:21 +0000 (10:45 -0400)]
closes #6254
Merge branch '6254-groups-during-setup'

9 years agorefs #6277 : ruby sdk with manifest validation method
radhika [Sun, 14 Jun 2015 01:31:29 +0000 (21:31 -0400)]
refs #6277 : ruby sdk with manifest validation method
Merge branch '6277-manifest-validation'

9 years ago6277: extra white space
radhika [Sun, 14 Jun 2015 01:21:39 +0000 (21:21 -0400)]
6277: extra white space

9 years agoMerge branch 'master' into 6277-manifest-validation
radhika [Sun, 14 Jun 2015 00:47:04 +0000 (20:47 -0400)]
Merge branch 'master' into 6277-manifest-validation

9 years ago6254: minor update to Groups text field label to avoid conflict with 'Virtual Machine...
radhika [Sat, 13 Jun 2015 02:24:49 +0000 (22:24 -0400)]
6254: minor update to Groups text field label to avoid conflict with 'Virtual Machine' lebel.

9 years ago6254: better groups text field label
radhika [Sat, 13 Jun 2015 01:19:35 +0000 (21:19 -0400)]
6254: better groups text field label

9 years ago6254: instead of tooltip, use a self explanatory label for groups text field.
radhika [Sat, 13 Jun 2015 01:06:23 +0000 (21:06 -0400)]
6254: instead of tooltip, use a self explanatory label for groups text field.

9 years ago7254: add groups to vm link.
radhika [Sat, 13 Jun 2015 00:26:28 +0000 (20:26 -0400)]
7254: add groups to vm link.

9 years ago3198: Fix frontrunning (subsequent updates after a commit causing the
Peter Amstutz [Fri, 12 Jun 2015 19:54:51 +0000 (15:54 -0400)]
3198: Fix frontrunning (subsequent updates after a commit causing the
collection to conflict with itself).  Also fix filename character encoding.

9 years ago6254: remove redundant statement
radhika [Fri, 12 Jun 2015 18:30:20 +0000 (14:30 -0400)]
6254: remove redundant statement

9 years ago6254: add groups and verify in test.
radhika [Fri, 12 Jun 2015 18:26:52 +0000 (14:26 -0400)]
6254: add groups and verify in test.

9 years agoMerge branch '6149-quiet-egg-info-stderr-wip'
Brett Smith [Fri, 12 Jun 2015 18:05:19 +0000 (14:05 -0400)]
Merge branch '6149-quiet-egg-info-stderr-wip'

Closes #6149, #6284.

9 years ago6149: crunch-job installer handles egg_info errors better.
Brett Smith [Thu, 11 Jun 2015 21:16:03 +0000 (17:16 -0400)]
6149: crunch-job installer handles egg_info errors better.

Capture the command's stderr and confirm that the error refers to
git.  If it does, ignore the stderr and set a build tag.  Otherwise,
propagate stderr and abort.

9 years ago6254: slight performance improvement where the can_login link is not retrieved and...
radhika [Fri, 12 Jun 2015 15:02:13 +0000 (11:02 -0400)]
6254: slight performance improvement where the can_login link is not retrieved and checked if the groups passed in are the same as those already saved.

9 years ago6254: add "groups" to user setup process; these comma separated groups entered in...
radhika [Fri, 12 Jun 2015 14:51:26 +0000 (10:51 -0400)]
6254: add "groups" to user setup process; these comma separated groups entered in the popup will be saved as an array of groups property for the user's can_login link.

9 years ago3198: Fix tests for change in ~conflict~ format. Tweak comments.
Peter Amstutz [Fri, 12 Jun 2015 14:33:39 +0000 (10:33 -0400)]
3198: Fix tests for change in ~conflict~ format.  Tweak comments.

9 years ago3198: Additional fixes based on review feedback.
Peter Amstutz [Thu, 11 Jun 2015 19:22:32 +0000 (15:22 -0400)]
3198: Additional fixes based on review feedback.

* Adjust how ~conflict~ files are renamed
* Add finalize() on fuse inodes() to terminate put and get threads.
* Improve naming of some test case helpers
* Relax regex match on authorization token

9 years ago3198: arvfile.py and collection.py updates based on feedback.
Peter Amstutz [Thu, 11 Jun 2015 17:12:21 +0000 (13:12 -0400)]
3198: arvfile.py and collection.py updates based on feedback.

* Add retryable ERROR state to buffer blocks.
* Fix race conditions in testing a bufferblock state before trying to change state.
* Change "modified" to "committed" (which has the opposite meaning, but is more
accurate the way the flag is used)
* Refactor block manager background upload/download threads
* Fix Collection.mkdirs() to match behavior of os.makedirs()

9 years ago6277: Catch whitespace errors, and "." and ".." in paths. Rename valid? to validate!.
Tom Clegg [Thu, 11 Jun 2015 05:58:49 +0000 (01:58 -0400)]
6277: Catch whitespace errors, and "." and ".." in paths. Rename valid? to validate!.

9 years ago6277: Add more restrictions to manifest format such as cannot start with '/' and...
radhika [Fri, 12 Jun 2015 00:13:45 +0000 (20:13 -0400)]
6277: Add more restrictions to manifest format such as cannot start with '/' and end with '/' for file names,
as well as stream names and files names should not contain '//'.
Added the tests provided by Tom during review.

9 years ago6277: valid manifest must end with new line.
radhika [Thu, 11 Jun 2015 20:19:05 +0000 (16:19 -0400)]
6277: valid manifest must end with new line.

9 years ago6277: improve error message for missing file tokens.
radhika [Thu, 11 Jun 2015 20:11:28 +0000 (16:11 -0400)]
6277: improve error message for missing file tokens.

9 years ago6277: add Manifest::valid? method in ruby sdk.
radhika [Thu, 11 Jun 2015 18:33:48 +0000 (14:33 -0400)]
6277: add Manifest::valid? method in ruby sdk.

9 years ago3198: Adjust language of errors to say what the error is instead of saying what the
Peter Amstutz [Wed, 10 Jun 2015 13:30:07 +0000 (09:30 -0400)]
3198: Adjust language of errors to say what the error is instead of saying what the
input should be.

9 years agoMerge branch 'master' into 3198-writable-fuse
Peter Amstutz [Wed, 10 Jun 2015 13:10:41 +0000 (09:10 -0400)]
Merge branch 'master' into 3198-writable-fuse

9 years agoUpdate arvados in bundle. refs #6203 refs #6277
Tom Clegg [Tue, 9 Jun 2015 19:16:28 +0000 (15:16 -0400)]
Update arvados in bundle. refs #6203 refs #6277

9 years agoUse default word wrap (no mid-word line breaks). refs #6057
Tom Clegg [Tue, 9 Jun 2015 19:12:46 +0000 (15:12 -0400)]
Use default word wrap (no mid-word line breaks). refs #6057

9 years agoqr1hi-automated-performance-suite is failing because the test doesnt give enough...
Nico Cesar [Tue, 9 Jun 2015 18:48:29 +0000 (14:48 -0400)]
qr1hi-automated-performance-suite is failing because the test doesnt give enough time for the page to render (now 50s makes the test past.). no issue #

9 years agoqr1hi-automated-performance-suite is failing because the test doesnt give enough...
Nico Cesar [Tue, 9 Jun 2015 18:38:18 +0000 (14:38 -0400)]
qr1hi-automated-performance-suite is failing because the test doesnt give enough time for the page to render

no issue #

9 years agoopenssl self cert creation failed because missing of "tmp" directory.
Nico Cesar [Tue, 9 Jun 2015 15:32:25 +0000 (11:32 -0400)]
openssl self cert creation failed because missing of "tmp" directory.
api server failed to start because missing "tmp/logs" and "tmp/api" ditectories

no issue #

9 years agoMerge branch '6235-go-sdk-discovery' closes #6235
Peter Amstutz [Tue, 9 Jun 2015 15:22:52 +0000 (11:22 -0400)]
Merge branch '6235-go-sdk-discovery' closes #6235

9 years agoMerge branch '5790-copy-most-recent-docker-image-wip'
Brett Smith [Tue, 9 Jun 2015 14:48:36 +0000 (10:48 -0400)]
Merge branch '5790-copy-most-recent-docker-image-wip'

Closes #5790, #6103.

9 years ago5790: Improve Docker image listing in Python SDK.
Brett Smith [Wed, 3 Jun 2015 20:59:24 +0000 (16:59 -0400)]
5790: Improve Docker image listing in Python SDK.

* Always fetch all relevant Docker links.
* Support finding images by image hash.
* Show image hashes when listing images by name.
* Like Docker itself, when an image has multiple names and we're not
  filtering by name, list each one.
* Better match the API server's priority logic:
  * Ignore links to collections that aren't found.
  * Links with an image_timestamp always have priority over those that
    don't, regardless of their respective created_at timestamps.

The main motivation for this change is to make sure arv-copy gets the
right Docker image when copying a pipeline template recursively.

This implementation goes through some trouble to parse timestamps out
of each Docker link only once.

9 years agoMerge branch '6152-compute-node-no-arv-wip'
Brett Smith [Tue, 9 Jun 2015 14:26:44 +0000 (10:26 -0400)]
Merge branch '6152-compute-node-no-arv-wip'

Closes #6152, #6256.

9 years ago6152: Use Python SDK for compute node installation.
Brett Smith [Fri, 5 Jun 2015 19:46:08 +0000 (15:46 -0400)]
6152: Use Python SDK for compute node installation.

This eliminates an otherwise-needless dependency on `arv` and the
entire Ruby stack.

9 years agocloses #6093
radhika [Tue, 9 Jun 2015 14:25:59 +0000 (10:25 -0400)]
closes #6093
Merge branch '6093-refresh-docs'

9 years ago6093: remove "Alternate way to add SSH keys" and add the "Manage account" link blurb...
radhika [Tue, 9 Jun 2015 14:21:38 +0000 (10:21 -0400)]
6093: remove "Alternate way to add SSH keys" and add the "Manage account" link blurb to "Adding your keys" section itself.

9 years agoMerge branch '6203-locator-regexp' refs #6203 refs #6277
Tom Clegg [Tue, 9 Jun 2015 14:11:35 +0000 (10:11 -0400)]
Merge branch '6203-locator-regexp' refs #6203 refs #6277

9 years agoadded shell-image back again to the build. I checked on my local machine and works...
Nico Cesar [Wed, 10 Jun 2015 16:26:15 +0000 (12:26 -0400)]
added shell-image back again to the build. I checked on my local machine and works great

no issue #

9 years ago5790: Fix PySDK Docker image listing comparing ints and datetimes.
Brett Smith [Wed, 10 Jun 2015 15:24:38 +0000 (11:24 -0400)]
5790: Fix PySDK Docker image listing comparing ints and datetimes.

Closes #5790.

9 years agoAdd instructions to the 'Create standard objects' page to create a cluster-wide reada...
Ward Vandewege [Wed, 10 Jun 2015 14:32:40 +0000 (10:32 -0400)]
Add instructions to the 'Create standard objects' page to create a cluster-wide readable project for standard Arvados Docker images.

refs #6096

9 years agocloses #6203
radhika [Wed, 10 Jun 2015 14:15:47 +0000 (10:15 -0400)]
closes #6203
Merge branch '6203-collection-perf-api'

9 years agoMerge branch '6203-collection-perf-api-TC' of git.curoverse.com:arvados into 6203...
radhika [Wed, 10 Jun 2015 14:06:35 +0000 (10:06 -0400)]
Merge branch '6203-collection-perf-api-TC' of git.curoverse.com:arvados into 6203-collection-perf-api-TC

Conflicts:
services/api/app/models/collection.rb

9 years ago6203: Fix loophole allowing locators in bogus manifests to be accepted
Tom Clegg [Mon, 8 Jun 2015 19:34:48 +0000 (15:34 -0400)]
6203: Fix loophole allowing locators in bogus manifests to be accepted
without verification and then signed in responses. refs #6277

9 years ago6203: Add tests for LOCATOR_REGEXP. Fix regexp to reject "++" and trailing "\n".
Tom Clegg [Mon, 8 Jun 2015 16:03:42 +0000 (12:03 -0400)]
6203: Add tests for LOCATOR_REGEXP. Fix regexp to reject "++" and trailing "\n".

9 years agoMerge branch 'master' into 6093-refresh-docs
radhika [Tue, 9 Jun 2015 14:09:07 +0000 (10:09 -0400)]
Merge branch 'master' into 6093-refresh-docs

9 years ago6203: Accept (and discard) hints in client-provided portable_data_hash.
Tom Clegg [Mon, 8 Jun 2015 14:10:26 +0000 (10:10 -0400)]
6203: Accept (and discard) hints in client-provided portable_data_hash.

9 years ago6203: Remove unused vars. Remove unnecessary newline manipulation.
Tom Clegg [Mon, 8 Jun 2015 07:11:22 +0000 (03:11 -0400)]
6203: Remove unused vars. Remove unnecessary newline manipulation.

9 years ago6235: Discovery() returns the requested value directly instead of a single-entry...
Peter Amstutz [Mon, 8 Jun 2015 13:36:33 +0000 (09:36 -0400)]
6235: Discovery() returns the requested value directly instead of a single-entry map.

9 years ago6203: Remove unused vars. Remove unnecessary newline manipulation.
Tom Clegg [Mon, 8 Jun 2015 07:11:22 +0000 (03:11 -0400)]
6203: Remove unused vars. Remove unnecessary newline manipulation.

9 years ago6203: Use faster =~ instead of match.
Tom Clegg [Mon, 8 Jun 2015 06:23:57 +0000 (02:23 -0400)]
6203: Use faster =~ instead of match.

9 years ago6203: Fix cheating test.
Tom Clegg [Mon, 8 Jun 2015 06:23:37 +0000 (02:23 -0400)]
6203: Fix cheating test.

9 years ago6203: Use each_line instead of split.each.
Tom Clegg [Mon, 8 Jun 2015 06:23:20 +0000 (02:23 -0400)]
6203: Use each_line instead of split.each.

9 years ago6203: Remove redundant split before each_line.
Tom Clegg [Mon, 8 Jun 2015 06:22:33 +0000 (02:22 -0400)]
6203: Remove redundant split before each_line.

9 years ago6203: Apply special case only to a 0-byte manifest: don't ignore white space.
Tom Clegg [Mon, 8 Jun 2015 05:50:30 +0000 (01:50 -0400)]
6203: Apply special case only to a 0-byte manifest: don't ignore white space.

9 years ago6203: Eliminate unneeded variable.
Tom Clegg [Mon, 8 Jun 2015 05:49:06 +0000 (01:49 -0400)]
6203: Eliminate unneeded variable.

9 years ago6203: Merge pdh validations into one method. Update comments. Add tests.
Tom Clegg [Mon, 8 Jun 2015 05:48:45 +0000 (01:48 -0400)]
6203: Merge pdh validations into one method. Update comments. Add tests.

9 years ago6203: Use LOCATION_REGEXP from sdk; also add back updated each_manifest_locator method
radhika [Tue, 9 Jun 2015 01:42:30 +0000 (21:42 -0400)]
6203: Use LOCATION_REGEXP from sdk; also add back updated each_manifest_locator method
with the same updates as munge method since this is simpler than the munge method. This
has seems further improved performance.

9 years ago6203: Use manifest.each_line and line.rstrip! instead of manifest.split("\n").
radhika [Mon, 8 Jun 2015 19:39:37 +0000 (15:39 -0400)]
6203: Use manifest.each_line and line.rstrip! instead of manifest.split("\n").
Performance was comparable in both cases; though each_line itself is twice as fast (we need to do strip, which eats away the gain).

9 years ago6203: further optimization of munge method; also, match[0].sub(/\+A[^+]*/, '') instea...
radhika [Mon, 8 Jun 2015 18:32:42 +0000 (14:32 -0400)]
6203: further optimization of munge method; also, match[0].sub(/\+A[^+]*/, '') instead of split+append
resulted in another 2 seconds saving in each of create and update operations!

9 years ago6203: compute_pdh, computed_pdh etc etc etc confusion. clean up to make it easier...
radhika [Mon, 8 Jun 2015 16:24:53 +0000 (12:24 -0400)]
6203: compute_pdh, computed_pdh etc etc etc confusion. clean up to make it easier to follow.

9 years ago6203: Benchmarking revealed that regexp.match(string) is 2.5x more expensive than...
radhika [Sat, 6 Jun 2015 23:36:13 +0000 (19:36 -0400)]
6203: Benchmarking revealed that regexp.match(string) is 2.5x more expensive than string =~ regexp. Updated check_signatures method accordingly.

9 years agoMerge branch 'master' into 6203-collection-perf-api
radhika [Sat, 6 Jun 2015 22:59:33 +0000 (18:59 -0400)]
Merge branch 'master' into 6203-collection-perf-api

9 years agobundler 1.10 brakes workbench build because
Nico Cesar [Fri, 5 Jun 2015 18:54:36 +0000 (14:54 -0400)]
bundler 1.10 brakes workbench build because

https://github.com/lucasefe/themes_for_rails/blob/master/themes_for_rails.gemspec

has a bug. And it's a NOTICE in 1.9.9 but its a FATAL in 1.10.x

this is our workaround.

no issue #

9 years agoMerge branch '6146-log-squeue-lost-tasks' refs #6146
Tom Clegg [Fri, 5 Jun 2015 17:00:31 +0000 (13:00 -0400)]
Merge branch '6146-log-squeue-lost-tasks' refs #6146

9 years ago6146: Document how --steps really works. Simplify squeue output format and parsing.
Tom Clegg [Thu, 4 Jun 2015 21:09:59 +0000 (17:09 -0400)]
6146: Document how --steps really works. Simplify squeue output format and parsing.

9 years agoMerge branch '6074-collections-index' closes #6074
Tom Clegg [Thu, 4 Jun 2015 19:29:35 +0000 (15:29 -0400)]
Merge branch '6074-collections-index' closes #6074

9 years agoMerge branch 'master' into 6093-refresh-docs
radhika [Thu, 4 Jun 2015 18:10:33 +0000 (14:10 -0400)]
Merge branch 'master' into 6093-refresh-docs

9 years ago6093: Add button-override css to make any buttons added inside the documentation...
radhika [Thu, 4 Jun 2015 18:09:39 +0000 (14:09 -0400)]
6093: Add button-override css to make any buttons added inside the documentation to appear unclickable to avoid any confusion.

9 years ago6203: Corrected one dumb switched order of if conditions that caused 5s lag!!
radhika [Thu, 4 Jun 2015 16:51:26 +0000 (12:51 -0400)]
6203: Corrected one dumb switched order of if conditions that caused 5s lag!!

9 years agoMerge branch 'master' into 6203-collection-perf-api
radhika [Thu, 4 Jun 2015 16:16:55 +0000 (12:16 -0400)]
Merge branch 'master' into 6203-collection-perf-api

9 years ago6087: Fix MissingAttribute check, and change it to a debug warning for now
Tom Clegg [Thu, 4 Jun 2015 15:21:43 +0000 (11:21 -0400)]
6087: Fix MissingAttribute check, and change it to a debug warning for now
because it reveals too many bugs. refs #6087

9 years ago6087: Fix MissingAttribute firing for new records during changes_applied. refs #6087
Tom Clegg [Thu, 4 Jun 2015 14:38:28 +0000 (10:38 -0400)]
6087: Fix MissingAttribute firing for new records during changes_applied. refs #6087

9 years agoMerge branch 'master' into 6203-collection-perf-api
radhika [Thu, 4 Jun 2015 14:27:04 +0000 (10:27 -0400)]
Merge branch 'master' into 6203-collection-perf-api

Conflicts:
apps/workbench/test/integration_performance/collection_unit_test.rb
apps/workbench/test/integration_performance/collections_controller_test.rb
services/api/test/integration/collections_performance_test.rb
services/api/test/unit/collection_performance_test.rb

9 years agoMerge branch '6087-collection-timing' closes #6087
Tom Clegg [Thu, 4 Jun 2015 13:37:59 +0000 (09:37 -0400)]
Merge branch '6087-collection-timing' closes #6087

9 years ago6087: If attributes are accessed but not loaded due to select(), raise instead of...
Tom Clegg [Wed, 3 Jun 2015 18:50:03 +0000 (14:50 -0400)]
6087: If attributes are accessed but not loaded due to select(), raise instead of returning nil/{}/[].

9 years ago6087: Remove unneeded CollectionsController#update special case.
Tom Clegg [Wed, 3 Jun 2015 16:05:11 +0000 (12:05 -0400)]
6087: Remove unneeded CollectionsController#update special case.

ArvadosBase#save now covers the general case of omitting unchanged attributes.

9 years ago6087: Reset changed-attrs list after saving. Fix only-send-changed-attrs logic. Add...
Tom Clegg [Tue, 2 Jun 2015 19:23:51 +0000 (15:23 -0400)]
6087: Reset changed-attrs list after saving. Fix only-send-changed-attrs logic. Add tests.

9 years ago6087: Strengthen "manifest_text is not lost in update" test.
Tom Clegg [Wed, 3 Jun 2015 16:00:19 +0000 (12:00 -0400)]
6087: Strengthen "manifest_text is not lost in update" test.

9 years ago6087: Add big-manifest tests, with some finer-grained performance numbers on stderr.
Tom Clegg [Mon, 25 May 2015 17:25:22 +0000 (13:25 -0400)]
6087: Add big-manifest tests, with some finer-grained performance numbers on stderr.

9 years ago6074: Use each instead of find_each, so our order() and limit() constraints are respe...
Tom Clegg [Thu, 4 Jun 2015 04:52:48 +0000 (00:52 -0400)]
6074: Use each instead of find_each, so our order() and limit() constraints are respected.

According to http://apidock.com/rails/ActiveRecord/Batches/find_each,
both order and limit are ignored.

The existing test "max_index_database_read does not interfere with
order" had two fatal bugs that prevented it from catching the
find_each problem:

1. It didn't select the 'name' column, so the 'name' order was
   ignored. But the test passed because the name wasn't returned,
   item['name'] was nil, and... nil !~ /pattern/ is true. Both
   problems are fixed here.

   (This explains why it seemed to find 15 names starting with
   Collection_9, rather than just the 11 that exist (_9 and _90..99).)

2. It tested only that the returned results followed the requested
   order, not that the order was followed when deciding what the limit
   should be. All of the items_available were the same size, so _any_
   order would have set the limit at 15 and passed the test.

The second problem is fixed by adding a separate test.

9 years ago6203: add trailing newline character in munge_manifest_locators method only when...
radhika [Thu, 4 Jun 2015 03:57:58 +0000 (23:57 -0400)]
6203: add trailing newline character in munge_manifest_locators method only when the original manifest ended with one; one of the unit tests did not like it otherwise.

9 years ago6074: Update config docs to match new max_index_database_read behavior.
Tom Clegg [Thu, 4 Jun 2015 03:41:06 +0000 (23:41 -0400)]
6074: Update config docs to match new max_index_database_read behavior.

9 years ago6203: Merge strip_manifest_text and maybe_clear_replication_confirmed into one method...
radhika [Thu, 4 Jun 2015 03:13:39 +0000 (23:13 -0400)]
6203: Merge strip_manifest_text and maybe_clear_replication_confirmed into one method to avoid repeated manifest parsing related expense.

9 years ago6235: Add method to get parameters from API discovery document.
Peter Amstutz [Wed, 3 Jun 2015 20:40:50 +0000 (16:40 -0400)]
6235: Add method to get parameters from API discovery document.

9 years ago6074: Never exceed the configured max_index_database_read (even by one
Tom Clegg [Wed, 3 Jun 2015 20:37:39 +0000 (16:37 -0400)]
6074: Never exceed the configured max_index_database_read (even by one
record) unless necessary to return one row.

Fix copy&paste error in test case.

9 years ago6074: Clear any existing ActiveRecord select() before adding our own,
Tom Clegg [Wed, 3 Jun 2015 20:28:01 +0000 (16:28 -0400)]
6074: Clear any existing ActiveRecord select() before adding our own,
otherwise we'll read all the big values when we're really just trying
to predict the result size.

9 years ago6074: Speed up db query by using octet_length() instead of length(). closes #6223
Tom Clegg [Wed, 3 Jun 2015 19:39:01 +0000 (15:39 -0400)]
6074: Speed up db query by using octet_length() instead of length(). closes #6223