arvados.git
10 years agoFixed scope to use request.request_method (the effective request method in
Peter Amstutz [Thu, 8 May 2014 13:30:36 +0000 (09:30 -0400)]
Fixed scope to use request.request_method (the effective request method in
rails) instead of request.method (the actual HTTP method).  Added word-wrap
style to popup.

10 years agoFixed incorrectly created scopes. Fixed link to use reader_tokens[] instead of
Peter Amstutz [Wed, 7 May 2014 13:57:33 +0000 (09:57 -0400)]
Fixed incorrectly created scopes.  Fixed link to use reader_tokens[] instead of
api_token.  Fixed to update color/text of sharing button on files page.

10 years agoAlmost working sharing button.
Peter Amstutz [Tue, 6 May 2014 21:10:04 +0000 (17:10 -0400)]
Almost working sharing button.

10 years agoAdded empty sharing popup.
Peter Amstutz [Tue, 6 May 2014 18:52:54 +0000 (14:52 -0400)]
Added empty sharing popup.

10 years agoRemove stray debug puts.
Tom Clegg [Tue, 6 May 2014 17:10:05 +0000 (13:10 -0400)]
Remove stray debug puts.

10 years agoMerge branch '1970-folder-view'
Tom Clegg [Tue, 6 May 2014 17:01:44 +0000 (13:01 -0400)]
Merge branch '1970-folder-view'

closes #1970

10 years agoMerge branch 'master' into 1970-folder-view
Tom Clegg [Tue, 6 May 2014 17:01:34 +0000 (13:01 -0400)]
Merge branch 'master' into 1970-folder-view

10 years agoAdd find?() method so "assert find?(...), msg" can be used in test cases.
Tom Clegg [Tue, 6 May 2014 16:58:14 +0000 (12:58 -0400)]
Add find?() method so "assert find?(...), msg" can be used in test cases.

10 years agoReplace unfailable assert() with a comment explaining what it means
Tom Clegg [Tue, 6 May 2014 16:37:29 +0000 (12:37 -0400)]
Replace unfailable assert() with a comment explaining what it means
for find() to raise an exception.

10 years agoFix so that a present but empty select parameter in queries no longer yields
Peter Amstutz [Tue, 6 May 2014 01:24:45 +0000 (21:24 -0400)]
Fix so that a present but empty select parameter in queries no longer yields
an error.

10 years agoRemove duplicate ERROR_ACTIONS constant from merge.
Tom Clegg [Tue, 6 May 2014 00:31:45 +0000 (20:31 -0400)]
Remove duplicate ERROR_ACTIONS constant from merge.

10 years agoEnsure edited description really gets saved.
Tom Clegg [Tue, 6 May 2014 00:31:18 +0000 (20:31 -0400)]
Ensure edited description really gets saved.

10 years agoUse send(symbol) instead of send(string).
Tom Clegg [Tue, 6 May 2014 00:22:38 +0000 (20:22 -0400)]
Use send(symbol) instead of send(string).

10 years agoChange icon for virtual machines nav.
Tom Clegg [Tue, 6 May 2014 00:21:08 +0000 (20:21 -0400)]
Change icon for virtual machines nav.

10 years agoRemove confusing return value.
Tom Clegg [Tue, 6 May 2014 00:20:46 +0000 (20:20 -0400)]
Remove confusing return value.

10 years agoMerge branch '2640-folder-api' into 1970-folder-view
Tom Clegg [Mon, 5 May 2014 22:33:04 +0000 (18:33 -0400)]
Merge branch '2640-folder-api' into 1970-folder-view

Conflicts:
apps/workbench/app/controllers/application_controller.rb
services/api/app/controllers/application_controller.rb

10 years agoMove contents action to GroupsController.
Tom Clegg [Mon, 5 May 2014 21:30:11 +0000 (17:30 -0400)]
Move contents action to GroupsController.

10 years agoFix broken test case.
Tom Clegg [Mon, 5 May 2014 21:24:10 +0000 (17:24 -0400)]
Fix broken test case.

10 years agoMerge branch 'master' of git.curoverse.com:arvados
Ward Vandewege [Mon, 5 May 2014 21:09:43 +0000 (17:09 -0400)]
Merge branch 'master' of git.curoverse.com:arvados

10 years agoDocumentation tweaks:
Ward Vandewege [Mon, 5 May 2014 21:06:01 +0000 (17:06 -0400)]
Documentation tweaks:
* Python SDK requires Python 2.7, make that clear up front
* Remove duplicated SDK installation instructions

10 years agoMerge branch '2640-folder-api'
Tom Clegg [Mon, 5 May 2014 21:02:37 +0000 (17:02 -0400)]
Merge branch '2640-folder-api'

10 years agoMerge branch 'master' into 2640-folder-api
Tom Clegg [Mon, 5 May 2014 21:01:50 +0000 (17:01 -0400)]
Merge branch 'master' into 2640-folder-api

Conflicts:
apps/workbench/app/models/arvados_api_client.rb

10 years agoRaise PermissionDeniedError even more consistently
Tom Clegg [Mon, 5 May 2014 20:55:19 +0000 (16:55 -0400)]
Raise PermissionDeniedError even more consistently

10 years agoMerge branch '2640-folder-api' into 1970-folder-view
Tom Clegg [Mon, 5 May 2014 20:14:34 +0000 (16:14 -0400)]
Merge branch '2640-folder-api' into 1970-folder-view

10 years agoRaise PermissionDeniedError more consistently
Tom Clegg [Mon, 5 May 2014 20:05:22 +0000 (16:05 -0400)]
Raise PermissionDeniedError more consistently

10 years agoComment mysterious testing code.
Tom Clegg [Mon, 5 May 2014 20:02:29 +0000 (16:02 -0400)]
Comment mysterious testing code.

10 years agoAdd test for links_for + multiple link_classes.
Tom Clegg [Mon, 5 May 2014 19:59:44 +0000 (15:59 -0400)]
Add test for links_for + multiple link_classes.

10 years agoMerge branch '1904-workbench-reader-tokens'
Brett Smith [Mon, 5 May 2014 19:20:45 +0000 (15:20 -0400)]
Merge branch '1904-workbench-reader-tokens'

Refs #1904.  Closes #2663, #2736.

10 years agoworkbench: Reader tokens show collection files.
Brett Smith [Mon, 5 May 2014 16:55:29 +0000 (12:55 -0400)]
workbench: Reader tokens show collection files.

Fundamentally, this commit aims to support reader tokens when showing
a file from a Collection.  Because this requires changing the token
handling generally, I also took this opportunity to improve error
reporting by checking the request's validity against the API server
before we pipe out to arv-get to render the file.

As a consequence, Workbench now returns a 404 if you request a file
using a token that does not have permission to read the collection.
Maybe this is not the best result, but previously it returned a 422,
so I think this counts as an improvement.

10 years agoworkbench: Add initial reader tokens support.
Brett Smith [Mon, 5 May 2014 14:54:53 +0000 (10:54 -0400)]
workbench: Add initial reader tokens support.

The API server recently gained support for reader tokens, which
optionally supplement the user's permissions for read-only
operations.  This commit extends Workbench to pass on reader tokens
for general index and show operations.

10 years agoworkbench: Add Collections controller tests.
Brett Smith [Wed, 30 Apr 2014 14:38:08 +0000 (10:38 -0400)]
workbench: Add Collections controller tests.

Working to establish a baseline of behavior before I go mucking with
this.

10 years agoworkbench: Remove trailing whitespace.
Brett Smith [Thu, 1 May 2014 14:42:33 +0000 (10:42 -0400)]
workbench: Remove trailing whitespace.

10 years agoMerge branch '2328-keep-permission-hints'
Tim Pierce [Mon, 5 May 2014 18:03:10 +0000 (14:03 -0400)]
Merge branch '2328-keep-permission-hints'

10 years agoResolve code review (closes #2328)
Tim Pierce [Mon, 5 May 2014 17:52:06 +0000 (13:52 -0400)]
Resolve code review (closes #2328)

Fix doc comments and argument names for the expiry timestamp arguments
for SignLocator and makePermSignature.

10 years agoFix ajax->refresh race condition in test case.
Tom Clegg [Mon, 5 May 2014 10:58:54 +0000 (06:58 -0400)]
Fix ajax->refresh race condition in test case.

10 years agoFix tests, make model.editable? work for new records.
Tom Clegg [Mon, 5 May 2014 10:32:27 +0000 (06:32 -0400)]
Fix tests, make model.editable? work for new records.

10 years agoBehave nicer if supplied owner_uuid is not a valid uuid at all.
Tom Clegg [Mon, 5 May 2014 10:08:30 +0000 (06:08 -0400)]
Behave nicer if supplied owner_uuid is not a valid uuid at all.

10 years agoEdit objects after creating them with x-editable.
Tom Clegg [Mon, 5 May 2014 10:06:16 +0000 (06:06 -0400)]
Edit objects after creating them with x-editable.

10 years agoImplement simple client-side folder contents search.
Tom Clegg [Mon, 5 May 2014 08:01:48 +0000 (04:01 -0400)]
Implement simple client-side folder contents search.

10 years agoImplement "remove from folder"
Tom Clegg [Mon, 5 May 2014 07:47:50 +0000 (03:47 -0400)]
Implement "remove from folder"

10 years agoName new folders "New folder", fix crash if folder name is nil
Tom Clegg [Mon, 5 May 2014 07:25:53 +0000 (03:25 -0400)]
Name new folders "New folder", fix crash if folder name is nil

10 years agoUpdate name in breadcrumb after editing elsewhere on page.
Tom Clegg [Mon, 5 May 2014 07:21:09 +0000 (03:21 -0400)]
Update name in breadcrumb after editing elsewhere on page.

10 years agoMerge branch '2640-folder-api' into 1970-folder-view
Tom Clegg [Mon, 5 May 2014 06:51:30 +0000 (02:51 -0400)]
Merge branch '2640-folder-api' into 1970-folder-view

10 years agoDo not try to record object_owner_uuid during earlier migrations.
Tom Clegg [Sun, 4 May 2014 18:49:11 +0000 (14:49 -0400)]
Do not try to record object_owner_uuid during earlier migrations.

10 years agoMerge branch 'master' into 2640-folder-api
Tom Clegg [Sun, 4 May 2014 01:25:19 +0000 (21:25 -0400)]
Merge branch 'master' into 2640-folder-api

10 years agoFix crashing "grant access to my own object" permission check.
Tom Clegg [Sun, 4 May 2014 01:22:17 +0000 (21:22 -0400)]
Fix crashing "grant access to my own object" permission check.

10 years agoPrevent ownership cycles.
Tom Clegg [Sun, 4 May 2014 01:08:18 +0000 (21:08 -0400)]
Prevent ownership cycles.

10 years agoMerge branch '2640-folder-api' into 1970-folder-view
Tom Clegg [Sat, 3 May 2014 03:20:56 +0000 (23:20 -0400)]
Merge branch '2640-folder-api' into 1970-folder-view

10 years agoImprove code formatting
Tom Clegg [Sat, 3 May 2014 00:00:04 +0000 (20:00 -0400)]
Improve code formatting

10 years agoReturn all links if link_class is not provided. Add docs.
Tom Clegg [Fri, 2 May 2014 23:45:16 +0000 (19:45 -0400)]
Return all links if link_class is not provided. Add docs.

10 years agoReturn empty list if no "links" supplied in api response. Add tests.
Tom Clegg [Fri, 2 May 2014 23:41:23 +0000 (19:41 -0400)]
Return empty list if no "links" supplied in api response. Add tests.

10 years agoIncorporating code review. (refs #2328)
Tim Pierce [Fri, 2 May 2014 22:26:08 +0000 (18:26 -0400)]
Incorporating code review. (refs #2328)

10 years agoMerge branch '2223-repo-owner-admin-perms'
Tom Clegg [Fri, 2 May 2014 20:27:18 +0000 (16:27 -0400)]
Merge branch '2223-repo-owner-admin-perms'

closes #2223

10 years agoAdd "remove item from folder" buttons
Tom Clegg [Fri, 2 May 2014 20:26:47 +0000 (16:26 -0400)]
Add "remove item from folder" buttons

10 years agoAdd writable_by to Group API response.
Tom Clegg [Fri, 2 May 2014 20:26:37 +0000 (16:26 -0400)]
Add writable_by to Group API response.

10 years agoMerge branch 'query-select-distinct'
Peter Amstutz [Fri, 2 May 2014 20:16:16 +0000 (16:16 -0400)]
Merge branch 'query-select-distinct'

10 years agoRestored support for old-style 'order' strings and added test. Clarified
Peter Amstutz [Fri, 2 May 2014 20:10:10 +0000 (16:10 -0400)]
Restored support for old-style 'order' strings and added test.  Clarified
documentation for 'distinct' as to the default behavior.

10 years agoFixed botched 'distinct' parameter, now is a boolean instead of taking a
Peter Amstutz [Fri, 2 May 2014 19:54:45 +0000 (15:54 -0400)]
Fixed botched 'distinct' parameter, now is a boolean instead of taking a
column.  New tests.  Also changed syntax of 'order' to take a JSON array for
consistency with 'filters' and 'select'.

10 years agoUpdate docs. (refs #2328)
Tim Pierce [Fri, 2 May 2014 19:09:46 +0000 (15:09 -0400)]
Update docs. (refs #2328)

10 years agoAdded permission helper functions.
Tim Pierce [Fri, 2 May 2014 19:05:07 +0000 (15:05 -0400)]
Added permission helper functions.

GeneratePerms returns a string representing the signed permission hint
for the blob identified by blob_hash, api_token and timestamp.

SignLocator takes a blob_locator, an api_token and a timestamp, and
returns a signed locator string.

VerifySignature returns true if the signature on the signed_locator can
be verified using the given api_token.

Refs #2328.

10 years agoUnify button styles.
Tom Clegg [Fri, 2 May 2014 18:22:21 +0000 (14:22 -0400)]
Unify button styles.

10 years agoAdd shadow to left nav.
Tom Clegg [Fri, 2 May 2014 17:34:30 +0000 (13:34 -0400)]
Add shadow to left nav.

10 years agoTake into account owner_uuid and is_admin when exporting repository permissions.
Tom Clegg [Fri, 2 May 2014 16:19:42 +0000 (12:19 -0400)]
Take into account owner_uuid and is_admin when exporting repository permissions.

10 years agoFix name_for method name.
Tom Clegg [Fri, 2 May 2014 14:34:10 +0000 (10:34 -0400)]
Fix name_for method name.

10 years agoFix crash if item has no name (backported from 1970-folder-view)
Tom Clegg [Fri, 2 May 2014 14:32:52 +0000 (10:32 -0400)]
Fix crash if item has no name (backported from 1970-folder-view)

10 years agoFix for interaction between 'select' and 'order' (SQL requires that order
Peter Amstutz [Fri, 2 May 2014 14:12:25 +0000 (10:12 -0400)]
Fix for interaction between 'select' and 'order' (SQL requires that order
fields show up in select when doing select distinct; readable_by does 'select distinct' by default to avoid duplicate rows).

10 years agoUse class_for_display more.
Tom Clegg [Fri, 2 May 2014 02:58:20 +0000 (22:58 -0400)]
Use class_for_display more.

10 years agoAdd folder list to left nav.
Tom Clegg [Fri, 2 May 2014 02:54:40 +0000 (22:54 -0400)]
Add folder list to left nav.

10 years agoMerge branch '2640-folder-api' into 1970-folder-view
Tom Clegg [Fri, 2 May 2014 02:24:06 +0000 (22:24 -0400)]
Merge branch '2640-folder-api' into 1970-folder-view

10 years agoAdd "Copy selections to current folder" button to selection drop-down.
Tom Clegg [Fri, 2 May 2014 02:23:57 +0000 (22:23 -0400)]
Add "Copy selections to current folder" button to selection drop-down.

10 years agoName links do not need to be owned by tail_uuid.
Tom Clegg [Fri, 2 May 2014 02:20:28 +0000 (22:20 -0400)]
Name links do not need to be owned by tail_uuid.

10 years agoMerge branch '2640-folder-api' into 1970-folder-view
Tom Clegg [Thu, 1 May 2014 23:57:07 +0000 (19:57 -0400)]
Merge branch '2640-folder-api' into 1970-folder-view

10 years agoAdd unique and valid name constraints.
Tom Clegg [Thu, 1 May 2014 22:01:37 +0000 (18:01 -0400)]
Add unique and valid name constraints.

10 years agoFix wrong infixes in fixture uuids.
Tom Clegg [Thu, 1 May 2014 21:43:50 +0000 (17:43 -0400)]
Fix wrong infixes in fixture uuids.

10 years agoMerge branch 'master' into 2640-folder-api
Tom Clegg [Thu, 1 May 2014 21:41:29 +0000 (17:41 -0400)]
Merge branch 'master' into 2640-folder-api

10 years agoMerge remote-tracking branch 'origin/master' into 2035-arv-mount-tags-folders
Peter Amstutz [Thu, 1 May 2014 20:26:09 +0000 (16:26 -0400)]
Merge remote-tracking branch 'origin/master' into 2035-arv-mount-tags-folders

Conflicts:
services/api/app/controllers/application_controller.rb

10 years agoAdded 'select' and 'distinct' parameters to discovery document. Improved
Peter Amstutz [Thu, 1 May 2014 18:54:51 +0000 (14:54 -0400)]
Added 'select' and 'distinct' parameters to discovery document.  Improved
select parameter to parse strings as json.

10 years agoUse partial unique index for name links.
Tom Clegg [Thu, 1 May 2014 18:38:46 +0000 (14:38 -0400)]
Use partial unique index for name links.

10 years agoFix log permission case broken in merge.
Tom Clegg [Thu, 1 May 2014 18:38:15 +0000 (14:38 -0400)]
Fix log permission case broken in merge.

10 years agoMerge branch 'master' into 2640-folder-api
Tom Clegg [Thu, 1 May 2014 18:26:40 +0000 (14:26 -0400)]
Merge branch 'master' into 2640-folder-api

Conflicts:
services/api/app/controllers/application_controller.rb
services/api/app/models/arvados_model.rb

10 years agoMerge branch 'master' of git.clinicalfuture.com:arvados
Peter Amstutz [Thu, 1 May 2014 17:16:10 +0000 (13:16 -0400)]
Merge branch 'master' of git.clinicalfuture.com:arvados

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.

10 years agoAnother go at migration, uses batched loading and transactions, should have
Peter Amstutz [Thu, 1 May 2014 17:15:54 +0000 (13:15 -0400)]
Another go at migration, uses batched loading and transactions, should have
improved performance.

10 years agoMerge branch '2328-signatures-for-integration-testing'
Tom Clegg [Thu, 1 May 2014 17:11:40 +0000 (13:11 -0400)]
Merge branch '2328-signatures-for-integration-testing'

refs #2328

10 years agoAdd partial unique index
Tom Clegg [Thu, 1 May 2014 17:11:22 +0000 (13:11 -0400)]
Add partial unique index

10 years agoAdd test cases that produce predictable signatures with fixed expiry times.
Tom Clegg [Thu, 1 May 2014 16:50:06 +0000 (12:50 -0400)]
Add test cases that produce predictable signatures with fixed expiry times.

10 years agoPut back missing parentheses.
Tom Clegg [Thu, 1 May 2014 16:03:02 +0000 (12:03 -0400)]
Put back missing parentheses.

10 years agoAdd "show object" button partials.
Tom Clegg [Thu, 1 May 2014 15:51:57 +0000 (11:51 -0400)]
Add "show object" button partials.

10 years agoAdd "Shared with" section to Sharing/Permissions panel.
Tom Clegg [Thu, 1 May 2014 15:50:51 +0000 (11:50 -0400)]
Add "Shared with" section to Sharing/Permissions panel.

10 years agoChanged Log.all.each to Log.find_each because Log.all loads all records (!) and
Peter Amstutz [Thu, 1 May 2014 14:06:19 +0000 (10:06 -0400)]
Changed Log.all.each to Log.find_each because Log.all loads all records (!) and
Log.find_each loads records in batches.  Hopefully this will enable migration
to run without being killed.

10 years agoFixed middleware customization so that it doesn't assume the presence or
Peter Amstutz [Thu, 1 May 2014 12:49:11 +0000 (08:49 -0400)]
Fixed middleware customization so that it doesn't assume the presence or
location of ActionDispatch::Static.

10 years agoUpdate tests for new layout.
Tom Clegg [Thu, 1 May 2014 03:25:32 +0000 (23:25 -0400)]
Update tests for new layout.

10 years agoDo not return Links with group contents
Tom Clegg [Thu, 1 May 2014 03:24:49 +0000 (23:24 -0400)]
Do not return Links with group contents

10 years agoSynchronize "show more" button style, turn off cards for now
Tom Clegg [Wed, 30 Apr 2014 22:45:41 +0000 (18:45 -0400)]
Synchronize "show more" button style, turn off cards for now

10 years agoFocus/hover side navs with white instead of arbitrary color.
Tom Clegg [Wed, 30 Apr 2014 22:33:12 +0000 (18:33 -0400)]
Focus/hover side navs with white instead of arbitrary color.

10 years agoRender cards with real content from first few items.
Tom Clegg [Wed, 30 Apr 2014 22:32:18 +0000 (18:32 -0400)]
Render cards with real content from first few items.

10 years agoFix up table columns, use explicit Open button instead of linking uuid
Tom Clegg [Wed, 30 Apr 2014 22:22:28 +0000 (18:22 -0400)]
Fix up table columns, use explicit Open button instead of linking uuid

10 years agoAdd integration test for folders.
Tom Clegg [Wed, 30 Apr 2014 20:57:16 +0000 (16:57 -0400)]
Add integration test for folders.

10 years agoFix "show all activity".
Tom Clegg [Wed, 30 Apr 2014 20:56:18 +0000 (16:56 -0400)]
Fix "show all activity".

10 years agoLess side-nav padding.
Tom Clegg [Wed, 30 Apr 2014 20:56:05 +0000 (16:56 -0400)]
Less side-nav padding.

10 years agoMerge branch 'master' of git.clinicalfuture.com:arvados
Peter Amstutz [Wed, 30 Apr 2014 20:55:06 +0000 (16:55 -0400)]
Merge branch 'master' of git.clinicalfuture.com:arvados

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.