radhika chippada [Mon, 24 Mar 2014 13:02:04 +0000 (09:02 -0400)]
Merge branch 'master' into 2187-enhance-user-setup
radhika chippada [Mon, 24 Mar 2014 12:58:50 +0000 (08:58 -0400)]
Raise error if both uuid and user.email are omitted in input parameters
Tom Clegg [Mon, 24 Mar 2014 02:33:40 +0000 (22:33 -0400)]
Accept ...&filters=&... in query string as "none" instead of "unparseable JSON".
radhika chippada [Mon, 24 Mar 2014 01:17:26 +0000 (21:17 -0400)]
Raise ArgumentError when required openid_prefix is not passed.
radhika chippada [Sun, 23 Mar 2014 21:20:37 +0000 (17:20 -0400)]
Raise exceptions on errors such as 'All users' group does not exist and a vm for the vm_uuid param does not exist. Add additional functional tests and update previous tests accordingly.
radhika chippada [Sun, 23 Mar 2014 20:51:59 +0000 (16:51 -0400)]
Fix tabs in the test class
radhika chippada [Sun, 23 Mar 2014 20:37:56 +0000 (16:37 -0400)]
Make sure oid_login_perm exists when setup is executed for an existing user
radhika chippada [Sun, 23 Mar 2014 19:50:13 +0000 (15:50 -0400)]
Include all the newly created link objects in the response from the setup method. Update all functional tests to verify links found in teh response.
radhika chippada [Sun, 23 Mar 2014 03:44:04 +0000 (23:44 -0400)]
Repo name and VM are optional to the setup method
radhika chippada [Sun, 23 Mar 2014 02:59:32 +0000 (22:59 -0400)]
Render 404 if no user is found for the uuid provided
radhika chippada [Sun, 23 Mar 2014 00:21:12 +0000 (20:21 -0400)]
Expect openid_prefix from the clients instead of managing it on the api server.
Ward Vandewege [Sat, 22 Mar 2014 14:59:17 +0000 (10:59 -0400)]
API server: strip all arvados-specific settings from the .example
environment files. These are now all configured via
application(.defaults).yml
Ward Vandewege [Sat, 22 Mar 2014 14:32:24 +0000 (10:32 -0400)]
Fix link, this fixes bug 2403
Tom Clegg [Sat, 22 Mar 2014 02:14:46 +0000 (22:14 -0400)]
Fix textile formatting.
Tom Clegg [Sat, 22 Mar 2014 00:38:23 +0000 (20:38 -0400)]
Fix up README, convert to textile.
Peter Amstutz [Fri, 21 Mar 2014 20:51:39 +0000 (16:51 -0400)]
Fixed paging so that it won't fail if the necessary methods are missing on the results object.
radhika chippada [Fri, 21 Mar 2014 20:36:47 +0000 (16:36 -0400)]
Add negative functional tests where a non-admin user invokes create or setup actions
Ward Vandewege [Fri, 21 Mar 2014 20:16:35 +0000 (16:16 -0400)]
Typo.
radhika chippada [Fri, 21 Mar 2014 20:10:29 +0000 (16:10 -0400)]
One more print statement
radhika chippada [Fri, 21 Mar 2014 20:07:43 +0000 (16:07 -0400)]
Remove print statement
radhika chippada [Fri, 21 Mar 2014 20:05:37 +0000 (16:05 -0400)]
Pass openid_prefix to setup method only when -o option is used
Ward Vandewege [Fri, 21 Mar 2014 20:03:38 +0000 (16:03 -0400)]
Merge branch 'master' of git.curoverse.com:arvados
Ward Vandewege [Fri, 21 Mar 2014 20:02:29 +0000 (16:02 -0400)]
Strip all arvados-specific settings from the .example environment files.
These are now all configured via application(.defaults).yml
Peter Amstutz [Fri, 21 Mar 2014 20:02:03 +0000 (16:02 -0400)]
Fixed pipeline templates page that was broken by paging merge.
radhika chippada [Fri, 21 Mar 2014 19:46:57 +0000 (15:46 -0400)]
some more refactoring and attention to coding standards
Peter Amstutz [Fri, 21 Mar 2014 19:30:56 +0000 (15:30 -0400)]
Merge branch 'master' of git.clinicalfuture.com:arvados
Peter Amstutz [Fri, 21 Mar 2014 19:30:42 +0000 (15:30 -0400)]
Fixed syntax error typo. We need tests for crunch-dispatcher.rb!
radhika chippada [Fri, 21 Mar 2014 19:13:57 +0000 (15:13 -0400)]
All functional tests passing with refactored code.
Brett Smith [Fri, 21 Mar 2014 19:00:15 +0000 (15:00 -0400)]
workbench: Add developer docs.
This adds a new README with information that's useful for people who
want to develop Workbench. Right now it's just information about how
to run and write tests. We can add to this as we go.
Some of this information was pulled from the installation guide. I
also deleted Rails' stock README while I was at it.
Tom Clegg [Fri, 21 Mar 2014 18:44:58 +0000 (14:44 -0400)]
Merge branch '1750-use-supported-discovery-doc'
refs #1750
Peter Amstutz [Fri, 21 Mar 2014 17:02:28 +0000 (13:02 -0400)]
Merge branch 'master' of git.clinicalfuture.com:arvados
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
Peter Amstutz [Fri, 21 Mar 2014 16:57:04 +0000 (12:57 -0400)]
Merge branch 'master' of git.clinicalfuture.com:arvados
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
Tom Clegg [Fri, 21 Mar 2014 16:56:08 +0000 (12:56 -0400)]
Merge branch '2316-no-clear-tmp-flag'
closes #2316
refs #2372
Tom Clegg [Fri, 21 Mar 2014 16:55:29 +0000 (12:55 -0400)]
Merge branch 'master' into 2316-no-clear-tmp-flag
Tom Clegg [Fri, 21 Mar 2014 16:52:04 +0000 (12:52 -0400)]
Use the supported discovery document instead of the old schema#show shim.
Brett Smith [Fri, 21 Mar 2014 15:47:06 +0000 (11:47 -0400)]
workbench: Bundle integration env bugfix.
The previous version did not unpack arguments correctly.
Ward Vandewege [Fri, 21 Mar 2014 15:36:25 +0000 (11:36 -0400)]
When running with WEBrick, auto-generate a new self-signed SSL
certificate for each run, rather than hardcoding a path to a certificate
and key file.
Brett Smith [Fri, 21 Mar 2014 15:34:05 +0000 (11:34 -0400)]
workbench: Expound Bundle+integration interaction.
Unsurprisingly, I don't write my best code and comments when I'm
frantically trying to fix the build.
Brett Smith [Fri, 21 Mar 2014 15:16:14 +0000 (11:16 -0400)]
workbench: Make SERVER_PID_PATH a constant.
Brett Smith [Fri, 21 Mar 2014 15:12:53 +0000 (11:12 -0400)]
workbench: Tweak integration test environment.
RUBYLIB and RUBYOPT seem to be necessary on the build server.
Brett Smith [Fri, 21 Mar 2014 14:26:16 +0000 (10:26 -0400)]
workbench: Improve API server integration launch.
The previous version sometimes tried (and failed) to find the server
pid before rails wrote it. This provides some limited retry, and
avoids spawning a subshell too.
Brett Smith [Fri, 21 Mar 2014 14:25:26 +0000 (10:25 -0400)]
workbench: Improve integration test environment.
Removing too much from the environment causes builds to fail in
Jenkins. Instead of using a whitelist of environment variables, use a
blacklist of variables that Bundle modifies.
Peter Amstutz [Fri, 21 Mar 2014 14:25:19 +0000 (10:25 -0400)]
Fixes bug loading API tokens page.
Added test using our new workbench testing framework to make sure it doesn't happen again.
radhika chippada [Fri, 21 Mar 2014 13:15:01 +0000 (09:15 -0400)]
All tests passing
Brett Smith [Fri, 21 Mar 2014 13:05:29 +0000 (09:05 -0400)]
Merge branch '2288-integration-tests'
radhika chippada [Fri, 21 Mar 2014 03:32:22 +0000 (23:32 -0400)]
testing setup method implementation
radhika chippada [Fri, 21 Mar 2014 00:51:07 +0000 (20:51 -0400)]
Merge branch 'master' into 2187-enhance-user-setup
radhika chippada [Fri, 21 Mar 2014 00:49:14 +0000 (20:49 -0400)]
setup-new-user script using the setup method.
radhika chippada [Fri, 21 Mar 2014 00:06:07 +0000 (20:06 -0400)]
Use setup method instead of create method to setup a new user
Brett Smith [Thu, 20 Mar 2014 21:26:48 +0000 (17:26 -0400)]
workbench: Fix typo in application.default.yml.
Brett Smith [Thu, 20 Mar 2014 21:24:24 +0000 (17:24 -0400)]
workbench: Make integration test settings default.
We know that these settings should work out of the box, given the
settings in the API server's `rails` script. Making them the default
makes it easier to get the tests running.
Tom Clegg [Thu, 20 Mar 2014 21:23:43 +0000 (17:23 -0400)]
Use flock() to prevent sharing crunch-tmp with another job in local dev mode.
radhika chippada [Thu, 20 Mar 2014 21:03:31 +0000 (17:03 -0400)]
Update the functional tests to use the setup method
radhika chippada [Thu, 20 Mar 2014 20:07:48 +0000 (16:07 -0400)]
Introduce a new setup method in the users controller
Peter Amstutz [Thu, 20 Mar 2014 20:03:03 +0000 (16:03 -0400)]
Merge branch '2193-fix-permissions-cache' (no functional changes, only unit tests)
Peter Amstutz [Thu, 20 Mar 2014 19:38:24 +0000 (15:38 -0400)]
Merge branch '2278-crunch-dispatcher-monitor-processes'
Peter Amstutz [Thu, 20 Mar 2014 19:32:10 +0000 (15:32 -0400)]
Silly git staging.
Peter Amstutz [Thu, 20 Mar 2014 19:23:56 +0000 (15:23 -0400)]
- Made a note about intentionally not setting "success"
- Changed if c[:job][:success] == false to elsif
- Changed == nil to .nil?
- Removed whitespace
radhika chippada [Thu, 20 Mar 2014 15:07:24 +0000 (11:07 -0400)]
Use rails configuration for default openid prefix.
radhika chippada [Thu, 20 Mar 2014 14:19:01 +0000 (10:19 -0400)]
Merge branch 'master' into 2187-enhance-user-setup
radhika chippada [Wed, 19 Mar 2014 21:03:07 +0000 (17:03 -0400)]
Replace tabs with spaces as per our coding standards
radhika chippada [Wed, 19 Mar 2014 20:32:58 +0000 (16:32 -0400)]
Remove -n aka just probe option from the setup-new-user script as per Ward's core review recommendation.
radhika chippada [Wed, 19 Mar 2014 20:18:54 +0000 (16:18 -0400)]
Update comments in the tests
radhika chippada [Wed, 19 Mar 2014 18:59:17 +0000 (14:59 -0400)]
When create is invoked with user object as input, check if object exists for the given uuid or email.
Brett Smith [Wed, 19 Mar 2014 18:50:21 +0000 (14:50 -0400)]
workbench: Document integration test dependencies.
This adds appropriate notes to the installation guide, and suggestions
to application.yml.example.
Brett Smith [Wed, 19 Mar 2014 16:24:37 +0000 (12:24 -0400)]
workbench: Add basic login integration tests.
Brett Smith [Wed, 19 Mar 2014 16:10:51 +0000 (12:10 -0400)]
workbench: Add VM integration tests.
This is the "start test" that Ward suggested I implement to start off.
It's easy but not trivial: it requires JavaScript support and filling
out a form.
Brett Smith [Wed, 19 Mar 2014 16:09:51 +0000 (12:09 -0400)]
workbench: Use Poltergeist for integration tests.
This is faster and will enable us to run integration tests on the
build server.
PhantomJS (http://phantomjs.org/) has to be installed in the $PATH for
this to work.
Brett Smith [Wed, 19 Mar 2014 15:44:49 +0000 (11:44 -0400)]
workbench: Add integration test helper module.
This provide a base test class that provides the Capybara DSL and a
couple of convenience methods. It also specifies a test runner class
that sets up the API server consistently, with the proper environment.
radhika chippada [Wed, 19 Mar 2014 16:00:10 +0000 (12:00 -0400)]
When using user_param, the user object is not expected. If passed, it will be discarded.
Brett Smith [Wed, 19 Mar 2014 15:42:30 +0000 (11:42 -0400)]
workbench: Add Capybara gem for integration tests.
radhika chippada [Wed, 19 Mar 2014 15:12:53 +0000 (11:12 -0400)]
More asserts for links
radhika chippada [Wed, 19 Mar 2014 14:11:49 +0000 (10:11 -0400)]
remove hard coded uuids from tests
radhika chippada [Wed, 19 Mar 2014 13:59:24 +0000 (09:59 -0400)]
Some more refactoring
radhika chippada [Wed, 19 Mar 2014 01:53:37 +0000 (21:53 -0400)]
Remove force option
radhika chippada [Wed, 19 Mar 2014 01:29:11 +0000 (21:29 -0400)]
Functional tests to verify links
radhika chippada [Mon, 17 Mar 2014 21:21:36 +0000 (17:21 -0400)]
Added functional tests for controller updates
radhika chippada [Mon, 17 Mar 2014 19:00:45 +0000 (15:00 -0400)]
Fix a nil check
Brett Smith [Mon, 17 Mar 2014 18:48:02 +0000 (14:48 -0400)]
js: Add identifiers to X-Editable templates.
This gives the form elements name and id attributes, as appropriate.
This will make it easier for us to refer to them in integration tests.
radhika chippada [Mon, 17 Mar 2014 18:44:51 +0000 (14:44 -0400)]
Fix an error introduced elsewhere in the file.
radhika chippada [Mon, 17 Mar 2014 18:14:10 +0000 (14:14 -0400)]
A simplified version of setup_new_user.rb script, where all the create user and links logic is moved into users controller.
Peter Amstutz [Mon, 17 Mar 2014 17:49:06 +0000 (13:49 -0400)]
* Allow the system user to update job columns, even if the job is "locked"
* Once the job process completes, automatically mark "job.running = false" and set "job.finished_at" if not set
* Exclude jobs from the queue where the "success" field is already set
* Consider a pipeline to be failed if any of the component jobs are marked as failed
radhika chippada [Mon, 17 Mar 2014 17:14:41 +0000 (13:14 -0400)]
All links in place
Tom Clegg [Mon, 17 Mar 2014 16:56:57 +0000 (12:56 -0400)]
Use --no-clear-tmp flag to decide whether to remove of old temporary
directories, rather than deciding based on whether script_version is a
commit or a local directory.
radhika chippada [Mon, 17 Mar 2014 13:19:00 +0000 (09:19 -0400)]
Test just_probe and openid_prefix options
radhika chippada [Sun, 16 Mar 2014 19:54:11 +0000 (15:54 -0400)]
More accomplished
radhika chippada [Sun, 16 Mar 2014 02:15:04 +0000 (22:15 -0400)]
Merge branch 'master' into 2187-enhance-user-setup
radhika chippada [Sun, 16 Mar 2014 02:12:44 +0000 (22:12 -0400)]
create and some links tested
Peter Amstutz [Fri, 14 Mar 2014 21:05:18 +0000 (17:05 -0400)]
Integration test for permission links.
Peter Amstutz [Fri, 14 Mar 2014 17:57:40 +0000 (13:57 -0400)]
Merge remote-tracking branch 'origin/master' into 2075-workbench-paging
Conflicts:
services/api/app/controllers/arvados/v1/schema_controller.rb
Tom Clegg [Fri, 14 Mar 2014 17:42:20 +0000 (13:42 -0400)]
Merge branch '2257-inequality-conditions'
closes #2257
Tom Clegg [Fri, 14 Mar 2014 17:38:23 +0000 (13:38 -0400)]
Add "filters" param to discovery document, add deprecation note to
"where" param description.
Brett Smith [Fri, 14 Mar 2014 17:34:29 +0000 (13:34 -0400)]
api: Improve compute_node_domain handling.
The default value was causing test failures on my machine because the
ERB evaluated to an empty string. And we want to avoid this causing
any DNS lookups during tests. Now we make the default false (in line
with our other compute_node_* settings), and suggest a change in
application.yml.example to demonstrate how it should be set.
I also fixed up the example about compute_node_nameservers while I was
at it.
This closes #2351.
Tom Clegg [Fri, 14 Mar 2014 14:31:03 +0000 (10:31 -0400)]
Make integer attributes searchable, add test cases.
Tom Clegg [Fri, 14 Mar 2014 14:17:46 +0000 (10:17 -0400)]
Merge branch 'master' into 2257-inequality-conditions
Peter Amstutz [Fri, 14 Mar 2014 13:59:27 +0000 (09:59 -0400)]
Added "Displaying X of Y out of Z"
Improved links to adjacent pages
radhika chippada [Fri, 14 Mar 2014 10:46:09 +0000 (06:46 -0400)]
Merge branch 'master' into 2187-enhance-user-setup
radhika chippada [Fri, 14 Mar 2014 02:33:02 +0000 (22:33 -0400)]
WIP - update the create action in users controller to create user object and also create the links
Peter Amstutz [Thu, 13 Mar 2014 21:07:46 +0000 (17:07 -0400)]
* Added support for offset and limit query parameters (?limit=x&offset=y) to workbench index pages.
* Created _paging partial for rendering forward/backward/jump to page N
* Added paging to generic index page, index pages for collections, pipeline instances, pipeline templates, groups.
radhika chippada [Thu, 13 Mar 2014 20:05:13 +0000 (16:05 -0400)]
Add functional test to create a new user