Tom Clegg [Mon, 24 Aug 2020 15:23:18 +0000 (11:23 -0400)]
Merge branch '16535-s3'
refs #16535
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Ward Vandewege [Sun, 23 Aug 2020 19:06:44 +0000 (15:06 -0400)]
Fix more ineffassign warnings.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Sat, 22 Aug 2020 15:37:27 +0000 (11:37 -0400)]
Fix more ineffassign warnings.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Tom Clegg [Sat, 22 Aug 2020 01:54:54 +0000 (21:54 -0400)]
Merge branch '16723-kill-vs-requeue'
fixes #16723
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Tom Clegg [Fri, 21 Aug 2020 20:40:34 +0000 (16:40 -0400)]
Fix config key case.
refs #16314
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Tom Clegg [Fri, 21 Aug 2020 20:39:34 +0000 (16:39 -0400)]
Merge branch '16314-testuserdb'
refs #16314
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Tom Clegg [Fri, 21 Aug 2020 20:11:46 +0000 (16:11 -0400)]
16723: Fix stubPool KillContainer(): return false if not running.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Ward Vandewege [Fri, 21 Aug 2020 19:35:45 +0000 (15:35 -0400)]
Merge branch '16565-no-more-latest-docker-jobs-image'
closes #16565
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Fri, 21 Aug 2020 19:35:00 +0000 (15:35 -0400)]
16565: Merge branch 'master' into 16565-no-more-latest-docker-jobs-image
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Fri, 21 Aug 2020 19:29:45 +0000 (15:29 -0400)]
16723: fix test to reflect new stub instance name.
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Tom Clegg [Fri, 21 Aug 2020 15:30:04 +0000 (11:30 -0400)]
16723: Don't lock a requeued container while old crunch-runs exist.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Tom Clegg [Fri, 21 Aug 2020 15:24:50 +0000 (11:24 -0400)]
16723: Fail test if a crunch-run stub is killed before finishing.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Tom Clegg [Fri, 21 Aug 2020 14:42:49 +0000 (10:42 -0400)]
16723: Hold uuidLock in kill() to avoid racing with unlock+start.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Tom Clegg [Fri, 21 Aug 2020 14:38:25 +0000 (10:38 -0400)]
16723: Fix double-container-running bug in test stub.
Two parts:
1. Update state to Complete before crunch-run exits, not after.
2. Don't call the "crashed while running" hook from the test stub
unless changing state to Running actually succeeded.
Also, call the "crashed while running" hook from the test stub if
changing state from Running to Complete fails.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Tom Clegg [Fri, 21 Aug 2020 13:24:02 +0000 (09:24 -0400)]
16723: Use more readable instance IDs in tests.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Ward Vandewege [Fri, 21 Aug 2020 13:36:45 +0000 (09:36 -0400)]
Fix whitespace in run-tests.sh
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Tom Clegg [Fri, 21 Aug 2020 02:21:14 +0000 (22:21 -0400)]
16723: Reject invalid updates in API stub.
When dispatcher notices crunch-run has exited and the last known state
is Locked, it requeues the container. If crunch-run changed the
container state to Running before exiting (and dispatcher hasn't
noticed yet), dispatcher relies on RailsAPI/controller to reject the
requeue attempt.
Without this, the scheduler's state=Queued call was being accepted
even after losing a race to the stub's state=Running call,
occasionally causing a container to run twice and fail the randomized
simulation test.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Tom Clegg [Fri, 21 Aug 2020 01:34:40 +0000 (21:34 -0400)]
16723: Fix wrong operation shown in debug log.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Tom Clegg [Thu, 20 Aug 2020 20:24:19 +0000 (16:24 -0400)]
16535: Add S3 DeleteObject API.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Ward Vandewege [Thu, 20 Aug 2020 19:39:26 +0000 (15:39 -0400)]
Merge branch '16625-add-azure-managed-image-support'
refs #16625
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Thu, 20 Aug 2020 19:38:38 +0000 (15:38 -0400)]
16625: fix tests.
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Thu, 20 Aug 2020 17:36:22 +0000 (13:36 -0400)]
16625: a-d-c: add support for disk images in an Azure Shared Image
Gallery. Also make sure to clean up nics in every scenario where
Create errors out.
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Tom Clegg [Thu, 20 Aug 2020 14:32:41 +0000 (10:32 -0400)]
16314: Clean up long bool expressions.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Ward Vandewege [Thu, 20 Aug 2020 14:29:36 +0000 (10:29 -0400)]
Merge branch '16625-add-azure-managed-image-support'
refs #16625
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Thu, 20 Aug 2020 14:28:09 +0000 (10:28 -0400)]
16625: Merge branch 'master' into 16625-add-azure-managed-image-support
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Tom Clegg [Thu, 20 Aug 2020 14:26:29 +0000 (10:26 -0400)]
16314: Export Login.Test.Enable config.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Ward Vandewege [Wed, 19 Aug 2020 21:43:47 +0000 (17:43 -0400)]
16625: implement some more review feedback.
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Lucas Di Pentima [Wed, 19 Aug 2020 19:23:36 +0000 (16:23 -0300)]
Pins oj gem on arvados-cli to avoid asking for ruby >= 2.4.
No issue #
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Ward Vandewege [Wed, 19 Aug 2020 18:33:28 +0000 (14:33 -0400)]
Merge branch '15887-python-3-cookbook-fixes'
closes #15887
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Wed, 19 Aug 2020 16:58:58 +0000 (12:58 -0400)]
15887: fix Python cookbook snippets for Python 3
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Nico Cesar [Wed, 19 Aug 2020 15:58:31 +0000 (11:58 -0400)]
Merge branch '16698-debug-ports-arvbox' into master
closes #16698
Arvados-DCO-1.1-Signed-off-by: Nico Cesar <nico@curii.com>
Ward Vandewege [Wed, 19 Aug 2020 13:54:41 +0000 (09:54 -0400)]
16565: stop pushing the 'latest' tag for our arvados/jobs docker image
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Wed, 19 Aug 2020 13:16:07 +0000 (09:16 -0400)]
Actively remove initializers/omniauth.rb in our rails package for the
API server. It has been a dangling symlink for a long time, and Rails
5.2 is no longer forgiving of that.
refs #16470
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Wed, 19 Aug 2020 01:54:20 +0000 (21:54 -0400)]
Stop installing initializers/omniauth.rb in our rails package for the
API server. It has been a dangling symlink for a long time, and Rails
5.2 is no longer forgiving of that.
refs #16470
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Tom Clegg [Tue, 18 Aug 2020 20:47:15 +0000 (16:47 -0400)]
Merge branch '16535-s3'
refs #16535
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Tom Clegg [Tue, 18 Aug 2020 20:37:58 +0000 (16:37 -0400)]
16314: Support "Test" authentication type.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Ward Vandewege [Tue, 18 Aug 2020 20:08:21 +0000 (16:08 -0400)]
Stop building the python pam package, that code was removed.
refs #16580
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Tom Clegg [Tue, 18 Aug 2020 20:03:28 +0000 (16:03 -0400)]
16535: Update go.sum.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Tom Clegg [Tue, 18 Aug 2020 20:02:56 +0000 (16:02 -0400)]
16535: Merge branch 'master'
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Tom Clegg [Tue, 18 Aug 2020 19:34:28 +0000 (15:34 -0400)]
16535: Use package consts for http methods.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Tom Clegg [Tue, 18 Aug 2020 18:40:40 +0000 (14:40 -0400)]
16535: Return 400 instead of 500 when unable to mkdir.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Tom Clegg [Tue, 18 Aug 2020 18:35:12 +0000 (14:35 -0400)]
16535: Return "invalid arg" error when attempting mkdir in project.
Previously "not found" was returned, which was misleading.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Ward Vandewege [Tue, 18 Aug 2020 18:23:42 +0000 (14:23 -0400)]
Merge branch '16580-remove-python2-packages'
closes #16580
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Tue, 18 Aug 2020 18:22:52 +0000 (14:22 -0400)]
16580: Merge branch 'master' into 16580-remove-python2-packages
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Tue, 18 Aug 2020 17:18:23 +0000 (13:18 -0400)]
16625: implement review feedback.
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Lucas Di Pentima [Mon, 17 Aug 2020 19:48:31 +0000 (16:48 -0300)]
Merge branch '16470-api-rails-52'
Refs #16470
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Peter Amstutz [Mon, 17 Aug 2020 18:51:04 +0000 (14:51 -0400)]
Add link from upgrade notes to general release notes.
no issue #
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Lucas Di Pentima [Mon, 17 Aug 2020 17:38:06 +0000 (14:38 -0300)]
16470: Avoids crashing when running db:create in development mode.
The 'preload_all_models' initializer is now run even when db:create is
called, so it avoids the database to be created on arvbox, for example,
because it attempts to access the database before being created.
This initializer was added 7 years ago and it now seems to not be needed
anymore, so I think it's the cleaner way to resolve this issue.
See: https://github.com/rails/rails/issues/32870
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Ward Vandewege [Mon, 17 Aug 2020 15:32:12 +0000 (11:32 -0400)]
Merge branch '16631-add-test'
closes #16631
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Mon, 17 Aug 2020 15:30:06 +0000 (11:30 -0400)]
16631: Merge branch 'master' into 16631-add-test
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Tom Clegg [Mon, 17 Aug 2020 15:00:08 +0000 (11:00 -0400)]
Merge branch '16663-running-ctrs-unknown-workers'
fixes #16663
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Tom Clegg [Mon, 17 Aug 2020 14:53:16 +0000 (10:53 -0400)]
16631: Remove some unneeded code.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Nico Cesar [Mon, 17 Aug 2020 14:47:48 +0000 (10:47 -0400)]
Merge branch '15889-delete-traffic_test.py' into master
closes #15889
Arvados-DCO-1.1-Signed-off-by: Nico Cesar <nico@curii.com>
Ward Vandewege [Mon, 17 Aug 2020 14:32:31 +0000 (10:32 -0400)]
16580: remove more references to Nodemanager.
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Nico Cesar [Mon, 17 Aug 2020 14:26:14 +0000 (10:26 -0400)]
deleted services/keep/tools/traffic_test.py
refs #15889
Arvados-DCO-1.1-Signed-off-by: Nico Cesar <nico@curii.com>
Tom Clegg [Mon, 17 Aug 2020 14:17:28 +0000 (10:17 -0400)]
16663: Merge branch 'master'
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Tom Clegg [Mon, 17 Aug 2020 14:16:47 +0000 (10:16 -0400)]
16663: Add comments in racy test.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Ward Vandewege [Mon, 17 Aug 2020 02:27:59 +0000 (22:27 -0400)]
Fix more ineffassign warnings.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Sat, 15 Aug 2020 20:20:22 +0000 (16:20 -0400)]
16625: a-d-c: add support for Azure managed images. Update our packer
file for Azure compute images to generate those instead of the
old VHD images. Update documentation.
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Sat, 15 Aug 2020 02:22:44 +0000 (22:22 -0400)]
Fix more ineffassign warnings.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Peter Amstutz [Fri, 14 Aug 2020 19:54:16 +0000 (15:54 -0400)]
Merge branch '16683-fed-sharing' refs #16683
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Fri, 14 Aug 2020 16:07:56 +0000 (12:07 -0400)]
16683: Add test, remove useless check for PDH pattern
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Fri, 14 Aug 2020 13:57:53 +0000 (09:57 -0400)]
16683: Check that remote cluster id is presumed valid
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Thu, 13 Aug 2020 20:31:31 +0000 (16:31 -0400)]
16683: Revert behavior change, run gofmt
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Thu, 13 Aug 2020 19:22:49 +0000 (15:22 -0400)]
16683: Accept PDH for head_uuid/tail_uuid
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Ward Vandewege [Thu, 13 Aug 2020 18:49:22 +0000 (14:49 -0400)]
16580: remove libpam-arvados
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Thu, 13 Aug 2020 18:39:33 +0000 (14:39 -0400)]
16580: remove arvados-node-manager
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Thu, 13 Aug 2020 17:22:43 +0000 (13:22 -0400)]
16580: stop building python2 packages
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Peter Amstutz [Wed, 12 Aug 2020 21:32:06 +0000 (17:32 -0400)]
16683: Permit granting permissions to remote users
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Wed, 12 Aug 2020 20:20:19 +0000 (16:20 -0400)]
16683: Sharing dialog query is compatible with federated user list
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Wed, 12 Aug 2020 20:10:32 +0000 (16:10 -0400)]
16683: Set and check ForwardedFor on federated list requests
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Thu, 13 Aug 2020 16:44:29 +0000 (12:44 -0400)]
16683: Add checks related to sharing and remote users
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Nico Cesar [Wed, 12 Aug 2020 19:51:53 +0000 (15:51 -0400)]
16698: add debug ports to arvbox on public{dev,demo}
refs #16698
Arvados-DCO-1.1-Signed-off-by: Nico Cesar <nico@curii.com>
Ward Vandewege [Wed, 12 Aug 2020 14:19:07 +0000 (10:19 -0400)]
documentation: disable download buffering in our sample nginx config for
keep-web and keepproxy. This helps when the clients are far away/slow.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Mon, 10 Aug 2020 23:32:43 +0000 (19:32 -0400)]
Fix some ineffassign warnings.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Mon, 10 Aug 2020 23:11:00 +0000 (19:11 -0400)]
Fix typo.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Peter Amstutz [Mon, 10 Aug 2020 20:10:48 +0000 (16:10 -0400)]
Merge branch '16353-1.2-release' refs #16353
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Mon, 10 Aug 2020 20:09:35 +0000 (16:09 -0400)]
16353: Add a section "Upgrading your workflow to CWL v1.2"
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Mon, 10 Aug 2020 17:17:57 +0000 (13:17 -0400)]
16353: Update cwltool for stable 1.2
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Lucas Di Pentima [Fri, 7 Aug 2020 22:11:27 +0000 (19:11 -0300)]
16470: Discards changes before locking instead of reloading the record.
There's no need to make a database roundtrip, because all the old attribute
values are available.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Ward Vandewege [Fri, 7 Aug 2020 22:01:45 +0000 (18:01 -0400)]
16631: simplify test
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Lucas Di Pentima [Fri, 7 Aug 2020 15:09:14 +0000 (12:09 -0300)]
16470: Removes active storage config file, ammends secrets.yml file.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 6 Aug 2020 12:22:28 +0000 (09:22 -0300)]
16470: Don't explicitly reload before locking on CR updates.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 5 Aug 2020 13:38:04 +0000 (10:38 -0300)]
16470: Fixes unrelated typo.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Mon, 3 Aug 2020 22:24:00 +0000 (19:24 -0300)]
16470: Fixes collection versioning management code.
Collection versioning management is implemented on an 'around_update' callback
so some 'attribute_changed()' & 'changes()' calls changed behaviour depending
on which side of the 'yield' were made.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 31 Jul 2020 19:43:40 +0000 (16:43 -0300)]
16470: Avoids crashing when running the rake task db:create.
There was a behaviour change on rake tasks that avoided the creation of the
test database. All initializers are now called from rake tasks, so those
initializers with code accessing the database will fail when the database
isn't created.
See: https://github.com/rails/rails/issues/32870
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 31 Jul 2020 17:38:20 +0000 (14:38 -0300)]
16470: File updates & additions from 'rake rails:update'
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 28 Jul 2020 20:51:16 +0000 (17:51 -0300)]
16470: Fixes deprecation warning.
Explained at: https://github.com/rails/rails/pull/29619#issuecomment-
392583498
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 28 Jul 2020 20:40:09 +0000 (17:40 -0300)]
16470: Removes exception deprecated on rails 3.2
Its substitute is already being used.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 28 Jul 2020 19:54:22 +0000 (16:54 -0300)]
16470: Upgrades rails to 5.2
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 28 Jul 2020 19:16:29 +0000 (16:16 -0300)]
16470: Fixes false unpersisted status when retrieving a record with audit logs.
The cleanest solution I came up with is to flag the instance when it's
retrieved from the database, and reset any changes after stashing its
state on the log_start_state callback.
Haven't found a way to read the serialized attributes without making
them appear as changed, and I think it isn't possible because the
attributes have to be unserialized before the read operation, and thus
the dirty state machinery would assume the attribute may be modified.
This solution isn't ideal, but I think it's acceptable as it doesn't
make additional database requests.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 28 Jul 2020 16:55:50 +0000 (13:55 -0300)]
16470: Adds ArvadosModel test exposing a bug with audit logs.
When audit logs are enabled, fetching objects from models with serialized
attributes (for example: User or ContainerRequest) return an unpersisted
instance even if reload() is called on it.
This is a problem because from Rails 5.2, lock!() and with_lock() will raise
an exception when called on unpersisted instances.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 24 Jul 2020 14:47:16 +0000 (11:47 -0300)]
16470: Fixes test on user model.
Rails 5.1 deprecated the attr_changed? in favor of more explicit methods
because there was ambiguity when called from an 'after' or 'before' callback.
The test UsersTest#test_cannot_set_is_active_to_false_directly started failing
because User.setup is called from both types of callbacks, so its internal
checks weren't passing in some cases.
Also, avoids doing unnecessary queries to get the 'All users' group.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 23 Jul 2020 20:54:32 +0000 (17:54 -0300)]
16470: Changes the way of setting the callback that sets the DB timezone.
This avoids intermittent freezes when running tests.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Ward Vandewege [Thu, 6 Aug 2020 21:16:53 +0000 (17:16 -0400)]
16631: add test
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Tom Clegg [Wed, 5 Aug 2020 14:26:44 +0000 (10:26 -0400)]
16535: Require Content-Type application/x-directory for dir markers.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>
Lucas Di Pentima [Tue, 21 Jul 2020 14:18:24 +0000 (11:18 -0300)]
16470: Removes cleanup code on test. All threads share a db connection.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 21 Jul 2020 13:22:41 +0000 (10:22 -0300)]
16470: Removes unnecessary gem that may also cause issues.
The gem doesn't seem to be used anywhere and may not be needed
anymore.
See: https://github.com/rails/rails/issues/28197#issuecomment-
291120834
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Mon, 20 Jul 2020 14:40:38 +0000 (11:40 -0300)]
16470: Fixes reload() API to match the overridden function.
reload()'s documentation states: "...in addition to the in-place modification
the method returns self for convenience."
https://api.rubyonrails.org/v5.1.7/classes/ActiveRecord/Persistence.html#method-i-reload
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Mon, 20 Jul 2020 14:36:06 +0000 (11:36 -0300)]
16470: Avoids DB connection closing when running tests on missing places.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
projects / arvados.git / log