Ward Vandewege [Mon, 1 Feb 2021 19:03:01 +0000 (14:03 -0500)]
Documentation: add a default base_url to the Rakefile to simplify
running linkchecker.
refs #17245
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Mon, 1 Feb 2021 19:02:28 +0000 (14:02 -0500)]
Fix broken documentation links.
refs #17245
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Mon, 1 Feb 2021 14:09:01 +0000 (09:09 -0500)]
Merge branch '17255-document-can_login-permission'
closes #17255
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Mon, 1 Feb 2021 14:08:44 +0000 (09:08 -0500)]
17255: Merge branch 'master' into 17255-document-can_login-permission
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Mon, 1 Feb 2021 14:08:16 +0000 (09:08 -0500)]
Merge branch '17245-slurm-install-docs'
closes #17245
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Mon, 1 Feb 2021 14:07:37 +0000 (09:07 -0500)]
17245: Merge branch 'master' into 17245-slurm-install-docs
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Mon, 1 Feb 2021 14:06:28 +0000 (09:06 -0500)]
Fix tests after yesterday's golint warning fix.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Mon, 1 Feb 2021 01:13:55 +0000 (20:13 -0500)]
Fix golint warning.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Fri, 29 Jan 2021 22:02:57 +0000 (17:02 -0500)]
17255: Document the "can_login" permission link in the API section.
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Peter Amstutz [Fri, 29 Jan 2021 22:31:35 +0000 (17:31 -0500)]
Merge branch '17293-save-logs' refs #17293
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Ward Vandewege [Fri, 29 Jan 2021 21:17:52 +0000 (16:17 -0500)]
17245: documentation: remove unlinked pages.
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Peter Amstutz [Fri, 29 Jan 2021 20:54:41 +0000 (15:54 -0500)]
17293: Update trash_at/deleted_at even on MarshalManifest error
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Ward Vandewege [Fri, 29 Jan 2021 20:49:42 +0000 (15:49 -0500)]
17245: documenation: re-add a modified version of our Slurm
configuration page to the index. Re-organize the index a bit to
make the separation between cloud and Slurm dispatching more
obvious.
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Thu, 28 Jan 2021 00:36:49 +0000 (19:36 -0500)]
Documentation: reflect the current state of anonymous token generation.
refs #16726
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Wed, 27 Jan 2021 14:49:18 +0000 (09:49 -0500)]
Documentation: the Arvados SSO server is deprecated, it is not the
default anymore.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Tom Clegg [Tue, 26 Jan 2021 20:44:40 +0000 (15:44 -0500)]
Merge branch '16669-oidc-access-token'
refs #16669
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>
Nico Cesar [Tue, 26 Jan 2021 19:50:55 +0000 (14:50 -0500)]
Merge branch '17271-doc-cgroupv2'
closes #17271
Arvados-DCO-1.1-Signed-off-by: Nico Cesar <nico@curii.com>
Nico Cesar [Tue, 26 Jan 2021 16:20:52 +0000 (11:20 -0500)]
Doc update: Arvados 2.1 is not compatible with cgroups V2.
Arvados-DCO-1.1-Signed-off-by: Nico Cesar <nico@curii.com>
Tom Clegg [Tue, 26 Jan 2021 04:58:15 +0000 (23:58 -0500)]
16669: Test oidcTokenAuthorizer cache.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>
Tom Clegg [Mon, 25 Jan 2021 21:01:51 +0000 (16:01 -0500)]
16669: Fix cache bug.
When caching a valid token we were updating the database with
exp=now+10m but updating the cache with exp="". When checking the
cache, exp="" indicates we don't need to re-check the access token and
extend the database entry's expiry field -- so we never did, we just
passed through the HMAC, which RailsAPI rejected based on the expiry
time in the database row.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>
Peter Amstutz [Mon, 25 Jan 2021 20:26:54 +0000 (15:26 -0500)]
Add missing file closes #17281
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Mon, 25 Jan 2021 19:56:15 +0000 (14:56 -0500)]
Merge branch '17286-print-urls' refs #17286
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Mon, 25 Jan 2021 16:25:36 +0000 (11:25 -0500)]
17286: Tweak output if neither workbench2 or workbench1 is defined
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Ward Vandewege [Sun, 24 Jan 2021 18:50:48 +0000 (13:50 -0500)]
Fix ineffassign warning.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Peter Amstutz [Fri, 22 Jan 2021 20:48:12 +0000 (15:48 -0500)]
17286: URL to final output collection
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Fri, 22 Jan 2021 19:26:09 +0000 (14:26 -0500)]
17286: Log clickable URL to container request in workbench
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Ward Vandewege [Fri, 22 Jan 2021 17:29:07 +0000 (12:29 -0500)]
Make sure that our Python 3 based packages conflict with the older
Python 2 based ones.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Lucas Di Pentima [Fri, 22 Jan 2021 16:28:51 +0000 (13:28 -0300)]
Merge branch '17256-nodejs-dependency-update'
Refs #17256
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 21 Jan 2021 22:46:22 +0000 (19:46 -0300)]
17256: Changes required nodejs version on package building scripts.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Ward Vandewege [Thu, 21 Jan 2021 21:51:55 +0000 (16:51 -0500)]
Merge branch '17215-aws-roles-a-d-c'
closes #17215
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Thu, 21 Jan 2021 21:51:11 +0000 (16:51 -0500)]
17215: Merge branch 'master' into 17215-aws-roles-a-d-c
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Lucas Di Pentima [Thu, 21 Jan 2021 20:39:31 +0000 (17:39 -0300)]
17256: Makes arvados-server install to ask for node v10.x
This is to be able to run wb2 integration tests with Cypress v6.x
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Nico Cesar [Thu, 21 Jan 2021 19:55:22 +0000 (14:55 -0500)]
Merge branch '17014-controller-container-requests-take3'
closes #17014
Arvados-DCO-1.1-Signed-off-by: Nico Cesar <nico@curii.com>
Lucas Di Pentima [Thu, 21 Jan 2021 18:16:05 +0000 (15:16 -0300)]
Merge branch '17109-keepweb-urls-samesite-doc'
Closes #17109
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 21 Jan 2021 18:15:20 +0000 (15:15 -0300)]
17109: Fixes typo.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 21 Jan 2021 15:55:13 +0000 (12:55 -0300)]
17109: Explains how keep-web handles requests with tokens in the URL.
Adds a reference to the RFC that explains the Same-Site concept.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Nico Cesar [Thu, 21 Jan 2021 01:35:36 +0000 (20:35 -0500)]
addressing https://dev.arvados.org/issues/17014#note-41
Arvados-DCO-1.1-Signed-off-by: Nico Cesar <nico@curii.com>
Nico Cesar [Thu, 7 Jan 2021 16:23:21 +0000 (11:23 -0500)]
17014: controller handles container requests
This commit has:
* Container Requests in the new codepath
* runtime_constraints and scheduling parameters have now default
values and cannot be nil. This affects Railsapi CR comparison
in Final state
* Adapted Login and Logout so they work for CR
* Tests in lib/controller/integration_test.go that take in account
runtime_token with intermediate clusters
* Some tests in lib/controller/federation_test.go had to be addapted,
but for the most part remained as is to gurantee compatibilty
* Added the check that SystemRootToken has to be non-empty
* Railsapi fixtures that include finalized CR that are used in the tests to
make sure we return the right object
* Minimal changes in the documentation to reflect all the user visible
changes
* Added expires_at parameter for login and related test
Arvados-DCO-1.1-Signed-off-by: Nico Cesar <nico@curii.com>
Ward Vandewege [Wed, 20 Jan 2021 22:12:20 +0000 (17:12 -0500)]
Merge branch '17222-doc-add-keep-components-overview'
refs #17222
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Wed, 20 Jan 2021 22:11:28 +0000 (17:11 -0500)]
Merge branch 'master' into 17222-doc-add-keep-components-overview
refs #17222
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Wed, 20 Jan 2021 21:39:54 +0000 (16:39 -0500)]
17222: implement review feedback.
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Wed, 20 Jan 2021 21:16:11 +0000 (16:16 -0500)]
17215: add IAM role support to arvados-dispatch-cloud on EC2.
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Wed, 20 Jan 2021 18:38:20 +0000 (13:38 -0500)]
17222: add overview documentation for the components of Keep.
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Lucas Di Pentima [Wed, 20 Jan 2021 15:10:42 +0000 (12:10 -0300)]
Merge branch '16981-logincluster-sync-groups-tests'
Closes #16981
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Peter Amstutz [Tue, 19 Jan 2021 22:01:25 +0000 (17:01 -0500)]
Merge branch '17267-broken-schema-links' refs #17267
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Tue, 19 Jan 2021 21:39:30 +0000 (16:39 -0500)]
17267: Add integration test for broken link in $schemas
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Mon, 18 Jan 2021 19:36:07 +0000 (14:36 -0500)]
17267: Don't immediately fail if an extension schema is missing
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Lucas Di Pentima [Thu, 14 Jan 2021 20:00:16 +0000 (17:00 -0300)]
17109: Adds notes about Keep-web Same-Site restrictions.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Ward Vandewege [Wed, 13 Jan 2021 21:37:48 +0000 (16:37 -0500)]
Documentation: make the arvados-dispatch-cloud installation instructions
a bit more clear.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Mon, 11 Jan 2021 14:18:01 +0000 (09:18 -0500)]
Merge branch '16106-azure-spot-instance-support'
closes #16106
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Mon, 11 Jan 2021 14:17:32 +0000 (09:17 -0500)]
16106: Merge branch 'master' into 16106-azure-spot-instance-support
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Mon, 11 Jan 2021 14:16:58 +0000 (09:16 -0500)]
16106: address review comments.
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Lucas Di Pentima [Fri, 8 Jan 2021 21:59:51 +0000 (18:59 -0300)]
16981: Removes the import cycle issue by moving code to lib/boot.
As the code was really meant to be lib/boot helpers, instead of having
it on the arvadostest package, it's now on lib/boot/helper.go
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 8 Jan 2021 21:37:14 +0000 (18:37 -0300)]
16981: Removes config loader code to fix import cycle.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 8 Jan 2021 15:24:14 +0000 (12:24 -0300)]
16981: Adds federation test on sync-groups.
Makes sure that running the tool on a federated cluster with admin credentials
from the LoginCluster works correctly.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 7 Jan 2021 22:27:39 +0000 (19:27 -0300)]
Fixes a couple of typos on the documentation. No issue #.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Ward Vandewege [Thu, 7 Jan 2021 18:40:53 +0000 (13:40 -0500)]
16106: update Azure preemptible node code after real world testing. Add
documentation.
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Peter Amstutz [Thu, 7 Jan 2021 16:49:59 +0000 (11:49 -0500)]
Merge branch '17224-login-sync' refs #17224
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Wed, 6 Jan 2021 21:39:19 +0000 (16:39 -0500)]
17224: Document LoginCluster configuration for login-sync
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Ward Vandewege [Wed, 6 Jan 2021 19:46:06 +0000 (14:46 -0500)]
Documentation: fix typos.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Wed, 6 Jan 2021 14:52:13 +0000 (09:52 -0500)]
16106: Merge branch 'master' into 16106-azure-spot-instance-support
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Tom Clegg [Wed, 6 Jan 2021 14:45:14 +0000 (09:45 -0500)]
Merge branch '17175-boot-fail-rake-seed'
fixes #17175
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>
Lucas Di Pentima [Tue, 5 Jan 2021 20:40:27 +0000 (17:40 -0300)]
16981: Extracts test federation building code to the arvadostest package.
This is going to be reused on other integration test suites.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Ward Vandewege [Tue, 5 Jan 2021 17:51:26 +0000 (12:51 -0500)]
Fix typos in the documentation.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Peter Amstutz [Tue, 5 Jan 2021 16:43:03 +0000 (11:43 -0500)]
Merge branch '17225-ruby-sdk' refs #17225
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Ward Vandewege [Mon, 4 Jan 2021 20:12:25 +0000 (15:12 -0500)]
We now publish packages for Ubuntu Focal (20.04), and have stopped
publishing them for Ubuntu Xenial (16.04).
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Peter Amstutz [Wed, 23 Dec 2020 21:19:39 +0000 (16:19 -0500)]
17224: Provide alternate credentials to use for creating user tokens
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Sat, 2 Jan 2021 16:59:57 +0000 (11:59 -0500)]
17224: Fix to have multiple clients connected to separate clusters
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Tom Clegg [Mon, 28 Dec 2020 21:52:16 +0000 (16:52 -0500)]
Merge branch '17151-system-token-validation'
closes #17151
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>
Tom Clegg [Mon, 28 Dec 2020 20:33:33 +0000 (15:33 -0500)]
17175: Wait for seedDatabase before starting railsapi.
If the rake task and the app start concurrently, they both try to set
up the database seeds. The exclusive-locking mechanism in
services/api/app/lib/current_api_client.rb doesn't cover this case
because the rake task and app don't use the same cache. If the app
commits the database seeds between the rake task's "check existing"
and "commit" steps, commit fails and the rake task aborts.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>
Tom Clegg [Mon, 28 Dec 2020 20:21:04 +0000 (15:21 -0500)]
17175: Fix logging label for setuidgid-wrapped procs.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>
Javier Bértoli [Wed, 23 Dec 2020 21:15:34 +0000 (18:15 -0300)]
Merge branch '17218-update-apt-repos'
closes #17218
Arvados-DCO-1.1-Signed-off-by: Javier Bértoli <jbertoli@curii.com>
Javier Bértoli [Wed, 23 Dec 2020 20:57:03 +0000 (17:57 -0300)]
Update the provision script to use the new arvados-formula
ref #17218
Arvados-DCO-1.1-Signed-off-by: Javier Bértoli <jbertoli@curii.com>
Ward Vandewege [Wed, 23 Dec 2020 16:58:03 +0000 (11:58 -0500)]
Fix arvados-src package version generation.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Lucas Di Pentima [Wed, 23 Dec 2020 15:27:35 +0000 (12:27 -0300)]
Merge branch '17118-arvput-fix'
Closes #17118
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Ward Vandewege [Wed, 23 Dec 2020 02:16:41 +0000 (21:16 -0500)]
Fix detection of packages that were already built.
refs #17218
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Tue, 22 Dec 2020 22:10:27 +0000 (17:10 -0500)]
Merge branch '17218-repository-update'
closes #17218
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Tue, 22 Dec 2020 19:52:26 +0000 (14:52 -0500)]
We've made a change in the structure of our apt repositories.
refs #17218
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Lucas Di Pentima [Tue, 22 Dec 2020 15:41:01 +0000 (12:41 -0300)]
17118: Changes the way exception raising is done on PySDK's KeepWriterThread.
This solves the OOM bug where some keepstores fail when uploading data.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Ward Vandewege [Mon, 21 Dec 2020 02:55:19 +0000 (21:55 -0500)]
Fix a few staticcheck warnings.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Fri, 18 Dec 2020 22:55:50 +0000 (17:55 -0500)]
Fix a few more golint warnings.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Fri, 18 Dec 2020 02:38:02 +0000 (21:38 -0500)]
Fix another golint warning.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Tom Clegg [Tue, 15 Dec 2020 05:31:48 +0000 (00:31 -0500)]
Merge branch '17208-s3-signature-double-slash'
fixes #17208
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>
Ward Vandewege [Tue, 15 Dec 2020 00:42:44 +0000 (19:42 -0500)]
Fix a few more golint warnings.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Lucas Di Pentima [Mon, 14 Dec 2020 21:35:29 +0000 (18:35 -0300)]
Merge branch '17152-collection-preserve-version-changes'
Refs #17152
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Tom Clegg [Mon, 14 Dec 2020 20:41:33 +0000 (15:41 -0500)]
17208: Update test for s3cmd's new console output.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>
Lucas Di Pentima [Mon, 14 Dec 2020 13:31:14 +0000 (10:31 -0300)]
17152: Improves modified_at conditional update check.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Ward Vandewege [Sun, 13 Dec 2020 19:26:57 +0000 (14:26 -0500)]
Fix more golint warnings.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Ward Vandewege [Sat, 12 Dec 2020 20:09:48 +0000 (15:09 -0500)]
Fix more golint warnings.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Lucas Di Pentima [Fri, 11 Dec 2020 15:28:22 +0000 (12:28 -0300)]
17152: Moves conditional preserve_version disabling to collection's controller.
There was a bug that flipped preserve_version to false after creating a new
version even though the update request included preserve_version=true.
This happened because the logic was at model level, and was incorrect because
at that level we cannot know if the client included the attribute on its
request.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Tom Clegg [Fri, 11 Dec 2020 05:43:40 +0000 (00:43 -0500)]
17208: Add test case.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>
Tom Clegg [Fri, 11 Dec 2020 01:32:29 +0000 (20:32 -0500)]
17208: Merge branch 'master'
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>
Lucas Di Pentima [Thu, 10 Dec 2020 20:58:58 +0000 (17:58 -0300)]
17152: Avoids creating audit logs when only 'preserve_version' is updated.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 10 Dec 2020 19:53:49 +0000 (16:53 -0300)]
17152: Changes preserve_version semantics, updates related documentation.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 10 Dec 2020 19:04:52 +0000 (16:04 -0300)]
17152: Updates collection tests to reflect the new behavior.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 10 Dec 2020 19:04:05 +0000 (16:04 -0300)]
17152: Updates API revision number.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Tom Clegg [Thu, 10 Dec 2020 21:41:41 +0000 (16:41 -0500)]
17208: Use normalized path to compute signatures.
Transparently clean paths containing "//".
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>
Ward Vandewege [Thu, 10 Dec 2020 15:33:57 +0000 (10:33 -0500)]
Costanalyzer bugfix: when a collection uuid is supplied, write the csv
files with the name of the associated container request uuid, not the
collection uuid. Also change tests to use a proper temporary directory
for the outputs, and do not reuse that directory between tests (which
hid the bug this commit fixed).
refs #17187
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Tom Clegg [Wed, 9 Dec 2020 23:47:15 +0000 (18:47 -0500)]
Merge branch '17202-no-redir-crossorigin'
refs #17202
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>
Ward Vandewege [Wed, 9 Dec 2020 22:06:06 +0000 (17:06 -0500)]
Fix ineffassign warning.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>