arvados.git
9 years agoMerge branch 'master' into 4523-search-index
Radhika Chippada [Wed, 14 Jan 2015 18:12:22 +0000 (13:12 -0500)]
Merge branch 'master' into 4523-search-index

9 years ago4523: try to resolve column order by down and up migrations through VERSION=201408170...
Radhika Chippada [Wed, 14 Jan 2015 18:11:03 +0000 (13:11 -0500)]
4523: try to resolve column order by down and up migrations through VERSION=20140817035914

9 years ago4523: use filters instead of where for search
Radhika Chippada [Wed, 14 Jan 2015 18:06:21 +0000 (13:06 -0500)]
4523: use filters instead of where for search

9 years ago4523: check for a specific file name and stream names in file_names.
Radhika Chippada [Wed, 14 Jan 2015 17:54:41 +0000 (12:54 -0500)]
4523: check for a specific file name and stream names in file_names.

9 years agoPython packages use python-daemon<2.
Brett Smith [Wed, 14 Jan 2015 17:47:38 +0000 (12:47 -0500)]
Python packages use python-daemon<2.

It's good to see python-daemon under active development, but they're
working out so many little issues so rapidly that we're having a hard
time keeping on top of them in our builds.  We're pinning the version
until things settle down a little.  No issue #.

9 years ago4523: update migration script to use execute instead of update_sql so that output...
Radhika Chippada [Wed, 14 Jan 2015 16:24:20 +0000 (11:24 -0500)]
4523: update migration script to use execute instead of update_sql so that output is not printed to console.

9 years agoMerge branch 'master' into 4523-search-index
Radhika Chippada [Wed, 14 Jan 2015 16:15:33 +0000 (11:15 -0500)]
Merge branch 'master' into 4523-search-index

9 years agocloses #3756
Radhika Chippada [Wed, 14 Jan 2015 16:14:56 +0000 (11:14 -0500)]
closes #3756
Merge branch '3756-show-user-button'

9 years agoMerge branch 'master' into 3756-show-user-button
Radhika Chippada [Wed, 14 Jan 2015 16:13:49 +0000 (11:13 -0500)]
Merge branch 'master' into 3756-show-user-button

9 years agoMerge branch '4968-refresh-project-dir' closes #4968
Peter Amstutz [Tue, 13 Jan 2015 20:15:56 +0000 (15:15 -0500)]
Merge branch '4968-refresh-project-dir' closes #4968

9 years ago4523: update migrate script to use batch size and instance method on collection.
Radhika Chippada [Tue, 13 Jan 2015 18:39:29 +0000 (13:39 -0500)]
4523: update migrate script to use batch size and instance method on collection.

9 years agoMerge branch 'master' into 4523-search-index
Radhika Chippada [Tue, 13 Jan 2015 17:03:56 +0000 (12:03 -0500)]
Merge branch 'master' into 4523-search-index

9 years agoExplicitly specify ruby 2.1 in "rvm alias" no issue #
Peter Amstutz [Mon, 12 Jan 2015 21:56:09 +0000 (16:56 -0500)]
Explicitly specify ruby 2.1 in "rvm alias" no issue #

9 years ago4968: Fix polling refresh on project directories
Peter Amstutz [Fri, 9 Jan 2015 02:26:32 +0000 (21:26 -0500)]
4968: Fix polling refresh on project directories

9 years ago3756: do not show 'Show' button in admin user's own row.
Radhika Chippada [Mon, 12 Jan 2015 19:01:40 +0000 (14:01 -0500)]
3756: do not show 'Show' button in admin user's own row.

9 years agoMerge branch '4924-arv-edit-error-handling' closes #4924
Peter Amstutz [Mon, 12 Jan 2015 18:39:34 +0000 (13:39 -0500)]
Merge branch '4924-arv-edit-error-handling' closes #4924

9 years ago4924: Collapse JSON rescue blocks to reduce duplicate code.
Peter Amstutz [Mon, 12 Jan 2015 18:38:45 +0000 (13:38 -0500)]
4924: Collapse JSON rescue blocks to reduce duplicate code.

9 years ago4924: Update prints uuid from results, not the uuid originally specified.
Peter Amstutz [Mon, 12 Jan 2015 17:23:40 +0000 (12:23 -0500)]
4924: Update prints uuid from results, not the uuid originally specified.
Catch Oj::ParseError as well as JSON::ParserError.  Titleize only HTTP status
messages, not every error message.

9 years ago4924: Rename HTTPResponse to ArvadosAPIError. Use NET::HTTP Response titles
Peter Amstutz [Mon, 12 Jan 2015 15:33:36 +0000 (10:33 -0500)]
4924: Rename HTTPResponse to ArvadosAPIError.  Use NET::HTTP Response titles
for error codes if no other error is available.

9 years ago4523: revert test update now that text attributes in non-collections objects are...
Radhika Chippada [Sat, 10 Jan 2015 02:28:04 +0000 (21:28 -0500)]
4523: revert test update now that text attributes in non-collections objects are not omitted from search index.

9 years agoMerge branch 'master' into 4523-search-index
Radhika Chippada [Sat, 10 Jan 2015 02:07:06 +0000 (21:07 -0500)]
Merge branch 'master' into 4523-search-index

9 years ago4523: include stream names in file_names
Radhika Chippada [Fri, 9 Jan 2015 23:11:10 +0000 (18:11 -0500)]
4523: include stream names in file_names

9 years ago4523: exclude manifest_text from collection -> searchable_columns and leave the other...
Radhika Chippada [Fri, 9 Jan 2015 23:00:07 +0000 (18:00 -0500)]
4523: exclude manifest_text from collection -> searchable_columns and leave the other text columns for other objects.

9 years agoAdd a magic pseudoclass to body, instead of appending a magic div. Selenium seems...
Tom Clegg [Fri, 9 Jan 2015 22:46:15 +0000 (17:46 -0500)]
Add a magic pseudoclass to body, instead of appending a magic div. Selenium seems to like this better. refs #3021

9 years agoDiagnostics really do need selenium. refs #3021
Tom Clegg [Fri, 9 Jan 2015 22:45:23 +0000 (17:45 -0500)]
Diagnostics really do need selenium. refs #3021

9 years agoMake angular shim minify-safe. No issue #
Tom Clegg [Fri, 9 Jan 2015 22:09:28 +0000 (17:09 -0500)]
Make angular shim minify-safe. No issue #

9 years agoMerge branch 'master' into 4523-search-index
Radhika Chippada [Fri, 9 Jan 2015 21:49:36 +0000 (16:49 -0500)]
Merge branch 'master' into 4523-search-index

9 years ago4924: Distinguish between errors the user can do something about (syntax errors
Peter Amstutz [Fri, 9 Jan 2015 20:37:42 +0000 (15:37 -0500)]
4924: Distinguish between errors the user can do something about (syntax errors
or well-formed server errors) and errors that the user probably can't recover
from (everything else.)  Prints "Updated object" on success.

9 years ago4523: update migration script to use sql to set file_names
Radhika Chippada [Fri, 9 Jan 2015 02:51:14 +0000 (21:51 -0500)]
4523: update migration script to use sql to set file_names

9 years ago3021: Fix phantomjs races by waiting for pages to appear. refs #3021
Tom Clegg [Thu, 8 Jan 2015 21:22:40 +0000 (16:22 -0500)]
3021: Fix phantomjs races by waiting for pages to appear. refs #3021

9 years agoMerge branch '3408-go-sdk-api-errors' refs #3408
Tom Clegg [Thu, 8 Jan 2015 21:04:01 +0000 (16:04 -0500)]
Merge branch '3408-go-sdk-api-errors' refs #3408

9 years ago3408: Propagate API error messages to caller.
Tom Clegg [Thu, 8 Jan 2015 20:50:42 +0000 (15:50 -0500)]
3408: Propagate API error messages to caller.

9 years ago4523: slightly improved large description
Radhika Chippada [Thu, 8 Jan 2015 19:57:58 +0000 (14:57 -0500)]
4523: slightly improved large description

9 years agoMerge branch 'master' into 4523-search-index
Radhika Chippada [Thu, 8 Jan 2015 19:45:47 +0000 (14:45 -0500)]
Merge branch 'master' into 4523-search-index

9 years ago4523: add a few functional tests for collections with file_names testing.
Radhika Chippada [Thu, 8 Jan 2015 19:44:17 +0000 (14:44 -0500)]
4523: add a few functional tests for collections with file_names testing.

9 years agoMerge branch '4312-crunch-report-sdk-version' closes #4312
Peter Amstutz [Thu, 8 Jan 2015 18:49:05 +0000 (13:49 -0500)]
Merge branch '4312-crunch-report-sdk-version' closes #4312

9 years ago4312: Remove redundant parenthesis.
Peter Amstutz [Thu, 8 Jan 2015 18:48:42 +0000 (13:48 -0500)]
4312: Remove redundant parenthesis.

9 years ago4523: separate filename based tests and description based tests.
Radhika Chippada [Thu, 8 Jan 2015 18:01:36 +0000 (13:01 -0500)]
4523: separate filename based tests and description based tests.

9 years ago4924: Refactor arv edit and arv create to improve error handling.
Peter Amstutz [Thu, 8 Jan 2015 15:26:35 +0000 (10:26 -0500)]
4924: Refactor arv edit and arv create to improve error handling.

* Error messages are now added in a comment block at the top of the file, and
  the file is re-opened in the user's editor.
* Does not try to update attributes that are not changed.
* Exiting the editor with the file unchanged exits the editing loop.

9 years ago4312: Fix dpkg search to use dpkg-query.
Peter Amstutz [Wed, 7 Jan 2015 21:32:23 +0000 (16:32 -0500)]
4312: Fix dpkg search to use dpkg-query.

9 years ago4523: some more test assertions
Radhika Chippada [Wed, 7 Jan 2015 20:42:41 +0000 (15:42 -0500)]
4523: some more test assertions

9 years ago4312: Call virtualenv pip directly instead of using activate.
Peter Amstutz [Wed, 7 Jan 2015 19:51:16 +0000 (14:51 -0500)]
4312: Call virtualenv pip directly instead of using activate.

9 years ago4312: Use "install" phase of bootstrap script to report the installed versions
Peter Amstutz [Wed, 7 Jan 2015 19:38:41 +0000 (14:38 -0500)]
4312: Use "install" phase of bootstrap script to report the installed versions
of any arvados pip or debian packages.  Like virtualenv logic, only reports for
task 0 (since every task starts the same image).

9 years ago4523: exclude text type columns from searchable_columns for ilike operator
Radhika Chippada [Wed, 7 Jan 2015 19:27:00 +0000 (14:27 -0500)]
4523: exclude text type columns from searchable_columns for ilike operator

9 years agoMerge branch 'master' into 4523-search-index
Radhika Chippada [Wed, 7 Jan 2015 18:02:18 +0000 (13:02 -0500)]
Merge branch 'master' into 4523-search-index

9 years ago4523: add tests to search for file name
Radhika Chippada [Wed, 7 Jan 2015 17:59:26 +0000 (12:59 -0500)]
4523: add tests to search for file name

9 years agoMerge branch '3021-more-phantomjs' refs #3021
Tom Clegg [Wed, 7 Jan 2015 17:14:42 +0000 (12:14 -0500)]
Merge branch '3021-more-phantomjs' refs #3021

9 years ago3021: Use selenium to land on #Advanced tab.
Tom Clegg [Wed, 7 Jan 2015 17:13:51 +0000 (12:13 -0500)]
3021: Use selenium to land on #Advanced tab.

9 years ago3021: Merge branch 'master' into 3021-more-phantomjs
Tom Clegg [Wed, 7 Jan 2015 17:14:21 +0000 (12:14 -0500)]
3021: Merge branch 'master' into 3021-more-phantomjs

9 years ago3021: Add random part to magic string.
Tom Clegg [Wed, 7 Jan 2015 15:01:32 +0000 (10:01 -0500)]
3021: Add random part to magic string.

9 years agoMerge branch '4598-crunch-failure-stats'
Tim Pierce [Wed, 7 Jan 2015 14:46:10 +0000 (09:46 -0500)]
Merge branch '4598-crunch-failure-stats'

Fixes #4598.

9 years ago4598: actually rename this time
Tim Pierce [Wed, 7 Jan 2015 14:45:06 +0000 (09:45 -0500)]
4598: actually rename this time

PEBCAK failure led to deleting the file without staging the new one. d'oh.

9 years ago4598: rename script
Tim Pierce [Wed, 7 Jan 2015 14:43:56 +0000 (09:43 -0500)]
4598: rename script

Renamed crunch-failure-report.py to crunch_failure_report.py to permit
importing (and eventually testing).

9 years ago3021: Wait for shown.bs.modal before trying to click butttons in the modal.
Tom Clegg [Tue, 6 Jan 2015 22:48:42 +0000 (17:48 -0500)]
3021: Wait for shown.bs.modal before trying to click butttons in the modal.
Remove a stray Headless.new.start.

9 years ago4598: catch exceptions more aggressively when looking up pipeline names
Tim Pierce [Tue, 6 Jan 2015 21:21:10 +0000 (21:21 +0000)]
4598: catch exceptions more aggressively when looking up pipeline names

Added exception handling for cases where:
* job is not recorded as belonging to any pipeline instance
* pipeline instance has no pipeline template

9 years agoMerge branch '4570-multi-auth-method' refs #4570
Peter Amstutz [Tue, 6 Jan 2015 19:06:28 +0000 (14:06 -0500)]
Merge branch '4570-multi-auth-method' refs #4570

9 years ago3021: Fix assertion broken in 9c10212.
Tom Clegg [Tue, 6 Jan 2015 18:52:16 +0000 (13:52 -0500)]
3021: Fix assertion broken in 9c10212.

9 years ago4570: Fix tabs, CSS on log in button.
Peter Amstutz [Tue, 6 Jan 2015 18:24:06 +0000 (13:24 -0500)]
4570: Fix tabs, CSS on log in button.

9 years ago3021: Wait for dialog to close before asserting page transition.
Tom Clegg [Tue, 6 Jan 2015 17:26:49 +0000 (12:26 -0500)]
3021: Wait for dialog to close before asserting page transition.

9 years agoMerge branch '4836-first-tab-load-wip'
Brett Smith [Tue, 6 Jan 2015 17:12:27 +0000 (12:12 -0500)]
Merge branch '4836-first-tab-load-wip'

Closes #4836, #4870.

9 years ago4836: Trigger Workbench infinite scroll load on tab show.
Brett Smith [Fri, 19 Dec 2014 22:40:13 +0000 (17:40 -0500)]
4836: Trigger Workbench infinite scroll load on tab show.

If an infinite scroller is in the first tab of a show page, but the
user is going to a different tab, we'll queue up the first event
to load data for the container, but when it fires the container won't
be visible so it will decline to load anything.  Then you can only get
data to load if you resize the window.

Fire a scroll event when a new tab is shown, to spur the infinite
scroller to load data as appropriate.

9 years ago4598: account for queued and cancelled jobs, fix sorting
Tim Pierce [Tue, 6 Jan 2015 16:03:10 +0000 (11:03 -0500)]
4598: account for queued and cancelled jobs, fix sorting

Per code review:
* Updated report to include job states "Cancelled" and "Queued" as well
  as Failed, Running and Complete, and to take these into account when
  calculating job counts.
* Fixed sorting for failure classes.

9 years ago4523: Add test to create collection with large manifest text. This test showed that...
Radhika Chippada [Tue, 6 Jan 2015 15:48:26 +0000 (10:48 -0500)]
4523: Add test to create collection with large manifest text. This test showed that the max size
the file_names column can have for successful search indexing is 2^13. Hence, setting the column
size to 2^12, so that there is enough room to accommodate slightly larger values for other columns.

9 years ago4523: extract unique file names from manifest text and set as file_names attribute...
Radhika Chippada [Tue, 6 Jan 2015 14:36:49 +0000 (09:36 -0500)]
4523: extract unique file names from manifest text and set as file_names attribute during save.

9 years agoMerge branch 'master' into 4570-multi-auth-method
Peter Amstutz [Tue, 6 Jan 2015 13:45:08 +0000 (08:45 -0500)]
Merge branch 'master' into 4570-multi-auth-method

9 years ago4570: Revert to links on log in page instead of form. Fixup documentation to
Peter Amstutz [Tue, 6 Jan 2015 13:44:49 +0000 (08:44 -0500)]
4570: Revert to links on log in page instead of form.  Fixup documentation to
to describe a production setup.

9 years ago3021: Use headless helper in performance and diagnostics tests, too.
Tom Clegg [Tue, 6 Jan 2015 06:02:06 +0000 (01:02 -0500)]
3021: Use headless helper in performance and diagnostics tests, too.

9 years ago3021: 4399: Refactor headless stuff into a module. Clear up new/start/stop use.
Tom Clegg [Tue, 6 Jan 2015 05:59:02 +0000 (00:59 -0500)]
3021: 4399: Refactor headless stuff into a module. Clear up new/start/stop use.

* Create one Headless per test process, when encountering the first
  test case that needs one.

* Call headless.start & stop exactly once for each test case that uses
  it.

9 years ago4523: update the collection file_names migration script to set the file_names during...
Radhika Chippada [Tue, 6 Jan 2015 05:11:26 +0000 (00:11 -0500)]
4523: update the collection file_names migration script to set the file_names during migration.

9 years ago4523: add file_names searchable column to collections data model.
Radhika Chippada [Tue, 6 Jan 2015 01:25:33 +0000 (20:25 -0500)]
4523: add file_names searchable column to collections data model.

9 years ago4523: set description size back to 2**19
Radhika Chippada [Tue, 6 Jan 2015 01:05:10 +0000 (20:05 -0500)]
4523: set description size back to 2**19

9 years ago4523: set description size to 2**17, which seems to be the upper limit for indexing.
Radhika Chippada [Mon, 5 Jan 2015 21:36:31 +0000 (16:36 -0500)]
4523: set description size to 2**17, which seems to be the upper limit for indexing.

9 years ago4523: Come back down to earth enough to make tests pass.
Tom Clegg [Mon, 5 Jan 2015 20:02:54 +0000 (15:02 -0500)]
4523: Come back down to earth enough to make tests pass.

9 years ago4523: Restore indexes accidentally deleted from structure.sql.
Tom Clegg [Mon, 5 Jan 2015 19:40:00 +0000 (14:40 -0500)]
4523: Restore indexes accidentally deleted from structure.sql.

9 years ago4598: formatting and calculation fixes (code review)
Tim Pierce [Mon, 5 Jan 2015 19:22:47 +0000 (14:22 -0500)]
4598: formatting and calculation fixes (code review)

Incorporating code review feedback from #4598-13.

Bugs fixed:
* Correct counting and percentage calculation of job failures.
** Jobs were getting categorized as both "unknown" and as a specific failure type.
* Crashes fixed: should not raise any unhandled exceptions.

Formatting fixes:
* Itemized failures are now sorted in descending order by failure type
* Better horizontal alignment
* Modified formatting to account for updated description.

9 years agoMerge branch '4869-keepalive' refs #4869
Peter Amstutz [Mon, 5 Jan 2015 16:37:54 +0000 (11:37 -0500)]
Merge branch '4869-keepalive' refs #4869

9 years ago4523: Do not search :text fields at all.
Tom Clegg [Mon, 5 Jan 2015 15:34:01 +0000 (10:34 -0500)]
4523: Do not search :text fields at all.

9 years ago4523: Simplify migration.
Tom Clegg [Mon, 5 Jan 2015 15:31:15 +0000 (10:31 -0500)]
4523: Simplify migration.

9 years ago4523: Increase string length limit. (Postgres allows nearly 1MiB here, no need for...
Tom Clegg [Mon, 5 Jan 2015 15:30:58 +0000 (10:30 -0500)]
4523: Increase string length limit. (Postgres allows nearly 1MiB here, no need for a smaller limit.)

9 years ago4523: Description is not unsearchable after all.
Tom Clegg [Mon, 5 Jan 2015 15:29:44 +0000 (10:29 -0500)]
4523: Description is not unsearchable after all.

9 years ago4869: Client.Timeout and Client.Transport are now correctly set in
Peter Amstutz [Mon, 5 Jan 2015 15:17:42 +0000 (10:17 -0500)]
4869: Client.Timeout and Client.Transport are now correctly set in
DiscoverKeepServers().  Improved comments.

9 years ago4523: Merge branch '4523-search-index' of git.curoverse.com:arvados into 4523-search...
Tom Clegg [Mon, 5 Jan 2015 15:05:57 +0000 (10:05 -0500)]
4523: Merge branch '4523-search-index' of git.curoverse.com:arvados into 4523-search-index

Conflicts:
services/api/test/unit/arvados_model_test.rb

9 years agoMerge branch 'master' into 4523-search-index
Radhika Chippada [Mon, 5 Jan 2015 14:48:35 +0000 (09:48 -0500)]
Merge branch 'master' into 4523-search-index

Conflicts:
services/api/db/migrate/20141208164553_owner_uuid_index.rb
services/api/db/structure.sql
services/api/test/unit/arvados_model_test.rb

9 years ago3021: Clean up headless/selenium/javascript choices.
Tom Clegg [Sun, 4 Jan 2015 08:17:45 +0000 (03:17 -0500)]
3021: Clean up headless/selenium/javascript choices.

9 years ago3021: Skip angular init if angular is not loaded.
Tom Clegg [Sat, 3 Jan 2015 06:52:34 +0000 (01:52 -0500)]
3021: Skip angular init if angular is not loaded.

9 years ago3021: Silence "invalid regexp" errors while typing regexp; put input in "has-error...
Tom Clegg [Sat, 3 Jan 2015 03:20:59 +0000 (22:20 -0500)]
3021: Silence "invalid regexp" errors while typing regexp; put input in "has-error" state instead.

9 years ago3021: 4399: Convert some tests from selenium to phantomjs. Restart Headless less.
Tom Clegg [Fri, 2 Jan 2015 22:38:34 +0000 (17:38 -0500)]
3021: 4399: Convert some tests from selenium to phantomjs. Restart Headless less.

9 years agoRemove cruft. No issue #
Tom Clegg [Wed, 31 Dec 2014 21:33:57 +0000 (16:33 -0500)]
Remove cruft. No issue #

9 years agoMerge branch '4887-invalidate-duplicate-ip-on-old-compute-nodes'
Ward Vandewege [Wed, 31 Dec 2014 15:01:59 +0000 (10:01 -0500)]
Merge branch '4887-invalidate-duplicate-ip-on-old-compute-nodes'

closes #4887

9 years agoMerge branch 'master' into 4887-invalidate-duplicate-ip-on-old-compute-nodes
Ward Vandewege [Wed, 31 Dec 2014 15:01:30 +0000 (10:01 -0500)]
Merge branch 'master' into 4887-invalidate-duplicate-ip-on-old-compute-nodes

9 years agoAddress review comments:
Ward Vandewege [Wed, 31 Dec 2014 15:00:21 +0000 (10:00 -0500)]
Address review comments:

* change stale_conflicting_nodes to a local variable
* minor performance optimization: add an additional check for ip_address being nil

refs #4887

9 years agoMerge branch '4877-dont-delete-stdout'
Tim Pierce [Tue, 30 Dec 2014 21:50:04 +0000 (16:50 -0500)]
Merge branch '4877-dont-delete-stdout'

Fixes #4877

9 years ago4877: don't delete /dev/stdout
Tim Pierce [Tue, 30 Dec 2014 21:45:42 +0000 (16:45 -0500)]
4877: don't delete /dev/stdout

Fixed the filename check before trying to delete /dev/stdout.

9 years ago4598: added failure types and short names
Tim Pierce [Tue, 30 Dec 2014 21:07:02 +0000 (16:07 -0500)]
4598: added failure types and short names

Added the sys/docker failure type. Failures now reported by short
failure name rather than by regex.

9 years ago4598: remove more dev/debugging features.
Tim Pierce [Tue, 30 Dec 2014 19:48:59 +0000 (14:48 -0500)]
4598: remove more dev/debugging features.

9 years ago4598: take out some debug reporting and --match option
Tim Pierce [Tue, 30 Dec 2014 19:47:31 +0000 (14:47 -0500)]
4598: take out some debug reporting and --match option

Remove debugging features.

9 years ago4598: fetch logs from Keep, more failure reporting
Tim Pierce [Tue, 30 Dec 2014 19:42:28 +0000 (14:42 -0500)]
4598: fetch logs from Keep, more failure reporting

Per standup review: fetch logs with a CollectionReader on the log
collection uuid, rather than fetching log records from the API server.

Perform full failure reporting including job URL details.

9 years agoDetect stale compute node records with the same IP address as the new
Ward Vandewege [Tue, 30 Dec 2014 19:31:53 +0000 (14:31 -0500)]
Detect stale compute node records with the same IP address as the new
node on its first ping. Clear the ip_address field on the stale nodes.

Refs #4887

9 years agoCleanups:
Ward Vandewege [Tue, 30 Dec 2014 18:28:57 +0000 (13:28 -0500)]
Cleanups:

* Remove old commented out code
* Remove superfluous test for presence of file on disk

refs #4887

9 years ago4598: bug fixes, added full stats collection
Tim Pierce [Tue, 30 Dec 2014 16:00:51 +0000 (11:00 -0500)]
4598: bug fixes, added full stats collection

Added code to report full stats on failed, successful, and incomplete
jobs.  Perform basic reporting on failed job causes (not yet working).