Lucas Di Pentima [Thu, 3 Dec 2020 21:58:22 +0000 (18:58 -0300)]
17152: Adjusts the collection service methods to preserve versions.
As the create() method sets preserve_version to true, it's better
to re-set it to true after each update, so that the modified_at timestamp
of the previous version doesn't change.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 2 Dec 2020 13:37:28 +0000 (10:37 -0300)]
Merge branch '17098-old-version-as-head'
Closes #17098
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 1 Dec 2020 21:26:32 +0000 (18:26 -0300)]
17098: Improves wording on the "Restore version" action.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 1 Dec 2020 13:27:16 +0000 (10:27 -0300)]
17098: Improves dialog message wording.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Mon, 30 Nov 2020 23:13:10 +0000 (20:13 -0300)]
17098: Adds confirmation dialog on 'Recover version' action.
Also updates integeration test.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Fri, 27 Nov 2020 19:00:19 +0000 (20:00 +0100)]
Merge branch '17114-side-panel-tree-as-list'
Refs #17114
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Thu, 26 Nov 2020 20:30:26 +0000 (21:30 +0100)]
17114: Code cleanup
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Wed, 25 Nov 2020 19:05:00 +0000 (16:05 -0300)]
17098: Removes unnecessary prop.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 25 Nov 2020 17:54:07 +0000 (14:54 -0300)]
17098: Adjusts resourceUuidToContextMenuKind() call on version browser.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 25 Nov 2020 17:53:29 +0000 (14:53 -0300)]
17098: Merge branch 'master' into 17098-old-version-as-head
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 25 Nov 2020 17:31:29 +0000 (14:31 -0300)]
Merge branch '13494-collection-version-browser'
Closes #13494
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 25 Nov 2020 16:25:17 +0000 (13:25 -0300)]
17098: Updates integration test for the 'recover version' operation.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 25 Nov 2020 16:08:19 +0000 (13:08 -0300)]
17098: Avoids offering the 'Add to favorites' action on old versions.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 25 Nov 2020 15:19:02 +0000 (12:19 -0300)]
17098: Adds integration test checks for the new action.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 25 Nov 2020 15:00:59 +0000 (12:00 -0300)]
17098: Fixes unit test for refactored menu kind function.
Added 'redux-mock-store' package that will allow us to unit test dispatched
actions.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Tue, 24 Nov 2020 22:04:10 +0000 (23:04 +0100)]
17114: FlatTree introduced to support old behaviour
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Tue, 24 Nov 2020 20:02:54 +0000 (17:02 -0300)]
13494: Adds context menu support to collection versions browser.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Tue, 24 Nov 2020 17:04:31 +0000 (18:04 +0100)]
17114: Code cleanup, style cleanup
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>01~
Lucas Di Pentima [Mon, 23 Nov 2020 22:38:16 +0000 (19:38 -0300)]
17098: Adds ability to recover an old version collection as the head version.
This includes a proper menu action set for old collections with the new action.
Also, duplicated code was removed for the collection admin menu action set.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Mon, 23 Nov 2020 22:22:22 +0000 (19:22 -0300)]
17098: Refactors context menu's kind decision function.
Over time, the function got several optional arguments that were mostly
intrinsic of the resource being queried, or the user type. This produced lot
of duplicated and error prone code on the caller's side.
Now, all callers only need to provide a uuid, the will get the same result.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Mon, 23 Nov 2020 16:08:18 +0000 (13:08 -0300)]
17098: Removes unused code file.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 20 Nov 2020 22:22:47 +0000 (19:22 -0300)]
13494: Re-activates other collection related tests.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 20 Nov 2020 21:54:38 +0000 (18:54 -0300)]
13494: Adds integration test for collection version browsing.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 20 Nov 2020 18:07:04 +0000 (15:07 -0300)]
13494: Forces complete collection panel reload on after file operations.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Thu, 19 Nov 2020 23:31:11 +0000 (00:31 +0100)]
17114: Replaced tree with list for children items
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Thu, 19 Nov 2020 19:17:59 +0000 (16:17 -0300)]
13494: Adds explaining tooltip to version number link on collection panel.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 19 Nov 2020 16:13:06 +0000 (13:13 -0300)]
13494: Fixes another integration test check.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 19 Nov 2020 13:48:49 +0000 (10:48 -0300)]
13494: Fixes integration test.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 18 Nov 2020 21:46:21 +0000 (18:46 -0300)]
13494: Makes several operations asynchronous.
Details panel's collection version browser refresh, property addition and
removal, file renaming and removal are now asynchronous.
Also, the details panel gets reloaded when this collection operations take
place.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 18 Nov 2020 21:43:45 +0000 (18:43 -0300)]
13494: Simplifies collection update action calling.
Also makes action asynchronous, and refresh details panel after the update
operation is done.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 18 Nov 2020 21:41:43 +0000 (18:41 -0300)]
13494: Avoids doing unnecessary API requests on collection's move action.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 18 Nov 2020 21:39:58 +0000 (18:39 -0300)]
13494: Fixes multi-value property removal.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 18 Nov 2020 18:21:23 +0000 (15:21 -0300)]
13494: Adds version number on collection's status renderer.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 18 Nov 2020 15:19:35 +0000 (12:19 -0300)]
13494: Enhances collection versions browser's layout.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 18 Nov 2020 14:30:48 +0000 (11:30 -0300)]
13494: Avoids unnecessary details panel re-renders.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 17 Nov 2020 15:25:42 +0000 (12:25 -0300)]
13494: Maintains 'Head version' data on the collection panel.
This is to avoid the rest of the information changing places on the panel.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 13 Nov 2020 22:50:04 +0000 (19:50 -0300)]
13494: Allows the user to open the versions tab by clicking on the version nr.
This is done by syncing the details panel component state with the general app
state where we currently store the active tab number.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 13 Nov 2020 19:54:35 +0000 (16:54 -0300)]
13494: Forces version list retrieval when details panel is toggled on.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 13 Nov 2020 18:16:19 +0000 (15:16 -0300)]
13494: Adds content to the "versions" tab on collection's details panel.
Old versions are requested only when the details panel is open.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 12 Nov 2020 19:51:00 +0000 (16:51 -0300)]
13494: Merge branch 'master' into 13494-collection-version-browser
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 12 Nov 2020 19:32:07 +0000 (16:32 -0300)]
Merge branch '15685-file-renaming-empty-name'
Closes #15685
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 12 Nov 2020 19:31:01 +0000 (16:31 -0300)]
15685: Adds missing redux-form configs for immediate validation feedback.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 12 Nov 2020 19:14:07 +0000 (16:14 -0300)]
15685: Adds validations to file names to avoid '.' and '..'
Although the backend already does validations, this will provide a better UX
because of the immediate feedback and better error message.
Also, adjusted tests.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 12 Nov 2020 19:11:54 +0000 (16:11 -0300)]
15685: Sets dialog forms to get immediate validation feedback.
Surprinsingly, this setting is off by default:
https://redux-form.com/7.4.2/docs/api/reduxform.md/#-code-touchonchange-boolean-code-optional-
...so validations only happened after the first field blur event.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Thu, 12 Nov 2020 17:12:56 +0000 (18:12 +0100)]
Merge branch '16005-collections-projects-open-in-new-tab'
closes #16005
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Thu, 12 Nov 2020 17:11:38 +0000 (18:11 +0100)]
16005: Removed unused functions
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Thu, 12 Nov 2020 17:02:37 +0000 (18:02 +0100)]
Merge branch '17101-login-doesnt-navigate-user-back-to-original-path'
closes #17101
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Thu, 12 Nov 2020 15:27:24 +0000 (12:27 -0300)]
13494: Fixes edge case on file size formatter.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 12 Nov 2020 15:24:54 +0000 (12:24 -0300)]
13494: Sets "owner" column off by default on different panels.
Also adds the column to "Public favorites" panel, but keep it off by default.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 12 Nov 2020 00:44:29 +0000 (21:44 -0300)]
15685: Fixed a rename test case that shouldn't be allowed on WB2.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 12 Nov 2020 00:12:43 +0000 (21:12 -0300)]
15685: Adds integration tests, fixes rename dialog error reporting.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 11 Nov 2020 21:46:47 +0000 (18:46 -0300)]
15685: Cleans up tests with example data.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Peter Amstutz [Wed, 11 Nov 2020 21:33:12 +0000 (16:33 -0500)]
17101: Use redux router instead of setting window.location.href
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Lucas Di Pentima [Wed, 11 Nov 2020 21:25:45 +0000 (18:25 -0300)]
15685: Adds empty dir name validation to rename file dialog.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 11 Nov 2020 21:10:28 +0000 (18:10 -0300)]
15685: Adds file path validation on rename file dialog.
Also, allows edition of the complete path instead of just the name, to mnatch
workbench1 behavior, enabling the user to move the file to a directory inside
the collection.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 11 Nov 2020 21:08:17 +0000 (18:08 -0300)]
15685: Removes unused code.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Wed, 11 Nov 2020 14:56:47 +0000 (15:56 +0100)]
16005: Copy to clipboard url fix
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Fri, 6 Nov 2020 21:15:21 +0000 (22:15 +0100)]
16005: Open collection and project in new tab feature added
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>1~
Daniel Kutyła [Wed, 11 Nov 2020 09:16:59 +0000 (10:16 +0100)]
17101: Persisting url before the login process
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Wed, 11 Nov 2020 08:08:36 +0000 (09:08 +0100)]
Merge branch '17096-collection-objects-downloaded-multiple-times'
closes #17096
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Tue, 10 Nov 2020 17:37:59 +0000 (14:37 -0300)]
13493: Merge branch 'master' into 13494-collection-version-browser
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 10 Nov 2020 15:58:15 +0000 (12:58 -0300)]
15685: Fixes file name encoding/decoding handling on webdav.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 10 Nov 2020 15:57:28 +0000 (12:57 -0300)]
15685: Expands file renaming tests exposing some edge cases.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Mon, 9 Nov 2020 16:39:54 +0000 (17:39 +0100)]
Merge remote-tracking branch 'origin/master' into 17096-collection-objects-downloaded-multiple-times
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Mon, 9 Nov 2020 15:31:48 +0000 (16:31 +0100)]
17096: Added check if collection data is present
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>1~
Ward Vandewege [Sat, 7 Nov 2020 15:31:17 +0000 (10:31 -0500)]
Add ubuntu2004 packages, remove debian9 packages.
refs #17086
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
Lucas Di Pentima [Fri, 6 Nov 2020 16:01:44 +0000 (13:01 -0300)]
15685: Merge branch 'master' into 15685-file-renaming-empty-name
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 6 Nov 2020 15:33:02 +0000 (12:33 -0300)]
15685: Fixes unneeded Math.floor() calls on some tests that need random numbers.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 5 Nov 2020 22:51:28 +0000 (19:51 -0300)]
Merge branch '17018-readonly-file-actions-fix'
Closes #17018
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 5 Nov 2020 22:40:12 +0000 (19:40 -0300)]
Merge branch '16719-collection-version-basic-ui'
Closes #16719
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 5 Nov 2020 22:16:33 +0000 (19:16 -0300)]
16719: Don't try to click something to force logout, just reload the page.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 5 Nov 2020 21:45:00 +0000 (18:45 -0300)]
16719: Fixes random test failures.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 5 Nov 2020 16:25:20 +0000 (13:25 -0300)]
16719: Renames test suite.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 5 Nov 2020 14:14:01 +0000 (11:14 -0300)]
16719: Merge branch '16719-collection-version-basic-ui' of git.arvados.org:arvados-workbench2 into 16719-collection-version-basic-ui
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Peter Amstutz [Thu, 5 Nov 2020 04:32:52 +0000 (23:32 -0500)]
16719: Revise layout for collection panel.
Use responsive two-column layout.
Stack label and value instead of side-by-side.
Fix styling of "Copy to clipboard" icon.
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Lucas Di Pentima [Fri, 23 Oct 2020 15:17:31 +0000 (12:17 -0300)]
17018: Fixes the bug adding checks for readonly context menu type.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 23 Oct 2020 14:01:27 +0000 (11:01 -0300)]
17018: Adds integration tests exposing the bug.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 22 Oct 2020 23:22:56 +0000 (20:22 -0300)]
15685: Avoids the webdav service to report server error responses as success.
This makes the rename file dialog code to report errors correctly.
Probably will fix other file managing issues.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 22 Oct 2020 23:20:01 +0000 (20:20 -0300)]
15685: Adds integration tests for file renaming.
Exposes the bug of not displaying an error when trying to rename a file
to an illegal name (like empty string).
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Wed, 21 Oct 2020 14:51:21 +0000 (16:51 +0200)]
Merge branch '17019-token-visible-within-test'
Closes #17019
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Wed, 21 Oct 2020 14:15:00 +0000 (16:15 +0200)]
17019: replaced domain and cluster with fake data
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Wed, 21 Oct 2020 09:08:35 +0000 (11:08 +0200)]
17019: replaced token with fake data
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Tue, 20 Oct 2020 21:42:30 +0000 (18:42 -0300)]
16719: Removes console debug message.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 20 Oct 2020 21:32:23 +0000 (18:32 -0300)]
16719: Merge branch 'master' into 16719-collection-version-basic-ui
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Mon, 19 Oct 2020 16:44:05 +0000 (13:44 -0300)]
13494: Refactors detail panel. Removes unused 'Size' field.
Detail panel now doesn't have a disabled 'Activity' tab that wasn't used
by anything. Instead, it can be customized to have any number of tabs
in addition to the default 'Details' tab.
This lays the ground for the new collection panel's Versions tab.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Mon, 19 Oct 2020 15:01:46 +0000 (12:01 -0300)]
13494: Minor UI fixes.
* Removes useless 'Size' field on the collections detail pane.
* Adds version number field.
* Avoids event propagation on the collection icon so that when clicked it
just opens the detail pane without collapsing the info pane.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Mon, 19 Oct 2020 14:14:58 +0000 (11:14 -0300)]
13494: Adds ability to customize the search label on DataExplorer.
Also, fixed DataExplorer's default search label as it was showing
'Search files' on wrong contexts (ie: Projects panel).
Also, hides the search feature on the Collection PDH panel, as it doesn't
make sense to search for files on different collections with identical
contents, and also kind of gets stuck when searching for collection names
and having one result, the panel auto navigates to the collection panel.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 16 Oct 2020 14:04:53 +0000 (11:04 -0300)]
13494: Shows correct collection icon on DataTables.
Also, adds 'Status' column on collection by PDH panel, consistently with
the search results listings.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 15 Oct 2020 21:05:55 +0000 (18:05 -0300)]
13494: Allows accesing old collections versions through PDH.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 20 Oct 2020 20:16:00 +0000 (17:16 -0300)]
16719: Deduplicates collection detail component.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Tue, 20 Oct 2020 14:46:07 +0000 (16:46 +0200)]
Merge branch '16812-token-appears-in-the-download-URL'
Closes #16812
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Tue, 20 Oct 2020 14:39:35 +0000 (11:39 -0300)]
16719: Enhances collection panel.
* 'More options' menu renamed to 'Actions' and moved to the top.
* 'This is an old version' warning moved to the bottom.
* Condensed layout makes the main panel to take less vertical space.
* Added attributes: version, created_at, modified_at.
* Reworded some attribute labels on past versions.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 20 Oct 2020 13:27:21 +0000 (10:27 -0300)]
16719: Changes wording from 'Copy to project' to 'Make a copy' on collections.
Also, removed duplicated code about context menus.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Mon, 19 Oct 2020 21:00:48 +0000 (18:00 -0300)]
Merge branch '16718-past-collection-versions-search'
Closes #16718
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Mon, 19 Oct 2020 19:37:24 +0000 (21:37 +0200)]
16812: Cleared token code
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Sun, 18 Oct 2020 22:20:11 +0000 (00:20 +0200)]
16812: Fixed failed tests
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Sun, 18 Oct 2020 22:11:38 +0000 (00:11 +0200)]
Merge branch '16812-token-appears-in-the-download-URL' of git.arvados.org:arvados-workbench2 into 16812-token-appears-in-the-download-URL
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Sun, 18 Oct 2020 14:03:00 +0000 (16:03 +0200)]
16812: Reverted changes in download action, fixed keep links
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Sun, 18 Oct 2020 14:03:00 +0000 (16:03 +0200)]
16812: Reverted changes in download action, fixed keep links
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Peter Amstutz [Thu, 15 Oct 2020 21:21:27 +0000 (17:21 -0400)]
16812: Handoff token using query param
Need to pass the token to keep-web without it being "sticky" in the
URL bar. Using a query param accomplishes this, because keep-web
knows to strip the api_token query parameter and respond with redirect
and a cookie which the browser can use to fetch the file safely.
Also distinguish between KeepWebService (now the download service) and
KeepWebInlineService (the one that will serve content that can be
displayed inline in the browser if it is safe to do so).
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
projects / arvados.git / log