Tim Pierce [Thu, 3 Jul 2014 15:45:47 +0000 (11:45 -0400)]
Merge branch '2873-permission-links-ownership'
Closes #2873. Huzzah!
Tim Pierce [Thu, 3 Jul 2014 15:38:32 +0000 (11:38 -0400)]
Merge branch '2985-shared-projects-descriptions'
Refs #2985, closes #3083, closes #3158.
Peter Amstutz [Thu, 3 Jul 2014 15:31:01 +0000 (11:31 -0400)]
Update arvados-cli dependency of API server so crunch-dispatch.rb uses
arv-run-pipeline-instance from commit:
c806ef1
no issue #
Ward Vandewege [Thu, 3 Jul 2014 15:03:09 +0000 (11:03 -0400)]
docker: mkimage-debootstrap.sh: wrap which calls that are expected to
fail in a set +e/set -e block
no issue #
Peter Amstutz [Thu, 3 Jul 2014 14:53:53 +0000 (10:53 -0400)]
"filters" is now propagated through from pipeline component to the job
submission. Also added example filter to documentation. no issue #
Tim Pierce [Thu, 3 Jul 2014 01:24:32 +0000 (21:24 -0400)]
2873: more code review changes
* get_permissions sets @offset and @limit explicitly to ensure that
render_list does the right thing.
* Tests updated to use permission links on Groups (permissions are not
yet working for other objects)
* Added tests for "uuid exists but is unreadable" and "uuid is readable
but not manageable"
Refs #2873.
Tim Pierce [Wed, 2 Jul 2014 19:15:20 +0000 (15:15 -0400)]
2985: display project descriptions inline
Project descriptions in the "My Projects" and "Projects shared with
me" panels are displayed inline next to the project name, not in a
tooltip.
Refs #2985, refs #3083.
Tim Pierce [Wed, 2 Jul 2014 18:07:06 +0000 (14:07 -0400)]
Merge branch '3151-permission-ttl'
Closes #3151.
Tim Pierce [Wed, 2 Jul 2014 18:02:56 +0000 (14:02 -0400)]
3151: use 2-week default permission TTL
Fixes #3151.
Ward Vandewege [Wed, 2 Jul 2014 14:37:36 +0000 (10:37 -0400)]
Merge branch '3118-docker-fixes'
refs #3118
Ward Vandewege [Wed, 2 Jul 2014 14:36:18 +0000 (10:36 -0400)]
Remove superfluous cd commands
refs #3131
Ward Vandewege [Wed, 2 Jul 2014 14:35:20 +0000 (10:35 -0400)]
Fix up link in the docker alert box.
refs #3131
Ward Vandewege [Wed, 2 Jul 2014 14:28:34 +0000 (10:28 -0400)]
The linkchecker rake task should return with the exit code of linkchecker.
no issue #
Ward Vandewege [Wed, 2 Jul 2014 13:52:38 +0000 (09:52 -0400)]
Merge branch '3118-docker-fixes'
refs #3118
Ward Vandewege [Wed, 2 Jul 2014 13:51:49 +0000 (09:51 -0400)]
Add state of the docker installation alert to the top of the docker
installation page, too.
Tim Pierce [Wed, 2 Jul 2014 12:59:58 +0000 (08:59 -0400)]
2873: changes for code review
Incorporating code review comments:
* @Link#get_permissions@ uses @Link.where@ instead of @find_objects_for_index@; @find_object_for_uuid@ just populates @@object@ with the head_uuid object and leaves @@objects@ alone.
* @ArvadosModel.lookup_by_uuid@ renamed @ArvadosModel.find_by_uuid@ and punts to the superclass if called as a subclass method.
* Test @get_permissions_returns_list@ checks that the :active user can get permissions. Also uses the group fixtures for testing permissions instead of collections (because can_manage permissions only work so far on users and groups.
(refs #2873)
Peter Amstutz [Wed, 2 Jul 2014 01:21:12 +0000 (21:21 -0400)]
Add explicit version constraint < 1.0.0 on 'jwt' gem for arvados-cli, because
google-api-client gem dependecy breaks with jwt 1.0.0. no issue #
Ward Vandewege [Tue, 1 Jul 2014 20:39:18 +0000 (16:39 -0400)]
Merge branch '3118-docker-fixes'
refs #3118
Ward Vandewege [Tue, 1 Jul 2014 20:38:47 +0000 (16:38 -0400)]
Merge branch 'master' into 3118-docker-fixes
Ward Vandewege [Tue, 1 Jul 2014 20:38:11 +0000 (16:38 -0400)]
Add documentation to doc.arvados.org for the local Docker install.
Peter Amstutz [Tue, 1 Jul 2014 15:38:27 +0000 (11:38 -0400)]
Change crunch-dispatch to use "git fetch-pack --all" insted of "git fetch" to
fetch entire repository instead of just the history for HEAD. This seems to be
the only way to ensure that arbitrary script version hashes not in the history
of the source's HEAD are fetched without using refs (tags or branches).
no issue #
Peter Amstutz [Tue, 1 Jul 2014 14:17:34 +0000 (10:17 -0400)]
Always initialize arvados.api() so it doesn't silently fail when
ARVADOS_API_HOST isn't set. Improve error handing in arv-mount. no issue #
Peter Amstutz [Tue, 1 Jul 2014 14:10:29 +0000 (10:10 -0400)]
Add dockerfile to build arvados/jobs-bwa-samtools image. no issue #
Tom Clegg [Tue, 1 Jul 2014 00:45:00 +0000 (20:45 -0400)]
Merge branch '3099-spinner-assets' closes #3099
Tom Clegg [Tue, 1 Jul 2014 00:41:15 +0000 (20:41 -0400)]
3099: Use appropriate tr>td markup if infinite scroll container is a table.
Remove unused class.
Peter Amstutz [Mon, 30 Jun 2014 20:15:52 +0000 (16:15 -0400)]
Update required arvados-cli package to get fix
55e1aaf (Fix 'arv' to handle
missing/non-writable $HOME). no issue #
Peter Amstutz [Mon, 30 Jun 2014 19:16:39 +0000 (15:16 -0400)]
Merge branch 'arv-crunch-HOME-envvar' no issue #
Peter Amstutz [Mon, 30 Jun 2014 19:16:21 +0000 (15:16 -0400)]
Set $HOME to /tmp/crunch-job for docker.
Ward Vandewege [Mon, 30 Jun 2014 19:14:39 +0000 (15:14 -0400)]
Merge branch '3118-docker-fixes'
refs #3118
Brett Smith [Mon, 30 Jun 2014 19:13:12 +0000 (15:13 -0400)]
Merge branch '2891-improve-workbench-errors'
Closes #3079, #3080, #2891, #3092.
Ward Vandewege [Mon, 30 Jun 2014 19:12:40 +0000 (15:12 -0400)]
Merge branch 'master' into 3118-docker-fixes
Brett Smith [Mon, 30 Jun 2014 18:31:40 +0000 (14:31 -0400)]
2891: Workbench details the requested item on its 404 page.
Brett Smith [Mon, 30 Jun 2014 18:08:29 +0000 (14:08 -0400)]
2891: Trying to show a non-UUID in Workbench renders 404.
Brett Smith [Fri, 27 Jun 2014 18:37:34 +0000 (14:37 -0400)]
2891: Workbench reliably reloads model columns after failure.
ArvadosBase @columns could get stuck as [] if the API server wasn't
available during Workbench's first API request. This change ensures
that it keeps trying to reload column information until it receives
good data.
Brett Smith [Fri, 27 Jun 2014 18:30:38 +0000 (14:30 -0400)]
2891: Workbench renders login exceptions earlier.
These changes are designed to ensure that if there are any problems
getting information from the current API token (other than expected
401 Unauthorized responses), those problems are raised early and
propagated up to the exception handler. This helps better ensure that
thread state is consistent when we get to later stages of request
processing.
Brett Smith [Thu, 26 Jun 2014 20:36:16 +0000 (16:36 -0400)]
2891: Workbench current_user copes when API server is unreachable.
Brett Smith [Thu, 26 Jun 2014 20:35:30 +0000 (16:35 -0400)]
2891: Workbench converts API HTTP errors to API exceptions.
Brett Smith [Wed, 25 Jun 2014 20:39:24 +0000 (16:39 -0400)]
2891: Guard against API server errors in Workbench layout.
The goal here is to generally avoid situations like #3031 where
trouble talking to the API server prevents us from even rendering an
error page. Previous commits made us smarter about logged in status.
This guards against other API errors.
Brett Smith [Wed, 25 Jun 2014 20:31:57 +0000 (16:31 -0400)]
Clean redundant conditional from Workbench layout.
Brett Smith [Wed, 25 Jun 2014 20:07:27 +0000 (16:07 -0400)]
2891: Workbench displays more info about API errors.
Brett Smith [Wed, 25 Jun 2014 18:11:10 +0000 (14:11 -0400)]
2891: Add Workbench test for expired API token.
Brett Smith [Mon, 23 Jun 2014 21:31:57 +0000 (17:31 -0400)]
2891: Add index link to Workbench 404 responses.
Brett Smith [Mon, 23 Jun 2014 19:53:18 +0000 (15:53 -0400)]
2891: Workbench returns 404 when API object doesn't exist.
Brett Smith [Mon, 23 Jun 2014 19:28:48 +0000 (15:28 -0400)]
2891: Workbench API client raises structured exceptions.
These changes will make it easier for the rest of the Workbench code
to cope with these errors more gracefully—even if that just means
friendlier reporting of the error.
Brett Smith [Tue, 24 Jun 2014 15:38:50 +0000 (11:38 -0400)]
2891: API server assigns error tokens.
These unique tokens are both logged and sent along with the response,
making it easier to cross-reference what the client does with what
happens on the API server.
Brett Smith [Tue, 24 Jun 2014 14:22:25 +0000 (10:22 -0400)]
2891: API server ApplicationController style updates.
This ports over some of the niceties we've recently implemented in the
Workbench ApplicationController.
Brett Smith [Wed, 25 Jun 2014 17:47:13 +0000 (13:47 -0400)]
2891: Fix bug in Workbench error page test.
Ward Vandewege [Mon, 30 Jun 2014 19:04:15 +0000 (15:04 -0400)]
docker: arvdoc: start up doc and workbench last so it's less likely the
user will overlook the URL hint that is printed out.
Ward Vandewege [Mon, 30 Jun 2014 19:02:16 +0000 (15:02 -0400)]
docker: arvdock: whitespace cleanup
Ward Vandewege [Mon, 30 Jun 2014 19:01:28 +0000 (15:01 -0400)]
docker: usability improvements for arvdock.
Peter Amstutz [Mon, 30 Jun 2014 18:50:15 +0000 (14:50 -0400)]
Set $HOME to $TASK_WORK for tasks. no issue #
Peter Amstutz [Mon, 30 Jun 2014 18:48:48 +0000 (14:48 -0400)]
Fix 'arv' to handle missing/non-writable $HOME. no issue #
radhika [Mon, 30 Jun 2014 16:50:16 +0000 (12:50 -0400)]
closes #3076
Merge branch '3076-topnav-help'
radhika [Mon, 30 Jun 2014 16:45:46 +0000 (12:45 -0400)]
Merge branch 'master' into 3076-topnav-help
radhika [Mon, 30 Jun 2014 16:19:16 +0000 (12:19 -0400)]
closes #3088
Merge branch '3088-project-chooser-on-run-pipeline-template'
radhika [Mon, 30 Jun 2014 16:16:11 +0000 (12:16 -0400)]
3088: address review feedback -- change the icon positioning on the Run button.
radhika [Mon, 30 Jun 2014 16:08:07 +0000 (12:08 -0400)]
Merge branch 'master' into 3088-project-chooser-on-run-pipeline-template
radhika [Mon, 30 Jun 2014 16:03:55 +0000 (12:03 -0400)]
refs #2659
Merge branch '2659-anonymous-server-side'
radhika [Mon, 30 Jun 2014 15:46:36 +0000 (11:46 -0400)]
Merge branch 'master' into 3088-project-chooser-on-run-pipeline-template
radhika [Mon, 30 Jun 2014 15:41:26 +0000 (11:41 -0400)]
Merge branch 'master' into 2659-anonymous-server-side
radhika [Mon, 30 Jun 2014 15:39:41 +0000 (11:39 -0400)]
2659: look for scopes and expires_at when getting anonymous token. also, update create anonymous user to check for group link even when the user exists.
Ward Vandewege [Mon, 30 Jun 2014 14:59:32 +0000 (10:59 -0400)]
docker: remove warehouse container; add new keep container.
refs #3120
Peter Amstutz [Mon, 30 Jun 2014 14:42:39 +0000 (10:42 -0400)]
Add 'run-command' generic crunch command wrapper. refs #2342
radhika [Mon, 30 Jun 2014 14:39:52 +0000 (10:39 -0400)]
2659: remove the share_the_aproject_with_all_groups fixture in links.
radhika [Mon, 30 Jun 2014 14:12:48 +0000 (10:12 -0400)]
Merge branch 'master' into 2659-anonymous-server-side
Ward Vandewege [Mon, 30 Jun 2014 04:24:06 +0000 (04:24 +0000)]
docker: bump up passenger version. This is highly unsatisfactory, and needs
proper fixing.
Ward Vandewege [Mon, 30 Jun 2014 04:23:15 +0000 (04:23 +0000)]
docker: fix up the link between workbench and the API server, work around the
lack of ERB parsing in application.yml
Ward Vandewege [Mon, 30 Jun 2014 03:43:31 +0000 (03:43 +0000)]
docker: a bunch of tweaks to bring the docker setup up to snuff with the latest
version of our codebase.
Ward Vandewege [Mon, 30 Jun 2014 03:43:13 +0000 (03:43 +0000)]
docker: arvdock: support new Debian docker.io packages
Ward Vandewege [Mon, 30 Jun 2014 01:02:13 +0000 (01:02 +0000)]
docker: more changes to support new Debian docker.io packages
Ward Vandewege [Mon, 30 Jun 2014 00:25:48 +0000 (00:25 +0000)]
docker: build_tools/build.rb: improve language around Google account.
Ward Vandewege [Mon, 30 Jun 2014 00:18:52 +0000 (00:18 +0000)]
docker: build_tools/build.rb: support new Debian docker.io packages
Ward Vandewege [Mon, 30 Jun 2014 00:08:10 +0000 (00:08 +0000)]
docker: build_tools/build.rb: exit with non-zero exit code when something goes
wrong.
Tim Pierce [Thu, 26 Jun 2014 18:17:48 +0000 (14:17 -0400)]
2873: add /permissions API method
The /permissions/:uuid method will return a list of all permissions that
the current user is allowed to see on the given uuid.
* New method LinksController::get_permissions, with a route from
/arvados/v1/permissions.
* LinksController overrides find_object_by_uuid to permit looking up a
uuid in any class, when called by get_permissions.
* Moved link permission checking to Link.ensure_owner_uuid_is_permitted.
* Use current_user.can? to check the user's permission on head_uuid.
Removed unnecessary owns? and can_manage? code.
* Unit tests:
* test/integration/permissions_test.rb: added tests:
* "get_permissions returns list"
* "get_permissions returns 404 for nonexistent uuid"
* "get_permissions returns 403 if user lacks manage permission"
* test/unit/link.rb: test that only permission and name links have
their ownership changed upon save.
* test/unit/permission_test.rb: test the following scenario: when user
"active" owns a group G which can_manage another group H, then
active user is permitted to create permission links directly on
objects in group H.
Refs #2873.
2873: perms
Peter Amstutz [Fri, 27 Jun 2014 16:16:05 +0000 (12:16 -0400)]
Fix tests broken by adding zero-length block manifests containing a zero length
file. refs #3084
Peter Amstutz [Fri, 27 Jun 2014 15:11:50 +0000 (11:11 -0400)]
Handle empty directories in arv-put. refs #3087
Peter Amstutz [Fri, 27 Jun 2014 14:57:24 +0000 (10:57 -0400)]
Handle zero-length streams that contain zero-length files. refs #3084
radhika [Fri, 27 Jun 2014 14:20:56 +0000 (10:20 -0400)]
Merge branch 'master' into 3076-topnav-help
radhika [Fri, 27 Jun 2014 14:19:59 +0000 (10:19 -0400)]
Merge branch 'master' into 3088-project-chooser-on-run-pipeline-template
Tom Clegg [Fri, 27 Jun 2014 14:17:09 +0000 (10:17 -0400)]
3099: Fix up loading spinners.
* Work around Rails asset pipeline bug by avoiding "-" in image filenames.
* Always use asset helpers: src="/assets/foo.gif" only works in dev mode.
* Center loading spinners.
* Use a "spinner" class to identify spinners in "remove spinner" code.
radhika [Fri, 27 Jun 2014 14:14:15 +0000 (10:14 -0400)]
Merge branch 'master' into 2659-anonymous-server-side
radhika [Fri, 27 Jun 2014 13:41:08 +0000 (09:41 -0400)]
2659: split server side implementation into a separate branch to facilitate better testing.
Peter Amstutz [Fri, 27 Jun 2014 13:26:02 +0000 (09:26 -0400)]
Update required arvados gem to depend on version of arv-run-pipeline-instance
that supports runtime constraints. no issue #
Peter Amstutz [Fri, 27 Jun 2014 12:47:59 +0000 (08:47 -0400)]
Merge branch 'pete-fixes' closes #3096
Peter Amstutz [Fri, 27 Jun 2014 12:45:50 +0000 (08:45 -0400)]
Fixed render_pipeline_component_attribute test if dataclass derives from ArvadosBase.
Peter Amstutz [Thu, 26 Jun 2014 21:10:26 +0000 (17:10 -0400)]
Merge branch 'pete-fixes' of git.curoverse.com:arvados into pete-fixes
Peter Amstutz [Thu, 26 Jun 2014 21:09:57 +0000 (17:09 -0400)]
Fixed get_n_objects_of_class datatype assertion for 'dataclass'
radhika [Thu, 26 Jun 2014 19:48:05 +0000 (15:48 -0400)]
3088: so sweet to have a test AND one that fails when code is updated.
radhika [Thu, 26 Jun 2014 19:37:30 +0000 (15:37 -0400)]
3088: the other right
radhika [Thu, 26 Jun 2014 19:28:24 +0000 (15:28 -0400)]
3088: show project chooser for run this pipeline on a template
Peter Amstutz [Thu, 26 Jun 2014 19:14:38 +0000 (15:14 -0400)]
Remove import from __future__
Peter Amstutz [Thu, 26 Jun 2014 19:13:37 +0000 (15:13 -0400)]
Remove spurious 'puts'
radhika [Thu, 26 Jun 2014 19:03:27 +0000 (15:03 -0400)]
3088: set the owner uuid on the newly created pipeline instance to the selected project.
Peter Amstutz [Thu, 26 Jun 2014 18:41:49 +0000 (14:41 -0400)]
:none dispatcher only runs one job at a time.
radhika [Thu, 26 Jun 2014 18:01:07 +0000 (14:01 -0400)]
3088: Run this pipeline on a template shows project chooser
Peter Amstutz [Thu, 26 Jun 2014 17:51:58 +0000 (13:51 -0400)]
Merge remote-tracking branch 'origin/master' into pete-fixes
Peter Amstutz [Thu, 26 Jun 2014 17:51:14 +0000 (13:51 -0400)]
Fixed logging statements to format correctly.
Peter Amstutz [Thu, 26 Jun 2014 17:31:14 +0000 (13:31 -0400)]
"Combine selected" actually works again.
Peter Amstutz [Thu, 26 Jun 2014 16:58:51 +0000 (12:58 -0400)]
fuse test fixes
Peter Amstutz [Thu, 26 Jun 2014 15:31:17 +0000 (11:31 -0400)]
Use logging module instead of "if DEBUG:"