arvados.git
10 years agoMake sure set return code non-zero.
Peter Amstutz [Tue, 1 Jul 2014 14:23:09 +0000 (10:23 -0400)]
Make sure set return code non-zero.

10 years agoAlways initialize arvados.api() so it doesn't silently fail when
Peter Amstutz [Tue, 1 Jul 2014 14:17:34 +0000 (10:17 -0400)]
Always initialize arvados.api() so it doesn't silently fail when
ARVADOS_API_HOST isn't set.  Improve error handing in arv-mount.  no issue #

10 years agoAdd dockerfile to build arvados/jobs-bwa-samtools image. no issue #
Peter Amstutz [Tue, 1 Jul 2014 14:10:29 +0000 (10:10 -0400)]
Add dockerfile to build arvados/jobs-bwa-samtools image. no issue #

10 years agoMerge branch '3099-spinner-assets' closes #3099
Tom Clegg [Tue, 1 Jul 2014 00:45:00 +0000 (20:45 -0400)]
Merge branch '3099-spinner-assets' closes #3099

10 years ago3099: Use appropriate tr>td markup if infinite scroll container is a table.
Tom Clegg [Tue, 1 Jul 2014 00:41:15 +0000 (20:41 -0400)]
3099: Use appropriate tr>td markup if infinite scroll container is a table.
Remove unused class.

10 years agoUpdate required arvados-cli package to get fix 55e1aaf (Fix 'arv' to handle
Peter Amstutz [Mon, 30 Jun 2014 20:15:52 +0000 (16:15 -0400)]
Update required arvados-cli package to get fix 55e1aaf (Fix 'arv' to handle
missing/non-writable $HOME). no issue #

10 years agoMerge branch 'arv-crunch-HOME-envvar' no issue #
Peter Amstutz [Mon, 30 Jun 2014 19:16:39 +0000 (15:16 -0400)]
Merge branch 'arv-crunch-HOME-envvar' no issue #

10 years agoSet $HOME to /tmp/crunch-job for docker.
Peter Amstutz [Mon, 30 Jun 2014 19:16:21 +0000 (15:16 -0400)]
Set $HOME to /tmp/crunch-job for docker.

10 years agoMerge branch '3118-docker-fixes'
Ward Vandewege [Mon, 30 Jun 2014 19:14:39 +0000 (15:14 -0400)]
Merge branch '3118-docker-fixes'

refs #3118

10 years agoMerge branch '2891-improve-workbench-errors'
Brett Smith [Mon, 30 Jun 2014 19:13:12 +0000 (15:13 -0400)]
Merge branch '2891-improve-workbench-errors'

Closes #3079, #3080, #2891, #3092.

10 years agoMerge branch 'master' into 3118-docker-fixes
Ward Vandewege [Mon, 30 Jun 2014 19:12:40 +0000 (15:12 -0400)]
Merge branch 'master' into 3118-docker-fixes

10 years ago2891: Workbench details the requested item on its 404 page.
Brett Smith [Mon, 30 Jun 2014 18:31:40 +0000 (14:31 -0400)]
2891: Workbench details the requested item on its 404 page.

10 years ago2891: Trying to show a non-UUID in Workbench renders 404.
Brett Smith [Mon, 30 Jun 2014 18:08:29 +0000 (14:08 -0400)]
2891: Trying to show a non-UUID in Workbench renders 404.

10 years ago2891: Workbench reliably reloads model columns after failure.
Brett Smith [Fri, 27 Jun 2014 18:37:34 +0000 (14:37 -0400)]
2891: Workbench reliably reloads model columns after failure.

ArvadosBase @columns could get stuck as [] if the API server wasn't
available during Workbench's first API request.  This change ensures
that it keeps trying to reload column information until it receives
good data.

10 years ago2891: Workbench renders login exceptions earlier.
Brett Smith [Fri, 27 Jun 2014 18:30:38 +0000 (14:30 -0400)]
2891: Workbench renders login exceptions earlier.

These changes are designed to ensure that if there are any problems
getting information from the current API token (other than expected
401 Unauthorized responses), those problems are raised early and
propagated up to the exception handler.  This helps better ensure that
thread state is consistent when we get to later stages of request
processing.

10 years ago2891: Workbench current_user copes when API server is unreachable.
Brett Smith [Thu, 26 Jun 2014 20:36:16 +0000 (16:36 -0400)]
2891: Workbench current_user copes when API server is unreachable.

10 years ago2891: Workbench converts API HTTP errors to API exceptions.
Brett Smith [Thu, 26 Jun 2014 20:35:30 +0000 (16:35 -0400)]
2891: Workbench converts API HTTP errors to API exceptions.

10 years ago2891: Guard against API server errors in Workbench layout.
Brett Smith [Wed, 25 Jun 2014 20:39:24 +0000 (16:39 -0400)]
2891: Guard against API server errors in Workbench layout.

The goal here is to generally avoid situations like #3031 where
trouble talking to the API server prevents us from even rendering an
error page.  Previous commits made us smarter about logged in status.
This guards against other API errors.

10 years agoClean redundant conditional from Workbench layout.
Brett Smith [Wed, 25 Jun 2014 20:31:57 +0000 (16:31 -0400)]
Clean redundant conditional from Workbench layout.

10 years ago2891: Workbench displays more info about API errors.
Brett Smith [Wed, 25 Jun 2014 20:07:27 +0000 (16:07 -0400)]
2891: Workbench displays more info about API errors.

10 years ago2891: Add Workbench test for expired API token.
Brett Smith [Wed, 25 Jun 2014 18:11:10 +0000 (14:11 -0400)]
2891: Add Workbench test for expired API token.

10 years ago2891: Add index link to Workbench 404 responses.
Brett Smith [Mon, 23 Jun 2014 21:31:57 +0000 (17:31 -0400)]
2891: Add index link to Workbench 404 responses.

10 years ago2891: Workbench returns 404 when API object doesn't exist.
Brett Smith [Mon, 23 Jun 2014 19:53:18 +0000 (15:53 -0400)]
2891: Workbench returns 404 when API object doesn't exist.

10 years ago2891: Workbench API client raises structured exceptions.
Brett Smith [Mon, 23 Jun 2014 19:28:48 +0000 (15:28 -0400)]
2891: Workbench API client raises structured exceptions.

These changes will make it easier for the rest of the Workbench code
to cope with these errors more gracefully—even if that just means
friendlier reporting of the error.

10 years ago2891: API server assigns error tokens.
Brett Smith [Tue, 24 Jun 2014 15:38:50 +0000 (11:38 -0400)]
2891: API server assigns error tokens.

These unique tokens are both logged and sent along with the response,
making it easier to cross-reference what the client does with what
happens on the API server.

10 years ago2891: API server ApplicationController style updates.
Brett Smith [Tue, 24 Jun 2014 14:22:25 +0000 (10:22 -0400)]
2891: API server ApplicationController style updates.

This ports over some of the niceties we've recently implemented in the
Workbench ApplicationController.

10 years ago2891: Fix bug in Workbench error page test.
Brett Smith [Wed, 25 Jun 2014 17:47:13 +0000 (13:47 -0400)]
2891: Fix bug in Workbench error page test.

10 years agodocker: arvdoc: start up doc and workbench last so it's less likely the
Ward Vandewege [Mon, 30 Jun 2014 19:04:15 +0000 (15:04 -0400)]
docker: arvdoc: start up doc and workbench last so it's less likely the
user will overlook the URL hint that is printed out.

10 years agodocker: arvdock: whitespace cleanup
Ward Vandewege [Mon, 30 Jun 2014 19:02:16 +0000 (15:02 -0400)]
docker: arvdock: whitespace cleanup

10 years agodocker: usability improvements for arvdock.
Ward Vandewege [Mon, 30 Jun 2014 19:01:28 +0000 (15:01 -0400)]
docker: usability improvements for arvdock.

10 years agoSet $HOME to $TASK_WORK for tasks. no issue #
Peter Amstutz [Mon, 30 Jun 2014 18:50:15 +0000 (14:50 -0400)]
Set $HOME to $TASK_WORK for tasks.  no issue #

10 years agoFix 'arv' to handle missing/non-writable $HOME. no issue #
Peter Amstutz [Mon, 30 Jun 2014 18:48:48 +0000 (14:48 -0400)]
Fix 'arv' to handle missing/non-writable $HOME.  no issue #

10 years agocloses #3076
radhika [Mon, 30 Jun 2014 16:50:16 +0000 (12:50 -0400)]
closes #3076
Merge branch '3076-topnav-help'

10 years agoMerge branch 'master' into 3076-topnav-help
radhika [Mon, 30 Jun 2014 16:45:46 +0000 (12:45 -0400)]
Merge branch 'master' into 3076-topnav-help

10 years agocloses #3088
radhika [Mon, 30 Jun 2014 16:19:16 +0000 (12:19 -0400)]
closes #3088
Merge branch '3088-project-chooser-on-run-pipeline-template'

10 years ago3088: address review feedback -- change the icon positioning on the Run button.
radhika [Mon, 30 Jun 2014 16:16:11 +0000 (12:16 -0400)]
3088: address review feedback -- change the icon positioning on the Run button.

10 years agoMerge branch 'master' into 3088-project-chooser-on-run-pipeline-template
radhika [Mon, 30 Jun 2014 16:08:07 +0000 (12:08 -0400)]
Merge branch 'master' into 3088-project-chooser-on-run-pipeline-template

10 years agorefs #2659
radhika [Mon, 30 Jun 2014 16:03:55 +0000 (12:03 -0400)]
refs #2659
Merge branch '2659-anonymous-server-side'

10 years agoMerge branch 'master' into 3088-project-chooser-on-run-pipeline-template
radhika [Mon, 30 Jun 2014 15:46:36 +0000 (11:46 -0400)]
Merge branch 'master' into 3088-project-chooser-on-run-pipeline-template

10 years agoMerge branch 'master' into 2659-anonymous-server-side
radhika [Mon, 30 Jun 2014 15:41:26 +0000 (11:41 -0400)]
Merge branch 'master' into 2659-anonymous-server-side

10 years ago2659: look for scopes and expires_at when getting anonymous token. also, update creat...
radhika [Mon, 30 Jun 2014 15:39:41 +0000 (11:39 -0400)]
2659: look for scopes and expires_at when getting anonymous token. also, update create anonymous user to check for group link even when the user exists.

10 years agodocker: remove warehouse container; add new keep container.
Ward Vandewege [Mon, 30 Jun 2014 14:59:32 +0000 (10:59 -0400)]
docker: remove warehouse container; add new keep container.

refs #3120

10 years agoAdd 'run-command' generic crunch command wrapper. refs #2342
Peter Amstutz [Mon, 30 Jun 2014 14:42:39 +0000 (10:42 -0400)]
Add 'run-command' generic crunch command wrapper.  refs #2342

10 years ago2659: remove the share_the_aproject_with_all_groups fixture in links.
radhika [Mon, 30 Jun 2014 14:39:52 +0000 (10:39 -0400)]
2659: remove the share_the_aproject_with_all_groups fixture in links.

10 years agoMerge branch 'master' into 2659-anonymous-server-side
radhika [Mon, 30 Jun 2014 14:12:48 +0000 (10:12 -0400)]
Merge branch 'master' into 2659-anonymous-server-side

10 years agodocker: bump up passenger version. This is highly unsatisfactory, and needs
Ward Vandewege [Mon, 30 Jun 2014 04:24:06 +0000 (04:24 +0000)]
docker: bump up passenger version. This is highly unsatisfactory, and needs
proper fixing.

10 years agodocker: fix up the link between workbench and the API server, work around the
Ward Vandewege [Mon, 30 Jun 2014 04:23:15 +0000 (04:23 +0000)]
docker: fix up the link between workbench and the API server, work around the
lack of ERB parsing in application.yml

10 years agodocker: a bunch of tweaks to bring the docker setup up to snuff with the latest
Ward Vandewege [Mon, 30 Jun 2014 03:43:31 +0000 (03:43 +0000)]
docker: a bunch of tweaks to bring the docker setup up to snuff with the latest
version of our codebase.

10 years agodocker: arvdock: support new Debian docker.io packages
Ward Vandewege [Mon, 30 Jun 2014 03:43:13 +0000 (03:43 +0000)]
docker: arvdock: support new Debian docker.io packages

10 years agodocker: more changes to support new Debian docker.io packages
Ward Vandewege [Mon, 30 Jun 2014 01:02:13 +0000 (01:02 +0000)]
docker: more changes to support new Debian docker.io packages

10 years agodocker: build_tools/build.rb: improve language around Google account.
Ward Vandewege [Mon, 30 Jun 2014 00:25:48 +0000 (00:25 +0000)]
docker: build_tools/build.rb: improve language around Google account.

10 years agodocker: build_tools/build.rb: support new Debian docker.io packages
Ward Vandewege [Mon, 30 Jun 2014 00:18:52 +0000 (00:18 +0000)]
docker: build_tools/build.rb: support new Debian docker.io packages

10 years agodocker: build_tools/build.rb: exit with non-zero exit code when something goes
Ward Vandewege [Mon, 30 Jun 2014 00:08:10 +0000 (00:08 +0000)]
docker: build_tools/build.rb: exit with non-zero exit code when something goes
wrong.

10 years agoFix tests broken by adding zero-length block manifests containing a zero length
Peter Amstutz [Fri, 27 Jun 2014 16:16:05 +0000 (12:16 -0400)]
Fix tests broken by adding zero-length block manifests containing a zero length
file.  refs #3084

10 years agoHandle empty directories in arv-put. refs #3087
Peter Amstutz [Fri, 27 Jun 2014 15:11:50 +0000 (11:11 -0400)]
Handle empty directories in arv-put.  refs #3087

10 years agoHandle zero-length streams that contain zero-length files. refs #3084
Peter Amstutz [Fri, 27 Jun 2014 14:57:24 +0000 (10:57 -0400)]
Handle zero-length streams that contain zero-length files.  refs #3084

10 years agoMerge branch 'master' into 3076-topnav-help
radhika [Fri, 27 Jun 2014 14:20:56 +0000 (10:20 -0400)]
Merge branch 'master' into 3076-topnav-help

10 years agoMerge branch 'master' into 3088-project-chooser-on-run-pipeline-template
radhika [Fri, 27 Jun 2014 14:19:59 +0000 (10:19 -0400)]
Merge branch 'master' into 3088-project-chooser-on-run-pipeline-template

10 years ago3099: Fix up loading spinners.
Tom Clegg [Fri, 27 Jun 2014 14:17:09 +0000 (10:17 -0400)]
3099: Fix up loading spinners.

* Work around Rails asset pipeline bug by avoiding "-" in image filenames.
* Always use asset helpers: src="/assets/foo.gif" only works in dev mode.
* Center loading spinners.
* Use a "spinner" class to identify spinners in "remove spinner" code.

10 years agoMerge branch 'master' into 2659-anonymous-server-side
radhika [Fri, 27 Jun 2014 14:14:15 +0000 (10:14 -0400)]
Merge branch 'master' into 2659-anonymous-server-side

10 years ago2659: split server side implementation into a separate branch to facilitate better...
radhika [Fri, 27 Jun 2014 13:41:08 +0000 (09:41 -0400)]
2659: split server side implementation into a separate branch to facilitate better testing.

10 years agoUpdate required arvados gem to depend on version of arv-run-pipeline-instance
Peter Amstutz [Fri, 27 Jun 2014 13:26:02 +0000 (09:26 -0400)]
Update required arvados gem to depend on version of arv-run-pipeline-instance
that supports runtime constraints.  no issue #

10 years agoMerge branch 'pete-fixes' closes #3096
Peter Amstutz [Fri, 27 Jun 2014 12:47:59 +0000 (08:47 -0400)]
Merge branch 'pete-fixes' closes #3096

10 years agoFixed render_pipeline_component_attribute test if dataclass derives from ArvadosBase.
Peter Amstutz [Fri, 27 Jun 2014 12:45:50 +0000 (08:45 -0400)]
Fixed render_pipeline_component_attribute test if dataclass derives from ArvadosBase.

10 years agoMerge branch 'pete-fixes' of git.curoverse.com:arvados into pete-fixes
Peter Amstutz [Thu, 26 Jun 2014 21:10:26 +0000 (17:10 -0400)]
Merge branch 'pete-fixes' of git.curoverse.com:arvados into pete-fixes

10 years agoFixed get_n_objects_of_class datatype assertion for 'dataclass'
Peter Amstutz [Thu, 26 Jun 2014 21:09:57 +0000 (17:09 -0400)]
Fixed get_n_objects_of_class datatype assertion for 'dataclass'

10 years ago3088: so sweet to have a test AND one that fails when code is updated.
radhika [Thu, 26 Jun 2014 19:48:05 +0000 (15:48 -0400)]
3088: so sweet to have a test AND one that fails when code is updated.

10 years ago3088: the other right
radhika [Thu, 26 Jun 2014 19:37:30 +0000 (15:37 -0400)]
3088: the other right

10 years ago3088: show project chooser for run this pipeline on a template
radhika [Thu, 26 Jun 2014 19:28:24 +0000 (15:28 -0400)]
3088: show project chooser for run this pipeline on a template

10 years agoRemove import from __future__
Peter Amstutz [Thu, 26 Jun 2014 19:14:38 +0000 (15:14 -0400)]
Remove import from __future__

10 years agoRemove spurious 'puts'
Peter Amstutz [Thu, 26 Jun 2014 19:13:37 +0000 (15:13 -0400)]
Remove spurious 'puts'

10 years ago3088: set the owner uuid on the newly created pipeline instance to the selected project.
radhika [Thu, 26 Jun 2014 19:03:27 +0000 (15:03 -0400)]
3088: set the owner uuid on the newly created pipeline instance to the selected project.

10 years ago:none dispatcher only runs one job at a time.
Peter Amstutz [Thu, 26 Jun 2014 18:41:49 +0000 (14:41 -0400)]
:none dispatcher only runs one job at a time.

10 years ago3088: Run this pipeline on a template shows project chooser
radhika [Thu, 26 Jun 2014 18:01:07 +0000 (14:01 -0400)]
3088: Run this pipeline on a template shows project chooser

10 years agoMerge remote-tracking branch 'origin/master' into pete-fixes
Peter Amstutz [Thu, 26 Jun 2014 17:51:58 +0000 (13:51 -0400)]
Merge remote-tracking branch 'origin/master' into pete-fixes

10 years agoFixed logging statements to format correctly.
Peter Amstutz [Thu, 26 Jun 2014 17:51:14 +0000 (13:51 -0400)]
Fixed logging statements to format correctly.

10 years ago"Combine selected" actually works again.
Peter Amstutz [Thu, 26 Jun 2014 17:31:14 +0000 (13:31 -0400)]
"Combine selected" actually works again.

10 years agofuse test fixes
Peter Amstutz [Thu, 26 Jun 2014 16:58:51 +0000 (12:58 -0400)]
fuse test fixes

10 years agoUse logging module instead of "if DEBUG:"
Peter Amstutz [Thu, 26 Jun 2014 15:31:17 +0000 (11:31 -0400)]
Use logging module instead of "if DEBUG:"

10 years agoRemove spurious 'puts'
Peter Amstutz [Thu, 26 Jun 2014 15:30:38 +0000 (11:30 -0400)]
Remove spurious 'puts'

10 years agoFixed regex for extracting just hash and size part of locator
Peter Amstutz [Thu, 26 Jun 2014 15:30:14 +0000 (11:30 -0400)]
Fixed regex for extracting just hash and size part of locator

10 years agoAdd -> indirection to $self->{'noVerifyHostname'}
Peter Amstutz [Thu, 26 Jun 2014 15:29:25 +0000 (11:29 -0400)]
Add -> indirection to  $self->{'noVerifyHostname'}

10 years agoUse /tmp/crunch-src for docker jobs and $ENV{CRUNCH_SRC} for non-docker. Removed...
Peter Amstutz [Thu, 26 Jun 2014 15:28:50 +0000 (11:28 -0400)]
Use /tmp/crunch-src for docker jobs and $ENV{CRUNCH_SRC} for non-docker.  Removed umask.

10 years agoRefactored "save temp file rescue behavior into function
Peter Amstutz [Thu, 26 Jun 2014 15:17:50 +0000 (11:17 -0400)]
Refactored "save temp file rescue behavior into function

10 years agoRefactored arv-normalize calls into function.
Peter Amstutz [Thu, 26 Jun 2014 15:17:32 +0000 (11:17 -0400)]
Refactored arv-normalize calls into function.

10 years agoReused variable 'n' for two different things. Oops.
Peter Amstutz [Thu, 26 Jun 2014 13:46:36 +0000 (09:46 -0400)]
Reused variable 'n' for two different things.  Oops.

10 years agoImprove arv edit failure handling.
Peter Amstutz [Thu, 26 Jun 2014 13:28:57 +0000 (09:28 -0400)]
Improve arv edit failure handling.

10 years agoMerge branch 'master' into 3088-project-chooser-on-run-pipeline-template
radhika [Wed, 25 Jun 2014 14:43:56 +0000 (10:43 -0400)]
Merge branch 'master' into 3088-project-chooser-on-run-pipeline-template

10 years agoEscape HTML entities in Workbench Job log viewer.
Brett Smith [Tue, 24 Jun 2014 21:11:00 +0000 (17:11 -0400)]
Escape HTML entities in Workbench Job log viewer.

No issue #.

10 years agoDon't print blkio stats if no reads or writes have occurred since the last poll.
Peter Amstutz [Tue, 24 Jun 2014 21:08:40 +0000 (17:08 -0400)]
Don't print blkio stats if no reads or writes have occurred since the last poll.

10 years ago3088: Show created at timestamp instead of Age
radhika [Tue, 24 Jun 2014 20:13:27 +0000 (16:13 -0400)]
3088: Show created at timestamp instead of Age

10 years agoMerge remote-tracking branch 'origin/master' into pete-fixes
Peter Amstutz [Tue, 24 Jun 2014 20:04:10 +0000 (16:04 -0400)]
Merge remote-tracking branch 'origin/master' into pete-fixes

10 years agoFix bad interaction between llfuse and daemonization in arv-mount.
Brett Smith [Tue, 24 Jun 2014 19:02:39 +0000 (15:02 -0400)]
Fix bad interaction between llfuse and daemonization in arv-mount.

Following PEP 3143, daemon.DaemonContext drops all open file
descriptors by default.  This causes arv-mount to fail, because
llfuse.init() opens /dev/fuse, and llfuse.main() uses that file
descriptor.  We now daemonize before doing real work to prevent this
unintentional breakage.

This effectively reverts 83c873af.  An alternative approach would've
been to call DaemonContext with a preserve_files argument.  I decided
against that because I couldn't find a reliable way to determine
which file descriptors llfuse needs.  If we really need the daemon to
report errors, and debugging with --foreground isn't sufficient, I
think we should implement proper logging to a file or syslog.

No issue #.

10 years ago3076: help menu class name
radhika [Tue, 24 Jun 2014 18:19:54 +0000 (14:19 -0400)]
3076: help menu class name

10 years ago3076: add Help dropdown to topnav.
radhika [Tue, 24 Jun 2014 18:08:49 +0000 (14:08 -0400)]
3076: add Help dropdown to topnav.

10 years agoMake task working directory world writable, to deal with uid mapping problems
Peter Amstutz [Tue, 24 Jun 2014 17:50:23 +0000 (13:50 -0400)]
Make task working directory world writable, to deal with uid mapping problems
where the uid of the crunch-job user doesn't match uid the docker image user.
CRUNCH_SRC, TASK_WORK, TASK_KEEPMOUNT and are now always bound to
/tmp/crunch-src, /tmp/crunch-job, /mnt respectively when running inside a
docker image.

10 years agoMagicDirectory.__contains__ now creates CollectionDirectory (which creates
Peter Amstutz [Tue, 24 Jun 2014 15:29:56 +0000 (11:29 -0400)]
MagicDirectory.__contains__ now creates CollectionDirectory (which creates
CollectionReader()) and uses update() to determine if a collection exists;
handles cases where the collection only exists on API server. Also improved
arv-mount debug logging.  no issue #

10 years agoRemove spurious print from fuse driver. no issue #
Peter Amstutz [Tue, 24 Jun 2014 14:26:14 +0000 (10:26 -0400)]
Remove spurious print from fuse driver.  no issue #

10 years agoAdd support for ARVADOS_API_HOST_INSECURE environment variable. Use Net::SSL
Peter Amstutz [Tue, 24 Jun 2014 13:16:25 +0000 (09:16 -0400)]
Add support for ARVADOS_API_HOST_INSECURE environment variable.  Use Net::SSL
instead of IO::Socket::SSL because the latter seems to ignore
PERL_LWP_SSL_VERIFY_HOSTNAME.  no issue #

10 years agoNow includes runtime_constraints from the component when creating a new job. no issue #
Peter Amstutz [Tue, 24 Jun 2014 13:12:59 +0000 (09:12 -0400)]
Now includes runtime_constraints from the component when creating a new job. no issue #