Lucas Di Pentima [Wed, 17 Feb 2021 18:48:32 +0000 (15:48 -0300)]
16848: Avoids showing API errors when the extra token creation fails.
If the cluster's config API.TokenLifetime isn't zero, creating new tokens
isn't allowed. From wb2's side, there's no way to know in advance if this
will be allowed so this commit avoids showing the error on app's bootup
and shows a warning message on the UI when the user tries to do it manually.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 16 Feb 2021 23:11:07 +0000 (20:11 -0300)]
16848: Makes 'Open as S3 bucket' dialog use the extra api token if available.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 16 Feb 2021 23:00:57 +0000 (20:00 -0300)]
16848: Adds an extra token to be displayed on the 'get token' dialog.
Also, adds a "Get new token" button to the dialog to allow the user to
request new tokens.
These extra tokens won't be expired on logout, so they're suitable for use
on S3 URLs and other tasks the user may need.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Mon, 15 Feb 2021 21:03:30 +0000 (18:03 -0300)]
16848: Adds test for idle timer reset via localStorage event.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Mon, 15 Feb 2021 20:44:13 +0000 (17:44 -0300)]
16848: Improved event handler installation/removal.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 12 Feb 2021 22:54:41 +0000 (19:54 -0300)]
16848: Synchronizes auto-logout between different windows/tabs.
On user action, a localStorage key is updated with the timestamp. The other
windows/tabs of the same app receive the change event and reset the idle
timer accordingly.
There's some event debouncing going on so there's a 1 sec delay between
the active window/tab and the rest.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 12 Feb 2021 16:23:06 +0000 (13:23 -0300)]
16848: Renames 'current token dialog' code to 'token dialog'.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 3 Feb 2021 19:50:00 +0000 (16:50 -0300)]
Merge branch '17308-property-editor-fixes'
Closes #17308
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Wed, 3 Feb 2021 19:47:02 +0000 (20:47 +0100)]
Merge branch '17205-render-owner-name'
closes #17205
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Wed, 3 Feb 2021 19:46:58 +0000 (16:46 -0300)]
17308: Removes forgotten .only() call on integration test.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Wed, 3 Feb 2021 19:29:08 +0000 (20:29 +0100)]
17205: Fixed types
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Wed, 3 Feb 2021 14:33:03 +0000 (11:33 -0300)]
Merge branch 'flaky-integration-test-fix'
No issue #
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 2 Feb 2021 22:48:49 +0000 (19:48 -0300)]
Hopefully fixes flaky test by asserting on different file names when looping.
No issue #
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Tue, 2 Feb 2021 22:33:48 +0000 (23:33 +0100)]
17205: Created new renderer for owner name
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Tue, 2 Feb 2021 19:41:55 +0000 (16:41 -0300)]
Avoids 404 responses when no container request is selected.
Refs #17319
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 2 Feb 2021 19:41:55 +0000 (16:41 -0300)]
Avoids 404 responses when no container request is selected.
Refs #17319
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 2 Feb 2021 16:20:17 +0000 (13:20 -0300)]
17308: Adds project creation with properties integration test.
Also reorganizes some test cases, and removes code duplication on the create
new project dialog for the property editor form.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Mon, 1 Feb 2021 22:27:09 +0000 (19:27 -0300)]
17308: Adds vocabulary terms handling to new project dialog's property editor.
Also, adds the ability to add multiple value properties. This makes the
new project dialog's editor behaviour consistent with the rest of the
application.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Thu, 28 Jan 2021 21:23:29 +0000 (22:23 +0100)]
17205: Added new component to fetch owner name
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Thu, 28 Jan 2021 19:29:46 +0000 (16:29 -0300)]
Merge branch '17266-property-ui-synonym-fix'
Closes #17266
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 27 Jan 2021 22:00:37 +0000 (19:00 -0300)]
17266: Fixes integration test.
One cypress test started failing because instead of using visit() now the
tests navigate to collection through the app router, so previous state is
kept. The problem was that on collection updates an action was dispatched
to update the parent project of the collection. This caused issues with the
details panel incorrectly loading the project's details instead of keeping
the collection's data on it.
Also, updated yarn.lock after the cypress 6.x update.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 26 Jan 2021 14:27:52 +0000 (11:27 -0300)]
17266: Handles onChange event separate on the property editor.
When changing the property value field, on every event a vocabulary match
is attempted just in case the user submits the form by hitting <enter>.
The bug happened because the vocabulary matching was only relying on the
onBlur event, that doesn't fire in this case.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Mon, 25 Jan 2021 20:33:55 +0000 (17:33 -0300)]
17266: Avoids adding a property value without a key.
Also resets the form whenever a property key changes, this avoids a previously
validated property value to be taken as valid with a different property key.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 27 Jan 2021 00:06:54 +0000 (21:06 -0300)]
17266: Exposes the bug with an integration test.
When the user typed a valid property value and hit <enter>, the literal
value's label is saved on the backend instead of its vocabulary ID.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 26 Jan 2021 14:23:43 +0000 (11:23 -0300)]
17266: Avoids reloading the app on cypress tests by using search.
Instead of using visit(url), whenever possible we should use some method
that makes the app do the routing. One way is to use the search bar with
UUIDs, as it will use the route to the proper resource panel.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Mon, 25 Jan 2021 21:03:25 +0000 (22:03 +0100)]
Merge branch '17256-File-selection-dialog-browser-tests'
closes #17256
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Mon, 25 Jan 2021 20:27:34 +0000 (21:27 +0100)]
Merge branch '17264-Files-in-file-picker-have-wrong-icon'
closes #17264
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Mon, 25 Jan 2021 20:23:34 +0000 (21:23 +0100)]
17264: Replaced file icon with new one
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Sun, 24 Jan 2021 10:32:48 +0000 (11:32 +0100)]
17256: Fixed broken tests
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Fri, 22 Jan 2021 18:38:29 +0000 (15:38 -0300)]
17256: Merge branch 'master' into 17256-File-selection-dialog-browser-tests
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 22 Jan 2021 16:50:53 +0000 (13:50 -0300)]
Updates the Dockefile to request a newer nodejs base image.
Refs #17256
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Thu, 21 Jan 2021 20:56:38 +0000 (21:56 +0100)]
17264: Added generic component to get resource icon
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Wed, 20 Jan 2021 18:22:44 +0000 (19:22 +0100)]
17256: Added browser tests
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Wed, 20 Jan 2021 15:29:58 +0000 (12:29 -0300)]
Merge branch '17109-keepweb-urls-pdh-support'
Refs #17109
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Fri, 15 Jan 2021 19:59:34 +0000 (20:59 +0100)]
Merge branch '17256-file-selection-dialog-issue'
refs #16256
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Fri, 15 Jan 2021 17:18:50 +0000 (18:18 +0100)]
17256: Code optimisation
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Thu, 14 Jan 2021 21:34:35 +0000 (18:34 -0300)]
17109: Adds support for inline keep-web PDH URLs.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Thu, 14 Jan 2021 20:56:37 +0000 (21:56 +0100)]
17256: Added map to enable item resolution
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Peter Amstutz [Thu, 14 Jan 2021 19:17:42 +0000 (14:17 -0500)]
Merge branch '17257-wf-advanced-settings' refs #17257
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Thu, 14 Jan 2021 19:17:13 +0000 (14:17 -0500)]
17257: Don't export DEFAULT_ADVANCED_FORM_VALUES any more
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Thu, 14 Jan 2021 18:28:54 +0000 (13:28 -0500)]
17257: openRunProcess calls getWorkflowRunnerSettings for correct defaults
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Lucas Di Pentima [Thu, 14 Jan 2021 13:58:01 +0000 (10:58 -0300)]
Merge branch '17109-keepweb-webdav-urls'
Refs #17109
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Wed, 13 Jan 2021 15:45:41 +0000 (16:45 +0100)]
Merge branch '17231-stuck-on-loading-page-after-login'
closes #17231
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Wed, 13 Jan 2021 12:57:18 +0000 (13:57 +0100)]
17231: Moved redirect code to other lifecycle method
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Tue, 12 Jan 2021 23:32:30 +0000 (20:32 -0300)]
17109: Hopefully fixes several integration test flakyness issues.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 12 Jan 2021 22:12:25 +0000 (19:12 -0300)]
17109: Fixes related unit test.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 12 Jan 2021 21:38:01 +0000 (18:38 -0300)]
17109: Merge branch 'master' into 17109-keepweb-webdav-urls
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 12 Jan 2021 21:33:50 +0000 (18:33 -0300)]
17109: Handles keep-web's inline wildcard urls correctly.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Tue, 12 Jan 2021 16:09:05 +0000 (17:09 +0100)]
Merge branch '15771-deleting-a-selection-of-files-fails'
closes #15771
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Tue, 12 Jan 2021 10:28:42 +0000 (11:28 +0100)]
15771: Fixed failing unit tests
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Mon, 11 Jan 2021 15:58:44 +0000 (16:58 +0100)]
Merge branch '17016-delete-single-file-deletes-whole-collection'
closes #17016
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Fri, 8 Jan 2021 20:59:27 +0000 (21:59 +0100)]
17231: Added timeout to allow app to load properly before redirect
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>01~
Peter Amstutz [Fri, 8 Jan 2021 19:28:20 +0000 (14:28 -0500)]
Add test guards to wait for progress bar to complete before continuing
no issue #
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Daniel Kutyła [Fri, 8 Jan 2021 16:37:32 +0000 (17:37 +0100)]
17016: Added more unit tests
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Peter Amstutz [Fri, 8 Jan 2021 16:18:25 +0000 (11:18 -0500)]
Fix type refs #17234
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Daniel Kutyła [Thu, 7 Jan 2021 21:34:07 +0000 (22:34 +0100)]
17016: Code optimisation
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Peter Amstutz [Thu, 7 Jan 2021 16:50:46 +0000 (11:50 -0500)]
Merge branch '17234-wf-runner-ram' refs #17234
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Wed, 6 Jan 2021 22:22:36 +0000 (17:22 -0500)]
Merge branch '16622-dav-s3-dialog' refs #16622
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Wed, 6 Jan 2021 22:14:10 +0000 (17:14 -0500)]
17234: Set RAM request for runner container consistently with a-c-r
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Wed, 6 Jan 2021 21:13:13 +0000 (16:13 -0500)]
16622: Add Enzyme tests for WebDavS3InfoDialog
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Tue, 5 Jan 2021 21:56:25 +0000 (16:56 -0500)]
16622: Show connection info for projects as well.
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Tue, 5 Jan 2021 21:00:19 +0000 (16:00 -0500)]
16622: Make the http version a link too
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Tue, 5 Jan 2021 20:57:58 +0000 (15:57 -0500)]
16622: Tweak icon & titles
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Tue, 5 Jan 2021 20:44:08 +0000 (15:44 -0500)]
16622: Use /by_id/, add Cyberduck and MacOS to popup.
Correctly select between collections and download endpoints depending
on whether wildcard DNS is configured.
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Daniel Kutyła [Tue, 5 Jan 2021 20:23:15 +0000 (21:23 +0100)]
17231: Changed the way we navigate to a other page
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Tue, 5 Jan 2021 18:40:31 +0000 (19:40 +0100)]
17016: Added browser test
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Peter Amstutz [Mon, 4 Jan 2021 20:56:03 +0000 (15:56 -0500)]
16622: Dialog with connection details for WebDAV and S3
Uses tabs to reduce visual clutter
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Mon, 4 Jan 2021 16:28:14 +0000 (11:28 -0500)]
Merge branch '17223-webshell' refs #17223
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Peter Amstutz [Wed, 23 Dec 2020 20:24:15 +0000 (15:24 -0500)]
17223: Provide working webshell link by directing user to Workbench1
Eventual fix will be to add the actual webshell javascript terminal
into Workbench 2.
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
Lucas Di Pentima [Mon, 14 Dec 2020 22:08:10 +0000 (19:08 -0300)]
Merge branch '17152-always-preserve-collection-versions'
Closes #17152
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 11 Dec 2020 22:26:36 +0000 (19:26 -0300)]
17152: Avoids returning for code consistency reasons.
Other webdav funcs don't return values, and there's no client code expecting
an answer from that func.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 11 Dec 2020 15:41:30 +0000 (12:41 -0300)]
17152: Avoids doing one extra request to persist versions on update.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Tue, 8 Dec 2020 21:17:12 +0000 (22:17 +0100)]
Merge branch '16812-images-issue-fix'
Closes #16812
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Tue, 8 Dec 2020 21:15:47 +0000 (22:15 +0100)]
16812: Tests improvements
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Tue, 8 Dec 2020 18:21:02 +0000 (19:21 +0100)]
16812: Adding token as query param
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Mon, 7 Dec 2020 19:39:33 +0000 (20:39 +0100)]
16812: Fixed img preview for collection items
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Fri, 4 Dec 2020 21:41:11 +0000 (18:41 -0300)]
17152: Adjusts cypress integration tests.
* Changes arvados' config disabling the collection idle versioning feature.
* Fixes one test that required versioning when updating via API calls.
The rest of the versioning tests continue to work because of the updates made
on workbench2.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Thu, 3 Dec 2020 21:58:22 +0000 (18:58 -0300)]
17152: Adjusts the collection service methods to preserve versions.
As the create() method sets preserve_version to true, it's better
to re-set it to true after each update, so that the modified_at timestamp
of the previous version doesn't change.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 2 Dec 2020 13:37:28 +0000 (10:37 -0300)]
Merge branch '17098-old-version-as-head'
Closes #17098
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Tue, 1 Dec 2020 22:04:59 +0000 (23:04 +0100)]
17016: Fixed deleteFiles function
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Tue, 1 Dec 2020 21:26:32 +0000 (18:26 -0300)]
17098: Improves wording on the "Restore version" action.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Tue, 1 Dec 2020 13:27:16 +0000 (10:27 -0300)]
17098: Improves dialog message wording.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Mon, 30 Nov 2020 23:13:10 +0000 (20:13 -0300)]
17098: Adds confirmation dialog on 'Recover version' action.
Also updates integeration test.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Fri, 27 Nov 2020 19:00:19 +0000 (20:00 +0100)]
Merge branch '17114-side-panel-tree-as-list'
Refs #17114
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Daniel Kutyła [Thu, 26 Nov 2020 20:30:26 +0000 (21:30 +0100)]
17114: Code cleanup
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Wed, 25 Nov 2020 19:05:00 +0000 (16:05 -0300)]
17098: Removes unnecessary prop.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 25 Nov 2020 17:54:07 +0000 (14:54 -0300)]
17098: Adjusts resourceUuidToContextMenuKind() call on version browser.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 25 Nov 2020 17:53:29 +0000 (14:53 -0300)]
17098: Merge branch 'master' into 17098-old-version-as-head
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 25 Nov 2020 17:31:29 +0000 (14:31 -0300)]
Merge branch '13494-collection-version-browser'
Closes #13494
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 25 Nov 2020 16:25:17 +0000 (13:25 -0300)]
17098: Updates integration test for the 'recover version' operation.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 25 Nov 2020 16:08:19 +0000 (13:08 -0300)]
17098: Avoids offering the 'Add to favorites' action on old versions.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 25 Nov 2020 15:19:02 +0000 (12:19 -0300)]
17098: Adds integration test checks for the new action.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Wed, 25 Nov 2020 15:00:59 +0000 (12:00 -0300)]
17098: Fixes unit test for refactored menu kind function.
Added 'redux-mock-store' package that will allow us to unit test dispatched
actions.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Tue, 24 Nov 2020 22:04:10 +0000 (23:04 +0100)]
17114: FlatTree introduced to support old behaviour
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
Lucas Di Pentima [Tue, 24 Nov 2020 20:02:54 +0000 (17:02 -0300)]
13494: Adds context menu support to collection versions browser.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Daniel Kutyła [Tue, 24 Nov 2020 17:04:31 +0000 (18:04 +0100)]
17114: Code cleanup, style cleanup
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>01~
Lucas Di Pentima [Mon, 23 Nov 2020 22:38:16 +0000 (19:38 -0300)]
17098: Adds ability to recover an old version collection as the head version.
This includes a proper menu action set for old collections with the new action.
Also, duplicated code was removed for the collection admin menu action set.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Mon, 23 Nov 2020 22:22:22 +0000 (19:22 -0300)]
17098: Refactors context menu's kind decision function.
Over time, the function got several optional arguments that were mostly
intrinsic of the resource being queried, or the user type. This produced lot
of duplicated and error prone code on the caller's side.
Now, all callers only need to provide a uuid, the will get the same result.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Mon, 23 Nov 2020 16:08:18 +0000 (13:08 -0300)]
17098: Removes unused code file.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Lucas Di Pentima [Fri, 20 Nov 2020 22:22:47 +0000 (19:22 -0300)]
13494: Re-activates other collection related tests.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>