arvados.git
4 years ago15610: Adds behaviors like the original Tree, and max height on VirtualTree.
Lucas Di Pentima [Fri, 26 Jun 2020 20:25:10 +0000 (17:25 -0300)]
15610: Adds behaviors like the original Tree, and max height on VirtualTree.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago15610: Code cleanup, styiling additions. (WIP)
Lucas Di Pentima [Wed, 24 Jun 2020 21:45:31 +0000 (18:45 -0300)]
15610: Code cleanup, styiling additions. (WIP)

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago15610: Uses a virtualized list to show the collection's file tree. (WIP)
Lucas Di Pentima [Tue, 23 Jun 2020 14:37:54 +0000 (11:37 -0300)]
15610: Uses a virtualized list to show the collection's file tree. (WIP)

This greatly improves rendering times when showing collections with many
files on a directory.
This is a POC: the whole tree is rendered expanded to show that it doesn't
affect render times, it still needs lots of tweaking to offer the same
behavior as before.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago15610: Avoids loading the file list on big collections, offers manual loading.
Lucas Di Pentima [Mon, 15 Jun 2020 19:03:58 +0000 (16:03 -0300)]
15610: Avoids loading the file list on big collections, offers manual loading.

After the previous performance enhancements, 75% of the time spent to show
the collection's files goes to the WebDAV request + parsing, so to avoid
inadvertently freezing the UI, when the file_count field passes a predefined
value (now 40k files), the user gets the option to manually load the file
listing by clicking on a button.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago15610: Removes dead code about collection manifest parsing.
Lucas Di Pentima [Fri, 12 Jun 2020 22:11:59 +0000 (19:11 -0300)]
15610: Removes dead code about collection manifest parsing.

File handling is done via WebDAV, I guess the code was written before
we had the service available.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago15610: Shows status indicator while loading collection's file data.
Lucas Di Pentima [Fri, 12 Jun 2020 20:54:31 +0000 (17:54 -0300)]
15610: Shows status indicator while loading collection's file data.

This includes the general app progress indicator, and a '(loading files...)'
text label where the file tree should be rendered.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago15610: Fixes file downloading.
Lucas Di Pentima [Fri, 12 Jun 2020 19:42:45 +0000 (16:42 -0300)]
15610: Fixes file downloading.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago15610: Enhances performance on tree handling.
Lucas Di Pentima [Fri, 12 Jun 2020 18:07:23 +0000 (15:07 -0300)]
15610: Enhances performance on tree handling.

Large trees (eg: large collection file hierarchies) handling performance boost
by doing in-place data manipulations instead of functional programming style
data copying.
This enables workbench2 to gracefully show mid-sized collections of around
50k items without making the user wait too much for the UI to respond.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoMerge branch '16439-objects-creation-placement-fix-tests'
Lucas Di Pentima [Wed, 10 Jun 2020 19:55:27 +0000 (16:55 -0300)]
Merge branch '16439-objects-creation-placement-fix-tests'
Closes #16439

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoMerge branch '16171-oidc'
Tom Clegg [Mon, 8 Jun 2020 14:30:20 +0000 (10:30 -0400)]
Merge branch '16171-oidc'

refs #16171

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16171: Add OpenIDConnect login option to config struct.
Tom Clegg [Thu, 4 Jun 2020 13:57:07 +0000 (09:57 -0400)]
16171: Add OpenIDConnect login option to config struct.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16439: Adds e2e tests for creating collections & projects.
Lucas Di Pentima [Wed, 3 Jun 2020 21:46:59 +0000 (18:46 -0300)]
16439: Adds e2e tests for creating collections & projects.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoMerge branch '16439-objects-creation-placement-fix'
Lucas Di Pentima [Wed, 3 Jun 2020 16:57:50 +0000 (13:57 -0300)]
Merge branch '16439-objects-creation-placement-fix'
Refs #16439

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16439: Adds SidePanelButton clickability tests.
Lucas Di Pentima [Tue, 2 Jun 2020 22:14:19 +0000 (19:14 -0300)]
16439: Adds SidePanelButton clickability tests.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16439: Merge branch 'master' into 16439-objects-creation-placement-fix
Lucas Di Pentima [Tue, 2 Jun 2020 19:14:27 +0000 (16:14 -0300)]
16439: Merge branch 'master' into 16439-objects-creation-placement-fix

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16439: Disables +NEW button even on trashed subprojects.
Lucas Di Pentima [Tue, 2 Jun 2020 19:05:22 +0000 (16:05 -0300)]
16439: Disables +NEW button even on trashed subprojects.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16439: Fixes colletion/project creation placement.
Lucas Di Pentima [Tue, 2 Jun 2020 18:47:42 +0000 (15:47 -0300)]
16439: Fixes colletion/project creation placement.

When the user was placed on other sections than 'Projects' on the side
panel, the newly created collections/projects were going to the user's
home project.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16439: Enables the +NEW button only when the user's view is writable.
Lucas Di Pentima [Mon, 1 Jun 2020 21:30:19 +0000 (18:30 -0300)]
16439: Enables the +NEW button only when the user's view is writable.

Also, makes the SidePanelButton component to not depend on a state property
set by a something rendered later, because that makes the button being
re-renderered at least twice on every location change, instead try to get the
current item id from the location url.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16439: Reduces vertical spacing between form elements.
Lucas Di Pentima [Mon, 1 Jun 2020 13:49:29 +0000 (10:49 -0300)]
16439: Reduces vertical spacing between form elements.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16439: Updates field label.
Lucas Di Pentima [Fri, 29 May 2020 18:59:42 +0000 (15:59 -0300)]
16439: Updates field label.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16439: Adds read-only field 'Location' to project/collection creation dialogs.
Lucas Di Pentima [Fri, 29 May 2020 14:05:24 +0000 (11:05 -0300)]
16439: Adds read-only field 'Location' to project/collection creation dialogs.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16439: Sends the user to the newly created project/collection.
Lucas Di Pentima [Thu, 28 May 2020 18:05:01 +0000 (15:05 -0300)]
16439: Sends the user to the newly created project/collection.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoMerge branch '16118-readonly-collections-lucas'
Lucas Di Pentima [Thu, 28 May 2020 00:11:54 +0000 (21:11 -0300)]
Merge branch '16118-readonly-collections-lucas'
Closes #16118

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16118: Shows only the readonly icon by the collection's name.
Lucas Di Pentima [Wed, 27 May 2020 23:57:55 +0000 (20:57 -0300)]
16118: Shows only the readonly icon by the collection's name.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16439: Allows creation of empty (no files) collections.
Lucas Di Pentima [Tue, 26 May 2020 15:18:17 +0000 (12:18 -0300)]
16439: Allows creation of empty (no files) collections.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16439: Fixes WebDAV request URL.
Lucas Di Pentima [Wed, 27 May 2020 21:21:38 +0000 (18:21 -0300)]
16439: Fixes WebDAV request URL.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16118: Changes the testing viewport size to avoid spurious test failures.
Lucas Di Pentima [Tue, 26 May 2020 14:18:47 +0000 (11:18 -0300)]
16118: Changes the testing viewport size to avoid spurious test failures.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16118: Restablishes error snackbar on requests.
Lucas Di Pentima [Fri, 22 May 2020 20:37:23 +0000 (17:37 -0300)]
16118: Restablishes error snackbar on requests.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16118: Changes read-only icon to be a slash+pencil fontawesome composite.
Lucas Di Pentima [Fri, 22 May 2020 20:31:32 +0000 (17:31 -0300)]
16118: Changes read-only icon to be a slash+pencil fontawesome composite.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16118: Enhances tests. Adds custom commands for resource creation.
Lucas Di Pentima [Fri, 22 May 2020 18:29:54 +0000 (15:29 -0300)]
16118: Enhances tests. Adds custom commands for resource creation.

* Checks that the properties editor form doesn't get shown on readonly colls.
* Creates collections inside a shared group to check for writability.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoMerge branch '15881-ldap'
Lucas Di Pentima [Mon, 18 May 2020 21:03:42 +0000 (18:03 -0300)]
Merge branch '15881-ldap'
Refs #15881

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16118: Fixes webdav tests by handling baseURLs with or without trailing slash.
Lucas Di Pentima [Mon, 18 May 2020 13:45:55 +0000 (10:45 -0300)]
16118: Fixes webdav tests by handling baseURLs with or without trailing slash.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16118: Adds test checking writable/readonly collection UI changes.
Lucas Di Pentima [Mon, 18 May 2020 13:12:23 +0000 (10:12 -0300)]
16118: Adds test checking writable/readonly collection UI changes.

WIP: There's deactivated code that shows a snackbar whenever a service request
returns an error, no matter if the error is handled somewhere up in the stack.
I think that isn't a good approach, also it prevents the 'readonly' case to
work because the snackbar appears in fron of a menu button and cannot be
clicked.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16118: Fixes WebDAV request URL.
Lucas Di Pentima [Fri, 15 May 2020 14:21:18 +0000 (11:21 -0300)]
16118: Fixes WebDAV request URL.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16118: Merge branch '15881-ldap' into 16118-readonly-collections-lucas
Lucas Di Pentima [Thu, 14 May 2020 23:46:57 +0000 (20:46 -0300)]
16118: Merge branch '15881-ldap' into 16118-readonly-collections-lucas

Need this before it gets merged to master to successfully run e2e test.

4 years ago15881: Simplifies code that decides if it need to show a login form.
Lucas Di Pentima [Thu, 14 May 2020 21:37:29 +0000 (18:37 -0300)]
15881: Simplifies code that decides if it need to show a login form.

Also, remove any trailing slashes on service's ExternalURLs coming from the
exported cluster config.
Refs #16392

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago15881: Use user/pass login if server config uses LDAP.
Tom Clegg [Thu, 14 May 2020 18:31:28 +0000 (14:31 -0400)]
15881: Use user/pass login if server config uses LDAP.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>

4 years ago16118: Changes read-only padlock icon with an explicit legend.
Lucas Di Pentima [Mon, 11 May 2020 19:53:27 +0000 (16:53 -0300)]
16118: Changes read-only padlock icon with an explicit legend.

Also adds cypress-specific attributes to be able to get UI elements in a more
readable way.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16118: Adds collection's integration test suite (WIP)
Lucas Di Pentima [Mon, 11 May 2020 19:50:21 +0000 (16:50 -0300)]
16118: Adds collection's integration test suite (WIP)

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16118: Restricts UI elements when a collection is read-only.
Lucas Di Pentima [Fri, 1 May 2020 20:56:22 +0000 (17:56 -0300)]
16118: Restricts UI elements when a collection is read-only.

* Shows a lock icon indicating the read-only access.
* The three-dotted 'More options' menu only shows appropriate actions.
* The properties panel only shows properties without the 'delete tag' button.
* The files panel general 'More options' menu shows appropriate actions.
* The files panel individual context menu also filters editing action when
  read-only.
* The files panel's upload button isn't rendered on read-only collections.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoMerge branch '16212-login-form'
Lucas Di Pentima [Thu, 30 Apr 2020 20:45:42 +0000 (17:45 -0300)]
Merge branch '16212-login-form'
Refs #16212

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16212: Adds tests for login via user/password form.
Lucas Di Pentima [Tue, 28 Apr 2020 22:06:02 +0000 (19:06 -0300)]
16212: Adds tests for login via user/password form.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16212: Refactors PeopleSelect component used on 'Share' dialog.
Lucas Di Pentima [Mon, 27 Apr 2020 22:06:29 +0000 (19:06 -0300)]
16212: Refactors PeopleSelect component used on 'Share' dialog.

* Now named ParticipantSelect as it also retrieves Groups.
* Search for 'any' field on Users instead of just email.
* Don't request groups if 'onlyPeople' prop passed.
* Show users' display name, including email.
* Fix chip rendering to show the same as what's listed.

TBD: ParticipantSelect retrieves only 5 items per request when autocompleting.
This may not be what users expect, but listing too many items require UI
adjustments.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16212: Uses getUserDisplayName() wherever needed to show a user's name.
Lucas Di Pentima [Fri, 24 Apr 2020 20:55:34 +0000 (17:55 -0300)]
16212: Uses getUserDisplayName() wherever needed to show a user's name.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16212: Displays user depending on available user data.
Lucas Di Pentima [Fri, 24 Apr 2020 15:06:29 +0000 (12:06 -0300)]
16212: Displays user depending on available user data.

Some times first/last names or email aren't available, so we want to
show other than an empty string.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16212: Assembles v2 token for authentication.
Lucas Di Pentima [Tue, 7 Apr 2020 21:52:10 +0000 (18:52 -0300)]
16212: Assembles v2 token for authentication.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16212: Updates form POST to use new 'users/authenticate' endpoint.
Lucas Di Pentima [Wed, 1 Apr 2020 16:10:55 +0000 (13:10 -0300)]
16212: Updates form POST to use new 'users/authenticate' endpoint.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16212: Support LoginCluster feature.
Lucas Di Pentima [Tue, 31 Mar 2020 18:59:40 +0000 (15:59 -0300)]
16212: Support LoginCluster feature.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16212: Loads remote clusters configs at app boot.
Lucas Di Pentima [Tue, 31 Mar 2020 18:35:29 +0000 (15:35 -0300)]
16212: Loads remote clusters configs at app boot.

When using a federation without LoginCluster, the user is given the option
to log in using any cluster as the 'home cluster'. If any of those remote
clusters has Login.PAM enabled, the login form is displayed.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16212: Sets api token on login success, re-focus on login error.
Lucas Di Pentima [Mon, 30 Mar 2020 16:29:48 +0000 (13:29 -0300)]
16212: Sets api token on login success, re-focus on login error.

Also, shows an error message if successful login response doesn't have a token.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16212: Set focus on username input element.
Lucas Di Pentima [Mon, 30 Mar 2020 14:43:43 +0000 (11:43 -0300)]
16212: Set focus on username input element.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16212: Adds login form when PAM Login is enabled. (WIP)
Lucas Di Pentima [Sun, 29 Mar 2020 14:50:01 +0000 (11:50 -0300)]
16212: Adds login form when PAM Login is enabled. (WIP)

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16212: Upgrades react & react-dom to support hooks.
Lucas Di Pentima [Fri, 27 Mar 2020 22:11:17 +0000 (19:11 -0300)]
16212: Upgrades react & react-dom to support hooks.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16212: Loads PAM login feature from exported config.
Lucas Di Pentima [Fri, 27 Mar 2020 21:50:04 +0000 (18:50 -0300)]
16212: Loads PAM login feature from exported config.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoMerge branch '16029-cypress-testing'
Lucas Di Pentima [Thu, 23 Apr 2020 16:44:12 +0000 (13:44 -0300)]
Merge branch '16029-cypress-testing'
Closes #16029

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16029: Add 'make integration-tests-in-docker'
Peter Amstutz [Thu, 23 Apr 2020 16:32:38 +0000 (12:32 -0400)]
16029: Add 'make integration-tests-in-docker'

Also update README

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16029: Adds options to orchestration script to allow interactive mode.
Lucas Di Pentima [Tue, 21 Apr 2020 15:18:23 +0000 (12:18 -0300)]
16029: Adds options to orchestration script to allow interactive mode.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16029: Enhances orquestration script in various ways.
Lucas Di Pentima [Mon, 20 Apr 2020 22:34:40 +0000 (19:34 -0300)]
16029: Enhances orquestration script in various ways.

* Checks if wb2's config.json exists and quits with a message.
* Adds timeouts on arvados-boot & wb2 executions to avoid wating for ever.
* If timeouts are reached, exits with error code and doesn't run tests.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16029: Working on a better way of launching arvados boot. (WIP)
Lucas Di Pentima [Mon, 20 Apr 2020 16:00:27 +0000 (13:00 -0300)]
16029: Working on a better way of launching arvados boot. (WIP)

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16029: Moves Dockefile to its own subdir.
Lucas Di Pentima [Fri, 17 Apr 2020 17:58:22 +0000 (14:58 -0300)]
16029: Moves Dockefile to its own subdir.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16029: Updates Dockerfile to build a seeded image with arvados boot deps.
Lucas Di Pentima [Wed, 15 Apr 2020 20:24:37 +0000 (17:24 -0300)]
16029: Updates Dockerfile to build a seeded image with arvados boot deps.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16029: Adds orquestration script.
Lucas Di Pentima [Wed, 15 Apr 2020 17:19:12 +0000 (14:19 -0300)]
16029: Adds orquestration script.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16029: Removes the need to use pre-existing fixtures.
Lucas Di Pentima [Mon, 13 Apr 2020 13:07:39 +0000 (10:07 -0300)]
16029: Removes the need to use pre-existing fixtures.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16029: Force cypress to request minimist 1.2.5 instead of vulnerable 1.2.0
Lucas Di Pentima [Tue, 7 Apr 2020 19:54:45 +0000 (16:54 -0300)]
16029: Force cypress to request minimist 1.2.5 instead of vulnerable 1.2.0

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16029: Merge branch 'master' into 16029-cypress-testing
Lucas Di Pentima [Mon, 6 Apr 2020 20:30:45 +0000 (17:30 -0300)]
16029: Merge branch 'master' into 16029-cypress-testing

4 years agoUpgrades vulnerable minimist module by upgrading handlebars (2 levels up).
Lucas Di Pentima [Mon, 6 Apr 2020 20:15:30 +0000 (17:15 -0300)]
Upgrades vulnerable minimist module by upgrading handlebars (2 levels up).

No issue #

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoUpgrades minimist package (indirect dependency) to address CVE-2020-7598.
Lucas Di Pentima [Mon, 6 Apr 2020 19:59:19 +0000 (16:59 -0300)]
Upgrades minimist package (indirect dependency) to address CVE-2020-7598.

No issue #

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoUpgrades acorn package (indirect dependency) to address a security issue.
Lucas Di Pentima [Mon, 6 Apr 2020 19:51:53 +0000 (16:51 -0300)]
Upgrades acorn package (indirect dependency) to address a security issue.

https://www.npmjs.com/advisories/1488

No issue #

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16029: Completes the basic set of login tests.
Lucas Di Pentima [Mon, 16 Mar 2020 19:09:00 +0000 (16:09 -0300)]
16029: Completes the basic set of login tests.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16029: Fixes failed login attempt by redirecting the user to the login page.
Lucas Di Pentima [Mon, 16 Mar 2020 19:04:27 +0000 (16:04 -0300)]
16029: Fixes failed login attempt by redirecting the user to the login page.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16029: Tests login with valid & expired tokens. Exposes a bug.
Lucas Di Pentima [Mon, 16 Mar 2020 18:22:27 +0000 (15:22 -0300)]
16029: Tests login with valid & expired tokens. Exposes a bug.

When using an expired/invalid token, workbench2 doesn't do anything, it
should at least show the login page.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16029: Adds support for reading YAML fixtures and receive config data.
Lucas Di Pentima [Sat, 14 Mar 2020 16:21:57 +0000 (13:21 -0300)]
16029: Adds support for reading YAML fixtures and receive config data.

Also, adds a command to reset the testing database.
Config data can be passed in several ways:

* Running 'yarn run cypress [open|run] --env fixtures=/a/path,controller_url=...'
* Setting environment variables named with the 'CYPRESS_' prefix.
* Using Cypress.config() inside the test cases.

For now, 3 config items are needed:

1. Arvados fixtures path
2. System root token (defined on arvados-boot's zzzzz.yml config file) so a
   database reset can be called.
3. Controller's URL

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoMerge branch '15951-filter-ui-polish'. Closes #15951
Lucas Di Pentima [Wed, 11 Mar 2020 13:32:18 +0000 (10:32 -0300)]
Merge branch '15951-filter-ui-polish'. Closes #15951

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago15951: Fixes 'select columns' button tooltip label & behavior.
Lucas Di Pentima [Tue, 10 Mar 2020 22:11:42 +0000 (19:11 -0300)]
15951: Fixes 'select columns' button tooltip label & behavior.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago15951: Removes dead code, updates tests to work with component being used.
Lucas Di Pentima [Wed, 4 Mar 2020 01:37:21 +0000 (22:37 -0300)]
15951: Removes dead code, updates tests to work with component being used.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago15951: Hides tooltips on filter buttons after being clicked.
Lucas Di Pentima [Wed, 4 Mar 2020 00:42:12 +0000 (21:42 -0300)]
15951: Hides tooltips on filter buttons after being clicked.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago15951: Accepts filter toggle actions when clicking on the entire row.
Lucas Di Pentima [Wed, 4 Mar 2020 00:20:28 +0000 (21:20 -0300)]
15951: Accepts filter toggle actions when clicking on the entire row.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago15951: Makes 'mutually exclusive' filter dialog auto-submit selection on click.
Lucas Di Pentima [Tue, 3 Mar 2020 21:45:05 +0000 (18:45 -0300)]
15951: Makes 'mutually exclusive' filter dialog auto-submit selection on click.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoMerge branch '16181-fix-vm-view' refs #16181
Peter Amstutz [Thu, 27 Feb 2020 19:51:31 +0000 (14:51 -0500)]
Merge branch '16181-fix-vm-view' refs #16181

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16181: Default to empty string if SSHHelpHostSuffix undefined
Peter Amstutz [Thu, 27 Feb 2020 19:50:28 +0000 (14:50 -0500)]
16181: Default to empty string if SSHHelpHostSuffix undefined

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16181: Rework the user attributes dialog a bit
Peter Amstutz [Thu, 27 Feb 2020 15:44:42 +0000 (10:44 -0500)]
16181: Rework the user attributes dialog a bit

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16181: Support SSHHelpHostSuffix, fix user VM page render issues
Peter Amstutz [Thu, 27 Feb 2020 15:02:32 +0000 (10:02 -0500)]
16181: Support SSHHelpHostSuffix, fix user VM page render issues

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

4 years ago16029: Adds first end-to-end tests for the login flow.
Lucas Di Pentima [Mon, 24 Feb 2020 20:35:36 +0000 (17:35 -0300)]
16029: Adds first end-to-end tests for the login flow.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16029: Adds cypress as a dev dependency.
Lucas Di Pentima [Fri, 21 Feb 2020 16:42:59 +0000 (13:42 -0300)]
16029: Adds cypress as a dev dependency.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoFixes package building.
Lucas Di Pentima [Wed, 19 Feb 2020 23:55:08 +0000 (20:55 -0300)]
Fixes package building.

No issue #

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoMerge branch '15781-multi-value-property-edit'
Lucas Di Pentima [Wed, 19 Feb 2020 21:43:32 +0000 (18:43 -0300)]
Merge branch '15781-multi-value-property-edit'

Refs #15781

4 years ago15781: Replaces 'like' operator with '=' on fallback property matches.
Lucas Di Pentima [Wed, 19 Feb 2020 21:31:58 +0000 (18:31 -0300)]
15781: Replaces 'like' operator with '=' on fallback property matches.

Also, add container requests to the search.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago15781: Changes filter fallback on properties to use 'like' instead of 'ilike'.
Lucas Di Pentima [Wed, 19 Feb 2020 18:21:46 +0000 (15:21 -0300)]
15781: Changes filter fallback on properties to use 'like' instead of 'ilike'.

This is to make it consistent with how 'contains' behaves, both doing case
insensitive matches.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoUpdate maintainer for our OS packages.
Ward Vandewege [Sat, 15 Feb 2020 02:18:18 +0000 (21:18 -0500)]
Update maintainer for our OS packages.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@jhvc.com>

4 years ago15781: Avoids showing duplicate property 'chips' on search editor.
Lucas Di Pentima [Fri, 14 Feb 2020 19:31:44 +0000 (16:31 -0300)]
15781: Avoids showing duplicate property 'chips' on search editor.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago15781: Fixes property removal on the advanced search editor.
Lucas Di Pentima [Fri, 14 Feb 2020 18:50:42 +0000 (15:50 -0300)]
15781: Fixes property removal on the advanced search editor.

Also, adds some tests ensuring that properties IDs are used when available.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago15781: Fixes project tag add/delete error handling.
Lucas Di Pentima [Thu, 13 Feb 2020 16:38:40 +0000 (13:38 -0300)]
15781: Fixes project tag add/delete error handling.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago15781: Fixes collection tag add/delete error handling.
Lucas Di Pentima [Thu, 13 Feb 2020 15:04:56 +0000 (12:04 -0300)]
15781: Fixes collection tag add/delete error handling.

Tags (chips) were added/removed to the UI even when the update call failed.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago15781: Uses 'contains' or 'ilike' on prop searches depending on API revision.
Lucas Di Pentima [Wed, 12 Feb 2020 23:59:46 +0000 (20:59 -0300)]
15781: Uses 'contains' or 'ilike' on prop searches depending on API revision.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago15718: Adds API revision number from discovery doc to sessions.
Lucas Di Pentima [Wed, 12 Feb 2020 22:53:20 +0000 (19:53 -0300)]
15718: Adds API revision number from discovery doc to sessions.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago15781: Merge branch 'master' into 15781-multi-value-property-edit
Lucas Di Pentima [Tue, 11 Feb 2020 13:54:41 +0000 (10:54 -0300)]
15781: Merge branch 'master' into 15781-multi-value-property-edit

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoMerge branch '16067-collection-copy-fix'
Lucas Di Pentima [Wed, 5 Feb 2020 22:02:54 +0000 (19:02 -0300)]
Merge branch '16067-collection-copy-fix'

Closes #16067

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16067: Adds remaining collection resource read-only fields.
Lucas Di Pentima [Wed, 5 Feb 2020 22:01:16 +0000 (19:01 -0300)]
16067: Adds remaining collection resource read-only fields.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years agoMerge branch '16116-collection-rename-fix'
Lucas Di Pentima [Wed, 5 Feb 2020 21:13:56 +0000 (18:13 -0300)]
Merge branch '16116-collection-rename-fix'

Closes #16116

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>

4 years ago16067: Ignores certain fields on create & update api calls.
Lucas Di Pentima [Wed, 5 Feb 2020 21:05:08 +0000 (18:05 -0300)]
16067: Ignores certain fields on create & update api calls.

Some fields like 'etag', 'kind', 'uuid' and others are read-only, so
they shouldn't be sent to the API server.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>