arvados.git
7 years agoMerge branch '12073-nodemanager-stale-nodes-recs-bis'
Lucas Di Pentima [Mon, 2 Oct 2017 14:24:59 +0000 (11:24 -0300)]
Merge branch '12073-nodemanager-stale-nodes-recs-bis'
Closes #12073

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <ldipentima@veritasgenetics.com>

7 years ago12073: Prioritize stale node records that have a slot_number when
Lucas Di Pentima [Sat, 30 Sep 2017 03:02:19 +0000 (00:02 -0300)]
12073: Prioritize stale node records that have a slot_number when
trying to assign one to a cloud node.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <ldipentima@veritasgenetics.com>

7 years agoMerge branch '12278-cwl-debug-flag' closes #12278
Peter Amstutz [Fri, 29 Sep 2017 20:33:12 +0000 (16:33 -0400)]
Merge branch '12278-cwl-debug-flag' closes #12278

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years agoMerge branch '12273-skip-special-files'
Tom Clegg [Fri, 29 Sep 2017 18:24:15 +0000 (14:24 -0400)]
Merge branch '12273-skip-special-files'

closes #12273

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years agoMerge branch '12341-slow-node-destroy'
Lucas Di Pentima [Fri, 29 Sep 2017 18:16:08 +0000 (15:16 -0300)]
Merge branch '12341-slow-node-destroy'
Closes #12341

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <ldipentima@veritasgenetics.com>

7 years ago12341: Ensure shutdown_actor.stop() is called on node_finished_shutdown.
Lucas Di Pentima [Fri, 29 Sep 2017 14:37:17 +0000 (11:37 -0300)]
12341: Ensure shutdown_actor.stop() is called on node_finished_shutdown.
Updated test related to shutdown race condition.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <ldipentima@veritasgenetics.com>

7 years agoMerge branch '12347-obey-wf-reuse-hint'
Tom Clegg [Fri, 29 Sep 2017 12:56:35 +0000 (08:56 -0400)]
Merge branch '12347-obey-wf-reuse-hint'

closes #12347

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12347: Don't reuse runner job/container if arv:enableReuse is false.
Tom Clegg [Thu, 28 Sep 2017 03:09:16 +0000 (23:09 -0400)]
12347: Don't reuse runner job/container if arv:enableReuse is false.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12341: If a node_destroy call succesfully destroys the VM but takes too long
Lucas Di Pentima [Thu, 28 Sep 2017 21:09:09 +0000 (18:09 -0300)]
12341: If a node_destroy call succesfully destroys the VM but takes too long
to finish with additional tasks, the cloud_node_update may be called
in the meantime, removing the node from the cloud_node list. If this happens,
node_finished_shutdown() won't be able to retrieve the node, and shouldn't
raise an exception.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <ldipentima@veritasgenetics.com>

7 years agoMerge branch '12347-disable-reuse'
Tom Clegg [Thu, 28 Sep 2017 20:54:28 +0000 (16:54 -0400)]
Merge branch '12347-disable-reuse'

refs #12347

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago11583: Fix hung goroutines when stubbed container never runs.
Tom Clegg [Thu, 28 Sep 2017 18:52:01 +0000 (14:52 -0400)]
11583: Fix hung goroutines when stubbed container never runs.

Test suite memory usage goes down from >8GB to 1.5GB.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago11583: Stop signal handlers on shutdown.
Tom Clegg [Thu, 28 Sep 2017 18:19:55 +0000 (14:19 -0400)]
11583: Stop signal handlers on shutdown.

Reduces noise in goroutine dumps during test suite.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12273: Skip non-regular files when uploading outputs to Keep.
Tom Clegg [Thu, 28 Sep 2017 17:57:21 +0000 (13:57 -0400)]
12273: Skip non-regular files when uploading outputs to Keep.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12278: Need to set debug logging in crunch_script.py
Peter Amstutz [Thu, 28 Sep 2017 16:52:44 +0000 (12:52 -0400)]
12278: Need to set debug logging in crunch_script.py

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12278: Bump schema-salad and cwltool for SourceLine fix.
Peter Amstutz [Thu, 28 Sep 2017 16:12:33 +0000 (12:12 -0400)]
12278: Bump schema-salad and cwltool for SourceLine fix.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12278: Filter nameext and nameroot from final cwl.output.json
Peter Amstutz [Tue, 26 Sep 2017 19:49:43 +0000 (15:49 -0400)]
12278: Filter nameext and nameroot from final cwl.output.json

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12278: SourceLine yields stack trace if debugging enabled
Peter Amstutz [Tue, 26 Sep 2017 13:44:57 +0000 (09:44 -0400)]
12278: SourceLine yields stack trace if debugging enabled

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12278: Can provide custom schema salad to dev jobs build.
Peter Amstutz [Mon, 25 Sep 2017 20:10:39 +0000 (16:10 -0400)]
12278: Can provide custom schema salad to dev jobs build.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12278: Propagate --debug flag to jobs.
Peter Amstutz [Mon, 25 Sep 2017 15:32:20 +0000 (11:32 -0400)]
12278: Propagate --debug flag to jobs.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12347: Fix --disable-reuse for jobs API.
Tom Clegg [Thu, 28 Sep 2017 02:24:06 +0000 (22:24 -0400)]
12347: Fix --disable-reuse for jobs API.

The --disable-reuse flag was creating a pipeline instance containing a
job that ran cwl with reuse disabled, but it didn't set
properties.run_options.enable_job_reuse on the pipeline instance
itself. If you had run before with --disable-reuse, that previous run
would be eligible for reuse.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12347: Fix formatting.
Tom Clegg [Thu, 28 Sep 2017 02:16:32 +0000 (22:16 -0400)]
12347: Fix formatting.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12347: Fix --disable-reuse for containers API.
Tom Clegg [Thu, 28 Sep 2017 02:11:11 +0000 (22:11 -0400)]
12347: Fix --disable-reuse for containers API.

The --disable-reuse flag was requesting a container to run
"arvados-cwl-runner --disable-reuse", but it didn't set
use_existing=False on the container request itself. If you had run
before with --disable-reuse, that previous run would be eligible for
reuse.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years agoUpdate documentation to reflect that we are packaging Debian 9
Ward Vandewege [Wed, 27 Sep 2017 21:57:16 +0000 (17:57 -0400)]
Update documentation to reflect that we are packaging Debian 9
('stretch').

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <wvandewege@veritasgenetics.com>

7 years ago12246: Make "possible causes" message easier to find and read. refs #12246
Peter Amstutz [Wed, 27 Sep 2017 18:21:32 +0000 (14:21 -0400)]
12246: Make "possible causes" message easier to find and read. refs #12246

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years agoMerge branch '12246-command-not-found'
Tom Clegg [Wed, 27 Sep 2017 17:01:36 +0000 (13:01 -0400)]
Merge branch '12246-command-not-found'

closes #12246

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12246: Add debugging clues when command is not found in container.
Tom Clegg [Wed, 27 Sep 2017 15:26:22 +0000 (11:26 -0400)]
12246: Add debugging clues when command is not found in container.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years agoMerge branch '12195-nodemanager-quota-error'
Lucas Di Pentima [Wed, 27 Sep 2017 14:05:14 +0000 (11:05 -0300)]
Merge branch '12195-nodemanager-quota-error'
Closes #12195

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <ldipentima@veritasgenetics.com>

7 years ago12195: Fixed warning message when the Retry-After header value cannot
Lucas Di Pentima [Wed, 27 Sep 2017 13:39:36 +0000 (10:39 -0300)]
12195: Fixed warning message when the Retry-After header value cannot
be converted to integer.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <ldipentima@veritasgenetics.com>

7 years agoSuppress superfluous error message.
Tom Clegg [Tue, 26 Sep 2017 20:29:42 +0000 (16:29 -0400)]
Suppress superfluous error message.

No issue #

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12032: Fix compatibility with PostgreSQL 9.4.
Tom Clegg [Tue, 26 Sep 2017 19:39:00 +0000 (15:39 -0400)]
12032: Fix compatibility with PostgreSQL 9.4.

9.4 doesn't have idle_in_transaction_session_timeout or row_security
configs, so couldn't execute structure.sql.

9.4 doesn't write "Dumped from/by version X", so 9.4 and 9.6 dev boxes
want an edit war.

refs #12032

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years agoMerge branch '12287-preserve-json-numbers' closes #12287
Peter Amstutz [Tue, 26 Sep 2017 19:28:32 +0000 (15:28 -0400)]
Merge branch '12287-preserve-json-numbers' closes #12287

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12287: Add number round-trip test.
Peter Amstutz [Tue, 26 Sep 2017 17:56:04 +0000 (13:56 -0400)]
12287: Add number round-trip test.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12287: Preserve JSON number types/formats in log file.
Tom Clegg [Tue, 26 Sep 2017 02:43:10 +0000 (22:43 -0400)]
12287: Preserve JSON number types/formats in log file.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years agoMerge branch '12316-fix-provenance-graph'
Ward Vandewege [Tue, 26 Sep 2017 02:12:55 +0000 (22:12 -0400)]
Merge branch '12316-fix-provenance-graph'

closes #12316

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <wvandewege@veritasgenetics.com>

7 years agoDo not blow up the provenance graph if a PDH used in the workflow no
Ward Vandewege [Mon, 25 Sep 2017 20:53:21 +0000 (16:53 -0400)]
Do not blow up the provenance graph if a PDH used in the workflow no
longer exists.

refs #12316

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <wvandewege@veritasgenetics.com>

7 years ago12276: Ensure dirent cache is disabled.
Tom Clegg [Fri, 22 Sep 2017 21:00:07 +0000 (17:00 -0400)]
12276: Ensure dirent cache is disabled.

Setting this to zero fixed flakiness in #7751, so we might still rely
on it being zero for reliability.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12276: Remove debug logging message.
Peter Amstutz [Fri, 22 Sep 2017 18:43:26 +0000 (14:43 -0400)]
12276: Remove debug logging message.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12276: Reduce number of spurious invalidations sent to kernel.
Peter Amstutz [Fri, 22 Sep 2017 15:21:07 +0000 (11:21 -0400)]
12276: Reduce number of spurious invalidations sent to kernel.

* New policy to only send invalidations on objects that have a nonzero
  kernel reference count.
* When clearing the contents of a CollectionDirectory, only invalidate the
  topmost directory entry, this should take care of invalidating all paths
  beneath it as well.
* Don't send invalidate_inode() when deleting an inode (by definition, the
  inode is unreferenced by the kernel).
* Remove allow_dirent_cache for now (this only relates to caching negative
  lookups, which we don't support).
* Set attribute attr_timeout based on the polling period of the underlying
  object.
* FuncToJSONFile sets allow_attr_cache = False instead of allow_dirent_cache =
  False (which is useless in this case).

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12298: Allow non-null log when cancelling an unrunnable container.
Tom Clegg [Wed, 20 Sep 2017 21:44:22 +0000 (17:44 -0400)]
12298: Allow non-null log when cancelling an unrunnable container.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12287: Preserve JSON number types/formats in container records.
Tom Clegg [Fri, 22 Sep 2017 18:58:34 +0000 (14:58 -0400)]
12287: Preserve JSON number types/formats in container records.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years agoMerge branch '12032-project-trash' refs #12032
Peter Amstutz [Mon, 25 Sep 2017 19:39:50 +0000 (15:39 -0400)]
Merge branch '12032-project-trash' refs #12032

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years agoMerge branch '12271-fpm-cleanup-on-rpm-upgrade' closes #12271
Javier Bértoli [Mon, 25 Sep 2017 19:00:02 +0000 (16:00 -0300)]
Merge branch '12271-fpm-cleanup-on-rpm-upgrade' closes #12271

Arvados-DCO-1.1-Signed-off-by: Javier Bértoli <jbertoli@veritasgenetics.com>

7 years ago12195: Log warning message when a retry-after header is not an integer.
Lucas Di Pentima [Mon, 25 Sep 2017 13:44:26 +0000 (10:44 -0300)]
12195: Log warning message when a retry-after header is not an integer.
Make sure min_retry_wait & max_retry_wait have sensible values.
Check that the effective retry wait is within bounds and doesn't get reset
when retry-after is zero, so it continues the exponential backoff plan.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <ldipentima@veritasgenetics.com>

7 years agoMerge branch '11068-cwl-missing-docker' closes #11068
Peter Amstutz [Mon, 25 Sep 2017 13:19:50 +0000 (09:19 -0400)]
Merge branch '11068-cwl-missing-docker' closes #11068

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years agoMerge branch '12276-fuse-deadlock' refs #12276
Peter Amstutz [Sat, 23 Sep 2017 00:38:00 +0000 (20:38 -0400)]
Merge branch '12276-fuse-deadlock' refs #12276

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12276: Ensure dirent cache is disabled.
Tom Clegg [Fri, 22 Sep 2017 21:00:07 +0000 (17:00 -0400)]
12276: Ensure dirent cache is disabled.

Setting this to zero fixed flakiness in #7751, so we might still rely
on it being zero for reliability.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12276: Remove debug logging message.
Peter Amstutz [Fri, 22 Sep 2017 18:43:26 +0000 (14:43 -0400)]
12276: Remove debug logging message.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12276: Reduce number of spurious invalidations sent to kernel.
Peter Amstutz [Fri, 22 Sep 2017 15:21:07 +0000 (11:21 -0400)]
12276: Reduce number of spurious invalidations sent to kernel.

* New policy to only send invalidations on objects that have a nonzero
  kernel reference count.
* When clearing the contents of a CollectionDirectory, only invalidate the
  topmost directory entry, this should take care of invalidating all paths
  beneath it as well.
* Don't send invalidate_inode() when deleting an inode (by definition, the
  inode is unreferenced by the kernel).
* Remove allow_dirent_cache for now (this only relates to caching negative
  lookups, which we don't support).
* Set attribute attr_timeout based on the polling period of the underlying
  object.
* FuncToJSONFile sets allow_attr_cache = False instead of allow_dirent_cache =
  False (which is useless in this case).

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years agoMerge branch '12298-cancel-fail'
Tom Clegg [Fri, 22 Sep 2017 13:27:01 +0000 (09:27 -0400)]
Merge branch '12298-cancel-fail'

refs #12298

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago11068: Catch OSError and give better error message when unable to execute Docker.
Peter Amstutz [Thu, 21 Sep 2017 18:04:27 +0000 (14:04 -0400)]
11068: Catch OSError and give better error message when unable to execute Docker.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years agoMerge branch '12292-cwl-tmpdir-default' refs #12292
Peter Amstutz [Thu, 21 Sep 2017 15:38:49 +0000 (11:38 -0400)]
Merge branch '12292-cwl-tmpdir-default' refs #12292

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years agoInstall upstream pip to work around Debian bug, no issue #
Peter Amstutz [Mon, 18 Sep 2017 21:40:05 +0000 (17:40 -0400)]
Install upstream pip to work around Debian bug, no issue #

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12292: Find crunchrunner vars even when mixed into a partial line
Peter Amstutz [Wed, 20 Sep 2017 20:05:18 +0000 (16:05 -0400)]
12292: Find crunchrunner vars even when mixed into a partial line

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12292: Set defaults for tmpdir, outdir, keep
Peter Amstutz [Wed, 20 Sep 2017 19:24:34 +0000 (15:24 -0400)]
12292: Set defaults for tmpdir, outdir, keep

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years agoAdd parameter for FPM so it removes old directories on upgrade
Javier Bértoli [Wed, 20 Sep 2017 22:51:54 +0000 (19:51 -0300)]
Add parameter for FPM so it removes old directories on upgrade

refs #12271

7 years ago12298: Allow non-null log when cancelling an unrunnable container.
Tom Clegg [Wed, 20 Sep 2017 21:44:22 +0000 (17:44 -0400)]
12298: Allow non-null log when cancelling an unrunnable container.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years agoFix dashboard crash on uncommitted container request.
Tom Clegg [Wed, 20 Sep 2017 20:03:53 +0000 (16:03 -0400)]
Fix dashboard crash on uncommitted container request.

refs #12246

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12195: Catch the special case when a RateLimitReachedError exception is raised,
Lucas Di Pentima [Wed, 20 Sep 2017 20:01:08 +0000 (17:01 -0300)]
12195: Catch the special case when a RateLimitReachedError exception is raised,
as it doesn't have a header attribute like its parent class.
Updated integration test to add a retry with this kind of error.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <ldipentima@veritasgenetics.com>

7 years agoMerge branch '12247-no-failed-checksum'
Tom Clegg [Wed, 20 Sep 2017 15:33:31 +0000 (11:33 -0400)]
Merge branch '12247-no-failed-checksum'

closes #12247

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years agoMerge branch '12107-faster-git'
Tom Clegg [Wed, 20 Sep 2017 13:57:31 +0000 (09:57 -0400)]
Merge branch '12107-faster-git'

closes #12107

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12107: Add protective comment.
Tom Clegg [Wed, 20 Sep 2017 13:54:47 +0000 (09:54 -0400)]
12107: Add protective comment.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years agoMerge branch '12084-dispatch-stuck'
Tom Clegg [Wed, 20 Sep 2017 13:45:06 +0000 (09:45 -0400)]
Merge branch '12084-dispatch-stuck'

closes #12084

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12084: Fix dispatcher getting bogged down on "too many open files".
Tom Clegg [Wed, 20 Sep 2017 02:14:37 +0000 (22:14 -0400)]
12084: Fix dispatcher getting bogged down on "too many open files".

Previously, handling the "too many open files" error from popen3
consisted of sleeping 1 second and trying the next job in the
queue. When lots of jobs were queued, this meant getting stuck in
start_jobs() for a long time, futilely trying to start different jobs,
which all failed for the same reason.

Worse, being stuck here meant none of the working jobs could finish,
which meant no file descriptors could be freed.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12084: Remove dead code.
Tom Clegg [Wed, 20 Sep 2017 01:54:05 +0000 (21:54 -0400)]
12084: Remove dead code.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12084: Reap children whose threads exit abnormally (status == nil).
Tom Clegg [Wed, 20 Sep 2017 01:51:38 +0000 (21:51 -0400)]
12084: Reap children whose threads exit abnormally (status == nil).

Ruby's thread status is false if the thread exited normally, nil if it
exited abnormally.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12107: Fix test suite dependence on outer git config.
Tom Clegg [Tue, 19 Sep 2017 14:02:47 +0000 (10:02 -0400)]
12107: Fix test suite dependence on outer git config.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12247: Simplify (Hash)Sum() usage.
Tom Clegg [Tue, 19 Sep 2017 14:47:06 +0000 (10:47 -0400)]
12247: Simplify (Hash)Sum() usage.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12247: Propagate write errors, don't hide them with "bad checksum".
Tom Clegg [Tue, 19 Sep 2017 14:37:43 +0000 (10:37 -0400)]
12247: Propagate write errors, don't hide them with "bad checksum".

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12107: Fix broken commit-exists-in-internal-repo check.
Tom Clegg [Tue, 19 Sep 2017 13:56:29 +0000 (09:56 -0400)]
12107: Fix broken commit-exists-in-internal-repo check.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12107: Fix broken "git branch --contains" check.
Tom Clegg [Tue, 19 Sep 2017 13:52:02 +0000 (09:52 -0400)]
12107: Fix broken "git branch --contains" check.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12107: Test fetch-and-tag on unreferenced and non-tip commits.
Tom Clegg [Mon, 18 Sep 2017 20:46:13 +0000 (16:46 -0400)]
12107: Test fetch-and-tag on unreferenced and non-tip commits.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12107: Use a fresh internal.git repo for each test run.
Tom Clegg [Mon, 18 Sep 2017 20:41:31 +0000 (16:41 -0400)]
12107: Use a fresh internal.git repo for each test run.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years agoBump PhantomJS version no issue #
Peter Amstutz [Mon, 18 Sep 2017 19:13:36 +0000 (15:13 -0400)]
Bump PhantomJS version no issue #

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years agoArvbox explicitly initializes postgres with en_US.UTF-8 locale. no issue #
Peter Amstutz [Fri, 15 Sep 2017 15:42:01 +0000 (11:42 -0400)]
Arvbox explicitly initializes postgres with en_US.UTF-8 locale.  no issue #

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years agoFix quoting in test_with_arvbox no issue #
Peter Amstutz [Mon, 18 Sep 2017 19:09:08 +0000 (15:09 -0400)]
Fix quoting in test_with_arvbox no issue #

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years agoMerge branch 'master' into 12107-faster-git
Tom Clegg [Mon, 18 Sep 2017 18:33:36 +0000 (14:33 -0400)]
Merge branch 'master' into 12107-faster-git

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years agoMerge branch '12197-show-pdh-in-trash'
Tom Clegg [Mon, 18 Sep 2017 18:25:25 +0000 (14:25 -0400)]
Merge branch '12197-show-pdh-in-trash'

closes #12197

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years agoMerge branch 'master' into 12197-show-pdh-in-trash
Tom Clegg [Mon, 18 Sep 2017 18:24:48 +0000 (14:24 -0400)]
Merge branch 'master' into 12197-show-pdh-in-trash

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12197: Update PDH column label for consistency.
Tom Clegg [Mon, 18 Sep 2017 18:10:40 +0000 (14:10 -0400)]
12197: Update PDH column label for consistency.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years agoRemove -f from 'docker tag' due to Docker update refs #12234
Peter Amstutz [Mon, 18 Sep 2017 14:13:58 +0000 (10:13 -0400)]
Remove -f from 'docker tag' due to Docker update refs #12234

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12197: Test PDH search and display on trash page.
Tom Clegg [Mon, 18 Sep 2017 03:03:29 +0000 (23:03 -0400)]
12197: Test PDH search and display on trash page.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years ago12197: Remove trash/delete labels on content rows.
Tom Clegg [Thu, 14 Sep 2017 15:31:05 +0000 (11:31 -0400)]
12197: Remove trash/delete labels on content rows.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

7 years agoArvbox support for caching and offline install of npm packages. no issue #
Peter Amstutz [Fri, 15 Sep 2017 00:22:49 +0000 (20:22 -0400)]
Arvbox support for caching and offline install of npm packages.  no issue #

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12032: Add permission_refresh_lock
Peter Amstutz [Thu, 14 Sep 2017 19:06:17 +0000 (15:06 -0400)]
12032: Add permission_refresh_lock

This ensures that when refreshing the permission view in a transaction, any
other transactions affecting permissions will either be committed (so that
results are visible to the refresh) or blocked (waiting to perform its own
refresh).

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12032: Don't need to refresh permission view in database seeds, should be done already.
Peter Amstutz [Wed, 13 Sep 2017 20:14:10 +0000 (16:14 -0400)]
12032: Don't need to refresh permission view in database seeds, should be done already.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12032: Remove user_uuid special case from all_perms.
Peter Amstutz [Wed, 13 Sep 2017 19:59:57 +0000 (15:59 -0400)]
12032: Remove user_uuid special case from all_perms.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12032: Remove unnecessary checks on user_uuids.
Peter Amstutz [Wed, 13 Sep 2017 19:50:35 +0000 (15:50 -0400)]
12032: Remove unnecessary checks on user_uuids.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12032: Remove hopefully-unnecessary view refreshes between tests.
Peter Amstutz [Wed, 13 Sep 2017 19:43:56 +0000 (15:43 -0400)]
12032: Remove hopefully-unnecessary view refreshes between tests.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12032: Refresh materialized_permission_view immediately after migration.
Peter Amstutz [Wed, 13 Sep 2017 17:17:46 +0000 (13:17 -0400)]
12032: Refresh materialized_permission_view immediately after migration.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12032: Remove startnode from materialized_permission_view (again), tests pass
Peter Amstutz [Wed, 13 Sep 2017 15:51:28 +0000 (11:51 -0400)]
12032: Remove startnode from materialized_permission_view (again), tests pass
without it.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12032: Update structure.sql from master schema + migration only.
Peter Amstutz [Wed, 13 Sep 2017 15:32:24 +0000 (11:32 -0400)]
12032: Update structure.sql from master schema + migration only.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12032: Container readable check uses subquery instead join to avoid returning
Peter Amstutz [Mon, 11 Sep 2017 20:57:06 +0000 (16:57 -0400)]
12032: Container readable check uses subquery instead join to avoid returning
duplicate rows.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12032: Database reset used by integration tests refreshes permission view.
Peter Amstutz [Mon, 11 Sep 2017 18:18:32 +0000 (14:18 -0400)]
12032: Database reset used by integration tests refreshes permission view.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12032: Fix down migration.
Peter Amstutz [Mon, 11 Sep 2017 16:12:42 +0000 (12:12 -0400)]
12032: Fix down migration.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12032: Restore create_permission_view.sql with note that it is only
Peter Amstutz [Fri, 8 Sep 2017 18:29:47 +0000 (14:29 -0400)]
12032: Restore create_permission_view.sql with note that it is only
present for migration reasons.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12032: Update install guide to specify minimum Postgres version of 9.3
Peter Amstutz [Fri, 8 Sep 2017 17:59:16 +0000 (13:59 -0400)]
12032: Update install guide to specify minimum Postgres version of 9.3

Include instructions for using SCL to get a newer Postgres on CentOS7.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12032: Add missing files.
Peter Amstutz [Fri, 8 Sep 2017 16:36:53 +0000 (12:36 -0400)]
12032: Add missing files.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12032: Rename permission_view and remove Rails permission cache.
Peter Amstutz [Fri, 8 Sep 2017 16:33:28 +0000 (12:33 -0400)]
12032: Rename permission_view and remove Rails permission cache.

Always refresh permission view when permission graph changes.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12032: Controller & integration test teardown invalidates permission view.
Peter Amstutz [Thu, 7 Sep 2017 21:44:10 +0000 (17:44 -0400)]
12032: Controller & integration test teardown invalidates permission view.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

7 years ago12032: Add comments to migration. Also special case api_client_authorizations
Peter Amstutz [Thu, 7 Sep 2017 17:39:12 +0000 (13:39 -0400)]
12032: Add comments to migration.  Also special case api_client_authorizations
in readable_by.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>