Tim Pierce [Fri, 31 Oct 2014 20:21:11 +0000 (16:21 -0400)]
4040: code review feedback
* Renamed
** collection_owned_by_fuse_1 -> collection_1_owned_by_fuse
** collection_owned_by_fuse_2 -> collection_2_owned_by_fuse
* Added fixtures pipeline_instance_owned_by_fuse and
pipeline_instance_in_fuse_project.
* Added name link for the empty collection, to exercise that links are
exposed in the filesystem in the expected way.
Tim Pierce [Thu, 30 Oct 2014 14:22:02 +0000 (10:22 -0400)]
4088: use filterable.js to filter on client side
Implemented client-side filtering via filterable.js:
* Designated filename rows as "filterable"
* Designated filename pattern input field as "filterable-control"
* Added "Select all" and "Unselect all" buttons with matching
select_all_files() and unselect_all_files() actions
* Limit selection actions (compare, move, copy etc) to visible page
elements only.
* Added integration tests "Filtering collection files by regexp" and
"Creating collection from list of filtered files".
Brett Smith [Wed, 29 Oct 2014 18:22:16 +0000 (14:22 -0400)]
Fix race condition in Node Manager shutdown tests.
ComputeNodeMonitorActor considers a shutdown when it's initialized.
Blocking on the subscription we send ensures that message is fully
processed before the tests continue. This is important because
several of them change the shutdown state immediately after, and that
might be seen by the internal shutdown consideration without this.
No issue #, but see
<https://ci.curoverse.com/job/arvados-api-server/1027/console>.
Phil Hodgson [Wed, 29 Oct 2014 15:39:56 +0000 (16:39 +0100)]
3618: Make tests pass: bugs were revealed in "Other objects" tab related to there not being any sorting going on there, etc.; add checks for HTML5 history and for nulls and undefineds
Tim Pierce [Tue, 28 Oct 2014 21:26:58 +0000 (17:26 -0400)]
4088: code review feedback
* Filter files by regex before .take(10000)
* Added "regular expression" placeholder in the filter input box
* Issue a Rails "alert" div if the regex could not be parsed
* Test that we're actually viewing a collection when no matches are
found (and not a fiddlesticks page or something)
Peter Amstutz [Tue, 28 Oct 2014 19:36:21 +0000 (15:36 -0400)]
4084: Split out behavior of updating job subscribe list to
arv-log-event-subscribe-to-pipeline-job-uuids. Fix arv:pane:reload
setTimeout() that was missing a timeout. Rename etarget -> $anchor. Refactor
removeClass calls. Add comments explaining tab reloading states better.
Peter Amstutz [Tue, 28 Oct 2014 18:18:10 +0000 (14:18 -0400)]
4031: Find for collection dependencies even in the middle of script parameter
fields. Server side collections with same PDH into a single entry with a
special name. Fix node descriptions, hyperlinks. More options to eliminate
certain node types for certain graphs to make them easier to read. Handle both
PDH and UUID when identifying collections.
radhika [Tue, 28 Oct 2014 16:18:17 +0000 (12:18 -0400)]
4091: enhance code to handle the case where there are more than one item in the next page matching the previous page's last object's created_at time.
Also, handle the case where the entire next page has the same created_at time as the previous page's last item; to keep things simple, stop scrolling in this case.
Tom Clegg [Tue, 28 Oct 2014 02:20:22 +0000 (22:20 -0400)]
3706: Remove automatic normalization. Add --normalize option to
arv-put. Add normalize() and stripped_manifest() methods to
CollectionReader. Clean up normalize code.
Tom Clegg [Tue, 28 Oct 2014 02:04:54 +0000 (22:04 -0400)]
3706: In CollectionReader, try fetching manifests before/after API
server when the ID is a Keep locator with/without a permission hint
respectively. Do not display a warning if the manifest is found one
way or the other.
Peter Amstutz [Mon, 27 Oct 2014 21:04:43 +0000 (17:04 -0400)]
4031: Refresh provenance helper graph generation to fix bugs and make better
use of available human readable names such as collections and components. Added tests.
Tim Pierce [Mon, 27 Oct 2014 18:06:12 +0000 (14:06 -0400)]
4015: simplify integration tests
Responding to code review in #4015-8:
We can (and should) test that the collection portable_data_hash is
recorded in individual tests without adding explicit new tests or
fixtures.
Updated test 'Create and run a pipeline' and the helper
create_and_run_pipeline_in_aproject to check that the collection
portable_data_hash, uuid and name have been recorded correctly in the
Advanced tab.