22141: Refactoring to reduce circular import dependencies
authorPeter Amstutz <peter.amstutz@curii.com>
Thu, 3 Oct 2024 21:26:37 +0000 (17:26 -0400)
committerPeter Amstutz <peter.amstutz@curii.com>
Thu, 3 Oct 2024 21:26:37 +0000 (17:26 -0400)
commite9d7b4ef3c2a02bb357f768cc8a87aae29395d91
treeeef0a720604109884924a6eddb08e1e21bbe1a8c
parentf3c9d9206965a35be9e4f1dad056fe72bcb7109d
22141: Refactoring to reduce circular import dependencies

The DataExplorer test started failing with the error "can't access
lexical declaration 'DataExplorer' before initialization".

I couldn't figure out exactly what I did that caused this to suddenly
start being a problem, but running the 'dpdm' tool on the codebase
showed a huge number of circular imports.

I moved several symbols directly or indirectly involving DataExplorer
out of the 'view' modules over to the 'action' modules and fixed
everything to import from the new location, and the DataExplorer test
is passing again.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
55 files changed:
services/workbench2/src/components/column-selector/column-selector.tsx
services/workbench2/src/components/data-explorer/data-explorer.tsx
services/workbench2/src/components/data-table-filters/data-table-filters-popover.tsx
services/workbench2/src/components/data-table-filters/data-table-filters-tree.tsx
services/workbench2/src/components/data-table-filters/data-table-filters.ts [moved from services/workbench2/src/components/data-table-filters/data-table-filters.tsx with 62% similarity]
services/workbench2/src/components/data-table/data-column.ts
services/workbench2/src/components/data-table/data-table.tsx
services/workbench2/src/components/subprocess-progress-bar/subprocess-progress-bar.tsx
services/workbench2/src/store/all-processes-panel/all-processes-panel-middleware-service.ts
services/workbench2/src/store/breadcrumbs/breadcrumbs-actions.ts
services/workbench2/src/store/data-explorer/data-explorer-action.ts
services/workbench2/src/store/data-explorer/data-explorer-middleware-service.ts
services/workbench2/src/store/data-explorer/data-explorer-reducer.ts
services/workbench2/src/store/favorite-panel/favorite-panel-middleware-service.ts
services/workbench2/src/store/process-panel/process-panel-actions.ts
services/workbench2/src/store/processes/processes-actions.ts
services/workbench2/src/store/processes/processes-middleware-service.ts
services/workbench2/src/store/project-panel/project-panel-data-middleware-service.ts
services/workbench2/src/store/project-panel/project-panel-run-middleware-service.ts
services/workbench2/src/store/public-favorites-panel/public-favorites-middleware-service.ts
services/workbench2/src/store/resource-type-filters/resource-type-filters.ts
services/workbench2/src/store/run-process-panel/run-process-panel-actions.cy.js
services/workbench2/src/store/run-process-panel/run-process-panel-actions.ts
services/workbench2/src/store/search-results-panel/search-results-middleware-service.ts
services/workbench2/src/store/shared-with-me-panel/shared-with-me-middleware-service.ts
services/workbench2/src/store/side-panel-tree/side-panel-tree-actions.ts
services/workbench2/src/store/trash-panel/trash-panel-middleware-service.ts
services/workbench2/src/store/workbench/workbench-actions.ts
services/workbench2/src/store/workflow-panel/workflow-panel-actions.cy.js
services/workbench2/src/store/workflow-panel/workflow-panel-actions.ts
services/workbench2/src/views-components/data-explorer/data-explorer.tsx
services/workbench2/src/views-components/side-panel-tree/side-panel-tree.tsx
services/workbench2/src/views/all-processes-panel/all-processes-panel.tsx
services/workbench2/src/views/api-client-authorization-panel/api-client-authorization-panel-root.tsx
services/workbench2/src/views/collection-content-address-panel/collection-content-address-panel.tsx
services/workbench2/src/views/favorite-panel/favorite-panel.tsx
services/workbench2/src/views/group-details-panel/group-details-panel.tsx
services/workbench2/src/views/groups-panel/groups-panel.tsx
services/workbench2/src/views/link-panel/link-panel-root.tsx
services/workbench2/src/views/project-panel/project-panel-data.tsx
services/workbench2/src/views/project-panel/project-panel-run.tsx
services/workbench2/src/views/public-favorites-panel/public-favorites-panel.tsx
services/workbench2/src/views/run-process-panel/run-process-advanced-form.tsx
services/workbench2/src/views/run-process-panel/run-process-basic-form.tsx
services/workbench2/src/views/run-process-panel/run-process-inputs-form.tsx
services/workbench2/src/views/run-process-panel/run-process-second-step.tsx
services/workbench2/src/views/search-results-panel/search-results-panel-view.tsx
services/workbench2/src/views/shared-with-me-panel/shared-with-me-columns.tsx [new file with mode: 0644]
services/workbench2/src/views/shared-with-me-panel/shared-with-me-panel.tsx
services/workbench2/src/views/subprocess-panel/subprocess-panel-root.tsx
services/workbench2/src/views/trash-panel/trash-panel.tsx
services/workbench2/src/views/user-panel/user-panel.tsx
services/workbench2/src/views/user-profile-panel/user-profile-panel-root.tsx
services/workbench2/src/views/workflow-panel/workflow-panel-view.tsx
services/workbench2/src/views/workflow-panel/workflow-processes-panel-root.tsx