From: Nico Cesar <nico@nicocesar.com>
Date: Mon, 19 Jul 2021 20:56:18 +0000 (-0400)
Subject: Addressing note 17
X-Git-Url: https://git.arvados.org/arvados.git/commitdiff_plain/refs/heads/17748-extra-claims

Addressing note 17

Arvados-DCO-1.1-Signed-off-by: Nico Cesar <nico@curii.com>
---

diff --git a/lib/controller/localdb/login_oidc_test.go b/lib/controller/localdb/login_oidc_test.go
index 1e7c09a6e7..4778e45f5f 100644
--- a/lib/controller/localdb/login_oidc_test.go
+++ b/lib/controller/localdb/login_oidc_test.go
@@ -490,22 +490,6 @@ func (s *OIDCLoginSuite) TestGoogleLogin_OIDCNameWithoutGivenAndFamilyNames(c *c
 	c.Check(authinfo.LastName, check.Equals, "Smith")
 }
 
-func (s *OIDCLoginSuite) TestGoogleLogin_OIDCClaimsWithGivenNames(c *check.C) {
-	s.fakeProvider.AuthName = "Federico Garcia Lorca"
-	s.fakeProvider.AuthGivenName = "Federico"
-	s.fakeProvider.AuthFamilyName = "Garcia Lorca"
-	s.fakeProvider.AuthEmail = "federico.garcia.lorca@primary.example.com"
-	state := s.startLogin(c)
-	s.localdb.Login(context.Background(), arvados.LoginOptions{
-		Code:  s.fakeProvider.ValidCode,
-		State: state,
-	})
-
-	authinfo := getCallbackAuthInfo(c, s.railsSpy)
-	c.Check(authinfo.FirstName, check.Equals, "Federico")
-	c.Check(authinfo.LastName, check.Equals, "Garcia Lorca")
-}
-
 // People API returns some additional email addresses.
 func (s *OIDCLoginSuite) TestGoogleLogin_AlternateEmailAddresses(c *check.C) {
 	s.fakeProvider.AuthEmail = "joe.smith@primary.example.com"