From: Lucas Di Pentima Date: Wed, 27 Sep 2017 03:44:47 +0000 (-0300) Subject: 12018: Avoid making duplicate api calls to add an already added user when X-Git-Tag: 1.1.1~23^2~29 X-Git-Url: https://git.arvados.org/arvados.git/commitdiff_plain/fd14dc21b4dc52b3168f32a644a4167cc55ab919?ds=sidebyside 12018: Avoid making duplicate api calls to add an already added user when the input file has the same line more than once. Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima --- diff --git a/sdk/python/arvados/commands/sync_groups.py b/sdk/python/arvados/commands/sync_groups.py index 2bc08e23d5..a1125de1b6 100644 --- a/sdk/python/arvados/commands/sync_groups.py +++ b/sdk/python/arvados/commands/sync_groups.py @@ -150,7 +150,8 @@ def main(arguments=None, stdout=sys.stdout, stderr=sys.stderr): groups_created += 1 # Both group & user exist, check if user is a member g_uuid = group_name_to_uuid[group] - if not user in remote_groups[g_uuid]['previous_members']: + if not (user in remote_groups[g_uuid]['previous_members'] or + user in remote_groups[g_uuid]['current_members']): # User wasn't a member, but should. api_client.links().create(body={ 'link_class': 'permission',