From: Tom Clegg <tom@curoverse.com>
Date: Wed, 30 Apr 2014 17:50:59 +0000 (-0400)
Subject: Fix "create folder"
X-Git-Tag: 1.1.0~2596^2~11^2~44
X-Git-Url: https://git.arvados.org/arvados.git/commitdiff_plain/f107a5232d5e8788ae19daf1c5f6639f0c3cdb68

Fix "create folder"
---

diff --git a/apps/workbench/app/controllers/application_controller.rb b/apps/workbench/app/controllers/application_controller.rb
index 6a761f6cb0..31f3464b0c 100644
--- a/apps/workbench/app/controllers/application_controller.rb
+++ b/apps/workbench/app/controllers/application_controller.rb
@@ -129,10 +129,10 @@ class ApplicationController < ActionController::Base
   end
 
   def create
-    new_resource_attrs = params[model_class.to_s.underscore.singularize]
-    new_resource_attrs ||= {}
-    new_resource_attrs.reject! { |k,v| k.to_s == 'uuid' }
-    @object ||= model_class.new new_resource_attrs
+    @new_resource_attrs ||= params[model_class.to_s.underscore.singularize]
+    @new_resource_attrs ||= {}
+    @new_resource_attrs.reject! { |k,v| k.to_s == 'uuid' }
+    @object ||= model_class.new @new_resource_attrs
     @object.save!
 
     respond_to do |f|
diff --git a/apps/workbench/app/controllers/folders_controller.rb b/apps/workbench/app/controllers/folders_controller.rb
index 12ffc205e7..3f536fbea4 100644
--- a/apps/workbench/app/controllers/folders_controller.rb
+++ b/apps/workbench/app/controllers/folders_controller.rb
@@ -14,8 +14,7 @@ class FoldersController < ApplicationController
   end
 
   def create
-    params['folder'] ||= {}.with_indifferent_access
-    params['folder']['group_class'] = 'folder'
+    @new_resource_attrs = (params['folder'] || {}).merge(group_class: 'folder')
     super
   end
 end
diff --git a/apps/workbench/app/models/group.rb b/apps/workbench/app/models/group.rb
index c628b5699c..53a9496c69 100644
--- a/apps/workbench/app/models/group.rb
+++ b/apps/workbench/app/models/group.rb
@@ -7,4 +7,8 @@ class Group < ArvadosBase
     ret.results = $arvados_api_client.unpack_api_response(res)
     ret
   end
+
+  def class_for_display
+    group_class == 'folder' ? 'Folder' : super
+  end
 end
diff --git a/apps/workbench/app/views/application/index.html.erb b/apps/workbench/app/views/application/index.html.erb
index 06735c1fb7..a32e7bfdb9 100644
--- a/apps/workbench/app/views/application/index.html.erb
+++ b/apps/workbench/app/views/application/index.html.erb
@@ -12,7 +12,7 @@
           'data-target' => '#user-setup-modal-window', return_to: request.url}  %>
       <div id="user-setup-modal-window" class="modal fade" role="dialog" aria-labelledby="myModalLabel" aria-hidden="true"></div>
     <% else %>
-      <%= button_to "Add a new #{controller.controller_name.humanize.downcase}",
+      <%= button_to "Add a new #{controller.controller_name.singularize.humanize.downcase}",
         { action: 'create' },
         { class: 'btn btn-primary pull-right' } %>
     <% end %>
diff --git a/apps/workbench/app/views/folders/show.html.erb b/apps/workbench/app/views/folders/show.html.erb
index a89afbca5e..c02c48b921 100644
--- a/apps/workbench/app/views/folders/show.html.erb
+++ b/apps/workbench/app/views/folders/show.html.erb
@@ -46,7 +46,7 @@
           Created: <%= @object.created_at.to_s(:long) %>
         </p>
         <p>
-          Last modified: <%= @object.modified_at.to_s(:long) %> by <%= link_to_if_arvados_object @object.modified_by_user_uuid %>
+          Last modified: <%= @object.modified_at.to_s(:long) %> by <%= link_to_if_arvados_object @object.modified_by_user_uuid, friendly_name: true %>
         </p>
         <% end %>
       </div>