From: Tom Clegg <tom@curoverse.com>
Date: Fri, 30 Jun 2017 19:34:08 +0000 (-0400)
Subject: 8784: Fix test for latest firefox.
X-Git-Tag: 1.1.0~155^2
X-Git-Url: https://git.arvados.org/arvados.git/commitdiff_plain/e59c1d365d9b6e1eff9b5cb030a8b1a3aaf14353

8784: Fix test for latest firefox.

Given "http://host:99999/path", Firefox 54 returns an error
"SyntaxError: The URI is malformed" instead of trying to connect to
port 99999 and returning a network error. Changing 99999 to 0 produces
the try-and-fail behavior we want to test.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curoverse.com>
---

diff --git a/apps/workbench/test/integration/collection_upload_test.rb b/apps/workbench/test/integration/collection_upload_test.rb
index 552a9cd5e8..f2a638f316 100644
--- a/apps/workbench/test/integration/collection_upload_test.rb
+++ b/apps/workbench/test/integration/collection_upload_test.rb
@@ -92,11 +92,11 @@ class CollectionUploadTest < ActionDispatch::IntegrationTest
   test "Report network error" do
     need_selenium "to make file uploads work"
     use_token :admin do
-      # Even if you somehow do port>2^16, surely nx.example.net won't
+      # Even if port 0 is a thing, surely nx.example.net won't
       # respond
       KeepService.where(service_type: 'proxy').first.
         update_attributes(service_host: 'nx.example.net',
-                          service_port: 99999)
+                          service_port: 0)
     end
     visit page_with_token 'active', sandbox_path