From: Tom Clegg <tom@curoverse.com>
Date: Fri, 3 Oct 2014 23:59:00 +0000 (-0400)
Subject: 3687: Add comment about redundant lookup.
X-Git-Tag: 1.1.0~2134^2~1
X-Git-Url: https://git.arvados.org/arvados.git/commitdiff_plain/d7d1d0f327ddc42d2d06b836863f51e09793894b

3687: Add comment about redundant lookup.
---

diff --git a/services/api/app/models/user.rb b/services/api/app/models/user.rb
index f283ea3ef8..6e7facd5d5 100644
--- a/services/api/app/models/user.rb
+++ b/services/api/app/models/user.rb
@@ -83,7 +83,10 @@ class User < ArvadosModel
                          end
       if sufficient_perms
         # Check permission links with head_uuid pointing directly at
-        # the target object
+        # the target object. If target is a Group, this is redundant
+        # and will fail except [a] if permission caching is broken or
+        # [b] during a race condition, where a permission link has
+        # *just* been added.
         if Link.where(link_class: 'permission',
                       name: sufficient_perms,
                       tail_uuid: groups_i_can(action) + [self.uuid],