From: Lucas Di Pentima <ldipentima@veritasgenetics.com>
Date: Thu, 8 Feb 2018 21:49:48 +0000 (-0300)
Subject: 11454: Replace link buttons with form buttons on search results,
X-Git-Tag: 1.1.4~85^2~5
X-Git-Url: https://git.arvados.org/arvados.git/commitdiff_plain/d76c4ddfa1e964a8a1dfdafd127aa7735126caea

11454: Replace link buttons with form buttons on search results,
so that embedded api tokens aren't shared accidentally.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <ldipentima@veritasgenetics.com>
---

diff --git a/apps/workbench/app/assets/javascripts/components/search.js b/apps/workbench/app/assets/javascripts/components/search.js
index 51d352ab82..f854411455 100644
--- a/apps/workbench/app/assets/javascripts/components/search.js
+++ b/apps/workbench/app/assets/javascripts/components/search.js
@@ -60,9 +60,16 @@ window.SearchResultsTable = {
                         tokenParam = '?api_token='+session.token
                     }
                     return m('tr', [
-                        m('td', [
+                        m('td', m('form', {
+                            onsubmit: function() {
+                                return false;
+                            }
+                        }, [
                             item.workbenchBaseURL() &&
-                                m('a.btn.btn-xs.btn-default', {
+                                m('button.btn.btn-xs.btn-default[type=submit]', {
+                                    onclick: m.withAttr('href', function(v) {
+                                        document.location = v;
+                                    }),
                                     'data-original-title': 'show '+item.objectType.description,
                                     'data-placement': 'top',
                                     'data-toggle': 'tooltip',
@@ -70,7 +77,7 @@ window.SearchResultsTable = {
                                     // Bootstrap's tooltip feature
                                     oncreate: function(vnode) { $(vnode.dom).tooltip() },
                                 }, iconsMap[item.objectType.wb_path]),
-                        ]),
+                        ])),
                         m('td.arvados-uuid', item.uuid),
                         m('td', item.name || '(unnamed)'),
                         m('td', m(LocalizedDateTime, {parse: item.modified_at})),