From: Tom Clegg <tom@curoverse.com>
Date: Mon, 26 Jun 2017 13:47:36 +0000 (-0400)
Subject: 11901: Fix unclosed db.Rows object.
X-Git-Tag: 1.1.0~170^2~5
X-Git-Url: https://git.arvados.org/arvados.git/commitdiff_plain/d25db7c02aa07e9d4812a029753c2b8606cf35b1

11901: Fix unclosed db.Rows object.

rows is closed implicitly when rows.Next() returns false, but when the
client hangs up, sendOldEvents returns without retrieving all
results. In this case rows.Close() needs to be called explicitly.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curoverse.com>
---

diff --git a/services/ws/session_v0.go b/services/ws/session_v0.go
index 44e2a1deb5..f8645eb887 100644
--- a/services/ws/session_v0.go
+++ b/services/ws/session_v0.go
@@ -157,6 +157,7 @@ func (sub *v0subscribe) sendOldEvents(sess *v0session) {
 		sess.log.WithError(err).Error("db.Query failed")
 		return
 	}
+	defer rows.Close()
 	for rows.Next() {
 		var id uint64
 		err := rows.Scan(&id)