From: Tom Clegg Date: Wed, 27 Apr 2022 14:07:50 +0000 (-0400) Subject: Merge branch '18947-githttpd' X-Git-Tag: 2.5.0~191 X-Git-Url: https://git.arvados.org/arvados.git/commitdiff_plain/ae92d144610446849eb568247a44f02ae985c281?hp=01a3368db1de44656e82fbc066e85ae4feb5eb75 Merge branch '18947-githttpd' refs #18947 Arvados-DCO-1.1-Signed-off-by: Tom Clegg --- diff --git a/.licenseignore b/.licenseignore index d13eee3901..387aeda944 100644 --- a/.licenseignore +++ b/.licenseignore @@ -51,6 +51,7 @@ docker/jobs/1078ECD7.key sdk/cwl/tests/input/blorp.txt sdk/cwl/tests/tool/blub.txt sdk/cwl/tests/federation/data/* +sdk/cwl/tests/fake-keep-mount/fake_collection_dir/.arvados#collection sdk/go/manifest/testdata/*_manifest sdk/java/.classpath sdk/java/pom.xml diff --git a/apps/workbench/Gemfile.lock b/apps/workbench/Gemfile.lock index ab4f3a173a..b272ffab83 100644 --- a/apps/workbench/Gemfile.lock +++ b/apps/workbench/Gemfile.lock @@ -179,7 +179,7 @@ GEM net-ssh-gateway (2.0.0) net-ssh (>= 4.0.0) nio4r (2.5.8) - nokogiri (1.13.3) + nokogiri (1.13.4) mini_portile2 (~> 2.8.0) racc (~> 1.4) npm-rails (0.2.1) diff --git a/apps/workbench/app/assets/javascripts/arvados_client.js b/apps/workbench/app/assets/javascripts/arvados_client.js index 478dc2901f..3fe8968eca 100644 --- a/apps/workbench/app/assets/javascripts/arvados_client.js +++ b/apps/workbench/app/assets/javascripts/arvados_client.js @@ -15,7 +15,6 @@ function ArvadosClient(arvadosApiToken, arvadosDiscoveryUri) { return this; //////////////////////////////// - var that = this; var promiseDiscovery; var discoveryDoc; diff --git a/apps/workbench/app/assets/javascripts/models/session_db.js b/apps/workbench/app/assets/javascripts/models/session_db.js index fd1cdfe149..70bd0a4ba5 100644 --- a/apps/workbench/app/assets/javascripts/models/session_db.js +++ b/apps/workbench/app/assets/javascripts/models/session_db.js @@ -173,7 +173,7 @@ window.SessionDB = function() { // scrub the location bar. if (document.location.search[0] != '?') { return; } var params = {}; - document.location.search.slice(1).split('&').map(function(kv) { + document.location.search.slice(1).split('&').forEach(function(kv) { var e = kv.indexOf('='); if (e < 0) { return; @@ -191,7 +191,7 @@ window.SessionDB = function() { }, fillMissingUUIDs: function() { var sessions = db.loadAll(); - Object.keys(sessions).map(function(key) { + Object.keys(sessions).forEach(function(key) { if (key.indexOf('://') < 0) { return; } @@ -291,7 +291,7 @@ window.SessionDB = function() { // a salted token. migrateNonFederatedSessions: function() { var sessions = db.loadActive(); - Object.keys(sessions).map(function(uuidPrefix) { + Object.keys(sessions).forEach(function(uuidPrefix) { session = sessions[uuidPrefix]; if (!session.isFromRails && session.token) { db.saltedToken(uuidPrefix).then(function(saltedToken) { @@ -310,7 +310,7 @@ window.SessionDB = function() { var doc = db.discoveryDoc(db.loadLocal()); if (doc === undefined) { return; } doc.map(function(d) { - Object.keys(d.remoteHosts).map(function(uuidPrefix) { + Object.keys(d.remoteHosts).forEach(function(uuidPrefix) { if (!(sessions[uuidPrefix])) { db.findAPI(d.remoteHosts[uuidPrefix]).then(function(baseURL) { db.login(baseURL, false); diff --git a/apps/workbench/app/views/collections/show_file_links.html.erb b/apps/workbench/app/views/collections/show_file_links.html.erb index a82d2556e7..d7483a6ab7 100644 --- a/apps/workbench/app/views/collections/show_file_links.html.erb +++ b/apps/workbench/app/views/collections/show_file_links.html.erb @@ -3,7 +3,7 @@ SPDX-License-Identifier: AGPL-3.0 %> - + <% coll_name = "Collection #{@object.uuid}" %> <% link_opts = {controller: 'collections', action: 'show_file', uuid: @object.uuid, reader_token: params[:reader_token]} %> diff --git a/apps/workbench/app/views/layouts/application.html.erb b/apps/workbench/app/views/layouts/application.html.erb index c0f01da283..93ce592679 100644 --- a/apps/workbench/app/views/layouts/application.html.erb +++ b/apps/workbench/app/views/layouts/application.html.erb @@ -3,7 +3,7 @@ SPDX-License-Identifier: AGPL-3.0 %> - + diff --git a/apps/workbench/app/views/projects/_compute_node_summary.html.erb b/apps/workbench/app/views/projects/_compute_node_summary.html.erb index 40a212e5b6..474fc7b9f5 100644 --- a/apps/workbench/app/views/projects/_compute_node_summary.html.erb +++ b/apps/workbench/app/views/projects/_compute_node_summary.html.erb @@ -13,8 +13,8 @@ SPDX-License-Identifier: AGPL-3.0 %> <td><%= nodes.select {|n| n.crunch_worker_state == "idle" }.size %></td> </tr> <tr> - <th>Busy nodes</th> - <th>Idle nodes</th> + <th scope="col">Busy nodes</th> + <th scope="col">Idle nodes</th> </tr> </table> </div> diff --git a/apps/workbench/app/views/projects/_container_summary.html.erb b/apps/workbench/app/views/projects/_container_summary.html.erb index 2df4d81c0f..c40ee370bd 100644 --- a/apps/workbench/app/views/projects/_container_summary.html.erb +++ b/apps/workbench/app/views/projects/_container_summary.html.erb @@ -9,8 +9,8 @@ SPDX-License-Identifier: AGPL-3.0 %> <col width="50%"> </colgroup> <tr> - <th>Pending containers</th> - <th>Running containers</th> + <th scope="col">Pending containers</th> + <th scope="col">Running containers</th> </tr> <tr> <% pending_containers = Container.order("created_at asc").filter([["state", "in", ["Queued", "Locked"]], ["priority", ">", 0]]).limit(1) %> @@ -19,8 +19,8 @@ SPDX-License-Identifier: AGPL-3.0 %> <td><%= running_containers.items_available %></td> </tr> <tr> - <th>Oldest pending</th> - <th>Longest running</th> + <th scope="col">Oldest pending</th> + <th scope="col">Longest running</th> </tr> <tr> <td><% if pending_containers.first then %> diff --git a/apps/workbench/app/views/users/activity.html.erb b/apps/workbench/app/views/users/activity.html.erb index 9df4b1fce3..64be1ea4a7 100644 --- a/apps/workbench/app/views/users/activity.html.erb +++ b/apps/workbench/app/views/users/activity.html.erb @@ -24,9 +24,9 @@ table#users-activity-table .cell-for-span-Last-month { <% end %> <tr> - <th rowspan="2">User</th> + <th scope="col" rowspan="2">User</th> <% @spans.each do |span, start_at, end_at| %> - <th colspan="3" class="cell-for-span-<%= span.gsub ' ','-' %>"> + <th scope="col" colspan="3" class="cell-for-span-<%= span.gsub ' ','-' %>"> <%= span %> <br /> <%= start_at.strftime('%b %-d') %> @@ -37,9 +37,9 @@ table#users-activity-table .cell-for-span-Last-month { </tr> <tr> <% @spans.each do |span, _| %> - <th class="cell-for-span-<%= span.gsub ' ','-' %>">Logins</th> - <th class="cell-for-span-<%= span.gsub ' ','-' %>">Jobs</th> - <th class="cell-for-span-<%= span.gsub ' ','-' %>">Pipelines</th> + <th scope="col" class="cell-for-span-<%= span.gsub ' ','-' %>">Logins</th> + <th scope="col" class="cell-for-span-<%= span.gsub ' ','-' %>">Jobs</th> + <th scope="col" class="cell-for-span-<%= span.gsub ' ','-' %>">Pipelines</th> <% end %> </tr> diff --git a/apps/workbench/app/views/users/storage.html.erb b/apps/workbench/app/views/users/storage.html.erb index 151ea8bb93..2a5265c408 100644 --- a/apps/workbench/app/views/users/storage.html.erb +++ b/apps/workbench/app/views/users/storage.html.erb @@ -17,21 +17,21 @@ table#users-storage-table .byte-value { </colgroup> <tr> - <th rowspan="2">User</th> - <th colspan="2"> + <th scope="col" rowspan="2">User</th> + <th scope="col" colspan="2"> Collections Read Size </th> - <th colspan="2"> + <th scope="col" colspan="2"> Collections Persisted Storage </th> - <th rowspan="2">Measured At</th> + <th scope="col" rowspan="2">Measured At</th> </tr> <tr> <% 2.times do %> - <th class="byte-value"> + <th scope="col" class="byte-value"> Total (unweighted) </th> - <th class="byte-value"> + <th scope="col" class="byte-value"> Shared (weighted) </th> <% end %> diff --git a/apps/workbench/app/views/virtual_machines/webshell.html.erb b/apps/workbench/app/views/virtual_machines/webshell.html.erb index 735583faec..d4f2cd0407 100644 --- a/apps/workbench/app/views/virtual_machines/webshell.html.erb +++ b/apps/workbench/app/views/virtual_machines/webshell.html.erb @@ -2,7 +2,9 @@ SPDX-License-Identifier: AGPL-3.0 %> -<html> +<!DOCTYPE html> +<html lang="en"> + <head> <title><%= @object.hostname %> / <%= Rails.configuration.Workbench.SiteName %>