From: Tom Clegg <tom@curoverse.com>
Date: Thu, 30 Jul 2015 14:04:02 +0000 (-0400)
Subject: 6663: Admins and repository owners can_manage, not just can_write
X-Git-Tag: 1.1.0~1457^2
X-Git-Url: https://git.arvados.org/arvados.git/commitdiff_plain/8699ba0baf2e346f0adc7ca79f0a8b129f56b9a7

6663: Admins and repository owners can_manage, not just can_write
(even though that might not translate to any additional functions with
the current gitolite config).
---

diff --git a/services/api/app/controllers/arvados/v1/repositories_controller.rb b/services/api/app/controllers/arvados/v1/repositories_controller.rb
index e61206d1a7..4bf9a6a094 100644
--- a/services/api/app/controllers/arvados/v1/repositories_controller.rb
+++ b/services/api/app/controllers/arvados/v1/repositories_controller.rb
@@ -62,12 +62,12 @@ class Arvados::V1::RepositoriesController < ApplicationController
           evidence << {name: perm.name, user_uuid: perm.tail_uuid}
         end
       end
-      # Owner of the repository, and all admins, can RW.
+      # Owner of the repository, and all admins, can do everything.
       ([repo.owner_uuid] | admins).each do |user_uuid|
         # Except: no permissions for inactive users, even if they own
         # repositories.
         next unless users[user_uuid]
-        evidence << {name: 'can_write', user_uuid: user_uuid}
+        evidence << {name: 'can_manage', user_uuid: user_uuid}
       end
       # Distill all the evidence about permissions on this repository
       # into one hash per user, of the form {'can_xxx' => true, ...}.