From: Brett Smith <brett.smith@curii.com>
Date: Fri, 14 Apr 2023 14:06:23 +0000 (-0400)
Subject: 18799: Mark self parameters as POSITIONAL_OR_KEYWORD
X-Git-Tag: 2.7.0~137^2~6
X-Git-Url: https://git.arvados.org/arvados.git/commitdiff_plain/7afaea0c59c4a2da152de652870f9b0e457f74cc

18799: Mark self parameters as POSITIONAL_OR_KEYWORD

On Python 3.7, if you mark a parameter POSITIONAL_ONLY, it will generate
a signature that uses the positional-only `/` syntax, *even though*
Python 3.7 cannot parse that syntax (it was added in Python 3.8, PEP 570).

POSITIONAL_OR_KEYWORD avoids that problem, and is probably more accurate
anyway.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>
---

diff --git a/sdk/python/discovery2pydoc.py b/sdk/python/discovery2pydoc.py
index 57ae316133..ad7606145a 100755
--- a/sdk/python/discovery2pydoc.py
+++ b/sdk/python/discovery2pydoc.py
@@ -200,7 +200,7 @@ class Method:
 
     def signature(self) -> inspect.Signature:
         parameters = [
-            inspect.Parameter('self', inspect.Parameter.POSITIONAL_ONLY),
+            inspect.Parameter('self', inspect.Parameter.POSITIONAL_OR_KEYWORD),
             *self._required_params,
             *self._optional_params,
         ]