From: Tom Clegg <tom@curii.com>
Date: Sat, 21 May 2022 00:56:47 +0000 (-0400)
Subject: 15370: Temporarily disable some docker tests.
X-Git-Tag: 2.5.0~157^2
X-Git-Url: https://git.arvados.org/arvados.git/commitdiff_plain/6caeb0768adabd32b50cc2ca6eb49d162745c4b0

15370: Temporarily disable some docker tests.

See https://dev.arvados.org/issues/15370#note-31

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>
---

diff --git a/cmd/arvados-package/build_test.go b/cmd/arvados-package/build_test.go
index 75e8f7604e..0f6288360c 100644
--- a/cmd/arvados-package/build_test.go
+++ b/cmd/arvados-package/build_test.go
@@ -29,7 +29,10 @@ func (s *BuildSuite) TestBuildAndInstall(c *check.C) {
 		c.Skip("skipping docker tests in short mode")
 	} else if _, err := exec.Command("docker", "info").CombinedOutput(); err != nil {
 		c.Skip("skipping docker tests because docker is not available")
+	} else if os.Getenv("ENABLE_DOCKER_TESTS") == "" {
+		c.Skip("docker tests temporarily disabled if ENABLE_DOCKER_TESTS is not set, see https://dev.arvados.org/issues/15370#note-31")
 	}
+
 	tmpdir := c.MkDir()
 	defer os.RemoveAll(tmpdir)
 	err := os.Chmod(tmpdir, 0755)
diff --git a/lib/crunchrun/integration_test.go b/lib/crunchrun/integration_test.go
index ec08937283..2ba7556cb5 100644
--- a/lib/crunchrun/integration_test.go
+++ b/lib/crunchrun/integration_test.go
@@ -249,6 +249,9 @@ func (s *integrationSuite) testRunTrivialContainer(c *C) {
 	if err := exec.Command("which", s.engine).Run(); err != nil {
 		c.Skip(fmt.Sprintf("%s: %s", s.engine, err))
 	}
+	if s.engine == "docker" && os.Getenv("ENABLE_DOCKER_TESTS") == "" {
+		c.Skip("docker tests temporarily disabled if ENABLE_DOCKER_TESTS is not set, see https://dev.arvados.org/issues/15370#note-31")
+	}
 	s.cr.Command = []string{"sh", "-c", "cat /mnt/in/inputfile >/mnt/out/inputfile && cat /mnt/json >/mnt/out/json && ! touch /mnt/in/shouldbereadonly && mkdir /mnt/out/emptydir"}
 	s.setup(c)