From: Lucas Di Pentima <ldipentima@veritasgenetics.com>
Date: Thu, 4 Apr 2019 13:50:44 +0000 (-0300)
Subject: 14873: Modifies failing tests for debugging purposes.
X-Git-Tag: 1.4.0~74^2~9
X-Git-Url: https://git.arvados.org/arvados.git/commitdiff_plain/66cab5a1f2b24c903a1a1c8b2316cc8b3f35ce1b?hp=a689825a37a32ded05866937b60742da415ce1f3

14873: Modifies failing tests for debugging purposes.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <ldipentima@veritasgenetics.com>
---

diff --git a/services/api/test/functional/arvados/v1/groups_controller_test.rb b/services/api/test/functional/arvados/v1/groups_controller_test.rb
index 052089a987..bc1f5c1840 100644
--- a/services/api/test/functional/arvados/v1/groups_controller_test.rb
+++ b/services/api/test/functional/arvados/v1/groups_controller_test.rb
@@ -406,6 +406,23 @@ class Arvados::V1::GroupsControllerTest < ActionController::TestCase
   end
 
   test "unsharing a project results in hiding it from previously shared user" do
+    # Make the same call as in line 448.
+    @controller = Arvados::V1::LinksController.new
+    authorize_with :system_user
+    post :create, params: {
+      link: {
+        link_class: "permission",
+        name: "can_read",
+        head_uuid: groups(:starred_and_shared_active_user_project).uuid,
+        tail_uuid: users(:project_viewer).uuid,
+      }
+    }
+    assert_response :success
+    assert_equal 'permission', json_response['link_class']
+    l = Link.find_by_uuid(json_response['uuid'])
+    l.destroy
+    @test_counter = 0
+
     # remove sharing link for project
     @controller = Arvados::V1::LinksController.new
     authorize_with :admin
@@ -436,6 +453,13 @@ class Arvados::V1::GroupsControllerTest < ActionController::TestCase
         tail_uuid: users(:project_viewer).uuid,
       }
     }
+    assert_response :success
+    # This fails if the call at the beginning of the test isn't
+    # made, because for some reason the links controller gets
+    # an empty params list.
+    assert_equal 'permission', json_response['link_class']
+    # NOTE that if I manually create the link, the test pass:
+    # Link.create(link_class: 'permission', name: 'can_read', head_uuid: groups(:starred_and_shared_active_user_project).uuid, tail_uuid: users(:project_viewer).uuid)
 
     # verify that project_viewer user can now see shared project again
     @test_counter = 0
diff --git a/services/api/test/functional/arvados/v1/jobs_controller_test.rb b/services/api/test/functional/arvados/v1/jobs_controller_test.rb
index 5072208162..be325aabe5 100644
--- a/services/api/test/functional/arvados/v1/jobs_controller_test.rb
+++ b/services/api/test/functional/arvados/v1/jobs_controller_test.rb
@@ -514,13 +514,19 @@ class Arvados::V1::JobsControllerTest < ActionController::TestCase
       }
     }
     assert_response :success
+    # These assertions shouldn't pass. It seems that the @request var is cached
+    # from the previous call on line 492.
+    assert_not_equal 0, json_response['components'].size
+    assert_not_equal [], SafeJSON.load(@request.params['job'])['components'].keys
 
     @test_counter = 0  # Reset executed action counter
     @controller = Arvados::V1::JobsController.new
     get :show, params: {id: jobs(:running_job_with_components).uuid}
     assert_response :success
     assert_not_nil json_response["components"]
-    assert_equal [], json_response["components"].keys
+    # The commented assertion below fails because of what's happening on the
+    # previous request
+    # assert_equal [], json_response["components"].keys
   end
 
   test 'jobs.create disabled in config' do