From: Tom Clegg <tclegg@veritasgenetics.com>
Date: Thu, 25 Oct 2018 19:52:21 +0000 (-0400)
Subject: 14407: Fix "too much recursion" error.
X-Git-Tag: 1.3.0~64^2~1
X-Git-Url: https://git.arvados.org/arvados.git/commitdiff_plain/62f6c1f0be5ebd4911ca0891e2b68db4c1e07a9a

14407: Fix "too much recursion" error.

The recursion error comes from evaluate_script() trying to serialize
the magical jQuery response. We don't need to see that response so
we can use execute_script() instead.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>
---

diff --git a/apps/workbench/test/integration_helper.rb b/apps/workbench/test/integration_helper.rb
index 224de20f17..1af7245a4e 100644
--- a/apps/workbench/test/integration_helper.rb
+++ b/apps/workbench/test/integration_helper.rb
@@ -103,14 +103,14 @@ module AssertDomEvent
   # DOM element.
   def assert_triggers_dom_event events, target='body'
     magic = 'received-dom-event-' + rand(2**30).to_s(36)
-    page.evaluate_script <<eos
+    page.execute_script <<eos
       $('#{target}').one('#{events}', function() {
         $('body').addClass('#{magic}');
       });
 eos
     yield
     assert_selector "body.#{magic}"
-    page.evaluate_script "$('body').removeClass('#{magic}');";
+    page.execute_script "$('body').removeClass('#{magic}');";
   end
 end