From: Ward Vandewege <ward@curii.com>
Date: Fri, 2 Apr 2021 01:09:41 +0000 (-0400)
Subject: Simplify code a bit.
X-Git-Tag: 2.2.0~79
X-Git-Url: https://git.arvados.org/arvados.git/commitdiff_plain/62b8ef851540106af34d6f5f432e794052355a15

Simplify code a bit.

refs #17503

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
---

diff --git a/lib/deduplicationreport/report.go b/lib/deduplicationreport/report.go
index d01d20fd7d..bb3405a493 100644
--- a/lib/deduplicationreport/report.go
+++ b/lib/deduplicationreport/report.go
@@ -106,12 +106,11 @@ func report(prog string, args []string, logger *logrus.Logger, stdout, stderr io
 	var err error
 
 	inputs, err = parseFlags(prog, args, logger, stderr)
-	if err != nil {
-		if err != flag.ErrHelp {
-			logger.Error(err.Error())
-			return 2
-		}
+	if err == flag.ErrHelp {
 		return 0
+	} else if err != nil {
+		logger.Error(err.Error())
+		return 2
 	}
 
 	// Arvados Client setup