From: Tom Clegg <tom@curii.com>
Date: Thu, 5 May 2022 15:23:56 +0000 (-0400)
Subject: 18794: Wait up to 10s for rails to notice config change.
X-Git-Tag: 2.5.0~184^2~7
X-Git-Url: https://git.arvados.org/arvados.git/commitdiff_plain/3b2568c566f7db8f56ba3425b21a4f7fcb46a083

18794: Wait up to 10s for rails to notice config change.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>
---

diff --git a/lib/controller/rails_restart_test.go b/lib/controller/rails_restart_test.go
index 75dd22b4a9..bb307d3216 100644
--- a/lib/controller/rails_restart_test.go
+++ b/lib/controller/rails_restart_test.go
@@ -13,6 +13,7 @@ import (
 	"net/http"
 	"net/url"
 	"os"
+	"strings"
 	"time"
 
 	"git.arvados.org/arvados.git/lib/config"
@@ -72,14 +73,17 @@ func (s *railsRestartSuite) TestConfigReload(c *check.C) {
 	newhash := fmt.Sprintf("%x", sha256.Sum256(append(confdata, '\n')))
 	c.Logf("newhash %s", newhash)
 
-	// Wait 2s to give RailsAPI's 1 Hz reload_config thread time
-	// to poll and hit restart.txt
-	time.Sleep(2 * time.Second)
-
-	resp, err = hc.Do(req)
-	c.Assert(err, check.IsNil)
-	c.Check(resp.StatusCode, check.Equals, http.StatusOK)
-	body, err = ioutil.ReadAll(resp.Body)
-	c.Assert(err, check.IsNil)
+	// Wait for RailsAPI's 1 Hz reload_config thread to poll and
+	// hit restart.txt
+	for deadline := time.Now().Add(10 * time.Second); time.Now().Before(deadline); time.Sleep(time.Second) {
+		resp, err = hc.Do(req)
+		c.Assert(err, check.IsNil)
+		c.Check(resp.StatusCode, check.Equals, http.StatusOK)
+		body, err = ioutil.ReadAll(resp.Body)
+		c.Assert(err, check.IsNil)
+		if strings.Contains(string(body), newhash) {
+			break
+		}
+	}
 	c.Check(string(body), check.Matches, `(?ms).*`+newhash+`.*`)
 }