From: Stephen Smith <stephen@curii.com>
Date: Thu, 8 Feb 2024 14:39:21 +0000 (-0500)
Subject: 21225: Combine project panel id consts
X-Git-Url: https://git.arvados.org/arvados.git/commitdiff_plain/373a377022b176e1151108c123ddd08d62861da0?ds=inline

21225: Combine project panel id consts

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
---

diff --git a/services/workbench2/src/store/project-panel/project-panel-action-bind.ts b/services/workbench2/src/store/project-panel/project-panel-action-bind.ts
index 31a5f8d6b6..a84039571b 100644
--- a/services/workbench2/src/store/project-panel/project-panel-action-bind.ts
+++ b/services/workbench2/src/store/project-panel/project-panel-action-bind.ts
@@ -4,6 +4,8 @@
 
 import { bindDataExplorerActions } from "store/data-explorer/data-explorer-action";
 
-const PROJECT_PANEL_ID = "projectPanel";
+// These are split into a separate file to avoid circular imports causing
+// invariant violations with unit tests
 
+export const PROJECT_PANEL_ID = "projectPanel";
 export const projectPanelActions = bindDataExplorerActions(PROJECT_PANEL_ID);
diff --git a/services/workbench2/src/store/project-panel/project-panel-action.ts b/services/workbench2/src/store/project-panel/project-panel-action.ts
index 305799e820..a0547ced23 100644
--- a/services/workbench2/src/store/project-panel/project-panel-action.ts
+++ b/services/workbench2/src/store/project-panel/project-panel-action.ts
@@ -9,7 +9,6 @@ import { getProperty } from "store/properties/properties";
 import { loadProject } from "store/workbench/workbench-actions";
 import { projectPanelActions } from "store/project-panel/project-panel-action-bind";
 
-export const PROJECT_PANEL_ID = "projectPanel";
 export const PROJECT_PANEL_CURRENT_UUID = "projectPanelCurrentUuid";
 export const IS_PROJECT_PANEL_TRASHED = "isProjectPanelTrashed";
 
diff --git a/services/workbench2/src/store/store.ts b/services/workbench2/src/store/store.ts
index 4033166bb9..b18bf8199e 100644
--- a/services/workbench2/src/store/store.ts
+++ b/services/workbench2/src/store/store.ts
@@ -19,7 +19,7 @@ import { snackbarReducer } from "./snackbar/snackbar-reducer";
 import { collectionPanelFilesReducer } from "./collection-panel/collection-panel-files/collection-panel-files-reducer";
 import { dataExplorerMiddleware } from "./data-explorer/data-explorer-middleware";
 import { FAVORITE_PANEL_ID } from "./favorite-panel/favorite-panel-action";
-import { PROJECT_PANEL_ID } from "./project-panel/project-panel-action";
+import { PROJECT_PANEL_ID } from "./project-panel/project-panel-action-bind";
 import { WORKFLOW_PROCESSES_PANEL_ID } from "./workflow-panel/workflow-panel-actions";
 import { ProjectPanelMiddlewareService } from "./project-panel/project-panel-middleware-service";
 import { FavoritePanelMiddlewareService } from "./favorite-panel/favorite-panel-middleware-service";
diff --git a/services/workbench2/src/views/project-panel/project-panel.tsx b/services/workbench2/src/views/project-panel/project-panel.tsx
index 19408d5db9..5e10d022cd 100644
--- a/services/workbench2/src/views/project-panel/project-panel.tsx
+++ b/services/workbench2/src/views/project-panel/project-panel.tsx
@@ -52,7 +52,8 @@ import { CollectionResource } from 'models/collection';
 import { resourceIsFrozen } from 'common/frozen-resources';
 import { ProjectResource } from 'models/project';
 import { deselectAllOthers, toggleOne } from 'store/multiselect/multiselect-actions';
-import { DetailsCardRoot } from 'views-components/details-card/details-card-root'; 
+import { DetailsCardRoot } from 'views-components/details-card/details-card-root';
+import { PROJECT_PANEL_ID } from 'store/project-panel/project-panel-action-bind';
 
 type CssRules = 'root' | 'button' ;
 
@@ -235,8 +236,6 @@ export const projectPanelColumns: DataColumns<string, ProjectResource> = [
     },
 ];
 
-export const PROJECT_PANEL_ID = 'projectPanel';
-
 const DEFAULT_VIEW_MESSAGES = ['Your project is empty.', 'Please create a project or create a collection and upload a data.'];
 
 interface ProjectPanelDataProps {