From: Tom Clegg <tom@curoverse.com>
Date: Wed, 3 Dec 2014 20:40:18 +0000 (-0500)
Subject: 4533: Lock all tables before deleting contents.
X-Git-Tag: 1.1.0~1947^2
X-Git-Url: https://git.arvados.org/arvados.git/commitdiff_plain/34d7bf56de6e43ff7f787e112ee88ffbc3056880

4533: Lock all tables before deleting contents.
---

diff --git a/services/api/app/controllers/database_controller.rb b/services/api/app/controllers/database_controller.rb
index a2e15ed156..4c3f4d9f8e 100644
--- a/services/api/app/controllers/database_controller.rb
+++ b/services/api/app/controllers/database_controller.rb
@@ -29,25 +29,33 @@ class DatabaseController < ApplicationController
     fixturesets = Dir.glob(Rails.root.join('test', 'fixtures', '*.yml')).
       collect { |yml| yml.match(/([^\/]*)\.yml$/)[1] }
 
-    # Delete existing fixtures (and everything else) from fixture
-    # tables
-    fixturesets.each do |x|
-      x.classify.constantize.unscoped.delete_all
+    ActiveRecord::Base.transaction do
+      # Avoid deadlock by locking all tables before doing anything
+      # drastic.
+      table_names = '"' + fixturesets.sort.join('","') + '"'
+      ActiveRecord::Base.connection.execute \
+      "LOCK TABLE #{table_names} IN SHARE ROW EXCLUSIVE MODE"
+
+      # Delete existing fixtures (and everything else) from fixture
+      # tables
+      fixturesets.each do |x|
+        x.classify.constantize.unscoped.delete_all
+      end
+
+      # create_fixtures() is a no-op for cached fixture sets, so
+      # uncache them all.
+      ActiveRecord::Fixtures.reset_cache
+      ActiveRecord::Fixtures.
+        create_fixtures(Rails.root.join('test', 'fixtures'), fixturesets)
+
+      # Dump cache of permissions etc.
+      Rails.cache.clear
+      ActiveRecord::Base.connection.clear_query_cache
+
+      # Reload database seeds
+      DatabaseSeeds.install
     end
 
-    # create_fixtures() is a no-op for cached fixture sets, so uncache
-    # them all.
-    ActiveRecord::Fixtures.reset_cache
-    ActiveRecord::Fixtures.
-      create_fixtures(Rails.root.join('test', 'fixtures'), fixturesets)
-
-    # Dump cache of permissions etc.
-    Rails.cache.clear
-    ActiveRecord::Base.connection.clear_query_cache
-
-    # Reload database seeds
-    DatabaseSeeds.install
-
     # Done.
     render json: {success: true}
   end