From: Ward Vandewege <ward@curoverse.com>
Date: Fri, 25 Apr 2014 15:38:48 +0000 (-0400)
Subject: Refactor AdminNotifier.
X-Git-Tag: 1.1.0~2575^2~17^2~9
X-Git-Url: https://git.arvados.org/arvados.git/commitdiff_plain/1eee45ce0bbae9e7d04a9382469d2c48fb0cfd3e?hp=1eee45ce0bbae9e7d04a9382469d2c48fb0cfd3e

Refactor AdminNotifier.

The old implementation was elegant, but not super useful in the
situation where you want to send different e-mails from a method.

Due to the way ActiveMailer is implemented, Rails would reuse the
Mail::Message object for sending the messages, which makes this
impossible to test.

So... I threw out the fancy solution in favor of something that also
works and can be tested fully.

I also added a number of tests.
---